53217 2011-01-26 17:41:33 -0800 new-run-webkit-tests: turn off pixel tests correctly by default for webkit-based ports 2011-01-27 14:21:31 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth eric mihaip ojan shanestephens tony webkit.review.bot oldest_to_newest 340653 0 dpranke 2011-01-26 17:41:33 -0800 new-run-webkit-tests: turn off pixel tests correctly by default for webkit-based ports 340666 1 80284 dpranke 2011-01-26 17:56:59 -0800 Created attachment 80284 Patch 340685 2 80285 dpranke 2011-01-26 18:17:27 -0800 Created attachment 80285 fix so that you can still manually enable pixel tests 340687 3 80285 mihaip 2011-01-26 18:21:40 -0800 Comment on attachment 80285 fix so that you can still manually enable pixel tests View in context: https://bugs.webkit.org/attachment.cgi?id=80285&action=review > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:60 > + if not hasattr(self._options, "pixel_tests") or self._options.pixel_tests == None: I think the condition "not get_option('pixel_tests')" should result in the same behavior. 340723 4 dpranke 2011-01-26 22:35:05 -0800 (In reply to comment #3) > (From update of attachment 80285 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=80285&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:60 > > + if not hasattr(self._options, "pixel_tests") or self._options.pixel_tests == None: > > I think the condition "not get_option('pixel_tests')" should result in the same behavior. "not get_option('pixel_tests')" would be True if was set to False. Which, in this case, would be harmless, but if you wanted the default to be True, would do the wrong thing, so probably better to leave it as it is. 340724 5 80285 eric 2011-01-26 22:48:38 -0800 Comment on attachment 80285 fix so that you can still manually enable pixel tests View in context: https://bugs.webkit.org/attachment.cgi?id=80285&action=review > Tools/Scripts/webkitpy/layout_tests/port/base.py:126 > + if not hasattr(self._options, 'configuration'): > + self._options.configuration = None > if self._options.configuration is None: seems sily. Why not combine these two with an or? 340736 6 dpranke 2011-01-26 23:20:59 -0800 (In reply to comment #5) > (From update of attachment 80285 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=80285&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/base.py:126 > > + if not hasattr(self._options, 'configuration'): > > + self._options.configuration = None > > if self._options.configuration is None: > > seems sily. Why not combine these two with an or? Can do! 341000 7 dpranke 2011-01-27 12:54:11 -0800 Committed r76829: <http://trac.webkit.org/changeset/76829> 341047 8 webkit.review.bot 2011-01-27 14:21:31 -0800 http://trac.webkit.org/changeset/76829 might have broken GTK Linux 32-bit Release The following tests are not passing: svg/animations/animate-text-nested-transforms.html 80284 2011-01-26 17:56:59 -0800 2011-01-26 18:17:25 -0800 Patch bug-53217-20110126175658.patch text/plain 4427 dpranke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiOGFm ZjU3YTFiODkzOGExYTAwY2ExNTExMzBhMGI1OGE4NGU0YmQzLi4xMjQzN2NjNzcyYTNkYTY1NmFh YTU2ZTExMWQzOTdhNjg3YTIxMmYzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDEtMjYgIERpcmsgUHJhbmtl ICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgbmV3LXJ1bi13ZWJraXQtdGVzdHM6IHR1cm4gb2ZmIHBpeGVsIHRl c3RzIGNvcnJlY3RseSBieSBkZWZhdWx0CisgICAgICAgIGZvciB3ZWJraXQtYmFzZWQgcG9ydHMu IHI3MDAxMyAoYnVnIDQ3NTEwKSB1c2VkCisgICAgICAgIHBvcnQuc2V0X29wdGlvbl9kZWZhdWx0 KCkgdG8gYXR0ZW1wdCB0byBzZXQgZGVmYXVsdCB2YWx1ZXMsIGJ1dAorICAgICAgICB0aGF0IGRp ZG4ndCB3b3JrIGNvcnJlY3RseS4gSSBoYXZlIHJlbW92ZWQgc2V0X29wdGlvbl9kZWZhdWx0Cisg ICAgICAgIGZvciBub3cgc2luY2UgaXQgd2FzIG9ubHkgYmVpbmcgdXNlZCBpbiB0d28gcGxhY2Vz IGFuZCBpbiB0aHJlZQorICAgICAgICB1c2VsZXNzIHVuaXQgdGVzdHMuIFRoZXJlIGlzIGEgc2Vw YXJhdGUgYnVnIG9wZW4gdG8gZml4IHRoZQorICAgICAgICBvcHRpb24gcGFyc2luZyAoNDgwOTUp LCBzbyB0aGlzIHdvcmthcm91bmQgaXMgZmluZSBmb3Igbm93LgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzIxNworCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHk6CisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5OgorICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZV91bml0dGVzdC5weToKKwogMjAxMS0wMS0y NiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjc2NzA5LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5CmluZGV4IGFlZWJjNjY4Njg4MjEwYzhlMDNh MWM2MDI4OGQ4OWJiNWEwMmJkZTcuLjM1ZWUxNDFkZWUwNDIyODQ4OTc4Mjc0NzUzOTlkNjQzNzlk MmQ1NzcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvYmFzZS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2Jhc2UucHkKQEAgLTEyMSw3ICsxMjEsOCBAQCBjbGFzcyBQb3J0KG9iamVjdCk6CiAgICAgICAg ICMgY2VydGFpbmx5IHdvbid0IGJlIGF2YWlsYWJsZSwgc28gaXQncyBhIGdvb2QgdGVzdCB0byBr ZWVwIHVzCiAgICAgICAgICMgZnJvbSBlcnJvcmluZyBvdXQgbGF0ZXIuCiAgICAgICAgIHNlbGYu X3ByZXR0eV9wYXRjaF9hdmFpbGFibGUgPSBzZWxmLl9maWxlc3lzdGVtLmV4aXN0cyhzZWxmLl9w cmV0dHlfcGF0Y2hfcGF0aCkKLSAgICAgICAgc2VsZi5zZXRfb3B0aW9uX2RlZmF1bHQoJ2NvbmZp Z3VyYXRpb24nLCBOb25lKQorICAgICAgICBpZiBub3QgaGFzYXR0cihzZWxmLl9vcHRpb25zLCAn Y29uZmlndXJhdGlvbicpOgorICAgICAgICAgICAgc2VsZi5fb3B0aW9ucy5jb25maWd1cmF0aW9u ID0gTm9uZQogICAgICAgICBpZiBzZWxmLl9vcHRpb25zLmNvbmZpZ3VyYXRpb24gaXMgTm9uZToK ICAgICAgICAgICAgIHNlbGYuX29wdGlvbnMuY29uZmlndXJhdGlvbiA9IHNlbGYuZGVmYXVsdF9j b25maWd1cmF0aW9uKCkKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC9iYXNlX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC9iYXNlX3VuaXR0ZXN0LnB5CmluZGV4IDcyZjJkMDVhNDJhZGU5Y2Fj ZmM5NzEwODhiMTkzOTcwNThhN2Q1MzguLjE4YjU2OGM4OTNlNmM5MDYyYjcyODYyZGI5NzcwYjFk NmRjOTA4MGIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvYmFzZV91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L2Jhc2VfdW5pdHRlc3QucHkKQEAgLTIyNCwxOSArMjI0LDYgQEAgY2xhc3Mg UG9ydFRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICBwb3J0ID0gYmFzZS5Qb3J0KCkK ICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChwb3J0LmdldF9vcHRpb24oJ2ZvbycsICdiYXInKSwg J2JhcicpCiAKLSAgICBkZWYgdGVzdF9zZXRfb3B0aW9uX2RlZmF1bHRfX3Vuc2V0KHNlbGYpOgot ICAgICAgICBwb3J0ID0gYmFzZS5Qb3J0KCkKLSAgICAgICAgcG9ydC5zZXRfb3B0aW9uX2RlZmF1 bHQoJ2ZvbycsICdiYXInKQotICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHBvcnQuZ2V0X29wdGlv bignZm9vJyksICdiYXInKQotCi0gICAgZGVmIHRlc3Rfc2V0X29wdGlvbl9kZWZhdWx0X19zZXQo c2VsZik6Ci0gICAgICAgIG9wdGlvbnMsIGFyZ3MgPSBvcHRwYXJzZS5PcHRpb25QYXJzZXIoKS5w YXJzZV9hcmdzKFtdKQotICAgICAgICBvcHRpb25zLmZvbyA9ICdiYXInCi0gICAgICAgIHBvcnQg PSBiYXNlLlBvcnQob3B0aW9ucz1vcHRpb25zKQotICAgICAgICAjIFRoaXMgY2FsbCBzaG91bGQg aGF2ZSBubyBlZmZlY3QuCi0gICAgICAgIHBvcnQuc2V0X29wdGlvbl9kZWZhdWx0KCdmb28nLCAn bmV3X2JhcicpCi0gICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwocG9ydC5nZXRfb3B0aW9uKCdmb28n KSwgJ2JhcicpCi0KICAgICBkZWYgdGVzdF9uYW1lX191bnNldChzZWxmKToKICAgICAgICAgcG9y dCA9IGJhc2UuUG9ydCgpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwocG9ydC5uYW1lKCksIE5v bmUpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L3dlYmtpdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Vi a2l0LnB5CmluZGV4IDQ3NjU1NWM1YTI5YzA5OWIwMmNhZjRiY2E0Y2Q4Mzk3OWRjZDc4MzcuLjBl M2QxMmY1ZTY1YTY5NDA4YTIyNzg0MTIxODAxN2RhNWYzZWNiZjkgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CisrKyBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CkBAIC01Nyw3ICs1 Nyw3IEBAIGNsYXNzIFdlYktpdFBvcnQoYmFzZS5Qb3J0KToKIAogICAgICAgICAjIEZJWE1FOiBk aXNhYmxlIHBpeGVsIHRlc3RzIHVudGlsIHRoZXkgYXJlIHJ1biBieSBkZWZhdWx0IG9uIHRoZQog ICAgICAgICAjIGJ1aWxkIG1hY2hpbmVzLgotICAgICAgICBzZWxmLnNldF9vcHRpb25fZGVmYXVs dCgncGl4ZWxfdGVzdHMnLCBGYWxzZSkKKyAgICAgICAgc2VsZi5fb3B0aW9ucy5waXhlbF90ZXN0 cyA9IEZhbHNlCiAKICAgICBkZWYgYmFzZWxpbmVfcGF0aChzZWxmKToKICAgICAgICAgcmV0dXJu IHNlbGYuX3dlYmtpdF9iYXNlbGluZV9wYXRoKHNlbGYuX25hbWUpCkBAIC0xMjAsOSArMTIwLDkg QEAgY2xhc3MgV2ViS2l0UG9ydChiYXNlLlBvcnQpOgogICAgICAgICByZXR1cm4gc2VsZi5fZGlm Zl9pbWFnZV9yZXBseShzcCwgZGlmZl9maWxlbmFtZSkKIAogICAgIGRlZiBfZGlmZl9pbWFnZV9y ZXF1ZXN0KHNlbGYsIGV4cGVjdGVkX2NvbnRlbnRzLCBhY3R1YWxfY29udGVudHMpOgotICAgICAg ICAjIEZJWE1FOiB1c2Ugc2VsZi5nZXRfb3B0aW9uKCd0b2xlcmFuY2UnKSBhbmQKLSAgICAgICAg IyBzZWxmLnNldF9vcHRpb25fZGVmYXVsdCgndG9sZXJhbmNlJywgMC4xKSBvbmNlIHRoYXQgYmVo YXZlcyBjb3JyZWN0bHkKLSAgICAgICAgIyB3aXRoIGRlZmF1bHQgdmFsdWVzLgorICAgICAgICAj IEZJWE1FOiBUaGVyZSBuZWVkcyB0byBiZSBhIG1vcmUgc2FuZSB3YXkgb2YgaGFuZGxpbmcgZGVm YXVsdAorICAgICAgICAjIHZhbHVlcyBmb3Igb3B0aW9ucyBzbyB0aGF0IHlvdSBjYW4gZGlzdGlu Z3Vpc2ggYmV0d2VlbiBhIGRlZmF1bHQKKyAgICAgICAgIyB2YWx1ZSBvZiBOb25lIGFuZCBhIGRl ZmF1bHQgdmFsdWUgdGhhdCB3YXNuJ3Qgc2V0LgogICAgICAgICBpZiBzZWxmLmdldF9vcHRpb24o J3RvbGVyYW5jZScpIGlzIG5vdCBOb25lOgogICAgICAgICAgICAgdG9sZXJhbmNlID0gc2VsZi5n ZXRfb3B0aW9uKCd0b2xlcmFuY2UnKQogICAgICAgICBlbHNlOgo= 80285 2011-01-26 18:17:27 -0800 2011-01-26 22:48:38 -0800 fix so that you can still manually enable pixel tests bug-53217-20110126181726.patch text/plain 4523 dpranke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiOGFm ZjU3YTFiODkzOGExYTAwY2ExNTExMzBhMGI1OGE4NGU0YmQzLi4xMjQzN2NjNzcyYTNkYTY1NmFh YTU2ZTExMWQzOTdhNjg3YTIxMmYzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDEtMjYgIERpcmsgUHJhbmtl ICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgbmV3LXJ1bi13ZWJraXQtdGVzdHM6IHR1cm4gb2ZmIHBpeGVsIHRl c3RzIGNvcnJlY3RseSBieSBkZWZhdWx0CisgICAgICAgIGZvciB3ZWJraXQtYmFzZWQgcG9ydHMu IHI3MDAxMyAoYnVnIDQ3NTEwKSB1c2VkCisgICAgICAgIHBvcnQuc2V0X29wdGlvbl9kZWZhdWx0 KCkgdG8gYXR0ZW1wdCB0byBzZXQgZGVmYXVsdCB2YWx1ZXMsIGJ1dAorICAgICAgICB0aGF0IGRp ZG4ndCB3b3JrIGNvcnJlY3RseS4gSSBoYXZlIHJlbW92ZWQgc2V0X29wdGlvbl9kZWZhdWx0Cisg ICAgICAgIGZvciBub3cgc2luY2UgaXQgd2FzIG9ubHkgYmVpbmcgdXNlZCBpbiB0d28gcGxhY2Vz IGFuZCBpbiB0aHJlZQorICAgICAgICB1c2VsZXNzIHVuaXQgdGVzdHMuIFRoZXJlIGlzIGEgc2Vw YXJhdGUgYnVnIG9wZW4gdG8gZml4IHRoZQorICAgICAgICBvcHRpb24gcGFyc2luZyAoNDgwOTUp LCBzbyB0aGlzIHdvcmthcm91bmQgaXMgZmluZSBmb3Igbm93LgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzIxNworCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHk6CisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5OgorICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZV91bml0dGVzdC5weToKKwogMjAxMS0wMS0y NiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjc2NzA5LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5CmluZGV4IGFlZWJjNjY4Njg4MjEwYzhlMDNh MWM2MDI4OGQ4OWJiNWEwMmJkZTcuLjM1ZWUxNDFkZWUwNDIyODQ4OTc4Mjc0NzUzOTlkNjQzNzlk MmQ1NzcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvYmFzZS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2Jhc2UucHkKQEAgLTEyMSw3ICsxMjEsOCBAQCBjbGFzcyBQb3J0KG9iamVjdCk6CiAgICAgICAg ICMgY2VydGFpbmx5IHdvbid0IGJlIGF2YWlsYWJsZSwgc28gaXQncyBhIGdvb2QgdGVzdCB0byBr ZWVwIHVzCiAgICAgICAgICMgZnJvbSBlcnJvcmluZyBvdXQgbGF0ZXIuCiAgICAgICAgIHNlbGYu X3ByZXR0eV9wYXRjaF9hdmFpbGFibGUgPSBzZWxmLl9maWxlc3lzdGVtLmV4aXN0cyhzZWxmLl9w cmV0dHlfcGF0Y2hfcGF0aCkKLSAgICAgICAgc2VsZi5zZXRfb3B0aW9uX2RlZmF1bHQoJ2NvbmZp Z3VyYXRpb24nLCBOb25lKQorICAgICAgICBpZiBub3QgaGFzYXR0cihzZWxmLl9vcHRpb25zLCAn Y29uZmlndXJhdGlvbicpOgorICAgICAgICAgICAgc2VsZi5fb3B0aW9ucy5jb25maWd1cmF0aW9u ID0gTm9uZQogICAgICAgICBpZiBzZWxmLl9vcHRpb25zLmNvbmZpZ3VyYXRpb24gaXMgTm9uZToK ICAgICAgICAgICAgIHNlbGYuX29wdGlvbnMuY29uZmlndXJhdGlvbiA9IHNlbGYuZGVmYXVsdF9j b25maWd1cmF0aW9uKCkKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC9iYXNlX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC9iYXNlX3VuaXR0ZXN0LnB5CmluZGV4IDcyZjJkMDVhNDJhZGU5Y2Fj ZmM5NzEwODhiMTkzOTcwNThhN2Q1MzguLjE4YjU2OGM4OTNlNmM5MDYyYjcyODYyZGI5NzcwYjFk NmRjOTA4MGIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvYmFzZV91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L2Jhc2VfdW5pdHRlc3QucHkKQEAgLTIyNCwxOSArMjI0LDYgQEAgY2xhc3Mg UG9ydFRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICBwb3J0ID0gYmFzZS5Qb3J0KCkK ICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChwb3J0LmdldF9vcHRpb24oJ2ZvbycsICdiYXInKSwg J2JhcicpCiAKLSAgICBkZWYgdGVzdF9zZXRfb3B0aW9uX2RlZmF1bHRfX3Vuc2V0KHNlbGYpOgot ICAgICAgICBwb3J0ID0gYmFzZS5Qb3J0KCkKLSAgICAgICAgcG9ydC5zZXRfb3B0aW9uX2RlZmF1 bHQoJ2ZvbycsICdiYXInKQotICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHBvcnQuZ2V0X29wdGlv bignZm9vJyksICdiYXInKQotCi0gICAgZGVmIHRlc3Rfc2V0X29wdGlvbl9kZWZhdWx0X19zZXQo c2VsZik6Ci0gICAgICAgIG9wdGlvbnMsIGFyZ3MgPSBvcHRwYXJzZS5PcHRpb25QYXJzZXIoKS5w YXJzZV9hcmdzKFtdKQotICAgICAgICBvcHRpb25zLmZvbyA9ICdiYXInCi0gICAgICAgIHBvcnQg PSBiYXNlLlBvcnQob3B0aW9ucz1vcHRpb25zKQotICAgICAgICAjIFRoaXMgY2FsbCBzaG91bGQg aGF2ZSBubyBlZmZlY3QuCi0gICAgICAgIHBvcnQuc2V0X29wdGlvbl9kZWZhdWx0KCdmb28nLCAn bmV3X2JhcicpCi0gICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwocG9ydC5nZXRfb3B0aW9uKCdmb28n KSwgJ2JhcicpCi0KICAgICBkZWYgdGVzdF9uYW1lX191bnNldChzZWxmKToKICAgICAgICAgcG9y dCA9IGJhc2UuUG9ydCgpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwocG9ydC5uYW1lKCksIE5v bmUpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L3dlYmtpdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Vi a2l0LnB5CmluZGV4IDQ3NjU1NWM1YTI5YzA5OWIwMmNhZjRiY2E0Y2Q4Mzk3OWRjZDc4MzcuLjEx MDJhMWJjZmQxOTYwMDIwOTI2YjU1MTQ5OTExYWJmYTE1MWM4YmQgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CisrKyBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CkBAIC01Nyw3ICs1 Nyw4IEBAIGNsYXNzIFdlYktpdFBvcnQoYmFzZS5Qb3J0KToKIAogICAgICAgICAjIEZJWE1FOiBk aXNhYmxlIHBpeGVsIHRlc3RzIHVudGlsIHRoZXkgYXJlIHJ1biBieSBkZWZhdWx0IG9uIHRoZQog ICAgICAgICAjIGJ1aWxkIG1hY2hpbmVzLgotICAgICAgICBzZWxmLnNldF9vcHRpb25fZGVmYXVs dCgncGl4ZWxfdGVzdHMnLCBGYWxzZSkKKyAgICAgICAgaWYgbm90IGhhc2F0dHIoc2VsZi5fb3B0 aW9ucywgInBpeGVsX3Rlc3RzIikgb3Igc2VsZi5fb3B0aW9ucy5waXhlbF90ZXN0cyA9PSBOb25l OgorICAgICAgICAgICAgc2VsZi5fb3B0aW9ucy5waXhlbF90ZXN0cyA9IEZhbHNlCiAKICAgICBk ZWYgYmFzZWxpbmVfcGF0aChzZWxmKToKICAgICAgICAgcmV0dXJuIHNlbGYuX3dlYmtpdF9iYXNl bGluZV9wYXRoKHNlbGYuX25hbWUpCkBAIC0xMjAsOSArMTIxLDkgQEAgY2xhc3MgV2ViS2l0UG9y dChiYXNlLlBvcnQpOgogICAgICAgICByZXR1cm4gc2VsZi5fZGlmZl9pbWFnZV9yZXBseShzcCwg ZGlmZl9maWxlbmFtZSkKIAogICAgIGRlZiBfZGlmZl9pbWFnZV9yZXF1ZXN0KHNlbGYsIGV4cGVj dGVkX2NvbnRlbnRzLCBhY3R1YWxfY29udGVudHMpOgotICAgICAgICAjIEZJWE1FOiB1c2Ugc2Vs Zi5nZXRfb3B0aW9uKCd0b2xlcmFuY2UnKSBhbmQKLSAgICAgICAgIyBzZWxmLnNldF9vcHRpb25f ZGVmYXVsdCgndG9sZXJhbmNlJywgMC4xKSBvbmNlIHRoYXQgYmVoYXZlcyBjb3JyZWN0bHkKLSAg ICAgICAgIyB3aXRoIGRlZmF1bHQgdmFsdWVzLgorICAgICAgICAjIEZJWE1FOiBUaGVyZSBuZWVk cyB0byBiZSBhIG1vcmUgc2FuZSB3YXkgb2YgaGFuZGxpbmcgZGVmYXVsdAorICAgICAgICAjIHZh bHVlcyBmb3Igb3B0aW9ucyBzbyB0aGF0IHlvdSBjYW4gZGlzdGluZ3Vpc2ggYmV0d2VlbiBhIGRl ZmF1bHQKKyAgICAgICAgIyB2YWx1ZSBvZiBOb25lIGFuZCBhIGRlZmF1bHQgdmFsdWUgdGhhdCB3 YXNuJ3Qgc2V0LgogICAgICAgICBpZiBzZWxmLmdldF9vcHRpb24oJ3RvbGVyYW5jZScpIGlzIG5v dCBOb25lOgogICAgICAgICAgICAgdG9sZXJhbmNlID0gc2VsZi5nZXRfb3B0aW9uKCd0b2xlcmFu Y2UnKQogICAgICAgICBlbHNlOgo=