53207 2011-01-26 17:18:04 -0800 [Chromium] Simplify small caps logic in complex text on linux 2011-01-27 15:03:21 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simonjam simonjam evan tony oldest_to_newest 340615 0 simonjam 2011-01-26 17:18:04 -0800 [Chromium] Simplify small caps logic in complex text on linux 340617 1 80274 simonjam 2011-01-26 17:20:31 -0800 Created attachment 80274 Patch 340938 2 simonjam 2011-01-27 10:56:40 -0800 This should simplify things a bit. 340949 3 80274 tony 2011-01-27 11:05:41 -0800 Comment on attachment 80274 Patch The code looks good, but can you still add a test case where an uppercase run becomes lowercase (if one doesn't exist)? That way we won't regress this in the future. 340967 4 simonjam 2011-01-27 11:31:03 -0800 (In reply to comment #3) > (From update of attachment 80274 [details]) > The code looks good, but can you still add a test case where an uppercase run becomes lowercase (if one doesn't exist)? That way we won't regress this in the future. I think the existing one already covers that with "Lorem ipsum." I'm not sure why that didn't occur to me earlier. :/ We also cover the opposite condition with "A?b?e" in atsui-small-caps-punctuation-size.html. It's not entirely intuitive, but punctuation is considered to be upper case. 340983 5 80274 tony 2011-01-27 12:02:01 -0800 Comment on attachment 80274 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80274&action=review > Source/WebCore/ChangeLog:9 > + No new tests. > + Nit: Please mention which tests cover this. 341001 6 80358 simonjam 2011-01-27 12:58:19 -0800 Created attachment 80358 Patch 341002 7 simonjam 2011-01-27 12:58:44 -0800 (In reply to comment #5) > (From update of attachment 80274 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=80274&action=review > > > Source/WebCore/ChangeLog:9 > > + No new tests. > > + > > Nit: Please mention which tests cover this. Done. 341073 8 simonjam 2011-01-27 15:03:21 -0800 Committed r76845: <http://trac.webkit.org/changeset/76845> 80274 2011-01-26 17:20:31 -0800 2011-01-27 12:58:17 -0800 Patch bug-53207-20110126172030.patch text/plain 3147 simonjam ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlNTIxMjZhNTIxZTI5OThlYmU2MTJlM2Y5ZjIyMGJmOWFmOGJiMTk1Li5j MWU5OTRkYjEyM2M4ZjRjYjg4MzEwMTA5NDA1MDRiYTk4Y2JiMGRjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTYgQEAKKzIwMTEtMDEtMjYgIEphbWVzIFNpbW9uc2VuICA8c2ltb25qYW1AY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtDaHJvbWl1bV0gU2ltcGxpZnkgc21hbGwgY2FwcyBsb2dpYyBpbiBjb21wbGV4IHRleHQgb24g bGludXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUz MjA3CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvY2hyb21pdW0vQ29tcGxleFRleHRDb250cm9sbGVyTGludXguY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Q29tcGxleFRleHRDb250cm9sbGVyOjpuZXh0U2NyaXB0UnVuKTogUmVtb3ZlIHJlZHVu ZGFudCBsb2dpYy4gQ2FzZSBjaGFuZ2VzIGluIGEgdGV4dCBydW4gaW1wbHkgRm9udERhdGEgY2hh bmdlcy4KKyAgICAgICAgKFdlYkNvcmU6OkNvbXBsZXhUZXh0Q29udHJvbGxlcjo6c2V0dXBGb250 Rm9yU2NyaXB0UnVuKTogVXBkYXRlIGNvbW1lbnQgdG8gcmVmbGVjdCBhYm92ZS4KKwogMjAxMS0w MS0yNiAgTmF0ZSBDaGFwaW4gIDxqYXBoZXRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9Db21wbGV4VGV4dENvbnRyb2xsZXJMaW51eC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Db21wbGV4VGV4dENvbnRyb2xsZXJM aW51eC5jcHAKaW5kZXggMzFmYzRmNzJlNDNlY2IyZjhmZWRkYjdiODk4OWI0YWVkNjM3NmQ0Yi4u OTdjMjI1Zjc5OWRkODlmMjA1YWI0MjEwNWJhNDA3NDNmMTcwNjk4NyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vQ29tcGxleFRleHRDb250cm9s bGVyTGludXguY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL0NvbXBsZXhUZXh0Q29udHJvbGxlckxpbnV4LmNwcApAQCAtMTYwLDE1ICsxNjAsMTEgQEAg Ym9vbCBDb21wbGV4VGV4dENvbnRyb2xsZXI6Om5leHRTY3JpcHRSdW4oKQogICAgIC8vIFNvIHdl IGFsbG93IHRoYXQgdG8gcnVuIGZpcnN0LCB0aGVuIGRvIGEgc2Vjb25kIHBhc3Mgb3ZlciB0aGUg cmFuZ2UgaXQKICAgICAvLyBmb3VuZCBhbmQgdGFrZSB0aGUgbGFyZ2VzdCBzdWJyZWdpb24gdGhh dCBzdGF5cyB3aXRoaW4gYSBzaW5nbGUgZm9udC4KICAgICBtX2N1cnJlbnRGb250RGF0YSA9IG1f Zm9udC0+Z2x5cGhEYXRhRm9yQ2hhcmFjdGVyKG1faXRlbS5zdHJpbmdbbV9pdGVtLml0ZW0ucG9z XSwgZmFsc2UpLmZvbnREYXRhOwotICAgIGJvb2wgaXNGaXJzdENoYXJhY3Rlckxvd2VyQ2FzZSA9 IHVfaXNsb3dlcihtX2l0ZW0uc3RyaW5nW21faXRlbS5pdGVtLnBvc10pOwogICAgIHVuc2lnbmVk IGVuZE9mUnVuOwogICAgIGZvciAoZW5kT2ZSdW4gPSAxOyBlbmRPZlJ1biA8IG1faXRlbS5pdGVt Lmxlbmd0aDsgKytlbmRPZlJ1bikgewotICAgICAgICBVQ2hhciBuZXh0Q2hhcmFjdGVyID0gbV9p dGVtLnN0cmluZ1ttX2l0ZW0uaXRlbS5wb3MgKyBlbmRPZlJ1bl07Ci0gICAgICAgIGNvbnN0IFNp bXBsZUZvbnREYXRhKiBuZXh0Rm9udERhdGEgPSBtX2ZvbnQtPmdseXBoRGF0YUZvckNoYXJhY3Rl cihuZXh0Q2hhcmFjdGVyLCBmYWxzZSkuZm9udERhdGE7CisgICAgICAgIGNvbnN0IFNpbXBsZUZv bnREYXRhKiBuZXh0Rm9udERhdGEgPSBtX2ZvbnQtPmdseXBoRGF0YUZvckNoYXJhY3RlcihtX2l0 ZW0uc3RyaW5nW21faXRlbS5pdGVtLnBvcyArIGVuZE9mUnVuXSwgZmFsc2UpLmZvbnREYXRhOwog ICAgICAgICBpZiAobmV4dEZvbnREYXRhICE9IG1fY3VycmVudEZvbnREYXRhKQogICAgICAgICAg ICAgYnJlYWs7Ci0gICAgICAgIGlmIChtX2ZvbnQtPmlzU21hbGxDYXBzKCkgJiYgaXNGaXJzdENo YXJhY3Rlckxvd2VyQ2FzZSAhPSB1X2lzbG93ZXIobmV4dENoYXJhY3RlcikpCi0gICAgICAgICAg ICBicmVhazsKICAgICB9CiAgICAgbV9pdGVtLml0ZW0ubGVuZ3RoID0gZW5kT2ZSdW47CiAgICAg bV9pbmRleE9mTmV4dFNjcmlwdFJ1biA9IG1faXRlbS5pdGVtLnBvcyArIGVuZE9mUnVuOwpAQCAt MTkzLDggKzE4OSw5IEBAIHZvaWQgQ29tcGxleFRleHRDb250cm9sbGVyOjpzZXR1cEZvbnRGb3JT Y3JpcHRSdW4oKQogewogICAgIEZvbnREYXRhVmFyaWFudCBmb250RGF0YVZhcmlhbnQgPSBBdXRv VmFyaWFudDsKICAgICAvLyBEZXRlcm1pbmUgaWYgdGhpcyBzY3JpcHQgcnVuIG5lZWRzIHRvIGJl IGNvbnZlcnRlZCB0byBzbWFsbCBjYXBzLgotICAgIC8vIG5leHRTY3JpcHRSdW4oKSB3aWxsIGFs d2F5cyBzZW5kIHVzIGEgcnVuIG9mIHRoZSBzYW1lIGNhc2UsIHNvIHdlIG9ubHkKLSAgICAvLyBu ZWVkIHRvIGNoZWNrIHRoZSBmaXJzdCBjaGFyYWN0ZXIncyBjYXNlLgorICAgIC8vIG5leHRTY3Jp cHRSdW4oKSB3aWxsIGFsd2F5cyBzZW5kIHVzIGEgcnVuIG9mIHRoZSBzYW1lIGNhc2UsIGJlY2F1 c2UgYQorICAgIC8vIGNhc2UgY2hhbmdlIHdoaWxlIGluIHNtYWxsLWNhcHMgbW9kZSBhbHdheXMg cmVzdWx0cyBpbiBkaWZmZXJlbnQKKyAgICAvLyBGb250RGF0YSwgc28gd2Ugb25seSBuZWVkIHRv IGNoZWNrIHRoZSBmaXJzdCBjaGFyYWN0ZXIncyBjYXNlLgogICAgIGlmIChtX2ZvbnQtPmlzU21h bGxDYXBzKCkgJiYgdV9pc2xvd2VyKG1faXRlbS5zdHJpbmdbbV9pdGVtLml0ZW0ucG9zXSkpIHsK ICAgICAgICAgbV9zbWFsbENhcHNTdHJpbmcgPSBTdHJpbmcobV9ydW4uZGF0YShtX2l0ZW0uaXRl bS5wb3MpLCBtX2l0ZW0uaXRlbS5sZW5ndGgpOwogICAgICAgICBtX3NtYWxsQ2Fwc1N0cmluZy5t YWtlVXBwZXIoKTsK 80358 2011-01-27 12:58:19 -0800 2011-01-27 13:38:51 -0800 Patch bug-53207-20110127125818.patch text/plain 3245 simonjam ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmMTQyOTMwZTY5YTk2ODJhNzE5NzFkOTc3ZDk0NjJmYzBjZTdjMTVjLi42 YTM1NTY2NTdkNjNiMGM2YWZiMzQ0OTY3OGE2NmVmNjg0M2RiMWNjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTcgQEAKKzIwMTEtMDEtMjcgIEphbWVzIFNpbW9uc2VuICA8c2ltb25qYW1AY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtDaHJvbWl1bV0gU2ltcGxpZnkgc21hbGwgY2FwcyBsb2dpYyBpbiBjb21wbGV4IHRleHQgb24g bGludXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUz MjA3CisKKyAgICAgICAgVGVzdDogZmFzdC90ZXh0L2F0c3VpLW11bHRpcGxlLXJlbmRlcmVycy5o dG1sCisgICAgICAgICAgICAgIGZhc3QvdGV4dC9hdHN1aS1zbWFsbC1jYXBzLXB1bmN0dWF0aW9u LXNpemUuaHRtbAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vQ29tcGxl eFRleHRDb250cm9sbGVyTGludXguY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29tcGxleFRleHRD b250cm9sbGVyOjpuZXh0U2NyaXB0UnVuKTogUmVtb3ZlIHJlZHVuZGFudCBsb2dpYy4gQ2FzZSBj aGFuZ2VzIGluIGEgdGV4dCBydW4gaW1wbHkgRm9udERhdGEgY2hhbmdlcy4KKyAgICAgICAgKFdl YkNvcmU6OkNvbXBsZXhUZXh0Q29udHJvbGxlcjo6c2V0dXBGb250Rm9yU2NyaXB0UnVuKTogVXBk YXRlIGNvbW1lbnQgdG8gcmVmbGVjdCBhYm92ZS4KKwogMjAxMS0wMS0yNyAgQ3JpcyBOZWNrYXIg IDxjZG5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtv di4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L0NvbXBsZXhUZXh0Q29udHJvbGxlckxpbnV4LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL0NvbXBsZXhUZXh0Q29udHJvbGxlckxpbnV4LmNwcAppbmRleCA2 ZDE1NTEwN2UzMTA4ZmIxZTVhY2IwZGZhNTYwNjQ2ZTQ1YjkzYjk4Li4wNTY2ZjBlYjVlYzM1YTQw ZmZhMTc3NWMwN2Q4ZjViOGRmNjcyNzFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Db21wbGV4VGV4dENvbnRyb2xsZXJMaW51eC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vQ29tcGxleFRleHRD b250cm9sbGVyTGludXguY3BwCkBAIC0xNjAsMTUgKzE2MCwxMSBAQCBib29sIENvbXBsZXhUZXh0 Q29udHJvbGxlcjo6bmV4dFNjcmlwdFJ1bigpCiAgICAgLy8gU28gd2UgYWxsb3cgdGhhdCB0byBy dW4gZmlyc3QsIHRoZW4gZG8gYSBzZWNvbmQgcGFzcyBvdmVyIHRoZSByYW5nZSBpdAogICAgIC8v IGZvdW5kIGFuZCB0YWtlIHRoZSBsYXJnZXN0IHN1YnJlZ2lvbiB0aGF0IHN0YXlzIHdpdGhpbiBh IHNpbmdsZSBmb250LgogICAgIG1fY3VycmVudEZvbnREYXRhID0gbV9mb250LT5nbHlwaERhdGFG b3JDaGFyYWN0ZXIobV9pdGVtLnN0cmluZ1ttX2l0ZW0uaXRlbS5wb3NdLCBmYWxzZSkuZm9udERh dGE7Ci0gICAgYm9vbCBpc0ZpcnN0Q2hhcmFjdGVyTG93ZXJDYXNlID0gdV9pc2xvd2VyKG1faXRl bS5zdHJpbmdbbV9pdGVtLml0ZW0ucG9zXSk7CiAgICAgdW5zaWduZWQgZW5kT2ZSdW47CiAgICAg Zm9yIChlbmRPZlJ1biA9IDE7IGVuZE9mUnVuIDwgbV9pdGVtLml0ZW0ubGVuZ3RoOyArK2VuZE9m UnVuKSB7Ci0gICAgICAgIFVDaGFyIG5leHRDaGFyYWN0ZXIgPSBtX2l0ZW0uc3RyaW5nW21faXRl bS5pdGVtLnBvcyArIGVuZE9mUnVuXTsKLSAgICAgICAgY29uc3QgU2ltcGxlRm9udERhdGEqIG5l eHRGb250RGF0YSA9IG1fZm9udC0+Z2x5cGhEYXRhRm9yQ2hhcmFjdGVyKG5leHRDaGFyYWN0ZXIs IGZhbHNlKS5mb250RGF0YTsKKyAgICAgICAgY29uc3QgU2ltcGxlRm9udERhdGEqIG5leHRGb250 RGF0YSA9IG1fZm9udC0+Z2x5cGhEYXRhRm9yQ2hhcmFjdGVyKG1faXRlbS5zdHJpbmdbbV9pdGVt Lml0ZW0ucG9zICsgZW5kT2ZSdW5dLCBmYWxzZSkuZm9udERhdGE7CiAgICAgICAgIGlmIChuZXh0 Rm9udERhdGEgIT0gbV9jdXJyZW50Rm9udERhdGEpCiAgICAgICAgICAgICBicmVhazsKLSAgICAg ICAgaWYgKG1fZm9udC0+aXNTbWFsbENhcHMoKSAmJiBpc0ZpcnN0Q2hhcmFjdGVyTG93ZXJDYXNl ICE9IHVfaXNsb3dlcihuZXh0Q2hhcmFjdGVyKSkKLSAgICAgICAgICAgIGJyZWFrOwogICAgIH0K ICAgICBtX2l0ZW0uaXRlbS5sZW5ndGggPSBlbmRPZlJ1bjsKICAgICBtX2luZGV4T2ZOZXh0U2Ny aXB0UnVuID0gbV9pdGVtLml0ZW0ucG9zICsgZW5kT2ZSdW47CkBAIC0xOTMsOCArMTg5LDkgQEAg dm9pZCBDb21wbGV4VGV4dENvbnRyb2xsZXI6OnNldHVwRm9udEZvclNjcmlwdFJ1bigpCiB7CiAg ICAgRm9udERhdGFWYXJpYW50IGZvbnREYXRhVmFyaWFudCA9IEF1dG9WYXJpYW50OwogICAgIC8v IERldGVybWluZSBpZiB0aGlzIHNjcmlwdCBydW4gbmVlZHMgdG8gYmUgY29udmVydGVkIHRvIHNt YWxsIGNhcHMuCi0gICAgLy8gbmV4dFNjcmlwdFJ1bigpIHdpbGwgYWx3YXlzIHNlbmQgdXMgYSBy dW4gb2YgdGhlIHNhbWUgY2FzZSwgc28gd2Ugb25seQotICAgIC8vIG5lZWQgdG8gY2hlY2sgdGhl IGZpcnN0IGNoYXJhY3RlcidzIGNhc2UuCisgICAgLy8gbmV4dFNjcmlwdFJ1bigpIHdpbGwgYWx3 YXlzIHNlbmQgdXMgYSBydW4gb2YgdGhlIHNhbWUgY2FzZSwgYmVjYXVzZSBhCisgICAgLy8gY2Fz ZSBjaGFuZ2Ugd2hpbGUgaW4gc21hbGwtY2FwcyBtb2RlIGFsd2F5cyByZXN1bHRzIGluIGRpZmZl cmVudAorICAgIC8vIEZvbnREYXRhLCBzbyB3ZSBvbmx5IG5lZWQgdG8gY2hlY2sgdGhlIGZpcnN0 IGNoYXJhY3RlcidzIGNhc2UuCiAgICAgaWYgKG1fZm9udC0+aXNTbWFsbENhcHMoKSAmJiB1X2lz bG93ZXIobV9pdGVtLnN0cmluZ1ttX2l0ZW0uaXRlbS5wb3NdKSkgewogICAgICAgICBtX3NtYWxs Q2Fwc1N0cmluZyA9IFN0cmluZyhtX3J1bi5kYXRhKG1faXRlbS5pdGVtLnBvcyksIG1faXRlbS5p dGVtLmxlbmd0aCk7CiAgICAgICAgIG1fc21hbGxDYXBzU3RyaW5nLm1ha2VVcHBlcigpOwo=