5318 2005-10-09 22:55:39 -0700 forced line break should not be allowed after a list marker 2005-10-24 10:47:44 -0700 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 koivisto hyatt ian oldest_to_newest 21680 0 koivisto 2005-10-09 22:55:39 -0700 It does not make much sense to break line after a list marker, the behaviour does not match other browsers either. 21681 1 4284 koivisto 2005-10-09 22:56:20 -0700 Created attachment 4284 test case 21682 2 4285 koivisto 2005-10-09 23:02:05 -0700 Created attachment 4285 patch this fixes the problem for list markers only, however there might be a need for more generic fix based on this comment in the code: // FIXME: This does not match WinIE, Opera, and Mozilla. They treat replaced elements // like characters in a word, and require spaces between the replaced elements in order // to break. 21690 3 4285 darin 2005-10-09 23:36:22 -0700 Comment on attachment 4285 patch r=me 21696 4 4285 hyatt 2005-10-10 02:24:42 -0700 Comment on attachment 4285 patch I'm minusing this, since I think the code needs better commenting, and because as you discovered, this problem is not unique to list markers. I'd rather see this fixed for replaced elements and list markers together than to just have some special-case code introduced for list markers. 21697 5 hyatt 2005-10-10 02:27:02 -0700 I think this may need a consult from Hixie actually. When considering ordered lists, there is an actual space generated between the "1." and the rest of the text, so it seems logical to me that this would provide a breaking opportunity. However, as you pointed out, it looks ugly. Hixie, what do you think? 21698 6 hyatt 2005-10-10 02:27:46 -0700 If we do decide that "1. " should not break despite having a space, then it probably is ok to special-case list markers. :) 21699 7 4285 hyatt 2005-10-10 02:29:29 -0700 Comment on attachment 4285 patch Bah, let's just land it and if it turns out to be wrong we can fix it later. :) 21719 8 koivisto 2005-10-10 09:46:25 -0700 I don't think it matters whether the list marker has space in it or not. It is treated as a replaced element so the space there is not a factor at all. Anyway, the patch only changes behaviour for forced line breaks, if the algorithm finds a normal break point then that is handled as before. 21746 9 ian 2005-10-10 15:13:34 -0700 If it's list-style-position: inside then it's just an inline element on the line and it should obey 'white-space' (the space is in the ::marker, and the property inherits from the display:list-item element). If it's list-style-position: outside then it should not wrap, it should be on the first line box, before the start of that line box, and thus should not be affected by wrapping or anything (and it's an inline-block, so white-space would only affect within the ::marker box anyway). HTH. 21755 10 4285 hyatt 2005-10-10 16:27:37 -0700 Comment on attachment 4285 patch Ok, so sounds like only outside list markers should ignore white-space rules, from what you're saying, so that's how we should refine this. Minusing for a new patch that checks listStylePosition 21861 11 4317 koivisto 2005-10-11 20:53:44 -0700 Created attachment 4317 updated test case 21862 12 4318 koivisto 2005-10-11 21:05:58 -0700 Created attachment 4318 updated patch Allow breaks after marker for list-style-position:inside. This should give the right behaviour. Markers are pretty much a hack, real (CSS3) markers would require some work. 22149 13 4318 hyatt 2005-10-16 23:47:46 -0700 Comment on attachment 4318 updated patch r=me 22820 14 bdakin 2005-10-24 10:47:44 -0700 I committed the fix for this bug. 4284 2005-10-09 22:56:20 -0700 2005-10-11 20:53:44 -0700 test case list-marker-linebreak.html text/html 256 koivisto PGh0bWw+Cjxib2R5Pgo8b2w+CjxsaT5hYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh YWFhYWEKPC9vbD4KPC9ib2R5Pgo8L2h0bWw+Cg== 4285 2005-10-09 23:02:05 -0700 2005-10-11 21:05:58 -0700 patch list-marker-linebreak.patch text/plain 1280 koivisto SW5kZXg6IGJpZGkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2to dG1sL3JlbmRlcmluZy9iaWRpLmNwcCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xNDcKZGlmZiAt cCAtdSAtcjEuMTQ3IGJpZGkuY3BwCi0tLSBiaWRpLmNwcAk5IE9jdCAyMDA1IDAxOjQ2OjE0IC0w MDAwCTEuMTQ3CisrKyBiaWRpLmNwcAkxMCBPY3QgMjAwNSAwNjowMzowMSAtMDAwMApAQCAtMjM5 OSw3ICsyMzk5LDcgQEAgQmlkaUl0ZXJhdG9yIFJlbmRlckJsb2NrOjpmaW5kTmV4dExpbmVCcgog ICAgICAgICBsYXN0ID0gbzsKICAgICAgICAgbyA9IG5leHQ7CiAKLSAgICAgICAgaWYgKCFsYXN0 LT5pc0Zsb2F0aW5nT3JQb3NpdGlvbmVkKCkgJiYgbGFzdC0+aXNSZXBsYWNlZCgpICYmIGxhc3Qt PnN0eWxlKCktPndoaXRlU3BhY2UoKSA9PSBOT1JNQUwpIHsKKyAgICAgICAgaWYgKCFsYXN0LT5p c0Zsb2F0aW5nT3JQb3NpdGlvbmVkKCkgJiYgbGFzdC0+aXNSZXBsYWNlZCgpICYmIGxhc3QtPnN0 eWxlKCktPndoaXRlU3BhY2UoKSA9PSBOT1JNQUwgJiYgIWxhc3QtPmlzTGlzdE1hcmtlcigpKSB7 CiAgICAgICAgICAgICAvLyBHbyBhaGVhZCBhbmQgYWRkIGluIHRtcFcuCiAgICAgICAgICAgICB3 ICs9IHRtcFc7CiAgICAgICAgICAgICB0bXBXID0gMDsKQEAgLTI0MzYsOCArMjQzNiw4IEBAIEJp ZGlJdGVyYXRvciBSZW5kZXJCbG9jazo6ZmluZE5leHRMaW5lQnIKICAgICAgICAgICAgICAgICBs QnJlYWsucG9zID0gbGFzdC0+aXNUZXh0KCkgPyBsYXN0LT5sZW5ndGgoKSA6IDA7CiAgICAgICAg ICAgICB9CiAgICAgICAgIH0gZWxzZSBpZiggbEJyZWFrLm9iaiApIHsKLSAgICAgICAgICAgIGlm KCBsYXN0ICE9IG8gKSB7Ci0gICAgICAgICAgICAgICAgLy8gYmV0dGVyIHRvIGJyZWFrIGJldHdl ZW4gb2JqZWN0IGJvdW5kYXJpZXMgdGhhbiBpbiB0aGUgbWlkZGxlIG9mIGEgd29yZAorICAgICAg ICAgICAgaWYoIGxhc3QgIT0gbyAmJiAhbGFzdC0+aXNMaXN0TWFya2VyKCkgKSB7CisgICAgICAg ICAgICAgICAgLy8gYmV0dGVyIHRvIGJyZWFrIGJldHdlZW4gb2JqZWN0IGJvdW5kYXJpZXMgdGhh biBpbiB0aGUgbWlkZGxlIG9mIGEgd29yZCAoZXhjZXB0IGZvciBsaXN0IG1hcmtlcnMpCiAgICAg ICAgICAgICAgICAgbEJyZWFrLm9iaiA9IG87CiAgICAgICAgICAgICAgICAgbEJyZWFrLnBvcyA9 IDA7CiAgICAgICAgICAgICB9IGVsc2Ugewo= 4317 2005-10-11 20:53:44 -0700 2005-10-11 20:53:44 -0700 updated test case list-marker-linebreak.html text/html 517 koivisto PGh0bWw+Cjxib2R5Pgo8b2w+CjxsaT5hYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh YWFhYWEKPC9vbD4KPG9sPgo8bGkgc3R5bGU9Imxpc3Qtc3R5bGUtcG9zaXRpb246aW5zaWRlIj5h YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWEKPC9vbD4KPC9ib2R5Pgo8L2h0 bWw+Cg== 4318 2005-10-11 21:05:58 -0700 2005-10-16 23:47:46 -0700 updated patch list-marker-linebreak.patch text/plain 1343 koivisto SW5kZXg6IGJpZGkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2to dG1sL3JlbmRlcmluZy9iaWRpLmNwcCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xNDgKZGlmZiAt cCAtdSAtcjEuMTQ4IGJpZGkuY3BwCi0tLSBiaWRpLmNwcAkxMCBPY3QgMjAwNSAwNzoxNjoyMyAt MDAwMAkxLjE0OAorKysgYmlkaS5jcHAJMTIgT2N0IDIwMDUgMDM6NTU6NTggLTAwMDAKQEAgLTIz OTksNyArMjM5OSw4IEBAIEJpZGlJdGVyYXRvciBSZW5kZXJCbG9jazo6ZmluZE5leHRMaW5lQnIK ICAgICAgICAgbGFzdCA9IG87CiAgICAgICAgIG8gPSBuZXh0OwogCi0gICAgICAgIGlmICghbGFz dC0+aXNGbG9hdGluZ09yUG9zaXRpb25lZCgpICYmIGxhc3QtPmlzUmVwbGFjZWQoKSAmJiBsYXN0 LT5zdHlsZSgpLT53aGl0ZVNwYWNlKCkgPT0gTk9STUFMKSB7CisgICAgICAgIGlmICghbGFzdC0+ aXNGbG9hdGluZ09yUG9zaXRpb25lZCgpICYmIGxhc3QtPmlzUmVwbGFjZWQoKSAmJiBsYXN0LT5z dHlsZSgpLT53aGl0ZVNwYWNlKCkgPT0gTk9STUFMICYmIAorICAgICAgICAgICAgKCFsYXN0LT5p c0xpc3RNYXJrZXIoKSB8fCBsYXN0LT5zdHlsZSgpLT5saXN0U3R5bGVQb3NpdGlvbigpPT1JTlNJ REUpKSB7CiAgICAgICAgICAgICAvLyBHbyBhaGVhZCBhbmQgYWRkIGluIHRtcFcuCiAgICAgICAg ICAgICB3ICs9IHRtcFc7CiAgICAgICAgICAgICB0bXBXID0gMDsKQEAgLTI0MzYsOCArMjQzNyw4 IEBAIEJpZGlJdGVyYXRvciBSZW5kZXJCbG9jazo6ZmluZE5leHRMaW5lQnIKICAgICAgICAgICAg ICAgICBsQnJlYWsucG9zID0gbGFzdC0+aXNUZXh0KCkgPyBsYXN0LT5sZW5ndGgoKSA6IDA7CiAg ICAgICAgICAgICB9CiAgICAgICAgIH0gZWxzZSBpZiggbEJyZWFrLm9iaiApIHsKLSAgICAgICAg ICAgIGlmKCBsYXN0ICE9IG8gKSB7Ci0gICAgICAgICAgICAgICAgLy8gYmV0dGVyIHRvIGJyZWFr IGJldHdlZW4gb2JqZWN0IGJvdW5kYXJpZXMgdGhhbiBpbiB0aGUgbWlkZGxlIG9mIGEgd29yZAor ICAgICAgICAgICAgaWYoIGxhc3QgIT0gbyAmJiAhbGFzdC0+aXNMaXN0TWFya2VyKCkgKSB7Cisg ICAgICAgICAgICAgICAgLy8gYmV0dGVyIHRvIGJyZWFrIGJldHdlZW4gb2JqZWN0IGJvdW5kYXJp ZXMgdGhhbiBpbiB0aGUgbWlkZGxlIG9mIGEgd29yZCAoZXhjZXB0IGZvciBsaXN0IG1hcmtlcnMp CiAgICAgICAgICAgICAgICAgbEJyZWFrLm9iaiA9IG87CiAgICAgICAgICAgICAgICAgbEJyZWFr LnBvcyA9IDA7CiAgICAgICAgICAgICB9IGVsc2Ugewo=