53176 2011-01-26 09:42:03 -0800 [Chromium]: FindInPage scoping infinite loop 2011-01-27 18:04:08 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC All RESOLVED FIXED P1 Normal --- 0 finnur.webkit webkit-unassigned commit-queue oldest_to_newest 340314 0 finnur.webkit 2011-01-26 09:42:03 -0800 Originally reported here: http://code.google.com/p/chromium/issues/detail?id=70505 When we restart scoping within a long text inside a textarea, we can get stuck in an infinite loop because originalEnd{Container|Offset} is not set correctly. I have a small patch coming which fixes this. 340833 1 80321 finnur.webkit 2011-01-27 04:35:53 -0800 Created attachment 80321 Addresses the issue 341204 2 80321 commit-queue 2011-01-27 18:04:05 -0800 Comment on attachment 80321 Addresses the issue Clearing flags on attachment: 80321 Committed r76889: <http://trac.webkit.org/changeset/76889> 341206 3 commit-queue 2011-01-27 18:04:08 -0800 All reviewed patches have been landed. Closing bug. 80321 2011-01-27 04:35:53 -0800 2011-01-27 18:04:05 -0800 Addresses the issue patch1 text/plain 2243 finnur.webkit SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA3Njc4NCkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTEtMDEtMjcgIEZpbm51ciBUaG9yYXJpbnNzb24gIDxmaW5udXIud2Via2l0QGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIGFkZHJlc3NlcyBhIHJlZ3Jlc3Npb24gaW50cm9kdWNlZCBieSByNzU3ODQsIGFzIGRlc2Ny aWJlZCBpbjoKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTUzMTc2CisKKyAgICAgICAgVGhlIHByb2JsZW0gaXMgdGhhdCBvcmlnaW5hbEVuZENvbnRhaW5l ciBhbmQgb3JpZ2luYWxFbmRPZmZzZXQgd2FzCisgICAgICAgIG1lYW50IHRvIGNhcHR1cmUgdGhl IGVuZCBvZiB0aGUgZG9jdW1lbnQsIGJ1dCB3YXMgYmVpbmcgYXNzaWduZWQgYWZ0ZXIKKyAgICAg ICAgYSBjYWxsIHRvIHNlYXJjaFJhbmdlLT5zZXRTdGFydCgpICh3aGVuIHNjb3BpbmcgaXMgcmVz dGFydGVkKSwgd2hpY2ggY2FuCisgICAgICAgIHJlc3VsdCBpbiB0aGUgUmFuZ2UgYmVpbmcgY29s bGFwc2VkIHRvIHN0YXJ0ICh0aGVyZWJ5IGFzc2lnbmluZyB0aGUKKyAgICAgICAgd3JvbmcgdmFs dWUgdG8gdGhlIENvbnRhaW5lci9PZmZzZXQgcGFpcikuCisKKyAgICAgICAgVGhpcyBjb2RlIGlz IG5ldmVyIHRyaWdnZXJlZCBieSBsYXlvdXQgdGVzdHMsIGJ1dCBJJ20gYWRkaW5nIGEgcmVncmVz c2lvbm8KKyAgICAgICAgdGVzdCBvbiB0aGUgQ2hyb21pdW0gc2lkZSBmb3IgdGhpcy4KKworICAg ICAgICAqIHNyYy9XZWJGcmFtZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUlt cGw6OnNjb3BlU3RyaW5nTWF0Y2hlcyk6CisKIDIwMTEtMDEtMjcgIEhhbnMgV2VubmJvcmcgIDxo YW5zQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBKZXJlbXkgT3Jsb3cuCklu ZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAJKHJldmlz aW9uIDc2Nzg0KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTU0NCw2ICsxNTQ0LDkgQEAgdm9pZCBXZWJGcmFtZUltcGw6 OnNjb3BlU3RyaW5nTWF0Y2hlcyhpbgogCiAgICAgUmVmUHRyPFJhbmdlPiBzZWFyY2hSYW5nZShy YW5nZU9mQ29udGVudHMoZnJhbWUoKS0+ZG9jdW1lbnQoKSkpOwogCisgICAgTm9kZSogb3JpZ2lu YWxFbmRDb250YWluZXIgPSBzZWFyY2hSYW5nZS0+ZW5kQ29udGFpbmVyKCk7CisgICAgaW50IG9y aWdpbmFsRW5kT2Zmc2V0ID0gc2VhcmNoUmFuZ2UtPmVuZE9mZnNldCgpOworCiAgICAgRXhjZXB0 aW9uQ29kZSBlYyA9IDAsIGVjMiA9IDA7CiAgICAgaWYgKG1fcmVzdW1lU2NvcGluZ0Zyb21SYW5n ZS5nZXQoKSkgewogICAgICAgICAvLyBUaGlzIGlzIGEgY29udGludWF0aW9uIG9mIGEgc2NvcGlu ZyBvcGVyYXRpb24gdGhhdCB0aW1lZCBvdXQgYW5kIGRpZG4ndApAQCAtMTU1OCw5ICsxNTYxLDYg QEAgdm9pZCBXZWJGcmFtZUltcGw6OnNjb3BlU3RyaW5nTWF0Y2hlcyhpbgogICAgICAgICB9CiAg ICAgfQogCi0gICAgTm9kZSogb3JpZ2luYWxFbmRDb250YWluZXIgPSBzZWFyY2hSYW5nZS0+ZW5k Q29udGFpbmVyKCk7Ci0gICAgaW50IG9yaWdpbmFsRW5kT2Zmc2V0ID0gc2VhcmNoUmFuZ2UtPmVu ZE9mZnNldCgpOwotCiAgICAgLy8gVGhpcyB0aW1lb3V0IGNvbnRyb2xzIGhvdyBsb25nIHdlIHNj b3BlIGJlZm9yZSByZWxlYXNpbmcgY29udHJvbC4gIFRoaXMKICAgICAvLyB2YWx1ZSBkb2VzIG5v dCBwcmV2ZW50IHVzIGZyb20gcnVubmluZyBmb3IgbG9uZ2VyIHRoYW4gdGhpcywgYnV0IGl0IGlz CiAgICAgLy8gcGVyaW9kaWNhbGx5IGNoZWNrZWQgdG8gc2VlIGlmIHdlIGhhdmUgZXhjZWVkZWQg b3VyIGFsbG9jYXRlZCB0aW1lLgo=