53172 2011-01-26 08:14:53 -0800 [Qt] Fix qt_minimal build 2011-01-26 10:43:04 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 ossy webkit-unassigned abarth eric laszlo.gombos webkit.review.bot oldest_to_newest 340266 0 ossy 2011-01-26 08:14:53 -0800 WebKit.pri: contains(DEFINES, QT_NO_UITOOLS): CONFIG -= uitools -> It should be after setting QT_NO_UITOOLS (Build error if CONFIG contains qt_minimal or if we have minimal Qt) In Tools/QtTestBrowser/locationedit.h we should include qconfig.h if QT_NO_INPUTDIALOG isn't disabled explicitly. (Build error if CONFIG doesn't contain qt_minimal, but we have minimal Qt) Patch is coming soon. 340268 1 ossy 2011-01-26 08:18:13 -0800 s/QT_NO_INPUTDIALOG isn't disabled explicitly/QT_NO_INPUTDIALOG isn't defined explicitly 340269 2 80195 ossy 2011-01-26 08:19:28 -0800 Created attachment 80195 proposed fix 340273 3 ossy 2011-01-26 08:28:16 -0800 After this fix is landed, I can make "Qt minimal" buildbot use minimal Qt instead of normal Qt. This bot will stand guard not to allow build breaks in the future with minimal Qt. qconfig-webkit-minimal.h: #define QT_NO_ANIMATION #define QT_NO_BEARERMANAGEMENT #define QT_NO_CLIPBOARD #define QT_NO_COMBOBOX #define QT_NO_CONCURRENT #define QT_NO_CRASHHANDLER #define QT_NO_CURSOR #define QT_NO_DESKTOPSERVICES #define QT_NO_FILEDIALOG #define QT_NO_GRAPHICSEFFECT #define QT_NO_IM #define QT_NO_INPUTDIALOG #define QT_NO_LINEEDIT #define QT_NO_MESSAGEBOX #define QT_NO_OPENSSL #define QT_NO_PRINTER #define QT_NO_QUUID_STRING #define QT_NO_SHORTCUT #define QT_NO_STYLE_STYLESHEET #define QT_NO_SYSTEMTRAYICON #define QT_NO_TEMPORARYFILE #define QT_NO_TOOLTIP #define QT_NO_UITOOLS #define QT_NO_UNDOCOMMAND #define QT_NO_UNDOSTACK #define QT_NO_XRENDER 340288 4 80195 kling 2011-01-26 08:57:35 -0800 Comment on attachment 80195 proposed fix rs=me 340325 5 ossy 2011-01-26 09:57:17 -0800 Landed in http://trac.webkit.org/changeset/76694 340343 6 webkit.review.bot 2011-01-26 10:43:04 -0800 http://trac.webkit.org/changeset/76694 might have broken GTK Linux 32-bit Release 80195 2011-01-26 08:19:28 -0800 2011-01-26 09:57:29 -0800 proposed fix 1.patch text/plain 1860 ossy ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBmZTdkNDZjLi4zODViNWY1 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTEtMDEtMjYgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEZpeCBxdF9t aW5pbWFsIGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD01MzE3MgorCisgICAgICAgICogU291cmNlL1dlYktpdC5wcmk6CisKIDIwMTEtMDEtMjUg IFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQucHJpIGIvU291cmNl L1dlYktpdC5wcmkKaW5kZXggYWI4YTZkNS4uZTc3OTAyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC5wcmkKKysrIGIvU291cmNlL1dlYktpdC5wcmkKQEAgLTEwNSw4ICsxMDUsNiBAQCBzeW1i aWFufG1hZW1vNXxtYWVtbzYgewogCiBkaXNhYmxlX3VpdG9vbHM6IERFRklORVMgKj0gUVRfTk9f VUlUT09MUwogCi1jb250YWlucyhERUZJTkVTLCBRVF9OT19VSVRPT0xTKTogQ09ORklHIC09IHVp dG9vbHMKLQogIyBEaXNhYmxlIGEgZmV3IHdhcm5pbmdzIG9uIFdpbmRvd3MuIFRoZSB3YXJuaW5n cyBhcmUgYWxzbwogIyBkaXNhYmxlZCBpbiBXZWJLaXRMaWJyYXJpZXMvd2luL3Rvb2xzL3ZzcHJv cHMvY29tbW9uLnZzcHJvcHMKIHdpbjMyLW1zdmMqfHdpbmNlKjogUU1BS0VfQ1hYRkxBR1MgKz0g LXdkNDI5MSAtd2Q0MzQ0IC13ZDQzOTYgLXdkNDUwMyAtd2Q0ODAwIC13ZDQ4MTkgLXdkNDk5NgpA QCAtMTM5LDMgKzEzNyw1IEBAIENPTkZJRyhxdF9taW5pbWFsKSB7CiAgICAgREVGSU5FUyAqPSBR VF9OT19VTkRPU1RBQ0sKICAgICBERUZJTkVTICo9IFFUX05PX1hSRU5ERVIKIH0KKworY29udGFp bnMoREVGSU5FUywgUVRfTk9fVUlUT09MUyk6IENPTkZJRyAtPSB1aXRvb2xzCmRpZmYgLS1naXQg YS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzVmNzE3OC4uODE5YmUx NyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDEyIEBACisyMDExLTAxLTI2ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg W1F0XSBGaXggcXRfbWluaW1hbCBidWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTMxNzIKKworICAgICAgICAqIFF0VGVzdEJyb3dzZXIvbG9jYXRp b25lZGl0Lmg6CisKIDIwMTEtMDEtMjUgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtp dC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1Rv b2xzL1F0VGVzdEJyb3dzZXIvbG9jYXRpb25lZGl0LmggYi9Ub29scy9RdFRlc3RCcm93c2VyL2xv Y2F0aW9uZWRpdC5oCmluZGV4IDc1MjQ5N2UuLjk2MmI0MjIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1F0 VGVzdEJyb3dzZXIvbG9jYXRpb25lZGl0LmgKKysrIGIvVG9vbHMvUXRUZXN0QnJvd3Nlci9sb2Nh dGlvbmVkaXQuaApAQCAtMjgsNiArMjgsOCBAQAogI2lmbmRlZiBsb2NhdGlvbmVkaXRfaAogI2Rl ZmluZSBsb2NhdGlvbmVkaXRfaAogCisjaW5jbHVkZSA8cWNvbmZpZy5oPgorCiAjaWZuZGVmIFFU X05PX0lOUFVURElBTE9HCiAjaW5jbHVkZSA8UXRHdWk+CiAK