53087 2011-01-25 07:35:51 -0800 Refactoring: replaced a hanging "else" with a "return" statement 2011-01-25 10:28:47 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 0 marcilio.mendonca webkit-unassigned commit-queue darin dbates oldest_to_newest 339645 0 marcilio.mendonca 2011-01-25 07:35:51 -0800 Refactoring: replaced a hanging "else" within an #if PLATFORM(MAC) block with a "return" statement so that the code is hopefully easier to read and less error prone. 339651 1 80065 marcilio.mendonca 2011-01-25 07:57:40 -0800 Created attachment 80065 Patch 339656 2 80065 darin 2011-01-25 08:24:36 -0800 Comment on attachment 80065 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80065&action=review > Source/JavaScriptCore/ChangeLog:10 > + with a "return" so that the code is more readable and less error pro prone 339725 3 80065 commit-queue 2011-01-25 10:28:42 -0800 Comment on attachment 80065 Patch Clearing flags on attachment: 80065 Committed r76609: <http://trac.webkit.org/changeset/76609> 339726 4 commit-queue 2011-01-25 10:28:47 -0800 All reviewed patches have been landed. Closing bug. 80065 2011-01-25 07:57:40 -0800 2011-01-25 10:28:42 -0800 Patch 0001-2011-01-25-Marcilio-Mendonca-mamendonca-rim.com.patch text/plain 2423 marcilio.mendonca RnJvbSBhODQ1NjA2NzYwN2Y0NDU0MjFmNThlZjE1MjRjNDEwNGQ4OGM4MWRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJjaWxpbyBNZW5kb25jYSA8bWFtZW5kb25jYUByaW0uY29t PgpEYXRlOiBNb24sIDI0IEphbiAyMDExIDE3OjA3OjA3IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0g MjAxMS0wMS0yNSAgTWFyY2lsaW8gTWVuZG9uY2EgIDxtYW1lbmRvbmNhQHJpbS5jb20+CgogICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBCdWcgNTMwODc6IFJlZmFj dG9yaW5nOiByZXBsYWNlZCBhIGhhbmdpbmcgImVsc2UiIHdpdGggYSAicmV0dXJuIgogICAgICAg IHN0YXRlbWVudAoJICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 MzA4Ny4KCiAgICAgICAgUmVmYWN0b3Jpbmcgd29yazogUmVwbGFjZWQgYSBoYW5naW5nICJlbHNl IiB3aXRoaW4gYW4gI2lmIFBMQVRGT1JNKE1BQykKICAgICAgICB3aXRoIGEgInJldHVybiIgc28g dGhhdCB0aGUgY29kZSBpcyBtb3JlIHJlYWRhYmxlIGFuZCBsZXNzIGVycm9yIHByb25lCgkgICAg KGUuZy4sICJlbHNlIiBkb2Vzbid0IHVzZSBicmFjZXMgc28gYWRkaW5nIGV4dHJhIGxpbmVzIHRv IHRoZSBlbHNlCgkgICAgYmxvY2sgd29uJ3QgaGF2ZSBhbnkgZWZmZWN0OyBldmVuIHdvcnNlLCBj b2RlIHN0aWxsIGNvbXBpbGVzCgkgICAgc3VjY2Vzc2Z1bGx5LgoKICAgICAgICAqIHd0Zi9Bc3Nl cnRpb25zLmNwcDoKLS0tCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAg IHwgICAxNiArKysrKysrKysrKysrKysrCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0Fzc2Vy dGlvbnMuY3BwIHwgICAgMyArKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwg MSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAyY2MxOWZlLi5lYzJl NTE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMS0wMS0y NSAgTWFyY2lsaW8gTWVuZG9uY2EgIDxtYW1lbmRvbmNhQHJpbS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDUzMDg3OiBSZWZhY3Rvcmlu ZzogcmVwbGFjZWQgYSBoYW5naW5nICJlbHNlIiB3aXRoIGEgInJldHVybiIKKyAgICAgICAgc3Rh dGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 MzA4Ny4KKworICAgICAgICBSZWZhY3RvcmluZyB3b3JrOiBSZXBsYWNlZCBhIGhhbmdpbmcgImVs c2UiIHdpdGhpbiBhbiAjaWYgUExBVEZPUk0oTQorICAgICAgICB3aXRoIGEgInJldHVybiIgc28g dGhhdCB0aGUgY29kZSBpcyBtb3JlIHJlYWRhYmxlIGFuZCBsZXNzIGVycm9yIHBybworICAgICAg ICAoZS5nLiwgImVsc2UiIGRvZXNuJ3QgdXNlIGJyYWNlcyBzbyBhZGRpbmcgZXh0cmEgbGluZXMg dG8gdGhlIGVsc2UKKyAgICAgICAgYmxvY2sgd29uJ3QgaGF2ZSBhbnkgZWZmZWN0OyBldmVuIHdv cnNlLCBjb2RlIHN0aWxsIGNvbXBpbGVzCisgICAgICAgIHN1Y2Nlc3NmdWxseS4KKworICAgICAg ICAqIHd0Zi9Bc3NlcnRpb25zLmNwcDoKKwogMjAxMS0wMS0yMCAgQW5kcmFzIEJlY3NpICA8YWJl Y3NpQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQ3NhYmEgT3N6dHJvZ29uw6Fj LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9Bc3NlcnRpb25zLmNwcCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvQXNzZXJ0aW9ucy5jcHAKaW5kZXggMTg0MTE1MC4u NDdlZjFiNSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9Bc3NlcnRpb25z LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0Fzc2VydGlvbnMuY3BwCkBAIC0x MDEsNyArMTAxLDggQEAgc3RhdGljIHZvaWQgdnByaW50Zl9zdGRlcnJfY29tbW9uKGNvbnN0IGNo YXIqIGZvcm1hdCwgdmFfbGlzdCBhcmdzKQogICAgICAgICBmcmVlKGJ1ZmZlcik7CiAgICAgICAg IENGUmVsZWFzZShzdHIpOwogICAgICAgICBDRlJlbGVhc2UoY2ZGb3JtYXQpOwotICAgIH0gZWxz ZQorICAgICAgICByZXR1cm47CisgICAgfQogI2VsaWYgUExBVEZPUk0oQlJFV01QKQogICAgIC8v IFdoZW4gc3RyIGlzIDAsIHRoZSByZXR1cm4gdmFsdWUgaXMgdGhlIG51bWJlciBvZiBieXRlcyBu ZWVkZWQKICAgICAvLyB0byBhY2NlcHQgdGhlIHJlc3VsdCBpbmNsdWRpbmcgbnVsbCB0ZXJtaW5h dGlvbi4KLS0gCjEuNy4zLjEubXN5c2dpdC4wCgo=