5308 2005-10-09 11:33:59 -0700 Number.toFixed doesn't include leading zero 2006-01-11 08:59:25 -0800 1 1 1 Unclassified WebKit JavaScriptCore 420+ Mac OS X 10.4 RESOLVED FIXED javascript:alert((0.5).toFixed(1)) P2 Normal --- 1 bob darin oldest_to_newest 21617 0 bob 2005-10-09 11:33:59 -0700 (0.5).toFixed(1) is ".5". (0.5).toString() is "0.5" and other browsers return "0.5" for both. 27578 1 ricciadams 2006-01-03 02:43:41 -0800 ECMA-262 Section 15.7.4.5 states that: 13. Let k be the number of characters in m. 14. If k > f, go to step 18. We are implementing this by creating an if block containing steps 15-17. Unfortuately, the statement we are using is: if (m.size() < f) { // Execute steps 15-17 } // Step 18... Hence, we are assuming that (k > f) is the same as !(k < f). This is logically not the case. I believe that the correct line is: if (m.size() <= f) { Unfortuately, I'm too tired to create/test a patch now. I will try to attach one later this week. 27698 2 5468 ricciadams 2006-01-03 20:59:26 -0800 Created attachment 5468 Patch and test case for 5308 Patch attached. This is basically changing the < to a <=. I also changed m.size() to k in order to make the code read more like the algorithm. 27700 3 5468 eric 2006-01-03 22:26:20 -0800 Comment on attachment 5468 Patch and test case for 5308 Looks fine. An even better test case would print "success" or "failure" to be more clear. 5468 2006-01-03 20:59:26 -0800 2006-01-03 22:26:20 -0800 Patch and test case for 5308 5308.txt text/plain 2313 ricciadams SW5kZXg6IEphdmFTY3JpcHRDb3JlL2tqcy9udW1iZXJfb2JqZWN0LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJD UyBmaWxlOiAvY3ZzL3Jvb3QvSmF2YVNjcmlwdENvcmUva2pzL251bWJlcl9vYmplY3QuY3BwLHYK cmV0cmlldmluZyByZXZpc2lvbiAxLjI5CmRpZmYgLXAgLXUgLXIxLjI5IEphdmFTY3JpcHRDb3Jl L2tqcy9udW1iZXJfb2JqZWN0LmNwcAotLS0gSmF2YVNjcmlwdENvcmUva2pzL251bWJlcl9vYmpl Y3QuY3BwCTMwIERlYyAyMDA1IDA4OjE0OjEyIC0wMDAwCTEuMjkKKysrIEphdmFTY3JpcHRDb3Jl L2tqcy9udW1iZXJfb2JqZWN0LmNwcAk0IEphbiAyMDA2IDA0OjU5OjI5IC0wMDAwCkBAIC0yMTgs NyArMjE4LDcgQEAgSlNWYWx1ZSAqTnVtYmVyUHJvdG9GdW5jOjpjYWxsQXNGdW5jdGlvbgogICAg ICAgVVN0cmluZyBtID0gaW50ZWdlcl9wYXJ0X25vZXhwKG4pOwogICAgICAgCiAgICAgICBpbnQg ayA9IG0uc2l6ZSgpOwotICAgICAgaWYgKG0uc2l6ZSgpIDwgZikgeworICAgICAgaWYgKGsgPD0g ZikgewogICAgICAgICAgIFVTdHJpbmcgeiA9ICIiOwogICAgICAgICAgIGZvciAoaW50IGkgPSAw OyBpIDwgZisxLWs7IGkrKykKICAgICAgICAgICAgICAgeiArPSAiMCI7CkluZGV4OiBMYXlvdXRU ZXN0cy9mYXN0L2pzL251bWJlci10b2ZpeGVkLXByZWNlZGluZy0wLWV4cGVjdGVkLnR4dAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09CmRpZmYgLU5wdSBMYXlvdXRUZXN0cy9mYXN0L2pzL251bWJlci10b2ZpeGVkLXByZWNl ZGluZy0wLWV4cGVjdGVkLnR4dAotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9udW1iZXItdG9maXhl ZC1wcmVjZWRpbmctMC1leHBlY3RlZC50eHQJMSBKYW4gMTk3MCAwMDowMDowMCAtMDAwMAorKysg TGF5b3V0VGVzdHMvZmFzdC9qcy9udW1iZXItdG9maXhlZC1wcmVjZWRpbmctMC1leHBlY3RlZC50 eHQJNCBKYW4gMjAwNiAwNDo0ODoxMSAtMDAwMApAQCAtMCwwICsxLDMgQEAKK1RoaXMgdGVzdHMg Zm9yIHJlZ3Jlc3Npb25zIHRvIGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTMwOC4gSWYgdGhpcyB0ZXN0IGlzIHN1Y2Nlc3NmdWwsICIwLjUiIHNob3VsZCBi ZSBkaXNwbGF5ZWQgYmVsb3cuCiswLjUKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy9udW1i ZXItdG9maXhlZC1wcmVjZWRpbmctMC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KZGlmZiAtTnB1IExheW91dFRl c3RzL2Zhc3QvanMvbnVtYmVyLXRvZml4ZWQtcHJlY2VkaW5nLTAuaHRtbAotLS0gTGF5b3V0VGVz dHMvZmFzdC9qcy9udW1iZXItdG9maXhlZC1wcmVjZWRpbmctMC5odG1sCTEgSmFuIDE5NzAgMDA6 MDA6MDAgLTAwMDAKKysrIExheW91dFRlc3RzL2Zhc3QvanMvbnVtYmVyLXRvZml4ZWQtcHJlY2Vk aW5nLTAuaHRtbAk0IEphbiAyMDA2IDA0OjQyOjUxIC0wMDAwCkBAIC0wLDAgKzEsMjYgQEAKKzxo dG1sPgorPGhlYWQ+CisgICAgPHNjcmlwdD4KKyAgICBmdW5jdGlvbiBkZWJ1ZyhzKSB7CisgICAg ICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdjb25zb2xlJykuaW5uZXJIVE1MICs9IHMgKyAn PGJyPic7CisgICAgfQorICAgIAorICAgIGZ1bmN0aW9uIHRlc3QoKSB7CisgICAgICAgIGZvciAo aiBpbiBpbmRleCkgeworICAgICAgICAgICAgdGVzdFByb3BlcnR5KGluZGV4W2pdKTsKKyAgICAg ICAgfQorICAgIH0KKyAgICBmdW5jdGlvbiBydW5UZXN0cygpIHsKKyAgICAgICAgaWYgKHdpbmRv dy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVy LmR1bXBBc1RleHQoKQorICAgICAgICBkZWJ1ZygwLjUxLnRvRml4ZWQoMSkpCisgICAgfQorICAg IDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25Mb2FkPSJydW5UZXN0cygpIj4KK1RoaXMgdGVz dHMgZm9yIHJlZ3Jlc3Npb25zIHRvIDxhIGhyZWY9Imh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2lu Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTMwOCI+aHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3Jn L3Nob3dfYnVnLmNnaT9pZD01MzA4PC9hPi4KK0lmIHRoaXMgdGVzdCBpcyBzdWNjZXNzZnVsLCAm cXVvdDswLjUmcXVvdDsgc2hvdWxkIGJlIGRpc3BsYXllZCBiZWxvdy4KKzwvYm9keT4KKzxwcmUg aWQ9ImNvbnNvbGUiPgorPC9wcmU+Cis8L2h0bWw+CgkK