5307 2005-10-09 11:32:24 -0700 Number.toFixed doesn't round 0.5 up 2006-06-22 22:01:03 -0700 1 1 1 Unclassified WebKit JavaScriptCore 420+ Mac OS X 10.4 RESOLVED FIXED javascript:alert((0.5).toFixed(0)) P2 Normal --- 1 bob webkit-unassigned fick_el oldest_to_newest 21616 0 bob 2005-10-09 11:32:24 -0700 Math.round() rounds 0.5 up, and (0.51).toFixed(0) rounds up, but (0.5).toFixed(0) does not. This is inconsistent with other browsers and itself. 27574 1 5444 ricciadams 2006-01-03 01:48:43 -0800 Created attachment 5444 Patch for 5307, including test case From my interpretation (and Maciej's) of ECMA-262 Section 15.7.4.5, it looks like step 10 means to round the number. Hence, 0.5.toFixed(0) should indeed be 1. 27575 2 ricciadams 2006-01-03 01:57:40 -0800 Note: I do not believe that the summary for this bug is correct. (0.51).toFixed() does round up to 1, it is only 0.5 that is (was) not working. Hence, the summary should probably read "Number.toFixed doesn't round up for 0.5" 27602 3 5444 ggaren 2006-01-03 09:25:31 -0800 Comment on attachment 5444 Patch for 5307, including test case r=me 27859 4 darin 2006-01-06 09:34:22 -0800 Should really put in a test for -0.5 too. 46763 5 ap 2006-06-22 22:01:03 -0700 *** Bug 9550 has been marked as a duplicate of this bug. *** 5444 2006-01-03 01:48:43 -0800 2006-01-03 09:25:31 -0800 Patch for 5307, including test case 5307.txt text/plain 2301 ricciadams SW5kZXg6IEphdmFTY3JpcHRDb3JlL2tqcy9udW1iZXJfb2JqZWN0LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJD UyBmaWxlOiAvY3ZzL3Jvb3QvSmF2YVNjcmlwdENvcmUva2pzL251bWJlcl9vYmplY3QuY3BwLHYK cmV0cmlldmluZyByZXZpc2lvbiAxLjI5CmRpZmYgLXAgLXUgLXIxLjI5IEphdmFTY3JpcHRDb3Jl L2tqcy9udW1iZXJfb2JqZWN0LmNwcAotLS0gSmF2YVNjcmlwdENvcmUva2pzL251bWJlcl9vYmpl Y3QuY3BwCTMwIERlYyAyMDA1IDA4OjE0OjEyIC0wMDAwCTEuMjkKKysrIEphdmFTY3JpcHRDb3Jl L2tqcy9udW1iZXJfb2JqZWN0LmNwcAkzIEphbiAyMDA2IDA5OjQ4OjA3IC0wMDAwCkBAIC0yMTIs NyArMjEyLDcgQEAgSlNWYWx1ZSAqTnVtYmVyUHJvdG9GdW5jOjpjYWxsQXNGdW5jdGlvbgogICAg ICAgICAgIHJldHVybiBqc1N0cmluZyhzK1VTdHJpbmc6OmZyb20oeCkpOwogICAgICAgCiAgICAg ICBkb3VibGUgbiA9IGZsb29yKHgqcG93KDEwLjAsIGYpKTsKLSAgICAgIGlmIChmYWJzKG4gLyBw b3coMTAuMCwgZikgLSB4KSA+IGZhYnMoKG4gKyAxKSAvIHBvdygxMC4wLCBmKSAtIHgpKQorICAg ICAgaWYgKGZhYnMobiAvIHBvdygxMC4wLCBmKSAtIHgpID49IGZhYnMoKG4gKyAxKSAvIHBvdygx MC4wLCBmKSAtIHgpKQogICAgICAgICAgIG4rKzsKICAgICAgIAogICAgICAgVVN0cmluZyBtID0g aW50ZWdlcl9wYXJ0X25vZXhwKG4pOwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy9udW1iZXIt dG9maXhlZC1yb3VuZC0wNS11cC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpkaWZmIC1OcHUgTGF5 b3V0VGVzdHMvZmFzdC9qcy9udW1iZXItdG9maXhlZC1yb3VuZC0wNS11cC1leHBlY3RlZC50eHQK LS0tIExheW91dFRlc3RzL2Zhc3QvanMvbnVtYmVyLXRvZml4ZWQtcm91bmQtMDUtdXAtZXhwZWN0 ZWQudHh0CTEgSmFuIDE5NzAgMDA6MDA6MDAgLTAwMDAKKysrIExheW91dFRlc3RzL2Zhc3QvanMv bnVtYmVyLXRvZml4ZWQtcm91bmQtMDUtdXAtZXhwZWN0ZWQudHh0CTMgSmFuIDIwMDYgMDk6Mjg6 MjEgLTAwMDAKQEAgLTAsMCArMSwzIEBACitUaGlzIHRlc3RzIGZvciByZWdyZXNzaW9ucyB0byBo dHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTUzMDcuIElmIHRo aXMgdGVzdCBpcyBzdWNjZXNzZnVsLCB0aGUgbnVtYmVyIDEgc2hvdWxkIGJlIGRpc3BsYXllZCBi ZWxvdy4KKzEKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy9udW1iZXItdG9maXhlZC1yb3Vu ZC0wNS11cC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KZGlmZiAtTnB1IExheW91dFRlc3RzL2Zhc3QvanMvbnVt YmVyLXRvZml4ZWQtcm91bmQtMDUtdXAuaHRtbAotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9udW1i ZXItdG9maXhlZC1yb3VuZC0wNS11cC5odG1sCTEgSmFuIDE5NzAgMDA6MDA6MDAgLTAwMDAKKysr IExheW91dFRlc3RzL2Zhc3QvanMvbnVtYmVyLXRvZml4ZWQtcm91bmQtMDUtdXAuaHRtbAkzIEph biAyMDA2IDA5OjIwOjMxIC0wMDAwCkBAIC0wLDAgKzEsMjEgQEAKKzxodG1sPgorPGhlYWQ+Cisg ICAgPHNjcmlwdD4KKyAgICBmdW5jdGlvbiBkZWJ1ZyhzKSB7CisgICAgICAgIGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCdjb25zb2xlJykuaW5uZXJIVE1MICs9IHMgKyAnPGJyPic7CisgICAgfQor ICAgIAorICAgIGZ1bmN0aW9uIHJ1blRlc3RzKCkgeworICAgICAgICBpZiAod2luZG93LmxheW91 dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFz VGV4dCgpCisgICAgICAgIGRlYnVnKDAuNS50b0ZpeGVkKDApKTsKKyAgICB9CisgICAgPC9zY3Jp cHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbkxvYWQ9InJ1blRlc3RzKCkiPgorVGhpcyB0ZXN0cyBmb3Ig cmVncmVzc2lvbnMgdG8gPGEgaHJlZj0iaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3No b3dfYnVnLmNnaT9pZD01MzA3Ij5odHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19i dWcuY2dpP2lkPTUzMDc8L2E+LgorSWYgdGhpcyB0ZXN0IGlzIHN1Y2Nlc3NmdWwsIHRoZSBudW1i ZXIgMSBzaG91bGQgYmUgZGlzcGxheWVkIGJlbG93LgorPC9ib2R5PgorPHByZSBpZD0iY29uc29s ZSI+Cis8L3ByZT4KKzwvaHRtbD4K