53066 2011-01-24 22:23:45 -0800 Web Inspector: fix data url's status and timing the network panel. 2011-04-05 14:59:31 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman webkit-unassigned apavlov bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik tonyg yurys oldest_to_newest 339502 0 pfeldman 2011-01-24 22:23:45 -0800 Today, data urls are shown as pending requests in the network panel. There should be no data urls in the network panel at all since there is no associated network request. 339503 1 pfeldman 2011-01-24 22:24:31 -0800 (crbug.com/69810) 379616 2 88246 vsevik 2011-04-05 09:13:15 -0700 Created attachment 88246 Patch Data URL resources now show "(data url)" in status cell. 379702 3 88246 pfeldman 2011-04-05 10:15:05 -0700 Comment on attachment 88246 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88246&action=review > Source/WebCore/inspector/front-end/NetworkPanel.js:1524 > + this._statusCell.textContent = WebInspector.UIString("(data url)"); You need to update English.lproj/localizedStrings.js with new string. > Source/WebCore/inspector/front-end/NetworkPanel.js:1525 > + this._statusCell.addStyleClass("network-dim-cell"); Seems like this line is common. > Source/WebCore/inspector/front-end/Resource.js:716 > + isFromDataURL: function() nit: isDataURL 379737 4 88276 vsevik 2011-04-05 10:52:41 -0700 Created attachment 88276 Patch with fixes 379876 5 88276 commit-queue 2011-04-05 14:59:27 -0700 Comment on attachment 88276 Patch with fixes Clearing flags on attachment: 88276 Committed r82985: <http://trac.webkit.org/changeset/82985> 379878 6 commit-queue 2011-04-05 14:59:31 -0700 All reviewed patches have been landed. Closing bug. 88246 2011-04-05 09:13:15 -0700 2011-04-05 10:52:41 -0700 Patch data_url text/plain 2419 vsevik ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ZWMxMGMxLi5iMTM5MjQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDQtMDUgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogZml4IGRhdGEgdXJsJ3Mgc3RhdHVzIGFuZCB0aW1pbmcgdGhlIG5ldHdvcmsgcGFuZWwu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzA2Ngor CisgICAgICAgIEFkZGVkIGRhdGEgdXJsIHN1cHBvcnQgZm9yIHN0YXR1cyBvZiBuZXR3b3JrIHJl c291cmNlcy4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya1BhbmVsLmpz OgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtEYXRhR3JpZE5vZGUucHJvdG90eXBlLl9y ZWZyZXNoU3RhdHVzQ2VsbCk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJj ZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZS5wcm90b3R5cGUuaXNGcm9tRGF0 YVVSTCk6CisKIDIwMTEtMDQtMDQgIEFuZHJleSBBZGFpa2luICA8YWFuZHJleUBnb29nbGUuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtQYW5lbC5qcyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya1BhbmVsLmpzCmluZGV4IGQ0MzVm OGIuLjcwZGRhZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvTmV0d29ya1BhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvTmV0d29ya1BhbmVsLmpzCkBAIC0xNTIwLDggKzE1MjAsMTMgQEAgV2ViSW5zcGVjdG9yLk5l dHdvcmtEYXRhR3JpZE5vZGUucHJvdG90eXBlID0gewogICAgICAgICAgICAgdGhpcy5fYXBwZW5k U3VidGl0bGUodGhpcy5fc3RhdHVzQ2VsbCwgdGhpcy5fcmVzb3VyY2Uuc3RhdHVzVGV4dCk7CiAg ICAgICAgICAgICB0aGlzLl9zdGF0dXNDZWxsLnRpdGxlID0gdGhpcy5fcmVzb3VyY2Uuc3RhdHVz Q29kZSArICIgIiArIHRoaXMuX3Jlc291cmNlLnN0YXR1c1RleHQ7CiAgICAgICAgIH0gZWxzZSB7 Ci0gICAgICAgICAgICB0aGlzLl9zdGF0dXNDZWxsLmFkZFN0eWxlQ2xhc3MoIm5ldHdvcmstZGlt LWNlbGwiKTsKLSAgICAgICAgICAgIHRoaXMuX3N0YXR1c0NlbGwudGV4dENvbnRlbnQgPSBXZWJJ bnNwZWN0b3IuVUlTdHJpbmcoIlBlbmRpbmciKTsKKyAgICAgICAgICAgIGlmICh0aGlzLl9yZXNv dXJjZS5pc0Zyb21EYXRhVVJMKCkgJiYgdGhpcy5fcmVzb3VyY2UuZmluaXNoZWQpIHsKKyAgICAg ICAgICAgICAgICB0aGlzLl9zdGF0dXNDZWxsLnRleHRDb250ZW50ID0gV2ViSW5zcGVjdG9yLlVJ U3RyaW5nKCIoZGF0YSB1cmwpIik7CisgICAgICAgICAgICAgICAgdGhpcy5fc3RhdHVzQ2VsbC5h ZGRTdHlsZUNsYXNzKCJuZXR3b3JrLWRpbS1jZWxsIik7CisgICAgICAgICAgICB9IGVsc2Ugewor ICAgICAgICAgICAgICAgIHRoaXMuX3N0YXR1c0NlbGwuYWRkU3R5bGVDbGFzcygibmV0d29yay1k aW0tY2VsbCIpOworICAgICAgICAgICAgICAgIHRoaXMuX3N0YXR1c0NlbGwudGV4dENvbnRlbnQg PSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlBlbmRpbmciKTsKKyAgICAgICAgICAgIH0KICAgICAg ICAgfQogICAgIH0sCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvUmVzb3VyY2UuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jl c291cmNlLmpzCmluZGV4IDgwMzVmZDguLjk3ZWZmMTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2UuanMKKysrIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZS5qcwpAQCAtNzEzLDYgKzcxMywxMSBAQCBXZWJJ bnNwZWN0b3IuUmVzb3VyY2UucHJvdG90eXBlID0gewogICAgICAgICAgICAgaW1hZ2Uuc3JjID0g dGhpcy51cmw7CiAgICAgfSwKIAorICAgIGlzRnJvbURhdGFVUkw6IGZ1bmN0aW9uKCkKKyAgICB7 CisgICAgICAgIHJldHVybiB0aGlzLnVybC5tYXRjaCgvXmRhdGE6L2kpOworICAgIH0sCisgICAg CiAgICAgX2NvbnRlbnRVUkw6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAgICAgIGNvbnN0IG1heERh dGFVcmxTaXplID0gMTAyNCAqIDEwMjQ7Cg== 88276 2011-04-05 10:52:41 -0700 2011-04-05 14:59:27 -0700 Patch with fixes data_url text/plain 2671 vsevik ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ZWMxMGMxLi5lZWMzOWUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDQtMDUgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogZml4IGRhdGEgdXJsJ3Mgc3RhdHVzIGFuZCB0aW1pbmcgdGhlIG5ldHdvcmsgcGFuZWwu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzA2Ngor CisgICAgICAgIEFkZGVkIGRhdGEgdXJsIHN1cHBvcnQgZm9yIHN0YXR1cyBvZiBuZXR3b3JrIHJl c291cmNlcy4KKworICAgICAgICAqIEVuZ2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qczoK KyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtQYW5lbC5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5OZXR3b3JrRGF0YUdyaWROb2RlLnByb3RvdHlwZS5fcmVmcmVzaFN0YXR1 c0NlbGwpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2UuanM6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2UucHJvdG90eXBlLmlzRGF0YVVSTCk6CisKIDIwMTEt MDQtMDQgIEFuZHJleSBBZGFpa2luICA8YWFuZHJleUBnb29nbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9F bmdsaXNoLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMgYi9Tb3VyY2UvV2ViQ29yZS9FbmdsaXNo Lmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKaW5kZXggMGFjZGU5NTkyOWQ0N2Y0YjBlMWZiM2I1 MzU2Yjk3ZDQ0MzkwNDQ2My4uMTU5MzhkOTdkOTg2NzZmODEwOTE4ZDNkYjBiODU0MDg1MWZlYzZk YyAxMDA2NDQKR0lUIGJpbmFyeSBwYXRjaApkZWx0YSA3Mgp6Y21YPiNrOW95PjxfIVR0eCt4NWEz PylGVXopO0ZpI0VgP0YkKUxtIzMqXn1YdUBadkAxQigzUUw7P05EQ3hrTDQKTjJNQVNkSFZ+SEQw fDAwSDVtZipICgpkZWx0YSAyMgplY21aMjZwWlV+MDxfIVR0bFNQRTlDYSk3cCt1U0VDd0ZkeGM5 fCskNwoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmV0 d29ya1BhbmVsLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3Jr UGFuZWwuanMKaW5kZXggZDQzNWY4Yi4uMDFlZjA2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrUGFuZWwuanMKQEAgLTE1MjAsOCArMTUyMCwx MSBAQCBXZWJJbnNwZWN0b3IuTmV0d29ya0RhdGFHcmlkTm9kZS5wcm90b3R5cGUgPSB7CiAgICAg ICAgICAgICB0aGlzLl9hcHBlbmRTdWJ0aXRsZSh0aGlzLl9zdGF0dXNDZWxsLCB0aGlzLl9yZXNv dXJjZS5zdGF0dXNUZXh0KTsKICAgICAgICAgICAgIHRoaXMuX3N0YXR1c0NlbGwudGl0bGUgPSB0 aGlzLl9yZXNvdXJjZS5zdGF0dXNDb2RlICsgIiAiICsgdGhpcy5fcmVzb3VyY2Uuc3RhdHVzVGV4 dDsKICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIGlmICh0aGlzLl9yZXNvdXJjZS5pc0Rh dGFVUkwoKSAmJiB0aGlzLl9yZXNvdXJjZS5maW5pc2hlZCkKKyAgICAgICAgICAgICAgICB0aGlz Ll9zdGF0dXNDZWxsLnRleHRDb250ZW50ID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCIoZGF0YSB1 cmwpIik7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgdGhpcy5fc3RhdHVzQ2Vs bC50ZXh0Q29udGVudCA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiUGVuZGluZyIpOwogICAgICAg ICAgICAgdGhpcy5fc3RhdHVzQ2VsbC5hZGRTdHlsZUNsYXNzKCJuZXR3b3JrLWRpbS1jZWxsIik7 Ci0gICAgICAgICAgICB0aGlzLl9zdGF0dXNDZWxsLnRleHRDb250ZW50ID0gV2ViSW5zcGVjdG9y LlVJU3RyaW5nKCJQZW5kaW5nIik7CiAgICAgICAgIH0KICAgICB9LAogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlLmpzIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZS5qcwppbmRleCA4MDM1ZmQ4Li4xZWMw NjE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291 cmNlLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2Uu anMKQEAgLTcxMyw2ICs3MTMsMTEgQEAgV2ViSW5zcGVjdG9yLlJlc291cmNlLnByb3RvdHlwZSA9 IHsKICAgICAgICAgICAgIGltYWdlLnNyYyA9IHRoaXMudXJsOwogICAgIH0sCiAKKyAgICBpc0Rh dGFVUkw6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIHJldHVybiB0aGlzLnVybC5tYXRjaCgv XmRhdGE6L2kpOworICAgIH0sCisgICAgCiAgICAgX2NvbnRlbnRVUkw6IGZ1bmN0aW9uKCkKICAg ICB7CiAgICAgICAgIGNvbnN0IG1heERhdGFVcmxTaXplID0gMTAyNCAqIDEwMjQ7Cg==