53059 2011-01-24 18:59:30 -0800 Add runtime checks for invariants in memory cache 2011-01-24 22:17:38 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 53045 1 mihaip mihaip commit-queue dglazkov gustavo koivisto tonyg webkit-ews webkit.review.bot xan.lopez oldest_to_newest 339445 0 mihaip 2011-01-24 18:59:30 -0800 Add runtime checks for invariants in memory cache 339446 1 80008 mihaip 2011-01-24 19:00:57 -0800 Created attachment 80008 Patch 339448 2 webkit.review.bot 2011-01-24 19:05:04 -0800 Attachment 80008 did not build on chromium: Build output: http://queues.webkit.org/results/7622317 339449 3 webkit.review.bot 2011-01-24 19:05:38 -0800 Attachment 80008 did not build on gtk: Build output: http://queues.webkit.org/results/7559348 339451 4 webkit-ews 2011-01-24 19:15:38 -0800 Attachment 80008 did not build on qt: Build output: http://queues.webkit.org/results/7561346 339462 5 webkit.review.bot 2011-01-24 20:36:58 -0800 Attachment 80008 did not build on mac: Build output: http://queues.webkit.org/results/7540340 339466 6 webkit.review.bot 2011-01-24 20:57:31 -0800 Attachment 80008 did not build on chromium: Build output: http://queues.webkit.org/results/7630223 339473 7 80014 mihaip 2011-01-24 21:32:52 -0800 Created attachment 80014 Patch 339474 8 mihaip 2011-01-24 21:34:46 -0800 Should now build in release mode. 339499 9 80014 commit-queue 2011-01-24 22:17:33 -0800 Comment on attachment 80014 Patch Clearing flags on attachment: 80014 Committed r76575: <http://trac.webkit.org/changeset/76575> 339500 10 commit-queue 2011-01-24 22:17:38 -0800 All reviewed patches have been landed. Closing bug. 80008 2011-01-24 19:00:57 -0800 2011-01-24 21:32:47 -0800 Patch bug-53059-20110124190056.patch text/plain 2319 mihaip ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyYWI2ZTdjNmY0NjM3NWRlOWExNGRhMTAzN2VmZjA4ZWU3ZWMwMzM3Li5m OTA3ZGYzNTVmMDkwYmY0ZjQ2ZDU4ZWE4YjdkYjVhNTFiYWIxODc1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjAgQEAKKzIwMTEtMDEtMjQgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkIHJ1bnRpbWUgY2hlY2tzIGZvciBpbnZhcmlhbnRzIGluIG1lbW9yeSBjYWNoZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTMwNTkKKyAgICAgICAg CisgICAgICAgIFRvIGhlbHAgdHJhY2sgZG93biBidWcgNTMwNDUsIGFkZCBzb21lIENSQVNIIGNh bGxzIGluIGFkZGl0aW9uIHRvCisgICAgICAgIEFTU0VSVHMsIHNvIHRoYXQgd2UgY2FuIHRyYWNr IGRvd24gZmFpbHVyZXMgaW4gcmVsaWFiaWxpdHkgYm90cy4KKworICAgICAgICBKdXN0IHNvbWUg Y2hlY2tzLCBubyBuZXcgdGVzdHMgbmVjZXNzYXJ5LgorICAgICAgICAKKyAgICAgICAgKiBjc3Mv Q1NTSW1hZ2VWYWx1ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NJbWFnZVZhbHVlOjpjYWNo ZWRJbWFnZSk6CisgICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkNhY2hlZFJlc291cmNlOjp+Q2FjaGVkUmVzb3VyY2UpOgorCiAyMDEx LTAxLTI0ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBXaW5kb3dz IFByb2R1Y3Rpb24gYnVpbGQgZml4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT SW1hZ2VWYWx1ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTSW1hZ2VWYWx1ZS5jcHAKaW5k ZXggYTkwMzhiOWE1Y2E3YWUzN2ZkMzlkNWE1MTM1OGU2ZWU0MmJjNDk3ZS4uNjg5NjU5NjNjNzQ4 NmI2YTljNzk1MDJiYjYyN2VjYThhMGU1MDJmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Y3NzL0NTU0ltYWdlVmFsdWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NJbWFnZVZh bHVlLmNwcApAQCAtNjcsNiArNjcsMTAgQEAgU3R5bGVDYWNoZWRJbWFnZSogQ1NTSW1hZ2VWYWx1 ZTo6Y2FjaGVkSW1hZ2UoQ2FjaGVkUmVzb3VyY2VMb2FkZXIqIGxvYWRlcikKIFN0eWxlQ2FjaGVk SW1hZ2UqIENTU0ltYWdlVmFsdWU6OmNhY2hlZEltYWdlKENhY2hlZFJlc291cmNlTG9hZGVyKiBs b2FkZXIsIGNvbnN0IFN0cmluZyYgdXJsKQogewogICAgIEFTU0VSVChsb2FkZXIpOworICAgIGlm ICghbG9hZGVyKSB7CisgICAgICAgIC8vIEZJWE1FOiBSZW1vdmUgd2hlbiBodHRwOi8vd2Via2l0 Lm9yZy9iLzUzMDQ1IGlzIGZpeGVkLgorICAgICAgICBDUkFTSCgpOworICAgIH0KIAogICAgIGlm ICghbV9hY2Nlc3NlZEltYWdlKSB7CiAgICAgICAgIG1fYWNjZXNzZWRJbWFnZSA9IHRydWU7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuY3Bw IGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcAppbmRleCAw NmIzMTMxNTQ2MzY3ODBlZDVlNDNlNDc4OWY5NzczNTI1ZTM1OTNlLi40Y2Q2NDdmZGEwNGQwMmFh ZWExMjQ2N2Q3MjJmYzc4OTkyOGQyNGYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9j YWNoZS9DYWNoZWRSZXNvdXJjZS5jcHAKQEAgLTExNyw2ICsxMTcsMTIgQEAgQ2FjaGVkUmVzb3Vy Y2U6On5DYWNoZWRSZXNvdXJjZSgpCiAgICAgQVNTRVJUKCFpbkNhY2hlKCkpOwogICAgIEFTU0VS VCghbV9kZWxldGVkKTsKICAgICBBU1NFUlQodXJsKCkuaXNOdWxsKCkgfHwgbWVtb3J5Q2FjaGUo KS0+cmVzb3VyY2VGb3JVUkwoS1VSTChQYXJzZWRVUkxTdHJpbmcsIHVybCgpKSkgIT0gdGhpcyk7 CisgICAgCisgICAgaWYgKG1fZGVsZXRlZCkgeworICAgICAgICAvLyBGSVhNRTogUmVtb3ZlIHdo ZW4gaHR0cDovL3dlYmtpdC5vcmcvYi81MzA0NSBpcyBmaXhlZC4KKyAgICAgICAgQ1JBU0goKTsK KyAgICB9CisgICAgCiAjaWZuZGVmIE5ERUJVRwogICAgIG1fZGVsZXRlZCA9IHRydWU7CiAgICAg Y2FjaGVkUmVzb3VyY2VMZWFrQ291bnRlci5kZWNyZW1lbnQoKTsK 80014 2011-01-24 21:32:52 -0800 2011-01-24 22:17:33 -0800 Patch bug-53059-20110124213251.patch text/plain 3217 mihaip ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2ZjE2NjI4YzcyMTQ4NzhmNjMzZjYzZjA5OGUxMGQ2NzU5Mzk1MzUwLi42 ZWE2NWMwNDRlNjdjYjlhN2I2NTM0MDhiMzBjY2YzNzViZWMwOTYyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjEgQEAKKzIwMTEtMDEtMjQgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkIHJ1bnRpbWUgY2hlY2tzIGZvciBpbnZhcmlhbnRzIGluIG1lbW9yeSBjYWNoZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTMwNTkKKyAgICAgICAg CisgICAgICAgIFRvIGhlbHAgdHJhY2sgZG93biBidWcgNTMwNDUsIGFkZCBzb21lIENSQVNIIGNh bGxzIGluIGFkZGl0aW9uIHRvCisgICAgICAgIEFTU0VSVHMsIHNvIHRoYXQgd2UgY2FuIHRyYWNr IGRvd24gZmFpbHVyZXMgaW4gcmVsaWFiaWxpdHkgYm90cy4KKworICAgICAgICBKdXN0IHNvbWUg Y2hlY2tzLCBubyBuZXcgdGVzdHMgbmVjZXNzYXJ5LgorICAgICAgICAKKyAgICAgICAgKiBjc3Mv Q1NTSW1hZ2VWYWx1ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NJbWFnZVZhbHVlOjpjYWNo ZWRJbWFnZSk6CisgICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmg6CisgICAg ICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkNhY2hlZFJlc291cmNlOjp+Q2FjaGVkUmVzb3VyY2UpOgorCiAyMDExLTAxLTI0ICBLZW50IFRh bXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJp IEdsYXprb3YuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTSW1hZ2VWYWx1ZS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTSW1hZ2VWYWx1ZS5jcHAKaW5kZXggYTkwMzhiOWE1 Y2E3YWUzN2ZkMzlkNWE1MTM1OGU2ZWU0MmJjNDk3ZS4uNjg5NjU5NjNjNzQ4NmI2YTljNzk1MDJi YjYyN2VjYThhMGU1MDJmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0ltYWdl VmFsdWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NJbWFnZVZhbHVlLmNwcApAQCAt NjcsNiArNjcsMTAgQEAgU3R5bGVDYWNoZWRJbWFnZSogQ1NTSW1hZ2VWYWx1ZTo6Y2FjaGVkSW1h Z2UoQ2FjaGVkUmVzb3VyY2VMb2FkZXIqIGxvYWRlcikKIFN0eWxlQ2FjaGVkSW1hZ2UqIENTU0lt YWdlVmFsdWU6OmNhY2hlZEltYWdlKENhY2hlZFJlc291cmNlTG9hZGVyKiBsb2FkZXIsIGNvbnN0 IFN0cmluZyYgdXJsKQogewogICAgIEFTU0VSVChsb2FkZXIpOworICAgIGlmICghbG9hZGVyKSB7 CisgICAgICAgIC8vIEZJWE1FOiBSZW1vdmUgd2hlbiBodHRwOi8vd2Via2l0Lm9yZy9iLzUzMDQ1 IGlzIGZpeGVkLgorICAgICAgICBDUkFTSCgpOworICAgIH0KIAogICAgIGlmICghbV9hY2Nlc3Nl ZEltYWdlKSB7CiAgICAgICAgIG1fYWNjZXNzZWRJbWFnZSA9IHRydWU7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuY3BwIGIvU291cmNlL1dl YkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcAppbmRleCAwNmIzMTMxNTQ2MzY3 ODBlZDVlNDNlNDc4OWY5NzczNTI1ZTM1OTNlLi44ODRiMTE1NjUzOTY3OGRjNGUyY2MwMTZmYTQ0 ZTYwNzVmYWFmYWFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2Fj aGVkUmVzb3VyY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRS ZXNvdXJjZS5jcHAKQEAgLTkzLDggKzkzLDggQEAgQ2FjaGVkUmVzb3VyY2U6OkNhY2hlZFJlc291 cmNlKGNvbnN0IFN0cmluZyYgdXJsLCBUeXBlIHR5cGUpCiAgICAgLCBtX2xvYWRpbmcoZmFsc2Up CiAgICAgLCBtX3R5cGUodHlwZSkKICAgICAsIG1fc3RhdHVzKFBlbmRpbmcpCi0jaWZuZGVmIE5E RUJVRwogICAgICwgbV9kZWxldGVkKGZhbHNlKQorI2lmbmRlZiBOREVCVUcKICAgICAsIG1fbHJ1 SW5kZXgoMCkKICNlbmRpZgogICAgICwgbV9uZXh0SW5BbGxSZXNvdXJjZXNMaXN0KDApCkBAIC0x MTcsNiArMTE3LDEyIEBAIENhY2hlZFJlc291cmNlOjp+Q2FjaGVkUmVzb3VyY2UoKQogICAgIEFT U0VSVCghaW5DYWNoZSgpKTsKICAgICBBU1NFUlQoIW1fZGVsZXRlZCk7CiAgICAgQVNTRVJUKHVy bCgpLmlzTnVsbCgpIHx8IG1lbW9yeUNhY2hlKCktPnJlc291cmNlRm9yVVJMKEtVUkwoUGFyc2Vk VVJMU3RyaW5nLCB1cmwoKSkpICE9IHRoaXMpOworICAgIAorICAgIGlmIChtX2RlbGV0ZWQpIHsK KyAgICAgICAgLy8gRklYTUU6IFJlbW92ZSB3aGVuIGh0dHA6Ly93ZWJraXQub3JnL2IvNTMwNDUg aXMgZml4ZWQuCisgICAgICAgIENSQVNIKCk7CisgICAgfQorICAgIAogI2lmbmRlZiBOREVCVUcK ICAgICBtX2RlbGV0ZWQgPSB0cnVlOwogICAgIGNhY2hlZFJlc291cmNlTGVha0NvdW50ZXIuZGVj cmVtZW50KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVk UmVzb3VyY2UuaCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5o CmluZGV4IDVjOGIzOGYxYWJhNTVlNTMwZTkzN2Q5MjMyNWEyMDJlZWQ4ZTRlNmQuLjMzNzlmOGMy MTFlYjNmYjBmNzc3OGM3Mzk1NzNlN2M1YmI2M2QyODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xv YWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5oCkBAIC0yNjYsOCArMjY2LDkgQEAgcHJpdmF0ZToK ICAgICB1bnNpZ25lZCBtX3R5cGUgOiAzOyAvLyBUeXBlCiAgICAgdW5zaWduZWQgbV9zdGF0dXMg OiAzOyAvLyBTdGF0dXMKIAotI2lmbmRlZiBOREVCVUcKKyAgICAvLyBGSVhNRTogTW92ZSBtX2Rl bGV0ZWQgYmFjayBpbnNpZGUgTkRFQlVHIHdoZW4gaHR0cDovL3dlYmtpdC5vcmcvYi81MzA0NSBp cyBmaXhlZC4KICAgICBib29sIG1fZGVsZXRlZDsKKyNpZm5kZWYgTkRFQlVHCiAgICAgdW5zaWdu ZWQgbV9scnVJbmRleDsKICNlbmRpZgogCg==