53057 2011-01-24 18:01:28 -0800 [GTK] Two tests crash after r76555 2011-02-01 17:32:49 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 mrobinson webkit-unassigned svillar xan.lopez oldest_to_newest 339421 0 mrobinson 2011-01-24 18:01:28 -0800 Two tests crash after r76555: http/tests/xmlhttprequest/simple-cross-origin-denied-events-post.html and http/tests/xmlhttprequest/simple-cross-origin-denied-events-sync.html. Here is the stack trace: #0 0x00007f02754aff01 in WebCore::sendRequestCallback (source=0x1872540, res=0x1871520, userData=0x0) at ../../Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:513 513 client->didFail(handle.get(), resourceError); Thread 1 (Thread 8568): #0 0x00007f02754aff01 in WebCore::sendRequestCallback (source=0x1872540, res=0x1871520, userData=0x0) at ../../Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:513 #1 0x00007f02754be8bd in sent_async (source=0x11296e0, result=0x18715e0, user_data=0x1871520) at ../../Source/WebCore/platform/network/soup/cache/soup-request-http.c:119 #2 0x00007f02754bc592 in wrapper_callback (source_object=0x11296e0, res=0x18715e0, user_data=0x1871520) at ../../Source/WebCore/platform/network/soup/cache/soup-http-input-stream.c:540 #3 0x00007f02754bc7a2 in send_async_finished (stream=0x11296e0) at ../../Source/WebCore/platform/network/soup/cache/soup-http-input-stream.c:600 #4 0x00007f02754bbd53 in webkit_soup_http_input_stream_finished (msg=0x17b4b20, stream=0x11296e0) at ../../Source/WebCore/platform/network/soup/cache/soup-http-input-stream.c:311 #5 0x00007f0277c87d1e in g_closure_invoke (closure=0x1892dd0, return_value=0x0, n_param_values=1, param_values=0x11dbc60, invocation_hint=0x7fffecbfe690) at /home/kov/debian/tmp/glib2.0-2.27.5.2010128/gobject/gclosure.c:766 #6 0x00007f0277ca0d99 in signal_emit_unlocked_R (node=0x17b21f0, detail=<value optimized out>, instance=<value optimized out>, emission_return=<value optimized out>, instance_and_params=<value optimized out>) at /home/kov/debian/tmp/glib2.0-2.27.5.2010128/gobject/gsignal.c:3252 #7 0x00007f0277ca2516 in g_signal_emit_valist (instance=0x17b4b20, signal_id=<value optimized out>, detail=0, var_args=0x7fffecbfe880) at /home/kov/debian/tmp/glib2.0-2.27.5.2010128/gobject/gsignal.c:2983 #8 0x00007f0277ca2d43 in g_signal_emit (instance=0x188bfe8, signal_id=6, detail=1) at /home/kov/debian/tmp/glib2.0-2.27.5.2010128/gobject/gsignal.c:3040 #9 0x00007f0277e3fb23 in process_queue_item (item=0x11b7ea0, should_prune=0x7fffecbfe9bc, loop=1) at soup-session-async.c:376 #10 0x00007f0277e3fe81 in run_queue (sa=<value optimized out>) at soup-session-async.c:418 #11 0x00007f0277e3ff33 in idle_run_queue (sa=0x7f0264001030) at soup-session-async.c:443 #12 0x00007f02734ed0b2 in g_main_dispatch (context=0x1127ee0) at /home/kov/debian/tmp/glib2.0-2.27.5.2010128/glib/gmain.c:2440 #13 g_main_context_dispatch (context=0x1127ee0) at /home/kov/debian/tmp/glib2.0-2.27.5.2010128/glib/gmain.c:3013 #14 0x00007f02734f1778 in g_main_context_iterate (context=0x1127ee0, block=<value optimized out>, dispatch=<value optimized out>, self=<value optimized out>) at /home/kov/debian/tmp/glib2.0-2.27.5.2010128/glib/gmain.c:3091 #15 0x00007f02734f1c85 in g_main_loop_run (loop=0x17b4740) at /home/kov/debian/tmp/glib2.0-2.27.5.2010128/glib/gmain.c:3299 #16 0x00007f0274649657 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0 #17 0x000000000041cac5 in runTest (testPathOrURL=...) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:655 #18 0x000000000041c19a in runTestingServerLoop () at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:469 #19 0x000000000041e09b in main (argc=2, argv=0x7fffecbff5e8) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1096 I will try to resolve this first thing tomorrow. 339793 1 mrobinson 2011-01-25 11:45:04 -0800 The issue here is that we are calling handle->start(...) unconditionally even if there is a scheduled failure. I believe we can remedy this problem by calling ::create instead of creating the handle manually. Should have a patch soon. 339852 2 80104 mrobinson 2011-01-25 12:39:17 -0800 Created attachment 80104 Patch 343549 3 80104 gustavo 2011-02-01 14:29:58 -0800 Comment on attachment 80104 Patch Tests are no longer timing out I assume? =) 343551 4 mrobinson 2011-02-01 14:33:35 -0800 (In reply to comment #3) > (From update of attachment 80104 [details]) > Tests are no longer timing out I assume? =) Thanks for the review! Tests still do not timeout because 1. ResourceHandle::create does not call handle->start if there is a scheduled failure. 2. The Soup caller does not start the internal event loop if there is a scheduled failure. 343707 5 mrobinson 2011-02-01 17:31:51 -0800 Committed r77343: <http://trac.webkit.org/changeset/77343> 80104 2011-01-25 12:39:17 -0800 2011-02-01 17:32:49 -0800 Patch bug-53057-20110125123917.patch text/plain 3701 mrobinson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhODNlNWYxNWZkZTY4MTJiMDU1YTA2MjMwZjUxNThjY2E0NTdkNWI2Li5mZWFlMWMw YWRlMzNkNDg2YzEzMDgwOTg4MjAzZTk0NWRmMTU5ZWU5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTEtMDEtMjUgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIFR3byB0 ZXN0cyBjcmFzaCBhZnRlciByNzY1NTUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTUzMDU3CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvU2tpcHBlZDog VW5za2lwIHRlc3RzIHdoaWNoIGFyZSBubyBsb25nZXIgY3Jhc2hpbmcuCisKIDIwMTEtMDEtMjQg IE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFNraXAg YSBzbGlnaHRseSBkaWZmZXJlbnQgc2V0IG9mIHRlc3RzIGFmdGVyIHI3NjU1NS4gU2VlbXMgdGhh dCBzb21lIG9mIHRoZXNlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tp cHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCmluZGV4IGY2NjhiZjIzMGY2 M2EwYmEzY2Q4Y2QwNzBjYTU3NDIyZDAzODllYjIuLjdiOTEzYTViYThkZjVlNWU0YWY5MzM1ZmQy ZDA2OTBlMDQxNTBhY2UgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lw cGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCkBAIC01NjA5LDkgKzU2 MDksMyBAQCBzdmcvdGV4dC90ZXh0LXZrZXJuLnN2ZwogIyBUaGlzIG1lZGlhIHRlc3Qgc2VlbXMg dG8gdGltZSBvdXQuCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 MzA1NgogbWVkaWEvdW5zdXBwb3J0ZWQtcnRzcC5odG1sCi0KLSMgVGhlc2UgdHdvIGNyYXNoIGFm dGVyIHI3NjU1NS4KLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUz MDU3Ci1odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3NpbXBsZS1jcm9zcy1vcmlnaW4tZGVuaWVk LWV2ZW50cy1zeW5jLmh0bWwKLWh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qvc2ltcGxlLWNyb3Nz LW9yaWdpbi1kZW5pZWQtZXZlbnRzLmh0bWwKLWh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qvc2lt cGxlLWNyb3NzLW9yaWdpbi1kZW5pZWQtZXZlbnRzLXBvc3Qtc3luYy5odG1sCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggOTAwOTZiZTkyNmMxNzM2MTYzZDg3MDIwNzU1MzhlNGUyYjI0MzViZS4uMjA0Zjk5OWIzMTdi NDNmNjdhYzQ5Zjc1OTcxMjJmYjIxMDc4YTE0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBA CisyMDExLTAxLTI1ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBUd28g dGVzdHMgY3Jhc2ggYWZ0ZXIgcjc2NTU1CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01MzA1NworCisgICAgICAgIEluc3RlYWQgb2YgY3JlYXRpbmcgc3lu Y2hyb25vdXMgUmVzb3VyY2VIYW5kbGVzIG1hbnVhbGx5LCB1c2UgdGhlIDo6Y3JlYXRlIGZhY3Rv cnkuCisgICAgICAgIFRoaXMgZW5zdXJlcyB0aGF0IDo6c3RhcnQoKSBpcyBub3QgY2FsbGVkIHdo ZW4gdGhlcmUgaXMgYSBzY2hlZHVsZWQgZmFpbHVyZSBhbmQgYWxzbworICAgICAgICByZWR1Y2Vz IGNvZGUgZHVwbGljYXRpb24uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVz b3VyY2VIYW5kbGVTb3VwLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlOjps b2FkUmVzb3VyY2VTeW5jaHJvbm91c2x5KTogVXNlIHRoZSA6OmNyZWF0ZSBmYWN0b3J5IG1ldGhv ZC4KKwogMjAxMS0wMS0yNCAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIHJvdW5kIGFzY2VudCBhbmQgZGVzY2VudCB0byBtYXRjaCBvbGQgY29k ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNv dXJjZUhhbmRsZVNvdXAuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3Vw L1Jlc291cmNlSGFuZGxlU291cC5jcHAKaW5kZXggNDdhN2M1ODAyZTBiMTVlNGUyNTM5Y2M0ZWUw NzhiZmE0MjRmZjY1Zi4uZTUxMGY5MTE0NjdhNTg4YmFlZDllOTk4OWVmZmUyNjkyZmRjNTI0YSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNl SGFuZGxlU291cC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3Vw L1Jlc291cmNlSGFuZGxlU291cC5jcHAKQEAgLTc5NSwxMSArNzk1LDkgQEAgYm9vbCBSZXNvdXJj ZUhhbmRsZTo6d2lsbExvYWRGcm9tQ2FjaGUoUmVzb3VyY2VSZXF1ZXN0JiwgRnJhbWUqKQogdm9p ZCBSZXNvdXJjZUhhbmRsZTo6bG9hZFJlc291cmNlU3luY2hyb25vdXNseShOZXR3b3JraW5nQ29u dGV4dCogY29udGV4dCwgY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBTdG9yZWRDcmVk ZW50aWFscyAvKnN0b3JlZENyZWRlbnRpYWxzKi8sIFJlc291cmNlRXJyb3ImIGVycm9yLCBSZXNv dXJjZVJlc3BvbnNlJiByZXNwb25zZSwgVmVjdG9yPGNoYXI+JiBkYXRhKQogewogICAgIFdlYkNv cmVTeW5jaHJvbm91c0xvYWRlciBzeW5jTG9hZGVyKGVycm9yLCByZXNwb25zZSwgZGF0YSk7Ci0g ICAgLy8gRklYTUU6IHdlIHNob3VsZCB1c2UgdGhlIFJlc291cmNlSGFuZGxlOjpjcmVhdGUgbWV0 aG9kIGhlcmUsCi0gICAgLy8gYnV0IGl0IG1ha2VzIHVzIHRpbWVvdXQgaW4gYSBjb3VwbGUgb2Yg dGVzdHMuIFNlZQotICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00MTgyMwotICAgIFJlZlB0cjxSZXNvdXJjZUhhbmRsZT4gaGFuZGxlID0gYWRvcHRSZWYobmV3 IFJlc291cmNlSGFuZGxlKHJlcXVlc3QsICZzeW5jTG9hZGVyLCBmYWxzZSAvKmRlZmVyc0xvYWRp bmcqLywgZmFsc2UgLypzaG91bGRDb250ZW50U25pZmYqLykpOwotICAgIGhhbmRsZS0+c3RhcnQo Y29udGV4dCk7CisgICAgUmVmUHRyPFJlc291cmNlSGFuZGxlPiBoYW5kbGUgPSBjcmVhdGUoY29u dGV4dCwgcmVxdWVzdCwgJnN5bmNMb2FkZXIsIGZhbHNlIC8qZGVmZXJzTG9hZGluZyovLCBmYWxz ZSAvKnNob3VsZENvbnRlbnRTbmlmZiovKTsKKyAgICBpZiAoIWhhbmRsZSkKKyAgICAgICAgcmV0 dXJuOwogCiAgICAgLy8gSWYgdGhlIHJlcXVlc3QgaGFzIGFscmVhZHkgZmFpbGVkLCBkbyBub3Qg cnVuIHRoZSBtYWluIGxvb3AsIG9yIGVsc2Ugd2UnbGwgYmxvY2sgaW5kZWZpbml0ZWx5LgogICAg IGlmIChoYW5kbGUtPmQtPm1fc2NoZWR1bGVkRmFpbHVyZVR5cGUgIT0gTm9GYWlsdXJlKQo=