53025 2011-01-24 11:00:44 -0800 Fill unpainted rects with the background color. 2011-01-24 11:12:06 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 339098 0 andersca 2011-01-24 11:00:44 -0800 Fill unpainted rects with the background color. 339100 1 79938 andersca 2011-01-24 11:02:07 -0800 Created attachment 79938 Patch 339106 2 79938 sam 2011-01-24 11:09:27 -0800 Comment on attachment 79938 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79938&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:1227 > +static void drawPageBackground(CGContextRef context, WebPageProxy *page, const IntRect& rect) * on the wrong side for WebPageProxy. 339109 3 andersca 2011-01-24 11:12:06 -0800 Committed r76533: <http://trac.webkit.org/changeset/76533> 79938 2011-01-24 11:02:07 -0800 2011-01-24 11:09:27 -0800 Patch bug-53025-20110124110205.patch text/plain 3388 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2NTMwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDEtMjQgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBGaWxsIHVucGFpbnRlZCByZWN0cyB3aXRoIHRoZSBiYWNr Z3JvdW5kIGNvbG9yLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTMwMjUKKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbToKKyAg ICAgICAgKGRyYXdQYWdlQmFja2dyb3VuZCk6CisgICAgICAgIEFkZCBuZXcgaGVscGVyIGZ1bmN0 aW9uLgorCisgICAgICAgICgtW1dLVmlldyBkcmF3UmVjdDpdKToKKyAgICAgICAgSXRlcmF0ZSBv dmVyIHRoZSB1bnBhaW50ZWQgcmVjdHMgYW5kIGZpbGwgdGhlbSB3aXRoIHRoZSBiYWNrZ3JvdW5k IGNvbG9yLgorCiAyMDExLTAxLTI0ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgSm9obiBTdWxsaXZhbi4KSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHJldmlzaW9uIDc2NTI5KQorKysgU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0x MjI0LDE0ICsxMjI0LDM0IEBAIC0gKHZvaWQpX3dpbmRvd0ZyYW1lRGlkQ2hhbmdlOihOU05vdGlm aWMKICAgICBbc2VsZiBfdXBkYXRlV2luZG93QW5kVmlld0ZyYW1lc107CiB9CiAKK3N0YXRpYyB2 b2lkIGRyYXdQYWdlQmFja2dyb3VuZChDR0NvbnRleHRSZWYgY29udGV4dCwgV2ViUGFnZVByb3h5 ICpwYWdlLCBjb25zdCBJbnRSZWN0JiByZWN0KQoreworICAgIGlmICghcGFnZS0+ZHJhd3NCYWNr Z3JvdW5kKCkpCisgICAgICAgIHJldHVybjsKKworICAgIENHQ29udGV4dFNhdmVHU3RhdGUoY29u dGV4dCk7CisgICAgQ0dDb250ZXh0U2V0QmxlbmRNb2RlKGNvbnRleHQsIGtDR0JsZW5kTW9kZUNv cHkpOworCisgICAgQ0dDb2xvclJlZiBiYWNrZ3JvdW5kQ29sb3I7CisgICAgaWYgKHBhZ2UtPmRy YXdzVHJhbnNwYXJlbnRCYWNrZ3JvdW5kKCkpCisgICAgICAgIGJhY2tncm91bmRDb2xvciA9IENH Q29sb3JHZXRDb25zdGFudENvbG9yKGtDR0NvbG9yQ2xlYXIpOworICAgIGVsc2UKKyAgICAgICAg YmFja2dyb3VuZENvbG9yID0gQ0dDb2xvckdldENvbnN0YW50Q29sb3Ioa0NHQ29sb3JXaGl0ZSk7 CisKKyAgICBDR0NvbnRleHRTZXRGaWxsQ29sb3JXaXRoQ29sb3IoY29udGV4dCwgYmFja2dyb3Vu ZENvbG9yKTsKKyAgICBDR0NvbnRleHRGaWxsUmVjdChjb250ZXh0LCByZWN0KTsKKworICAgIENH Q29udGV4dFJlc3RvcmVHU3RhdGUoY29udGV4dCk7Cit9CisKIC0gKHZvaWQpZHJhd1JlY3Q6KE5T UmVjdClyZWN0CiB7CiAgICAgTE9HKFZpZXcsICJkcmF3UmVjdDogeDolZywgeTolZywgd2lkdGg6 JWcsIGhlaWdodDolZyIsIHJlY3Qub3JpZ2luLngsIHJlY3Qub3JpZ2luLnksIHJlY3Quc2l6ZS53 aWR0aCwgcmVjdC5zaXplLmhlaWdodCk7CiAgICAgX2RhdGEtPl9wYWdlLT5lbmRQcmludGluZygp OwogICAgIGlmICh1c2VOZXdEcmF3aW5nQXJlYSgpKSB7Ci0gICAgICAgIGlmIChEcmF3aW5nQXJl YVByb3h5SW1wbCogZHJhd2luZ0FyZWEgPSBzdGF0aWNfY2FzdDxEcmF3aW5nQXJlYVByb3h5SW1w bCo+KF9kYXRhLT5fcGFnZS0+ZHJhd2luZ0FyZWEoKSkpIHsKLSAgICAgICAgICAgIENHQ29udGV4 dFJlZiBjb250ZXh0ID0gc3RhdGljX2Nhc3Q8Q0dDb250ZXh0UmVmPihbW05TR3JhcGhpY3NDb250 ZXh0IGN1cnJlbnRDb250ZXh0XSBncmFwaGljc1BvcnRdKTsKKyAgICAgICAgQ0dDb250ZXh0UmVm IGNvbnRleHQgPSBzdGF0aWNfY2FzdDxDR0NvbnRleHRSZWY+KFtbTlNHcmFwaGljc0NvbnRleHQg Y3VycmVudENvbnRleHRdIGdyYXBoaWNzUG9ydF0pOwogCisgICAgICAgIGlmIChEcmF3aW5nQXJl YVByb3h5SW1wbCogZHJhd2luZ0FyZWEgPSBzdGF0aWNfY2FzdDxEcmF3aW5nQXJlYVByb3h5SW1w bCo+KF9kYXRhLT5fcGFnZS0+ZHJhd2luZ0FyZWEoKSkpIHsKICAgICAgICAgICAgIGNvbnN0IE5T UmVjdCAqcmVjdHNCZWluZ0RyYXduOwogICAgICAgICAgICAgTlNJbnRlZ2VyIG51bVJlY3RzQmVp bmdEcmF3bjsKICAgICAgICAgICAgIFtzZWxmIGdldFJlY3RzQmVpbmdEcmF3bjomcmVjdHNCZWlu Z0RyYXduIGNvdW50OiZudW1SZWN0c0JlaW5nRHJhd25dOwpAQCAtMTIzOSwxMSArMTI1OSwxMyBA QCAtICh2b2lkKWRyYXdSZWN0OihOU1JlY3QpcmVjdAogICAgICAgICAgICAgICAgIFJlZ2lvbiB1 bnBhaW50ZWRSZWdpb247CiAgICAgICAgICAgICAgICAgSW50UmVjdCByZWN0ID0gZW5jbG9zaW5n SW50UmVjdChyZWN0c0JlaW5nRHJhd25baV0pOwogICAgICAgICAgICAgICAgIGRyYXdpbmdBcmVh LT5wYWludChjb250ZXh0LCByZWN0LCB1bnBhaW50ZWRSZWdpb24pOworCisgICAgICAgICAgICAg ICAgVmVjdG9yPEludFJlY3Q+IHVucGFpbnRlZFJlY3RzID0gdW5wYWludGVkUmVnaW9uLnJlY3Rz KCk7CisgICAgICAgICAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCB1bnBhaW50ZWRSZWN0 cy5zaXplKCk7ICsraSkKKyAgICAgICAgICAgICAgICAgICAgZHJhd1BhZ2VCYWNrZ3JvdW5kKGNv bnRleHQsIF9kYXRhLT5fcGFnZS5nZXQoKSwgdW5wYWludGVkUmVjdHNbaV0pOwogICAgICAgICAg ICAgfQotICAgICAgICB9IGVsc2UgaWYgKF9kYXRhLT5fcGFnZS0+ZHJhd3NCYWNrZ3JvdW5kKCkp IHsKLSAgICAgICAgICAgIFtfZGF0YS0+X3BhZ2UtPmRyYXdzVHJhbnNwYXJlbnRCYWNrZ3JvdW5k KCkgPyBbTlNDb2xvciBjbGVhckNvbG9yXSA6IFtOU0NvbG9yIHdoaXRlQ29sb3JdIHNldF07Ci0g ICAgICAgICAgICBOU1JlY3RGaWxsKHJlY3QpOwotICAgICAgICB9CisgICAgICAgIH0gZWxzZSAK KyAgICAgICAgICAgIGRyYXdQYWdlQmFja2dyb3VuZChjb250ZXh0LCBfZGF0YS0+X3BhZ2UuZ2V0 KCksIGVuY2xvc2luZ0ludFJlY3QocmVjdCkpOwogCiAgICAgICAgIF9kYXRhLT5fcGFnZS0+ZGlk RHJhdygpOwogICAgICAgICByZXR1cm47Cg==