53015 2011-01-24 08:34:53 -0800 Remove obsolete public/API methods in chromium port 2011-01-24 09:36:41 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 satish webkit-unassigned ossy oldest_to_newest 339033 0 satish 2011-01-24 08:34:53 -0800 In http://trac.webkit.org/changeset/76128 the speech input API was changed to include additional parameters. Now that chromium has picked up this change we no longer need the old style wrappers which were left in place for a clean transition. 339034 1 79926 satish 2011-01-24 08:38:48 -0800 Created attachment 79926 Patch 339047 2 79929 satish 2011-01-24 08:55:56 -0800 Created attachment 79929 Patch 339048 3 79929 ossy 2011-01-24 08:59:15 -0800 Comment on attachment 79929 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79929&action=review Otherwise LGTM, rs=me. > Source/WebKit/chromium/ChangeLog:5 > + Remove obsolete public/API methods in chromium port s/methods/method 339063 4 satish 2011-01-24 09:36:41 -0800 Committed r76526: <http://trac.webkit.org/changeset/76526> 79926 2011-01-24 08:38:48 -0800 2011-01-24 08:55:51 -0800 Patch bug-53015-20110124163846.patch text/plain 975 satish ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNwZWVjaElucHV0 Q29udHJvbGxlci5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU3BlZWNoSW5w dXRDb250cm9sbGVyLmgKaW5kZXggZWI4M2VjN2EwZmM0ZmUxY2ZmZjA2YTdjM2M0OTA4MTllNWZh ZDg1NS4uNTc3YzVlMjU2M2FhMTE5ZDQ2ZWE2NWJiN2RiNjdmZDY4ZWI0ZDU5OSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU3BlZWNoSW5wdXRDb250cm9sbGVy LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU3BlZWNoSW5wdXRDb250 cm9sbGVyLmgKQEAgLTQ3LDExICs0Nyw2IEBAIHB1YmxpYzoKICAgICAvLyB0ZXh0IGFyZSByZXR1 cm5lZCB2aWEgdGhlIGxpc3RlbmVyIGludGVyZmFjZS4KICAgICB2aXJ0dWFsIGJvb2wgc3RhcnRS ZWNvZ25pdGlvbihpbnQgcmVxdWVzdElkLCBjb25zdCBXZWJSZWN0JiBlbGVtZW50UmVjdCwgY29u c3QgV2ViU3RyaW5nJiBsYW5ndWFnZSwgY29uc3QgV2ViU3RyaW5nJiBncmFtbWFyLCBjb25zdCBX ZWJTZWN1cml0eU9yaWdpbiYgb3JpZ2luKQogICAgIHsKLSAgICAgICAgcmV0dXJuIHN0YXJ0UmVj b2duaXRpb24ocmVxdWVzdElkLCBlbGVtZW50UmVjdCwgbGFuZ3VhZ2UsIGdyYW1tYXIpOwotICAg IH0KLSAgICAvLyBUT0RPKHNhdGlzaCk6IFJlbW92ZSB0aGlzIG9uY2UgY2hyb21pdW0gaGFzIHJv bGxlZCBwYXN0IHRoZSBhYm92ZSBjaGFuZ2UuCi0gICAgdmlydHVhbCBib29sIHN0YXJ0UmVjb2du aXRpb24oaW50IHJlcXVlc3RJZCwgY29uc3QgV2ViUmVjdCYgZWxlbWVudFJlY3QsIGNvbnN0IFdl YlN0cmluZyYgbGFuZ3VhZ2UsIGNvbnN0IFdlYlN0cmluZyYgZ3JhbW1hcikKLSAgICB7CiAgICAg ICAgIFdFQktJVF9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICAgICAgcmV0dXJuIGZhbHNlOwog ICAgIH0K 79929 2011-01-24 08:55:56 -0800 2011-01-24 08:59:15 -0800 Patch bug-53015-20110124165554.patch text/plain 1676 satish ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggNjA0MWE5NTYwZDI1NjNhNTNjNWM3YzhiOGMw Mzk2YmNkYTEwNjA1YS4uOTU3ZWIwYjlhOTU0MGNlNGJmYmIxMTkyNjBhMWJhMTA2MjBhM2I4OCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0wMS0yNCAg U2F0aXNoIFNhbXBhdGggIDxzYXRpc2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBvYnNvbGV0ZSBwdWJsaWMvQVBJ IG1ldGhvZHMgaW4gY2hyb21pdW0gcG9ydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTMwMTUKKworICAgICAgICAqIHB1YmxpYy9XZWJTcGVlY2hJbnB1 dENvbnRyb2xsZXIuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViU3BlZWNoSW5wdXRDb250cm9sbGVy OjpzdGFydFJlY29nbml0aW9uKTogUmVtb3ZlZCBvYnNvbGV0ZSBtZXRob2QKKwogMjAxMC0wMS0y NCAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGFyaW4gRmlzaGVyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViU3BlZWNoSW5wdXRDb250cm9sbGVyLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJTcGVlY2hJbnB1dENvbnRyb2xsZXIuaAppbmRleCBlYjgzZWM3YTBmYzRmZTFjZmZm MDZhN2MzYzQ5MDgxOWU1ZmFkODU1Li41NzdjNWUyNTYzYWExMTlkNDZlYTY1YmI3ZGI2N2ZkNjhl YjRkNTk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTcGVl Y2hJbnB1dENvbnRyb2xsZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJTcGVlY2hJbnB1dENvbnRyb2xsZXIuaApAQCAtNDcsMTEgKzQ3LDYgQEAgcHVibGljOgogICAg IC8vIHRleHQgYXJlIHJldHVybmVkIHZpYSB0aGUgbGlzdGVuZXIgaW50ZXJmYWNlLgogICAgIHZp cnR1YWwgYm9vbCBzdGFydFJlY29nbml0aW9uKGludCByZXF1ZXN0SWQsIGNvbnN0IFdlYlJlY3Qm IGVsZW1lbnRSZWN0LCBjb25zdCBXZWJTdHJpbmcmIGxhbmd1YWdlLCBjb25zdCBXZWJTdHJpbmcm IGdyYW1tYXIsIGNvbnN0IFdlYlNlY3VyaXR5T3JpZ2luJiBvcmlnaW4pCiAgICAgewotICAgICAg ICByZXR1cm4gc3RhcnRSZWNvZ25pdGlvbihyZXF1ZXN0SWQsIGVsZW1lbnRSZWN0LCBsYW5ndWFn ZSwgZ3JhbW1hcik7Ci0gICAgfQotICAgIC8vIFRPRE8oc2F0aXNoKTogUmVtb3ZlIHRoaXMgb25j ZSBjaHJvbWl1bSBoYXMgcm9sbGVkIHBhc3QgdGhlIGFib3ZlIGNoYW5nZS4KLSAgICB2aXJ0dWFs IGJvb2wgc3RhcnRSZWNvZ25pdGlvbihpbnQgcmVxdWVzdElkLCBjb25zdCBXZWJSZWN0JiBlbGVt ZW50UmVjdCwgY29uc3QgV2ViU3RyaW5nJiBsYW5ndWFnZSwgY29uc3QgV2ViU3RyaW5nJiBncmFt bWFyKQotICAgIHsKICAgICAgICAgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgICAg ICByZXR1cm4gZmFsc2U7CiAgICAgfQo=