5301 2005-10-08 07:41:58 -0700 webcore+svg build fails with gcc3.3 2005-10-11 02:08:27 -0700 1 1 1 Unclassified WebKit SVG 420+ Mac OS X 10.4 RESOLVED FIXED P4 Normal --- 1 julien.palmas eric oldest_to_newest 21581 0 julien.palmas 2005-10-08 07:41:58 -0700 2 errors with gcc3.3 - kdom/core/NodeImpl.h This file is included by KWQSlot.mm before the macro #define id ID_HACK in DrawDocument.mm This might be a bug of gcc4.0 - WebCore+SVG/DrawView.mm Many "may not respond to ..." warnings because DrawViewPrivate methods are not declared in the @interface. Build fails as we treat warnings as errors. The definitions of those methods are before their use (in the same file), so I don't know if there should be a warning ... 21582 1 4257 julien.palmas 2005-10-08 07:42:29 -0700 Created attachment 4257 Proposed patch 21589 2 4257 eric 2005-10-08 12:42:16 -0700 Comment on attachment 4257 Proposed patch The first change doesn't need to be in an #if block, since adding the forward defnitions there probably should have been done in the first place (and certainly doesn't hurt gcc 4.0). For the second change you should instead put the #define id ID_HACK block in the .mm file which is actually including this NodeImpl.h (likely through a long chain of other includes). See how this is done in DrawDocument.mm. You won't need to put them inside #if __GNUC__ <4 blocks then. Please correct those two and post another patch. Thanks! 21590 3 eric 2005-10-08 12:44:03 -0700 Now that I'm reading your comments: - kdom/core/NodeImpl.h This file is included by KWQSlot.mm before the macro #define id ID_HACK in DrawDocument.mm This might be a bug of gcc4.0 Just add a id -> ID_HACK around the include in KWQSlot.mm (inside the SVG_SUPPORT block). 21645 4 4274 julien.palmas 2005-10-09 18:36:56 -0700 Created attachment 4274 modified patch Put the #define id ID_HACK in KWQSlot.mm, not anymore in NodeImpl.h Put the #define id ID_HACK in DrawCanvasItem.mm. #undef id was needed in KWQApplication.h for other includes from this file. 21674 5 eric 2005-10-09 21:46:29 -0700 I'm still not convinced the qapplication.h change was necessary. If it is, it shouldn't be SVG specific. Can you explain to me why? 21741 6 4274 eric 2005-10-10 14:52:49 -0700 Comment on attachment 4274 modified patch We talked about an alternative solution to the KWQApplication.h problem (by removing the qapplication.h include from RenderStyle.h). Otherwise the patch looks good. I look forward to landing the final version! 21756 7 4302 julien.palmas 2005-10-10 18:09:21 -0700 Created attachment 4302 modified patch Like eric suggested, added #import <qapplication.h> before the #define id ID_HACK macro in DrawCanvasItem.mm 21757 8 4302 eric 2005-10-10 18:11:12 -0700 Comment on attachment 4302 modified patch Looks great! r=me 4257 2005-10-08 07:42:29 -0700 2005-10-09 18:36:56 -0700 Proposed patch gcc33_patch text/plain 1503 julien.palmas SW5kZXg6IFdlYkNvcmUrU1ZHL0RyYXdWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMv cm9vdC9TVkdTdXBwb3J0L1dlYkNvcmUrU1ZHL0RyYXdWaWV3Lm1tLHYKcmV0cmlldmluZyByZXZp c2lvbiAxLjcKZGlmZiAtcCAtdSAtcjEuNyBXZWJDb3JlK1NWRy9EcmF3Vmlldy5tbQotLS0gV2Vi Q29yZStTVkcvRHJhd1ZpZXcubW0JNSBPY3QgMjAwNSAwNTozNjo1NCAtMDAwMAkxLjcKKysrIFdl YkNvcmUrU1ZHL0RyYXdWaWV3Lm1tCTggT2N0IDIwMDUgMTQ6MjM6MDQgLTAwMDAKQEAgLTkwLDYg KzkwLDEzIEBAIHR5cGVkZWYgZW51bSB7CiAgICAgS0NhbnZhc1ZpZXdRdWFydHogKmNhbnZhc1Zp ZXc7CiAgICAgS1JlbmRlcmluZ0RldmljZUNvbnRleHRRdWFydHogKnF1YXJ0ekNvbnRleHQ7CiB9 CisKKyNpZiBfX0dOVUNfXyA8IDQKKy0gKERyYXdEb2N1bWVudCAqKWRvY3VtZW50OworLSAodm9p ZClzZXREb2N1bWVudDooRHJhd0RvY3VtZW50ICopZG9jOworLSAodm9pZClkcmF3UmVjdDooTlNS ZWN0KWRpcnR5Vmlld1JlY3Q7CisjZW5kaWYKKwogQGVuZCAKIAogQGltcGxlbWVudGF0aW9uIERy YXdWaWV3UHJpdmF0ZQpJbmRleDoga2RvbS9jb3JlL05vZGVJbXBsLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg ZmlsZTogL2N2cy9yb290L1NWR1N1cHBvcnQva2RvbS9jb3JlL05vZGVJbXBsLmgsdgpyZXRyaWV2 aW5nIHJldmlzaW9uIDEuNgpkaWZmIC1wIC11IC1yMS42IGtkb20vY29yZS9Ob2RlSW1wbC5oCi0t LSBrZG9tL2NvcmUvTm9kZUltcGwuaAkyOCBTZXAgMjAwNSAwNTowNjowNSAtMDAwMAkxLjYKKysr IGtkb20vY29yZS9Ob2RlSW1wbC5oCTggT2N0IDIwMDUgMTQ6MjM6MDYgLTAwMDAKQEAgLTQ3LDkg KzQ3LDE1IEBAIGNvbnN0IFFfVUlOVDE2IGFueU5hbWVzcGFjZSA9IDB4ZmZmZjsKIGNvbnN0IFFf VUlOVDE2IHhodG1sTmFtZXNwYWNlID0gMTsKIGNvbnN0IFFfVUlOVDE2IGFueUxvY2FsTmFtZSA9 IDB4ZmZmZjsKIAorI2lmIF9fR05VQ19fIDwgNAorI2RlZmluZSBpZCBJRF9IQUNLCisjZW5kaWYK IGlubGluZSBRX1VJTlQxNiBsb2NhbE5hbWVQYXJ0KFFfVUlOVDMyIGlkKSB7IHJldHVybiBpZCAm IE5vZGVJbXBsX0lkTG9jYWxNYXNrOyB9CiBpbmxpbmUgUV9VSU5UMTYgbmFtZXNwYWNlUGFydChR X1VJTlQzMiBpZCkgeyByZXR1cm4gKCgodW5zaWduZWQgaW50KWlkKSAmIE5vZGVJbXBsX0lkTlNN YXNrKSA+PiAxNjsgfQogaW5saW5lIFFfVUlOVDMyIG1ha2VJZChRX1VJTlQxNiBuLCBRX1VJTlQx NiBsKSB7IHJldHVybiAobiA8PCAxNikgfCBsOyB9CisjaWYgX19HTlVDX18gPCA0CisjdW5kZWYg aWQKKyNlbmRpZgogCiBjb25zdCBRX1VJTlQzMiBhbnlRTmFtZSA9IG1ha2VJZChhbnlOYW1lc3Bh Y2UsIGFueUxvY2FsTmFtZSk7CiAK 4274 2005-10-09 18:36:56 -0700 2005-10-10 18:09:21 -0700 modified patch patch_gcc33 text/plain 2394 julien.palmas SW5kZXg6IFdlYkNvcmUva3dxL0tXUUFwcGxpY2F0aW9uLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTog L2N2cy9yb290L1dlYkNvcmUva3dxL0tXUUFwcGxpY2F0aW9uLmgsdgpyZXRyaWV2aW5nIHJldmlz aW9uIDEuMjQKZGlmZiAtcCAtdSAtcjEuMjQgS1dRQXBwbGljYXRpb24uaAotLS0gV2ViQ29yZS9r d3EvS1dRQXBwbGljYXRpb24uaAkzMCBBdWcgMjAwNSAwOTozMDoyMyAtMDAwMAkxLjI0CisrKyBX ZWJDb3JlL2t3cS9LV1FBcHBsaWNhdGlvbi5oCTEwIE9jdCAyMDA1IDAxOjIzOjU4IC0wMDAwCkBA IC0yNiw2ICsyNiwxMCBAQAogI2lmbmRlZiBRQVBQTElDQVRJT05fSF8KICNkZWZpbmUgUUFQUExJ Q0FUSU9OX0hfCiAKKyNpZmRlZiBTVkdfU1VQUE9SVAorI3VuZGVmIGlkCisjZW5kaWYKKwogI2lu Y2x1ZGUgIktXUVBhbGV0dGUuaCIKICNpbmNsdWRlICJLV1FXaWRnZXQuaCIKIApJbmRleDogV2Vi Q29yZS9rd3EvS1dRU2xvdC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29y ZS9rd3EvS1dRU2xvdC5tbSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zNQpkaWZmIC1wIC11IC1y MS4zNSBLV1FTbG90Lm1tCi0tLSBXZWJDb3JlL2t3cS9LV1FTbG90Lm1tCTMgT2N0IDIwMDUgMjE6 MTM6MDkgLTAwMDAJMS4zNQorKysgV2ViQ29yZS9rd3EvS1dRU2xvdC5tbQkxMCBPY3QgMjAwNSAw MToyMzo1OCAtMDAwMApAQCAtMzUsNyArMzUsOSBAQAogI2ltcG9ydCAicmVuZGVyX2xheWVyLmgi CiAjaW1wb3J0ICJ4bWxodHRwcmVxdWVzdC5oIgogI2lmZGVmIFNWR19TVVBQT1JUCisjZGVmaW5l IGlkIElEX0hBQ0sKICNpbXBvcnQgImtzdmcyL21pc2MvS1NWR1RpbWVTY2hlZHVsZXIuaCIKKyN1 bmRlZiBpZAogI2VuZGlmCiAKIHVzaW5nIERPTTo6RG9jdW1lbnRJbXBsOwpJbmRleDogU1ZHU3Vw cG9ydC9XZWJDb3JlK1NWRy9EcmF3Q2FudmFzSXRlbS5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAv Y3ZzL3Jvb3QvU1ZHU3VwcG9ydC9XZWJDb3JlK1NWRy9EcmF3Q2FudmFzSXRlbS5tbSx2CnJldHJp ZXZpbmcgcmV2aXNpb24gMS41CmRpZmYgLXAgLXUgLXIxLjUgRHJhd0NhbnZhc0l0ZW0ubW0KLS0t IFNWR1N1cHBvcnQvV2ViQ29yZStTVkcvRHJhd0NhbnZhc0l0ZW0ubW0JNSBPY3QgMjAwNSAwNToz Njo1NCAtMDAwMAkxLjUKKysrIFNWR1N1cHBvcnQvV2ViQ29yZStTVkcvRHJhd0NhbnZhc0l0ZW0u bW0JMTAgT2N0IDIwMDUgMDE6MjI6NDUgLTAwMDAKQEAgLTI5LDYgKzI5LDggQEAKICNpbXBvcnQg PGtjYW52YXMvS0NhbnZhcy5oPgogI2ltcG9ydCA8a2NhbnZhcy9LQ2FudmFzSXRlbS5oPgogCisj ZGVmaW5lIGlkIElEX0hBQ0sKKwogI2ltcG9ydCA8a2RvbS9OYW1lc3BhY2UuaD4KICNpbXBvcnQg PGtkb20vSGVscGVyLmg+CiAjaW1wb3J0IDxrZG9tL0RPTVN0cmluZy5oPgpAQCAtMzgsNiArNDAs OCBAQAogI2ltcG9ydCA8a3N2ZzIvc3ZnL1NWR1JlY3RFbGVtZW50SW1wbC5oPgogI2ltcG9ydCA8 a3N2ZzIvc3ZnL1NWR1BhdGhFbGVtZW50SW1wbC5oPgogCisjdW5kZWYgaWQKKwogI2ltcG9ydCAi S1dRVGV4dFN0cmVhbS5oIgogCiB1c2luZyBuYW1lc3BhY2UgS0RPTTsKSW5kZXg6IFNWR1N1cHBv cnQvV2ViQ29yZStTVkcvRHJhd1ZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290 L1NWR1N1cHBvcnQvV2ViQ29yZStTVkcvRHJhd1ZpZXcubW0sdgpyZXRyaWV2aW5nIHJldmlzaW9u IDEuNwpkaWZmIC1wIC11IC1yMS43IERyYXdWaWV3Lm1tCi0tLSBTVkdTdXBwb3J0L1dlYkNvcmUr U1ZHL0RyYXdWaWV3Lm1tCTUgT2N0IDIwMDUgMDU6MzY6NTQgLTAwMDAJMS43CisrKyBTVkdTdXBw b3J0L1dlYkNvcmUrU1ZHL0RyYXdWaWV3Lm1tCTEwIE9jdCAyMDA1IDAxOjIyOjQ1IC0wMDAwCkBA IC05MCw2ICs5MCwxMSBAQCB0eXBlZGVmIGVudW0gewogICAgIEtDYW52YXNWaWV3UXVhcnR6ICpj YW52YXNWaWV3OwogICAgIEtSZW5kZXJpbmdEZXZpY2VDb250ZXh0UXVhcnR6ICpxdWFydHpDb250 ZXh0OwogfQorCistIChEcmF3RG9jdW1lbnQgKilkb2N1bWVudDsKKy0gKHZvaWQpc2V0RG9jdW1l bnQ6KERyYXdEb2N1bWVudCAqKWRvYzsKKy0gKHZvaWQpZHJhd1JlY3Q6KE5TUmVjdClkaXJ0eVZp ZXdSZWN0OworICAgICAKIEBlbmQgCiAKIEBpbXBsZW1lbnRhdGlvbiBEcmF3Vmlld1ByaXZhdGUK 4302 2005-10-10 18:09:21 -0700 2005-10-10 18:11:12 -0700 modified patch patch_gcc33 text/plain 1971 julien.palmas PyAuRFNfU3RvcmUKPyBHWmlwSW5mbGF0ZXIuY3BwCj8gR1ppcEluZmxhdGVyLmgKSW5kZXg6IFNW R1N1cHBvcnQvV2ViQ29yZStTVkcvRHJhd0NhbnZhc0l0ZW0ubW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmls ZTogL2N2cy9yb290L1NWR1N1cHBvcnQvV2ViQ29yZStTVkcvRHJhd0NhbnZhc0l0ZW0ubW0sdgpy ZXRyaWV2aW5nIHJldmlzaW9uIDEuNQpkaWZmIC11IC1wIC1yMS41IERyYXdDYW52YXNJdGVtLm1t Ci0tLSBTVkdTdXBwb3J0L1dlYkNvcmUrU1ZHL0RyYXdDYW52YXNJdGVtLm1tCTUgT2N0IDIwMDUg MDU6MzY6NTQgLTAwMDAJMS41CisrKyBTVkdTdXBwb3J0L1dlYkNvcmUrU1ZHL0RyYXdDYW52YXNJ dGVtLm1tCTExIE9jdCAyMDA1IDAxOjAzOjU2IC0wMDAwCkBAIC0yOSw2ICsyOSwxMCBAQAogI2lt cG9ydCA8a2NhbnZhcy9LQ2FudmFzLmg+CiAjaW1wb3J0IDxrY2FudmFzL0tDYW52YXNJdGVtLmg+ CiAKKyNpbXBvcnQgPHFhcHBsaWNhdGlvbi5oPgorCisjZGVmaW5lIGlkIElEX0hBQ0sKKwogI2lt cG9ydCA8a2RvbS9OYW1lc3BhY2UuaD4KICNpbXBvcnQgPGtkb20vSGVscGVyLmg+CiAjaW1wb3J0 IDxrZG9tL0RPTVN0cmluZy5oPgpAQCAtMzgsNiArNDIsOCBAQAogI2ltcG9ydCA8a3N2ZzIvc3Zn L1NWR1JlY3RFbGVtZW50SW1wbC5oPgogI2ltcG9ydCA8a3N2ZzIvc3ZnL1NWR1BhdGhFbGVtZW50 SW1wbC5oPgogCisjdW5kZWYgaWQKKwogI2ltcG9ydCAiS1dRVGV4dFN0cmVhbS5oIgogCiB1c2lu ZyBuYW1lc3BhY2UgS0RPTTsKSW5kZXg6IFNWR1N1cHBvcnQvV2ViQ29yZStTVkcvRHJhd1ZpZXcu bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1NWR1N1cHBvcnQvV2ViQ29yZStTVkcv RHJhd1ZpZXcubW0sdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNwpkaWZmIC11IC1wIC1yMS43IERy YXdWaWV3Lm1tCi0tLSBTVkdTdXBwb3J0L1dlYkNvcmUrU1ZHL0RyYXdWaWV3Lm1tCTUgT2N0IDIw MDUgMDU6MzY6NTQgLTAwMDAJMS43CisrKyBTVkdTdXBwb3J0L1dlYkNvcmUrU1ZHL0RyYXdWaWV3 Lm1tCTExIE9jdCAyMDA1IDAxOjAzOjU3IC0wMDAwCkBAIC05MCw2ICs5MCwxMSBAQCB0eXBlZGVm IGVudW0gewogICAgIEtDYW52YXNWaWV3UXVhcnR6ICpjYW52YXNWaWV3OwogICAgIEtSZW5kZXJp bmdEZXZpY2VDb250ZXh0UXVhcnR6ICpxdWFydHpDb250ZXh0OwogfQorCistIChEcmF3RG9jdW1l bnQgKilkb2N1bWVudDsKKy0gKHZvaWQpc2V0RG9jdW1lbnQ6KERyYXdEb2N1bWVudCAqKWRvYzsK Ky0gKHZvaWQpZHJhd1JlY3Q6KE5TUmVjdClkaXJ0eVZpZXdSZWN0OworCiBAZW5kIAogCiBAaW1w bGVtZW50YXRpb24gRHJhd1ZpZXdQcml2YXRlCkluZGV4OiBXZWJDb3JlL2t3cS9LV1FTbG90Lm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2t3cS9LV1FTbG90Lm1tLHYK cmV0cmlldmluZyByZXZpc2lvbiAxLjM1CmRpZmYgLXUgLXAgLXIxLjM1IEtXUVNsb3QubW0KLS0t IFdlYkNvcmUva3dxL0tXUVNsb3QubW0gIDMgT2N0IDIwMDUgMjE6MTM6MDkgLTAwMDAgICAgICAg MS4zNQorKysgV2ViQ29yZS9rd3EvS1dRU2xvdC5tbSAgMTEgT2N0IDIwMDUgMDE6MDE6NDQgLTAw MDAKQEAgLTM1LDcgKzM1LDkgQEAKICNpbXBvcnQgInJlbmRlcl9sYXllci5oIgogI2ltcG9ydCAi eG1saHR0cHJlcXVlc3QuaCIKICNpZmRlZiBTVkdfU1VQUE9SVAorI2RlZmluZSBpZCBJRF9IQUNL CiAjaW1wb3J0ICJrc3ZnMi9taXNjL0tTVkdUaW1lU2NoZWR1bGVyLmgiCisjdW5kZWYgaWQKICNl bmRpZgogCiB1c2luZyBET006OkRvY3VtZW50SW1wbDsK