52985 2011-01-23 15:26:39 -0800 Eliminated early return inside WebPageProxy::scaleWebView 2011-06-20 11:09:54 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac (Intel) OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dkaleta webkit-unassigned commit-queue dkaleta eric oldest_to_newest 338773 0 dkaleta 2011-01-23 15:26:39 -0800 Eliminated early return inside WebPageProxy::scaleWebView, making it consistent with WebKit1. 338775 1 79877 dkaleta 2011-01-23 15:30:08 -0800 Created attachment 79877 Proposed patch 338776 2 79878 dkaleta 2011-01-23 15:35:59 -0800 Created attachment 79878 Proposed patch 338778 3 79879 dkaleta 2011-01-23 15:38:48 -0800 Created attachment 79879 Proposed patch 338779 4 79880 dkaleta 2011-01-23 15:41:28 -0800 Created attachment 79880 Proposed patch 338780 5 79880 kdecker 2011-01-23 15:41:54 -0800 Comment on attachment 79880 Proposed patch r=me 423308 6 eric 2011-06-18 19:56:01 -0700 Kevin? did you plan to land this patch? You marked it cq-, but the author is not a committer. 423698 7 dkaleta 2011-06-20 09:19:59 -0700 This patch was already committed. > Kevin? did you plan to land this patch? You marked it cq-, but the author is not a committer. 79877 2011-01-23 15:30:08 -0800 2011-01-23 15:35:59 -0800 Proposed patch textmate stdin 7CH8KT.txt text/plain 1103 dkaleta SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2NDcyKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDEtMjMgIERhbWlhbiBL YWxldGEgIDxka2FsZXRhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICA8cmRhcjovL3Byb2JsZW0vODkwNTE3MT4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyOTg1CisKKyAgICAgICAgKiBV SVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5 OjpzY2FsZVdlYlZpZXcpOgorICAgICAgICBzYW1lIHNjYWxlIGZhY3Rvci4KKwogMjAxMS0wMS0y MyAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEYW4gQmVybnN0ZWluLgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBh Z2VQcm94eS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBh Z2VQcm94eS5jcHAJKHJldmlzaW9uIDc2NDY3KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg5MCw5ICs4OTAsNiBAQCB2b2lk IFdlYlBhZ2VQcm94eTo6c2NhbGVXZWJWaWV3KGRvdWJsZSBzCiAgICAgaWYgKCFpc1ZhbGlkKCkp CiAgICAgICAgIHJldHVybjsKIAotICAgIGlmIChtX3ZpZXdTY2FsZUZhY3RvciA9PSBzY2FsZSkK LSAgICAgICAgcmV0dXJuOwotCiAgICAgbV92aWV3U2NhbGVGYWN0b3IgPSBzY2FsZTsKICAgICBw cm9jZXNzKCktPnNlbmQoTWVzc2FnZXM6OldlYlBhZ2U6OlNjYWxlV2ViVmlldyhzY2FsZSwgb3Jp Z2luKSwgbV9wYWdlSUQpOwogfQo= 79878 2011-01-23 15:35:59 -0800 2011-01-23 15:38:48 -0800 Proposed patch textmate stdin KgEpzm.txt text/plain 1075 dkaleta SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2NDcyKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDEtMjMgIERhbWlhbiBL YWxldGEgIDxka2FsZXRhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICA8cmRhcjovL3Byb2JsZW0vODkwNTE3MT4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyOTg1CisKKyAgICAgICAgKiBV SVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5 OjpzY2FsZVdlYlZpZXcpOgorCiAyMDExLTAxLTIzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBA YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkocmV2aXNpb24gNzY0Njcp CisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkod29ya2luZyBj b3B5KQpAQCAtODkwLDkgKzg5MCw2IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpzY2FsZVdlYlZpZXco ZG91YmxlIHMKICAgICBpZiAoIWlzVmFsaWQoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYg KG1fdmlld1NjYWxlRmFjdG9yID09IHNjYWxlKQotICAgICAgICByZXR1cm47Ci0KICAgICBtX3Zp ZXdTY2FsZUZhY3RvciA9IHNjYWxlOwogICAgIHByb2Nlc3MoKS0+c2VuZChNZXNzYWdlczo6V2Vi UGFnZTo6U2NhbGVXZWJWaWV3KHNjYWxlLCBvcmlnaW4pLCBtX3BhZ2VJRCk7CiB9Cg== 79879 2011-01-23 15:38:48 -0800 2011-01-23 15:41:28 -0800 Proposed patch textmate stdin Q7GBxM.txt text/plain 1179 dkaleta SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2NDcyKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDEtMjMgIERhbWlhbiBL YWxldGEgIDxka2FsZXRhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICA8cmRhcjovL3Byb2JsZW0vODkwNTE3MT4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyOTg1IEVsaW1pbmF0ZWQgZWFy bHkgcmV0dXJuIAorICAgICAgICBpbnNpZGUgV2ViUGFnZVByb3h5OjpzY2FsZVdlYlZpZXcsIG1h a2luZyBpdCBjb25zaXN0ZW50IHdpdGggV2ViS2l0MS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9X ZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OnNjYWxlV2Vi Vmlldyk6CisKIDIwMTEtMDEtMjMgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KSW5kZXg6IFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCShyZXZpc2lvbiA3NjQ2NykKKysrIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04 OTAsOSArODkwLDYgQEAgdm9pZCBXZWJQYWdlUHJveHk6OnNjYWxlV2ViVmlldyhkb3VibGUgcwog ICAgIGlmICghaXNWYWxpZCgpKQogICAgICAgICByZXR1cm47CiAKLSAgICBpZiAobV92aWV3U2Nh bGVGYWN0b3IgPT0gc2NhbGUpCi0gICAgICAgIHJldHVybjsKLQogICAgIG1fdmlld1NjYWxlRmFj dG9yID0gc2NhbGU7CiAgICAgcHJvY2VzcygpLT5zZW5kKE1lc3NhZ2VzOjpXZWJQYWdlOjpTY2Fs ZVdlYlZpZXcoc2NhbGUsIG9yaWdpbiksIG1fcGFnZUlEKTsKIH0K 79880 2011-01-23 15:41:28 -0800 2011-01-23 15:46:35 -0800 Proposed patch textmate stdin yM29co.txt text/plain 1180 dkaleta SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2NDcyKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDEtMjMgIERhbWlhbiBL YWxldGEgIDxka2FsZXRhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICA8cmRhcjovL3Byb2JsZW0vODkwNTE3MT4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyOTg1IAorCisgICAgICAgICog VUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94 eTo6c2NhbGVXZWJWaWV3KTogRWxpbWluYXRlZCBlYXJseSByZXR1cm4gaW5zaWRlIFdlYlBhZ2VQ cm94eTo6c2NhbGVXZWJWaWV3LCBtYWtpbmcgaXQgCisgICAgICAgIGNvbnNpc3RlbnQgd2l0aCBX ZWJLaXQxLgorCiAyMDExLTAxLTIzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCkluZGV4OiBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkocmV2aXNpb24gNzY0NjcpCisrKyBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAt ODkwLDkgKzg5MCw2IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpzY2FsZVdlYlZpZXcoZG91YmxlIHMK ICAgICBpZiAoIWlzVmFsaWQoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKG1fdmlld1Nj YWxlRmFjdG9yID09IHNjYWxlKQotICAgICAgICByZXR1cm47Ci0KICAgICBtX3ZpZXdTY2FsZUZh Y3RvciA9IHNjYWxlOwogICAgIHByb2Nlc3MoKS0+c2VuZChNZXNzYWdlczo6V2ViUGFnZTo6U2Nh bGVXZWJWaWV3KHNjYWxlLCBvcmlnaW4pLCBtX3BhZ2VJRCk7CiB9Cg==