52969 2011-01-22 14:50:39 -0800 Fix FFTFrameStub to compile properly 2011-01-22 16:34:35 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 crogers webkit-unassigned commit-queue dbates dglazkov eric kbr oldest_to_newest 338638 0 crogers 2011-01-22 14:50:39 -0800 Fix FFTFrameStub to compile properly 338640 1 79859 crogers 2011-01-22 14:57:49 -0800 Created attachment 79859 Patch 338641 2 79859 eric 2011-01-22 15:01:21 -0800 Comment on attachment 79859 Patch What was the build error? I don't understand why commenting things out like this is the right fix. 338644 3 crogers 2011-01-22 15:05:27 -0800 the build error is that it will not compile on Linux because the log2() function is not known. Since this is simply a stub implementation there's no need to initialize these variables to other than zero. 338655 4 79859 dbates 2011-01-22 16:31:07 -0800 Comment on attachment 79859 Patch Will land by hand as requested by Chris Rogers. 338656 5 dbates 2011-01-22 16:34:35 -0800 Committed r76456: <http://trac.webkit.org/changeset/76456> 79859 2011-01-22 14:57:49 -0800 2011-01-22 16:31:07 -0800 Patch bug-52969-20110122145747.patch text/plain 1209 crogers SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2NDU1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDEtMjIgIENocmlzIFJv Z2VycyAgPGNyb2dlcnNAZ29vZ2xlLmNvbT4KKworICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZp eAorCisgICAgICAgIEZpeCBGRlRGcmFtZVN0dWIgdG8gY29tcGlsZSBwcm9wZXJseQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI5NjkKKworICAgICAg ICBObyBuZXcgdGVzdHMgc2luY2UgdGhpcyBpcyBhIGJ1aWxkIGZpeAorCisgICAgICAgICogcGxh dGZvcm0vYXVkaW8vRkZURnJhbWVTdHViLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZGVEZyYW1l OjpGRlRGcmFtZSk6CisKIDIwMTEtMDEtMjIgIEFuZHJlaSBQb3Blc2N1ICA8YW5kcmVpcEBnb29n bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEplcmVteSBPcmxvdy4KSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL0ZGVEZyYW1lU3R1Yi5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vRkZURnJhbWVTdHViLmNwcAkocmV2aXNpb24g NzY0MTkpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9GRlRGcmFtZVN0dWIuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zNiw5ICszNiw5IEBACiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK IC8vIE5vcm1hbCBjb25zdHJ1Y3RvcjogYWxsb2NhdGVzIGZvciBhIGdpdmVuIGZmdFNpemUuCi1G RlRGcmFtZTo6RkZURnJhbWUodW5zaWduZWQgZmZ0U2l6ZSkKLSAgICA6IG1fRkZUU2l6ZShmZnRT aXplKQotICAgICwgbV9sb2cyRkZUU2l6ZShzdGF0aWNfY2FzdDx1bnNpZ25lZD4obG9nMihmZnRT aXplKSkpCitGRlRGcmFtZTo6RkZURnJhbWUodW5zaWduZWQgLypmZnRTaXplKi8pCisgICAgOiBt X0ZGVFNpemUoMCkKKyAgICAsIG1fbG9nMkZGVFNpemUoMCkKIHsKICAgICBBU1NFUlRfTk9UX1JF QUNIRUQoKTsKIH0K