52951 2011-01-21 23:43:26 -0800 WebKit2 generates a bad PDF for cross process messaging 2011-01-22 00:22:14 -0800 1 1 1 Unclassified WebKit Printing 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap ap andersca commit-queue sam oldest_to_newest 338530 0 ap 2011-01-21 23:43:26 -0800 It's offset down by frame.height - page.height, so most pages draw outside PDF media box. While the error in web process is compensated by a symmetrical error in UI process, nothing guarantees that CGPDFContext won't discard the data outside media box. 338531 1 79832 ap 2011-01-21 23:46:17 -0800 Created attachment 79832 proposed fix 338532 2 79832 mitz 2011-01-21 23:49:08 -0800 Comment on attachment 79832 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=79832&action=review > Source/WebCore/ChangeLog:21 > +2011-01-21 Alexey Proskuryakov <ap@apple.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Need a short description and bug URL (OOPS!) > + > + No new tests. (OOPS!) > + > + * page/PrintContext.cpp: > + (WebCore::PrintContext::spoolRect): > + Redundant change log entry. 338533 3 79833 ap 2011-01-21 23:56:11 -0800 Created attachment 79833 patch for landing Oops. 338536 4 79833 commit-queue 2011-01-22 00:22:09 -0800 Comment on attachment 79833 patch for landing Clearing flags on attachment: 79833 Committed r76433: <http://trac.webkit.org/changeset/76433> 338537 5 commit-queue 2011-01-22 00:22:14 -0800 All reviewed patches have been landed. Closing bug. 79832 2011-01-21 23:46:17 -0800 2011-01-21 23:56:11 -0800 proposed fix BadPDF.txt text/plain 2810 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2NDMyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDEtMjEgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTUyOTUxCisgICAgICAgIFdlYktpdDIgZ2VuZXJhdGVzIGEgYmFkIFBERiBmb3IgY3Jvc3Mg cHJvY2VzcyBtZXNzYWdpbmcKKworICAgICAgICAqIHBhZ2UvUHJpbnRDb250ZXh0LmNwcDogKFdl YkNvcmU6OlByaW50Q29udGV4dDo6c3Bvb2xSZWN0KTogVXNlIGEgY29ycmVjdCBvZmZzZXQgdG8g YWN0dWFsbHkKKyAgICAgICAgZHJhdyBpbnNpZGUgdGhlIHJlcXVlc3RlZCByZWN0YW5nbGUuCisK KzIwMTEtMDEtMjEgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTmVlZCBhIHNob3J0IGRl c2NyaXB0aW9uIGFuZCBidWcgVVJMIChPT1BTISkKKworICAgICAgICBObyBuZXcgdGVzdHMuIChP T1BTISkKKworICAgICAgICAqIHBhZ2UvUHJpbnRDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlByaW50Q29udGV4dDo6c3Bvb2xSZWN0KToKKwogMjAxMS0wMS0yMSAgWXVyeSBTZW1pa2hh dHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJh cnRoLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9QcmludENvbnRleHQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvUHJpbnRDb250ZXh0LmNwcAkocmV2aXNpb24gNzY0 MjYpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL1ByaW50Q29udGV4dC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTE2Niw3ICsxNjYsNyBAQCB2b2lkIFByaW50Q29udGV4dDo6c3Bvb2xSZWN0KEdyYXBo aWNzQ29uCiB7CiAgICAgY3R4LnNhdmUoKTsKICAgICBjdHguc2NhbGUoRmxvYXRTaXplKDEsIC0x KSk7Ci0gICAgY3R4LnRyYW5zbGF0ZSgwLCAtcmVjdC5oZWlnaHQoKSk7CisgICAgY3R4LnRyYW5z bGF0ZSgwLCAtbV9mcmFtZS0+dmlldygpLT5jb250ZW50c0hlaWdodCgpKTsKICAgICBjdHguY2xp cChyZWN0KTsKICAgICBtX2ZyYW1lLT52aWV3KCktPnBhaW50Q29udGVudHMoJmN0eCwgcmVjdCk7 CiAgICAgY3R4LnJlc3RvcmUoKTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2NDMyKQorKysg U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDEtMjEgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyOTUxCisgICAgICAgIFdlYktpdDIgZ2VuZXJhdGVz IGEgYmFkIFBERiBmb3IgY3Jvc3MgcHJvY2VzcyBtZXNzYWdpbmcKKworICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvbWFjL1dLVmlldy5tbToKKyAgICAgICAgKC1bV0tWaWV3IF9yZWN1cnNpdmVEaXNw bGF5UmVjdElmTmVlZGVkSWdub3JpbmdPcGFjaXR5OmlzVmlzaWJsZVJlY3Q6cmVjdElzVmlzaWJs ZVJlY3RGb3JWaWV3OnRvcFZpZXc6XSk6CisgICAgICAgIFVzZSBhIGNvcnJlY3Qgb2Zmc2V0IHdo ZW4gZmxpcHBpbmcuCisKIDIwMTEtMDEtMjEgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHJldmlzaW9uIDc2NDI2KQor KysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCSh3b3JraW5nIGNv cHkpCkBAIC0xNDk3LDcgKzE0OTcsNyBAQCAtICh2b2lkKV9yZWN1cnNpdmVEaXNwbGF5UmVjdElm TmVlZGVkSWduCiAgICAgQ0dDb250ZXh0U2F2ZUdTdGF0ZShjb250ZXh0KTsKICAgICAvLyBGbGlw IHRoZSBkZXN0aW5hdGlvbi4KICAgICBDR0NvbnRleHRTY2FsZUNUTShjb250ZXh0LCAxLCAtMSk7 Ci0gICAgQ0dDb250ZXh0VHJhbnNsYXRlQ1RNKGNvbnRleHQsIDAsIC1yZWN0LnNpemUuaGVpZ2h0 KTsKKyAgICBDR0NvbnRleHRUcmFuc2xhdGVDVE0oY29udGV4dCwgMCwgLUNHUERGUGFnZUdldEJv eFJlY3QocGRmUGFnZSwga0NHUERGTWVkaWFCb3gpLnNpemUuaGVpZ2h0KTsKICAgICBDR0NvbnRl eHREcmF3UERGUGFnZShjb250ZXh0LCBwZGZQYWdlKTsKICAgICBDR0NvbnRleHRSZXN0b3JlR1N0 YXRlKGNvbnRleHQpOwogfQo= 79833 2011-01-21 23:56:11 -0800 2011-01-22 00:22:09 -0800 patch for landing BadPDF.txt text/plain 2548 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2NDMyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDEtMjEgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJl cm5zdGVpbi4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTI5NTEKKyAgICAgICAgV2ViS2l0MiBnZW5lcmF0ZXMgYSBiYWQgUERGIGZvciBjcm9zcyBw cm9jZXNzIG1lc3NhZ2luZworCisgICAgICAgICogcGFnZS9QcmludENvbnRleHQuY3BwOiAoV2Vi Q29yZTo6UHJpbnRDb250ZXh0OjpzcG9vbFJlY3QpOiBVc2UgYSBjb3JyZWN0IG9mZnNldCB0byBh Y3R1YWxseQorICAgICAgICBkcmF3IGluc2lkZSB0aGUgcmVxdWVzdGVkIHJlY3RhbmdsZS4KKwog MjAxMS0wMS0yMSAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9Q cmludENvbnRleHQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvUHJpbnRD b250ZXh0LmNwcAkocmV2aXNpb24gNzY0MjYpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL1ByaW50 Q29udGV4dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2Niw3ICsxNjYsNyBAQCB2b2lkIFByaW50 Q29udGV4dDo6c3Bvb2xSZWN0KEdyYXBoaWNzQ29uCiB7CiAgICAgY3R4LnNhdmUoKTsKICAgICBj dHguc2NhbGUoRmxvYXRTaXplKDEsIC0xKSk7Ci0gICAgY3R4LnRyYW5zbGF0ZSgwLCAtcmVjdC5o ZWlnaHQoKSk7CisgICAgY3R4LnRyYW5zbGF0ZSgwLCAtbV9mcmFtZS0+dmlldygpLT5jb250ZW50 c0hlaWdodCgpKTsKICAgICBjdHguY2xpcChyZWN0KTsKICAgICBtX2ZyYW1lLT52aWV3KCktPnBh aW50Q29udGVudHMoJmN0eCwgcmVjdCk7CiAgICAgY3R4LnJlc3RvcmUoKTsKSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cJKHJldmlzaW9uIDc2NDMyKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDEtMjEgIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KKwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI5NTEKKyAg ICAgICAgV2ViS2l0MiBnZW5lcmF0ZXMgYSBiYWQgUERGIGZvciBjcm9zcyBwcm9jZXNzIG1lc3Nh Z2luZworCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tOgorICAgICAgICAo LVtXS1ZpZXcgX3JlY3Vyc2l2ZURpc3BsYXlSZWN0SWZOZWVkZWRJZ25vcmluZ09wYWNpdHk6aXNW aXNpYmxlUmVjdDpyZWN0SXNWaXNpYmxlUmVjdEZvclZpZXc6dG9wVmlldzpdKToKKyAgICAgICAg VXNlIGEgY29ycmVjdCBvZmZzZXQgd2hlbiBmbGlwcGluZy4KKwogMjAxMS0wMS0yMSAgQWxleGV5 IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4g QmVybnN0ZWluLgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3 Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmll dy5tbQkocmV2aXNpb24gNzY0MjYpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21h Yy9XS1ZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTE0OTcsNyArMTQ5Nyw3IEBAIC0gKHZvaWQp X3JlY3Vyc2l2ZURpc3BsYXlSZWN0SWZOZWVkZWRJZ24KICAgICBDR0NvbnRleHRTYXZlR1N0YXRl KGNvbnRleHQpOwogICAgIC8vIEZsaXAgdGhlIGRlc3RpbmF0aW9uLgogICAgIENHQ29udGV4dFNj YWxlQ1RNKGNvbnRleHQsIDEsIC0xKTsKLSAgICBDR0NvbnRleHRUcmFuc2xhdGVDVE0oY29udGV4 dCwgMCwgLXJlY3Quc2l6ZS5oZWlnaHQpOworICAgIENHQ29udGV4dFRyYW5zbGF0ZUNUTShjb250 ZXh0LCAwLCAtQ0dQREZQYWdlR2V0Qm94UmVjdChwZGZQYWdlLCBrQ0dQREZNZWRpYUJveCkuc2l6 ZS5oZWlnaHQpOwogICAgIENHQ29udGV4dERyYXdQREZQYWdlKGNvbnRleHQsIHBkZlBhZ2UpOwog ICAgIENHQ29udGV4dFJlc3RvcmVHU3RhdGUoY29udGV4dCk7CiB9Cg==