52935 2011-01-21 15:41:03 -0800 [chromium] turn off gyp circular dependency checking and roll chromium deps 2011-01-24 09:37:56 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony dglazkov jamesr mark oldest_to_newest 338393 0 tony 2011-01-21 15:41:03 -0800 [chromium] turn off gyp circular dependency checking and roll chromium deps 338395 1 79805 tony 2011-01-21 15:42:09 -0800 Created attachment 79805 Patch 338396 2 tony 2011-01-21 15:43:05 -0800 Turning off gyp circular dependencies is needed to get us to roll past chromium@72103. 338413 3 jamesr 2011-01-21 16:08:34 -0800 Are you sure we don't have the circular dependency on mac as well? Which part of the cycle exists only on mac? Would it be better to just fix the dependency issue? 338414 4 jamesr 2011-01-21 16:08:45 -0800 (In reply to comment #3) > Are you sure we don't have the circular dependency on mac as well? Which part of the cycle exists only on mac? exists only on !mac, that is 338417 5 tony 2011-01-21 16:17:43 -0800 (In reply to comment #4) > (In reply to comment #3) > > Are you sure we don't have the circular dependency on mac as well? Which part of the cycle exists only on mac? > > exists only on !mac, that is Yes, if it existed on mac, gyp_chromium would have failed. The dependency is here in a *nix only section: http://git.chromium.org/gitweb/?p=chromium.git;a=blob;f=skia/skia.gyp;h=4c51e8aed406af1293e4168899f65d4755fdc815;hb=HEAD#l714 I've notified the original authors (thakis and reed) of the circular dependency and I think they're going to fix it. They'll have to fix it if we need this on mac. 338418 6 tony 2011-01-21 16:18:35 -0800 Here's the same logic in gyp_chromium that would fail for the same reason: http://git.chromium.org/gitweb/?p=chromium.git;a=blob;f=build/gyp_chromium;h=21717705f30340011f5128ff3f7439955812d8ea;hb=HEAD#l107 338430 7 79805 jamesr 2011-01-21 16:53:01 -0800 Comment on attachment 79805 Patch T.T 339064 8 tony 2011-01-24 09:37:56 -0800 Committed r76527: <http://trac.webkit.org/changeset/76527> 79805 2011-01-21 15:42:09 -0800 2011-01-21 16:53:01 -0800 Patch bug-52935-20110121154328.patch text/plain 2552 tony ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggODg5NWZlMWFlNWNmZTgyY2FjNWZiOGVkZTM2 ZDM5ZTMzZjVkODUxYi4uNWMyZTg3MWI1YjJiYjc1ZmExZmIyOGE1MWY1NjI2NDM2MjIyMDQxMCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMS0wMS0yMSAg VG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gdHVybiBvZmYgZ3lwIGNpcmN1bGFy IGRlcGVuZGVuY3kgY2hlY2tpbmcgYW5kIHJvbGwgY2hyb21pdW0gZGVwcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI5MzUKKworICAgICAgICAqIERF UFM6CisgICAgICAgICogZ3lwX3dlYmtpdDogVHVybiBvZmYgZ3lwIGNpcmN1bGFyIGRlcGVuZGVu Y3kgY2hlY2tpbmcgb24gTGludXgKKyAgICAgICAgICAgIGFuZCBXaW4gc2luY2Ugd2UgZG9uJ3Qg ZG8gdGhlc2UgY2hlY2tzIGluIGd5cF9jaHJvbWl1bS4gIEl0J3MKKyAgICAgICAgICAgIGp1c3Qg bWFraW5nIGl0IGhhcmRlciBmb3IgdXMgdG8gcm9sbCBERVBTIGFuZCBoYXZlIHNvbWV0aGluZwor ICAgICAgICAgICAgZXhwbG9kZS4KKwogMjAxMS0wMS0yMSAgQ2hyaXMgUm9nZXJzICA8Y3JvZ2Vy c0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vREVQUyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vREVQUwppbmRleCA4ZDA4YzNmYzdiZDQ0OGMwY2U4NGUyYjAzZWE1ZDA4MTlmNDBmNDkyLi4x NTFkN2RjZGMxZThmYzEzYTQyMTI2ZGNmYjdlMDJkZDRjODdjNWQyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0RFUFMKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9ERVBT CkBAIC0zMiw3ICszMiw3IEBACiAKIHZhcnMgPSB7CiAgICdjaHJvbWl1bV9zdm4nOiAnaHR0cDov L3NyYy5jaHJvbWl1bS5vcmcvc3ZuL3RydW5rL3NyYycsCi0gICdjaHJvbWl1bV9yZXYnOiAnNzE5 NjknCisgICdjaHJvbWl1bV9yZXYnOiAnNzIxODEnCiB9CiAKIGRlcHMgPSB7CkBAIC01Niw2ICs1 Niw4IEBAIGRlcHMgPSB7CiAgICMgc2tpYSBkZXBlbmRlbmNpZXMKICAgJ3NraWEnOgogICAgIFZh cignY2hyb21pdW1fc3ZuJykrJy9za2lhQCcrVmFyKCdjaHJvbWl1bV9yZXYnKSwKKyAgJ3RoaXJk X3BhcnR5L3NraWEvZ3B1JzoKKyAgICBGcm9tKCdjaHJvbWl1bV9kZXBzJywgJ3NyYy90aGlyZF9w YXJ0eS9za2lhL2dwdScpLAogICAndGhpcmRfcGFydHkvc2tpYS9zcmMnOgogICAgIEZyb20oJ2No cm9taXVtX2RlcHMnLCAnc3JjL3RoaXJkX3BhcnR5L3NraWEvc3JjJyksCiAgICd0aGlyZF9wYXJ0 eS9za2lhL2luY2x1ZGUnOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9neXBf d2Via2l0IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9neXBfd2Via2l0CmluZGV4IDI5ZTNlN2My Nzc4NTIxMzA2MDE0OWI0MmY0ZTIyMjUxOGYyYmVkNGUuLjc2OGFjYWNlZTQ0ZmJlYTk1NjM1OWJh YjY3MmFjOTY4NGI5NmUyOTQgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZ3lw X3dlYmtpdAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2d5cF93ZWJraXQKQEAgLTc2LDYg Kzc2LDE1IEBAIGlmIF9fbmFtZV9fID09ICdfX21haW5fXyc6CiAgICMgQWRkIGluY2x1ZGVzLgog ICBhcmdzLmV4dGVuZChbJy1JJyArIGkgZm9yIGkgaW4gYWRkaXRpb25hbF9pbmNsdWRlX2ZpbGVz KGFyZ3MpXSkKIAorICAjIFRoZXJlIHNob3VsZG4ndCBiZSBhIGNpcmN1bGFyIGRlcGVuZGVuY3kg cmVsYXRpb25zaGlwIGJldHdlZW4gLmd5cCBmaWxlcywKKyAgIyBidXQgaW4gQ2hyb21pdW0ncyAu Z3lwIGZpbGVzLCBvbiBub24tTWFjIHBsYXRmb3JtcywgY2lyY3VsYXIgcmVsYXRpb25zaGlwcwor ICAjIGN1cnJlbnRseSBleGlzdC4gIFRoZSBjaGVjayBmb3IgY2lyY3VsYXIgZGVwZW5kZW5jaWVz IGlzIGN1cnJlbnRseQorICAjIGJ5cGFzc2VkIG9uIG90aGVyIHBsYXRmb3JtcywgYnV0IGlzIGxl ZnQgZW5hYmxlZCBvbiB0aGUgTWFjLCB3aGVyZSBhCisgICMgdmlvbGF0aW9uIG9mIHRoZSBydWxl IGNhdXNlcyBYY29kZSB0byBtaXNiZWhhdmUgYmFkbHkuCisgICMgaHR0cDovL2NyYnVnLmNvbS8z NTg3OC4KKyAgaWYgc3lzLnBsYXRmb3JtIG5vdCBpbiAoJ2RhcndpbicsKToKKyAgICBhcmdzLmFw cGVuZCgnLS1uby1jaXJjdWxhci1jaGVjaycpCisKICAgIyBPbiBsaW51eCwgd2Ugd2FudCBneXAg dG8gb3V0cHV0IGEgbWFrZWZpbGUgKGRlZmF1bHQgaXMgc2NvbnMpLgogICBpZiBzeXMucGxhdGZv cm0gPT0gJ2xpbnV4Mic6CiAgICAgYXJncy5leHRlbmQoWyctZm1ha2UnLAo=