52927 2011-01-21 15:01:07 -0800 nrwt: handle broken pipe errors from DRT more cleanly 2011-02-03 20:07:20 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth eric mihaip ojan oldest_to_newest 338363 0 dpranke 2011-01-21 15:01:07 -0800 nrwt: handle broken pipe errors from DRT more cleanly 338364 1 79799 dpranke 2011-01-21 15:02:09 -0800 Created attachment 79799 Patch 338648 2 79799 eric 2011-01-22 15:10:01 -0800 Comment on attachment 79799 Patch Looks reasonable. Seems we should have a test though. 338702 3 dpranke 2011-01-23 10:22:11 -0800 I thought about this a fair amount before uploading the patch, and it's not clear to me how to usefully test this. To do so either requires spawning off a process that crashes at exactly the right point (since most of the time I'll pick up the crash during the read loop) or mocking out several layers of calls, which seems overly contrived and kind of pointless. I'm open to suggestions, though; any ideas on how you would test it? 338710 4 79799 eric 2011-01-23 11:09:22 -0800 Comment on attachment 79799 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79799&action=review > Tools/Scripts/webkitpy/layout_tests/port/server_process.py:119 > + self._proc.stdin.write(input) Oh, I had assumed one would just mock the multiple layers. I don't know how much other mocking has already been done for testing this class. 344456 5 81015 dpranke 2011-02-02 17:49:28 -0800 Created attachment 81015 add unit test for broken pipes 345277 6 dpranke 2011-02-03 20:07:20 -0800 Committed r77592: <http://trac.webkit.org/changeset/77592> 79799 2011-01-21 15:02:09 -0800 2011-02-02 17:49:25 -0800 Patch bug-52927-20110121150208.patch text/plain 1356 dpranke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxNzM1 MjNmYzgwNDU5NWRhMzRkZDVlMWExNTZmMzBlZmM3MjA0ZGY2Li5kMTA4NmEwNGJkMTRjYjE3NjQ1 OTYzMDkwZjE0MmE4MmEyM2Q0NzJhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDEtMjEgIERpcmsgUHJhbmtl ICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgbnJ3dDogaGFuZGxlICJicm9rZW4gcGlwZSIgbm90aWZpY2F0aW9u cyBmcm9tIERSVCBtb3JlIGNsZWFubHkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTUyOTI3CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9wb3J0L3NlcnZlcl9wcm9jZXNzLnB5OgorCiAyMDExLTAxLTIxICBEYXJpbiBB ZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgIEZpeCBNYWMgYnVpbGQuCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3NlcnZlcl9wcm9j ZXNzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9zZXJ2ZXJf cHJvY2Vzcy5weQppbmRleCA1YTBhNDBjZTY5MGZlNTM2OTYwMDE5YTQzY2NiYWM2YTQ5MzQyZTc5 Li43OTc0Zjk0MDlhYmUwYjhjMjE2MGRlNWE0MzE3NWFlMGVhOTM0ZmM3IDEwMDY0NAotLS0gYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3NlcnZlcl9wcm9jZXNzLnB5 CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvc2VydmVyX3By b2Nlc3MucHkKQEAgLTExNSw3ICsxMTUsMTEgQEAgY2xhc3MgU2VydmVyUHJvY2VzczoKICAgICAg ICAgaWYgaXMgbm90IGFscmVhZHkgcnVubmluZy4iIiIKICAgICAgICAgaWYgbm90IHNlbGYuX3By b2M6CiAgICAgICAgICAgICBzZWxmLl9zdGFydCgpCi0gICAgICAgIHNlbGYuX3Byb2Muc3RkaW4u d3JpdGUoaW5wdXQpCisgICAgICAgIHRyeToKKyAgICAgICAgICAgIHNlbGYuX3Byb2Muc3RkaW4u d3JpdGUoaW5wdXQpCisgICAgICAgIGV4Y2VwdCBJT0Vycm9yLCBlOgorICAgICAgICAgICAgc2Vs Zi5zdG9wKCkKKyAgICAgICAgICAgIHNlbGYuY3Jhc2hlZCA9IFRydWUKIAogICAgIGRlZiByZWFk X2xpbmUoc2VsZiwgdGltZW91dCk6CiAgICAgICAgICIiIlJlYWQgYSBzaW5nbGUgbGluZSBmcm9t IHRoZSBzdWJwcm9jZXNzLCB3YWl0aW5nIHVudGlsIHRoZSBkZWFkbGluZS4K 81015 2011-02-02 17:49:28 -0800 2011-02-03 09:21:27 -0800 add unit test for broken pipes bug-52927-20110202174927.patch text/plain 4670 dpranke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyY2Zh MTlmNjFiM2E3M2Q4YzA2NDc1ZmFlOWM5YjhlYmE5YTQwYmIzLi5hMGRmMDY4NjA0ZGQ3MTA0ZDBl MDIzMjdiNjJlZjJjNmExMDYxOGE5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDEtMjEgIERpcmsgUHJhbmtl ICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgbnJ3dDogaGFuZGxlICJicm9rZW4gcGlwZSIgbm90aWZpY2F0aW9u cyBmcm9tIERSVCBtb3JlIGNsZWFubHkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTUyOTI3CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9wb3J0L3NlcnZlcl9wcm9jZXNzLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvc2VydmVyX3Byb2Nlc3NfdW5pdHRlc3QucHk6CisKIDIw MTEtMDItMDIgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgTWloYWkgUGFycGFyaXRhLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvc2VydmVyX3Byb2Nlc3MucHkKaW5kZXggNWEw YTQwY2U2OTBmZTUzNjk2MDAxOWE0M2NjYmFjNmE0OTM0MmU3OS4uNzk3NGY5NDA5YWJlMGI4YzIx NjBkZTVhNDMxNzVhZTBlYTkzNGZjNyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3NlcnZlcl9wcm9jZXNzLnB5CkBAIC0xMTUsNyAr MTE1LDExIEBAIGNsYXNzIFNlcnZlclByb2Nlc3M6CiAgICAgICAgIGlmIGlzIG5vdCBhbHJlYWR5 IHJ1bm5pbmcuIiIiCiAgICAgICAgIGlmIG5vdCBzZWxmLl9wcm9jOgogICAgICAgICAgICAgc2Vs Zi5fc3RhcnQoKQotICAgICAgICBzZWxmLl9wcm9jLnN0ZGluLndyaXRlKGlucHV0KQorICAgICAg ICB0cnk6CisgICAgICAgICAgICBzZWxmLl9wcm9jLnN0ZGluLndyaXRlKGlucHV0KQorICAgICAg ICBleGNlcHQgSU9FcnJvciwgZToKKyAgICAgICAgICAgIHNlbGYuc3RvcCgpCisgICAgICAgICAg ICBzZWxmLmNyYXNoZWQgPSBUcnVlCiAKICAgICBkZWYgcmVhZF9saW5lKHNlbGYsIHRpbWVvdXQp OgogICAgICAgICAiIiJSZWFkIGEgc2luZ2xlIGxpbmUgZnJvbSB0aGUgc3VicHJvY2Vzcywgd2Fp dGluZyB1bnRpbCB0aGUgZGVhZGxpbmUuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L3NlcnZlcl9wcm9jZXNzX3VuaXR0ZXN0LnB5IGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9zZXJ2ZXJfcHJvY2Vzc191bml0dGVz dC5weQpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi5mMzQyOWNiY2Y2Yjc3MzQ2Yzg0ZDllNjZmNmMxNDAwYjUxNDU3M2Y3 Ci0tLSAvZGV2L251bGwKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9zZXJ2ZXJfcHJvY2Vzc191bml0dGVzdC5weQpAQCAtMCwwICsxLDc3IEBACisjIENvcHly aWdodCAoQykgMjAxMSBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorIworIyBSZWRp c3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdp dGhvdXQKKyMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZv bGxvd2luZyBjb25kaXRpb25zIGFyZQorIyBtZXQ6CisjCisjICAgICogUmVkaXN0cmlidXRpb25z IG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMgbm90aWNl LCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgor IyAgICAqIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUg YWJvdmUKKyMgY29weXJpZ2h0IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRo ZSBmb2xsb3dpbmcgZGlzY2xhaW1lcgorIyBpbiB0aGUgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3Ro ZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlCisjIGRpc3RyaWJ1dGlvbi4KKyMgICAgKiBO ZWl0aGVyIHRoZSBuYW1lIG9mIEdvb2dsZSBJbmMuIG5vciB0aGUgbmFtZXMgb2YgaXRzCisjIGNv bnRyaWJ1dG9ycyBtYXkgYmUgdXNlZCB0byBlbmRvcnNlIG9yIHByb21vdGUgcHJvZHVjdHMgZGVy aXZlZCBmcm9tCisjIHRoaXMgc29mdHdhcmUgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVu IHBlcm1pc3Npb24uCisjCisjIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIENPUFlS SUdIVCBIT0xERVJTIEFORCBDT05UUklCVVRPUlMKKyMgIkFTIElTIiBBTkQgQU5ZIEVYUFJFU1Mg T1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QKKyMgTElNSVRFRCBUTywg VEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9S CisjIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFM TCBUSEUgQ09QWVJJR0hUCisjIE9XTkVSIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFO WSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLAorIyBTUEVDSUFMLCBFWEVNUExBUlksIE9S IENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UCisjIExJTUlURUQgVE8s IFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNF LAorIyBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIg Q0FVU0VEIEFORCBPTiBBTlkKKyMgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05U UkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAorIyAoSU5DTFVESU5HIE5FR0xJR0VOQ0Ug T1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyMgT0YgVEhJ UyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERB TUFHRS4KKworaW1wb3J0IHVuaXR0ZXN0CisKK2Zyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLnBv cnQgaW1wb3J0IHNlcnZlcl9wcm9jZXNzCisKKworY2xhc3MgTW9ja0ZpbGUob2JqZWN0KToKKyAg ICBkZWYgX19pbml0X18oc2VsZiwgc2VydmVyX3Byb2Nlc3MpOgorICAgICAgICBzZWxmLl9zZXJ2 ZXJfcHJvY2VzcyA9IHNlcnZlcl9wcm9jZXNzCisKKyAgICBkZWYgZmlsZW5vKHNlbGYpOgorICAg ICAgICByZXR1cm4gMQorCisgICAgZGVmIHdyaXRlKHNlbGYsIGxpbmUpOgorICAgICAgICBzZWxm Ll9zZXJ2ZXJfcHJvY2Vzcy5icm9rZW5fcGlwZXMuYXBwZW5kKHNlbGYpCisgICAgICAgIHJhaXNl IElPRXJyb3IKKworICAgIGRlZiBjbG9zZShzZWxmKToKKyAgICAgICAgcGFzcworCisKK2NsYXNz IE1vY2tQcm9jKG9iamVjdCk6CisgICAgZGVmIF9faW5pdF9fKHNlbGYsIHNlcnZlcl9wcm9jZXNz KToKKyAgICAgICAgc2VsZi5zdGRpbiA9IE1vY2tGaWxlKHNlcnZlcl9wcm9jZXNzKQorICAgICAg ICBzZWxmLnN0ZG91dCA9IE1vY2tGaWxlKHNlcnZlcl9wcm9jZXNzKQorICAgICAgICBzZWxmLnN0 ZGVyciA9IE1vY2tGaWxlKHNlcnZlcl9wcm9jZXNzKQorICAgICAgICBzZWxmLnBpZCA9IDEKKwor ICAgIGRlZiBwb2xsKHNlbGYpOgorICAgICAgICByZXR1cm4gMQorCisKK2NsYXNzIEZha2VTZXJ2 ZXJQcm9jZXNzKHNlcnZlcl9wcm9jZXNzLlNlcnZlclByb2Nlc3MpOgorICAgIGRlZiBfc3RhcnQo c2VsZik6CisgICAgICAgIHNlbGYuX3Byb2MgPSBNb2NrUHJvYyhzZWxmKQorICAgICAgICBzZWxm LnN0ZGluID0gc2VsZi5fcHJvYy5zdGRpbgorICAgICAgICBzZWxmLmJyb2tlbl9waXBlcyA9IFtd CisKKworY2xhc3MgVGVzdFNlcnZlclByb2Nlc3ModW5pdHRlc3QuVGVzdENhc2UpOgorICAgIGRl ZiB0ZXN0X2Jyb2tlbl9waXBlKHNlbGYpOgorICAgICAgICBzZXJ2ZXJfcHJvY2VzcyA9IEZha2VT ZXJ2ZXJQcm9jZXNzKHBvcnRfb2JqPU5vbmUsIG5hbWU9InRlc3QiLCBjbWQ9WyJ0ZXN0Il0pCisg ICAgICAgIHNlcnZlcl9wcm9jZXNzLndyaXRlKCJzaG91bGQgYnJlYWsiKQorICAgICAgICBzZWxm LmFzc2VydFRydWUoc2VydmVyX3Byb2Nlc3MuY3Jhc2hlZCkKKyAgICAgICAgc2VsZi5hc3NlcnRF cXVhbHMoc2VydmVyX3Byb2Nlc3MuX3Byb2MsIE5vbmUpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1 YWxzKHNlcnZlcl9wcm9jZXNzLmJyb2tlbl9waXBlcywgW3NlcnZlcl9wcm9jZXNzLnN0ZGluXSkK KworCitpZiBfX25hbWVfXyA9PSAnX19tYWluX18nOgorICAgIHVuaXR0ZXN0Lm1haW4oKQo=