52925 2011-01-21 14:29:33 -0800 WebKit2: Need API to stop loading a WKFrame 2011-04-07 11:12:45 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 bweinstein bweinstein andersca sam oldest_to_newest 338348 0 bweinstein 2011-01-21 14:29:33 -0800 We need WebKit2 API to stop loading a WKFrame. 338350 1 79794 bweinstein 2011-01-21 14:33:32 -0800 Created attachment 79794 [PATCH] Fix 338365 2 79794 aroben 2011-01-21 15:03:14 -0800 Comment on attachment 79794 [PATCH] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=79794&action=review > Source/WebKit2/UIProcess/WebFrameProxy.cpp:90 > + m_page->process()->send(Messages::WebPage::StopLoadingFrame(m_frameID), m_page->pageID()); It looks like this is the first message that WebFrameProxy will be sending. You should check with Sam or Anders that this is the right place to send the message from. 338366 3 bweinstein 2011-01-21 15:04:03 -0800 (In reply to comment #2) > (From update of attachment 79794 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=79794&action=review > > > Source/WebKit2/UIProcess/WebFrameProxy.cpp:90 > > + m_page->process()->send(Messages::WebPage::StopLoadingFrame(m_frameID), m_page->pageID()); > > It looks like this is the first message that WebFrameProxy will be sending. You should check with Sam or Anders that this is the right place to send the message from. Anders told me this was the right way to do it - I will double check to confirm that this is correct. Thanks for the review! 381504 4 bweinstein 2011-04-07 11:12:45 -0700 Landed in r76403. 79794 2011-01-21 14:33:32 -0800 2011-01-21 15:03:14 -0800 [PATCH] Fix stop_loading_frame.patch text/plain 5541 bweinstein SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2Mzk0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDEtMjEgIEJyaWFuIFdl aW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYktpdDI6IE5lZWQgQVBJIHRvIHN0b3AgbG9hZGlu ZyBhIFdLRnJhbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTUyOTI1CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tGcmFtZS5jcHA6CisgICAg ICAgIChXS0ZyYW1lU3RvcExvYWRpbmcpOiBDYWxsIHRocm91Z2ggdG8gV2ViRnJhbWVQcm94eTo6 c3RvcExvYWRpbmcuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLRnJhbWUuaDoKKyAgICAg ICAgKiBVSVByb2Nlc3MvV2ViRnJhbWVQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkZy YW1lUHJveHk6OnN0b3BMb2FkaW5nKTogU2VuZCBhIG1lc3NhZ2UgdG8gdGhlIFdlYlByb2Nlc3Mg dG8gc3RvcCBsb2FkaW5nIHRoZSBmcmFtZQorICAgICAgICAgICAgd2l0aCB0aGUgcGFzc2VkIGlu IElELgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJGcmFtZVByb3h5Lmg6CisgICAgICAgICogV2Vi UHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpz dG9wTG9hZGluZ0ZyYW1lKTogQ2FsbCBzdG9wRm9yVXNlckNhbmNlbCBvbiB0aGUgcGFzc2VkLWlu IGZyYW1lLgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmg6CisgICAgICAg ICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UubWVzc2FnZXMuaW46IEFkZCBTdG9wTG9hZGlu Z0ZyYW1lLgorCiAyMDExLTAxLTIxICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpJbmRleDogU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYkZyYW1lUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJGcmFtZVByb3h5LmNwcAkocmV2aXNpb24gNzYzNjUpCisrKyBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViRnJhbWVQcm94eS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI5 LDYgKzI5LDcgQEAKICNpbmNsdWRlICJXZWJDb250ZXh0LmgiCiAjaW5jbHVkZSAiV2ViRm9ybVN1 Ym1pc3Npb25MaXN0ZW5lclByb3h5LmgiCiAjaW5jbHVkZSAiV2ViRnJhbWVQb2xpY3lMaXN0ZW5l clByb3h5LmgiCisjaW5jbHVkZSAiV2ViUGFnZU1lc3NhZ2VzLmgiCiAjaW5jbHVkZSAiV2ViUGFn ZVByb3h5LmgiCiAjaW5jbHVkZSA8V2ViQ29yZS9ET01JbXBsZW1lbnRhdGlvbi5oPgogI2luY2x1 ZGUgPFdlYkNvcmUvSW1hZ2UuaD4KQEAgLTgxLDYgKzgyLDE0IEBAIGJvb2wgV2ViRnJhbWVQcm94 eTo6aXNNYWluRnJhbWUoKSBjb25zdAogICAgIHJldHVybiB0aGlzID09IG1fcGFnZS0+bWFpbkZy YW1lKCk7CiB9CiAKK3ZvaWQgV2ViRnJhbWVQcm94eTo6c3RvcExvYWRpbmcoKSBjb25zdAorewor ICAgIGlmICghbV9wYWdlLT5pc1ZhbGlkKCkpCisgICAgICAgIHJldHVybjsKKworICAgIG1fcGFn ZS0+cHJvY2VzcygpLT5zZW5kKE1lc3NhZ2VzOjpXZWJQYWdlOjpTdG9wTG9hZGluZ0ZyYW1lKG1f ZnJhbWVJRCksIG1fcGFnZS0+cGFnZUlEKCkpOworfQorICAgIAogYm9vbCBXZWJGcmFtZVByb3h5 OjpjYW5Qcm92aWRlU291cmNlKCkgY29uc3QKIHsKICAgICByZXR1cm4gaXNEaXNwbGF5aW5nTWFy a3VwRG9jdW1lbnQoKTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJGcmFtZVBy b3h5LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkZyYW1lUHJv eHkuaAkocmV2aXNpb24gNzYzNjUpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViRnJh bWVQcm94eS5oCSh3b3JraW5nIGNvcHkpCkBAIC04Niw2ICs4Niw4IEBAIHB1YmxpYzoKICAgICBi b29sIGlzRnJhbWVTZXQoKSBjb25zdCB7IHJldHVybiBtX2lzRnJhbWVTZXQ7IH0KIAogICAgIExv YWRTdGF0ZSBsb2FkU3RhdGUoKSBjb25zdCB7IHJldHVybiBtX2xvYWRTdGF0ZTsgfQorICAgIAor ICAgIHZvaWQgc3RvcExvYWRpbmcoKSBjb25zdDsKIAogICAgIGNvbnN0IFN0cmluZyYgdXJsKCkg Y29uc3QgeyByZXR1cm4gbV91cmw7IH0KICAgICBjb25zdCBTdHJpbmcmIHByb3Zpc2lvbmFsVVJM KCkgY29uc3QgeyByZXR1cm4gbV9wcm92aXNpb25hbFVSTDsgfQpJbmRleDogU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9DL1dLRnJhbWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0ZyYW1lLmNwcAkocmV2aXNpb24gNzYzNjUpCisrKyBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tGcmFtZS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTc1LDYgKzc1LDExIEBAIFdLVVJMUmVmIFdLRnJhbWVDb3B5VW5yZWFjaGFibGVVUkwoV0tGcmEK ICAgICByZXR1cm4gdG9Db3BpZWRVUkxBUEkodG9JbXBsKGZyYW1lUmVmKS0+dW5yZWFjaGFibGVV UkwoKSk7CiB9CiAKK3ZvaWQgV0tGcmFtZVN0b3BMb2FkaW5nKFdLRnJhbWVSZWYgZnJhbWVSZWYp Cit7CisgICAgdG9JbXBsKGZyYW1lUmVmKS0+c3RvcExvYWRpbmcoKTsKK30KKwogV0tTdHJpbmdS ZWYgV0tGcmFtZUNvcHlNSU1FVHlwZShXS0ZyYW1lUmVmIGZyYW1lUmVmKQogewogICAgIHJldHVy biB0b0NvcGllZEFQSSh0b0ltcGwoZnJhbWVSZWYpLT5taW1lVHlwZSgpKTsKSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0ZyYW1lLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLRnJhbWUuaAkocmV2aXNpb24gNzYzNjUpCisrKyBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tGcmFtZS5oCSh3b3JraW5nIGNvcHkpCkBA IC01MSw2ICs1MSw4IEBAIFdLX0VYUE9SVCBXS1VSTFJlZiBXS0ZyYW1lQ29weVByb3Zpc2lvbmEK IFdLX0VYUE9SVCBXS1VSTFJlZiBXS0ZyYW1lQ29weVVSTChXS0ZyYW1lUmVmIGZyYW1lKTsKIFdL X0VYUE9SVCBXS1VSTFJlZiBXS0ZyYW1lQ29weVVucmVhY2hhYmxlVVJMKFdLRnJhbWVSZWYgZnJh bWUpOwogCitXS19FWFBPUlQgdm9pZCBXS0ZyYW1lU3RvcExvYWRpbmcoV0tGcmFtZVJlZiBmcmFt ZSk7CisKIFdLX0VYUE9SVCBXS1N0cmluZ1JlZiBXS0ZyYW1lQ29weU1JTUVUeXBlKFdLRnJhbWVS ZWYgZnJhbWUpOwogV0tfRVhQT1JUIFdLU3RyaW5nUmVmIFdLRnJhbWVDb3B5VGl0bGUoV0tGcmFt ZVJlZiBmcmFtZSk7CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9X ZWJQYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvV2ViUGFnZS5jcHAJKHJldmlzaW9uIDc2MzY1KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MzksNiArNDM5LDE1 IEBAIHZvaWQgV2ViUGFnZTo6bG9hZFBsYWluVGV4dFN0cmluZyhjb25zdCAKICAgICBsb2FkRGF0 YShzaGFyZWRCdWZmZXIsICJ0ZXh0L3BsYWluIiwgInV0Zi0xNiIsIGJsYW5rVVJMKCksIEtVUkwo KSk7CiB9CiAKK3ZvaWQgV2ViUGFnZTo6c3RvcExvYWRpbmdGcmFtZSh1aW50NjRfdCBmcmFtZUlE KQoreworICAgIFdlYkZyYW1lKiBmcmFtZSA9IFdlYlByb2Nlc3M6OnNoYXJlZCgpLndlYkZyYW1l KGZyYW1lSUQpOworICAgIGlmICghZnJhbWUpCisgICAgICAgIHJldHVybjsKKworICAgIGZyYW1l LT5jb3JlRnJhbWUoKS0+bG9hZGVyKCktPnN0b3BGb3JVc2VyQ2FuY2VsKCk7Cit9CisKIHZvaWQg V2ViUGFnZTo6c3RvcExvYWRpbmcoKQogewogICAgIG1fbWFpbkZyYW1lLT5jb3JlRnJhbWUoKS0+ bG9hZGVyKCktPnN0b3BGb3JVc2VyQ2FuY2VsKCk7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgJKHJldmlzaW9uIDc2MzY1KQorKysgU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaAkod29ya2luZyBjb3B5KQpAQCAtMjAw LDYgKzIwMCw3IEBAIHB1YmxpYzoKICAgICBib29sIGRyYXdzVHJhbnNwYXJlbnRCYWNrZ3JvdW5k KCkgY29uc3QgeyByZXR1cm4gbV9kcmF3c1RyYW5zcGFyZW50QmFja2dyb3VuZDsgfQogCiAgICAg dm9pZCBzdG9wTG9hZGluZygpOworICAgIHZvaWQgc3RvcExvYWRpbmdGcmFtZSh1aW50NjRfdCBm cmFtZUlEKTsKICAgICB2b2lkIHNldERlZmVyc0xvYWRpbmcoYm9vbCBkZWZlckxvYWRpbmcpOwog CiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQpJbmRleDogU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UubWVzc2FnZXMuaW4KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UubWVzc2FnZXMuaW4JKHJldmlz aW9uIDc2MzY1KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2Uu bWVzc2FnZXMuaW4JKHdvcmtpbmcgY29weSkKQEAgLTQ2LDYgKzQ2LDggQEAgbWVzc2FnZXMgLT4g V2ViUGFnZSB7CiAgICAgTG9hZFVSTFJlcXVlc3QoV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0IHJl cXVlc3QsIFdlYktpdDo6U2FuZGJveEV4dGVuc2lvbjo6SGFuZGxlIHNhbmRib3hFeHRlbnNpb25I YW5kbGUpCiAgICAgUmVsb2FkKGJvb2wgcmVsb2FkRnJvbU9yaWdpbikKICAgICBTdG9wTG9hZGlu ZygpCisKKyAgICBTdG9wTG9hZGluZ0ZyYW1lKHVpbnQ2NF90IGZyYW1lSUQpCiAgICAgCiAgICAg UmVzdG9yZVNlc3Npb25BbmROYXZpZ2F0ZVRvQ3VycmVudEl0ZW0oV2ViS2l0OjpTZXNzaW9uU3Rh dGUgc3RhdGUpCiAK