52918 2011-01-21 14:02:51 -0800 DrawingAreaProxyImpl::paint should return the unpainted region 2011-01-21 14:09:24 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 338327 0 andersca 2011-01-21 14:02:51 -0800 DrawingAreaProxyImpl::paint should return the unpainted region 338329 1 79789 andersca 2011-01-21 14:04:07 -0800 Created attachment 79789 Patch 338332 2 79789 mitz 2011-01-21 14:06:23 -0800 Comment on attachment 79789 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79789&action=review > Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:65 > + unpaintedRegion.subtract(IntRect(0, 0, m_backingStore->size().width(), m_backingStore->size().height())); This is better written as IntRect(IntPoint(), m_backingStore.size()) 338335 3 andersca 2011-01-21 14:09:24 -0800 Committed r76393: <http://trac.webkit.org/changeset/76393> 79789 2011-01-21 14:04:07 -0800 2011-01-21 14:06:23 -0800 Patch bug-52918-20110121140406.patch text/plain 4407 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2MzkyKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDEtMjEgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBEcmF3aW5nQXJlYVByb3h5SW1wbDo6cGFpbnQgc2hvdWxk IHJldHVybiB0aGUgdW5wYWludGVkIHJlZ2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI5MTgKKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvbWFj L1dLVmlldy5tbToKKyAgICAgICAgKC1bV0tWaWV3IGRyYXdSZWN0Ol0pOgorICAgICAgICBBZGQg dW5wYWludGVkUmVnaW9uIHBhcmFtZXRlci4KKworICAgICAgICAqIFVJUHJvY2Vzcy9CYWNraW5n U3RvcmUuaDoKKyAgICAgICAgKFdlYktpdDo6QmFja2luZ1N0b3JlOjpzaXplKToKKyAgICAgICAg QWRkIGEgc2l6ZSBnZXR0ZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94 eUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpEcmF3aW5nQXJlYVByb3h5SW1wbDo6cGFpbnQp OgorICAgICAgICBJbml0aWFsaXplIHRoZSB1bnBhaW50ZWQgcmVnaW9uIHRvIHRoZSBkaXJ0eSBy ZWdpb24sIHRoZW4gc3VidHJhY3QgdGhlIHBhaW50ZWQgcmVnaW9uLgorCiAyMDExLTAxLTIxICBB bmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGFuIEJlcm5zdGVpbiBhbmQgTWFjaWVqIFN0YWNob3dpYWsuCkluZGV4OiBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQmFja2luZ1N0b3JlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0JhY2tpbmdTdG9yZS5oCShyZXZpc2lvbiA3NjM1NikKKysrIFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9CYWNraW5nU3RvcmUuaAkod29ya2luZyBjb3B5KQpAQCAtNTEsNiAr NTEsOCBAQCBwdWJsaWM6CiAgICAgc3RhdGljIFBhc3NPd25QdHI8QmFja2luZ1N0b3JlPiBjcmVh dGUoY29uc3QgV2ViQ29yZTo6SW50U2l6ZSYsIFdlYlBhZ2VQcm94eSopOwogICAgIH5CYWNraW5n U3RvcmUoKTsKIAorICAgIGNvbnN0IFdlYkNvcmU6OkludFNpemUmIHNpemUoKSBjb25zdCB7IHJl dHVybiBtX3NpemU7IH0KKwogI2lmIFBMQVRGT1JNKE1BQykKICAgICB0eXBlZGVmIENHQ29udGV4 dFJlZiBQbGF0Zm9ybUdyYXBoaWNzQ29udGV4dDsKICNlbmRpZgpJbmRleDogU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHlJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94eUltcGwuY3BwCShyZXZpc2lvbiA3 NjM1NikKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5SW1wbC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTI2LDYgKzI2LDcgQEAKICNpbmNsdWRlICJEcmF3aW5nQXJl YVByb3h5SW1wbC5oIgogCiAjaW5jbHVkZSAiRHJhd2luZ0FyZWFNZXNzYWdlcy5oIgorI2luY2x1 ZGUgIlJlZ2lvbi5oIgogI2luY2x1ZGUgIlVwZGF0ZUluZm8uaCIKICNpbmNsdWRlICJXZWJQYWdl UHJveHkuaCIKICNpbmNsdWRlICJXZWJQcm9jZXNzUHJveHkuaCIKQEAgLTUzLDEyICs1NCwxNSBA QCBEcmF3aW5nQXJlYVByb3h5SW1wbDo6fkRyYXdpbmdBcmVhUHJveHlJCiB7CiB9CiAKLXZvaWQg RHJhd2luZ0FyZWFQcm94eUltcGw6OnBhaW50KEJhY2tpbmdTdG9yZTo6UGxhdGZvcm1HcmFwaGlj c0NvbnRleHQgY29udGV4dCwgY29uc3QgSW50UmVjdCYgcmVjdCkKK3ZvaWQgRHJhd2luZ0FyZWFQ cm94eUltcGw6OnBhaW50KEJhY2tpbmdTdG9yZTo6UGxhdGZvcm1HcmFwaGljc0NvbnRleHQgY29u dGV4dCwgY29uc3QgSW50UmVjdCYgcmVjdCwgUmVnaW9uJiB1bnBhaW50ZWRSZWdpb24pCiB7Cisg ICAgdW5wYWludGVkUmVnaW9uID0gcmVjdDsKKwogICAgIGlmICghbV9iYWNraW5nU3RvcmUpCiAg ICAgICAgIHJldHVybjsKIAogICAgIG1fYmFja2luZ1N0b3JlLT5wYWludChjb250ZXh0LCByZWN0 KTsKKyAgICB1bnBhaW50ZWRSZWdpb24uc3VidHJhY3QoSW50UmVjdCgwLCAwLCBtX2JhY2tpbmdT dG9yZS0+c2l6ZSgpLndpZHRoKCksIG1fYmFja2luZ1N0b3JlLT5zaXplKCkuaGVpZ2h0KCkpKTsK IH0KIAogdm9pZCBEcmF3aW5nQXJlYVByb3h5SW1wbDo6ZGlkUmVjZWl2ZU1lc3NhZ2UoQ29yZUlQ Qzo6Q29ubmVjdGlvbiosIENvcmVJUEM6Ok1lc3NhZ2VJRCwgQ29yZUlQQzo6QXJndW1lbnREZWNv ZGVyKikKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5SW1w bC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9EcmF3aW5nQXJlYVBy b3h5SW1wbC5oCShyZXZpc2lvbiA3NjM1NikKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9E cmF3aW5nQXJlYVByb3h5SW1wbC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMSwxMiArMzEsMTQgQEAK IAogbmFtZXNwYWNlIFdlYktpdCB7CiAKK2NsYXNzIFJlZ2lvbjsKKwogY2xhc3MgRHJhd2luZ0Fy ZWFQcm94eUltcGwgOiBwdWJsaWMgRHJhd2luZ0FyZWFQcm94eSB7CiBwdWJsaWM6CiAgICAgc3Rh dGljIFBhc3NPd25QdHI8RHJhd2luZ0FyZWFQcm94eUltcGw+IGNyZWF0ZShXZWJQYWdlUHJveHkq KTsKICAgICB2aXJ0dWFsIH5EcmF3aW5nQXJlYVByb3h5SW1wbCgpOwogCi0gICAgdm9pZCBwYWlu dChCYWNraW5nU3RvcmU6OlBsYXRmb3JtR3JhcGhpY3NDb250ZXh0LCBjb25zdCBXZWJDb3JlOjpJ bnRSZWN0Jik7CisgICAgdm9pZCBwYWludChCYWNraW5nU3RvcmU6OlBsYXRmb3JtR3JhcGhpY3ND b250ZXh0LCBjb25zdCBXZWJDb3JlOjpJbnRSZWN0JiwgUmVnaW9uJiB1bnBhaW50ZWRSZWdpb24p OwogCiBwcml2YXRlOgogICAgIGV4cGxpY2l0IERyYXdpbmdBcmVhUHJveHlJbXBsKFdlYlBhZ2VQ cm94eSopOwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5t bQkocmV2aXNpb24gNzYzNTYpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9X S1ZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTM3LDYgKzM3LDcgQEAKICNpbXBvcnQgIlBhZ2VD bGllbnRJbXBsLmgiCiAjaW1wb3J0ICJQYXN0ZWJvYXJkVHlwZXMuaCIKICNpbXBvcnQgIlByaW50 SW5mby5oIgorI2ltcG9ydCAiUmVnaW9uLmgiCiAjaW1wb3J0ICJSdW5Mb29wLmgiCiAjaW1wb3J0 ICJUZXh0Q2hlY2tlci5oIgogI2ltcG9ydCAiVGV4dENoZWNrZXJTdGF0ZS5oIgpAQCAtMTI3NCw4 ICsxMjc1LDkgQEAgLSAodm9pZClkcmF3UmVjdDooTlNSZWN0KXJlY3QKICAgICAgICAgICAgIE5T SW50ZWdlciBudW1SZWN0c0JlaW5nRHJhd247CiAgICAgICAgICAgICBbc2VsZiBnZXRSZWN0c0Jl aW5nRHJhd246JnJlY3RzQmVpbmdEcmF3biBjb3VudDombnVtUmVjdHNCZWluZ0RyYXduXTsKICAg ICAgICAgICAgIGZvciAoTlNJbnRlZ2VyIGkgPSAwOyBpIDwgbnVtUmVjdHNCZWluZ0RyYXduOyAr K2kpIHsKKyAgICAgICAgICAgICAgICBSZWdpb24gdW5wYWludGVkUmVnaW9uOwogICAgICAgICAg ICAgICAgIEludFJlY3QgcmVjdCA9IGVuY2xvc2luZ0ludFJlY3QocmVjdHNCZWluZ0RyYXduW2ld KTsKLSAgICAgICAgICAgICAgICBkcmF3aW5nQXJlYS0+cGFpbnQoY29udGV4dCwgcmVjdCk7Cisg ICAgICAgICAgICAgICAgZHJhd2luZ0FyZWEtPnBhaW50KGNvbnRleHQsIHJlY3QsIHVucGFpbnRl ZFJlZ2lvbik7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0gZWxzZSBpZiAoX2RhdGEtPl9wYWdl LT5kcmF3c0JhY2tncm91bmQoKSkgewogICAgICAgICAgICAgW19kYXRhLT5fcGFnZS0+ZHJhd3NU cmFuc3BhcmVudEJhY2tncm91bmQoKSA/IFtOU0NvbG9yIGNsZWFyQ29sb3JdIDogW05TQ29sb3Ig d2hpdGVDb2xvcl0gc2V0XTsK