52915 2011-01-21 13:41:19 -0800 reduce number of FrameLoaderClient::didChangeScrollOffset calls 2011-01-21 14:32:27 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony sam oldest_to_newest 338300 0 tony 2011-01-21 13:41:19 -0800 reduce number of FrameLoaderClient::didChangeScrollOffset calls 338320 1 79786 tony 2011-01-21 14:00:18 -0800 Created attachment 79786 Patch 338326 2 tony 2011-01-21 14:02:42 -0800 In particular, it seems like the code that was around lines 550-560 here: http://trac.webkit.org/changeset/76291/trunk/Source/WebCore/platform/ScrollView.cpp got lost in r76291. This results in lots of extra calls to FrameLoaderClient::didChangeScrollOffset. It turns out that chromium is the only port that implements this method (so that session restore can remember the page offset), so it's hard to test using DRT. 338339 3 79786 sam 2011-01-21 14:21:20 -0800 Comment on attachment 79786 Patch Thanks for catching this. r+ 338349 4 tony 2011-01-21 14:32:27 -0800 Committed r76395: <http://trac.webkit.org/changeset/76395> 79786 2011-01-21 14:00:18 -0800 2011-01-21 14:21:20 -0800 Patch bug-52915-20110121140137.patch text/plain 1634 tony ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4MGMzZjZhMWUxMzg4ZDViMzEyZTZlODM2NjUxYzc3ODg4MWU2MjM1Li44 Y2QwMzU4OTlhNzY1ZGIxZGRhOGRhNmFkNGQzZjc0MjcwYWM0NDg3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTggQEAKKzIwMTEtMDEtMjEgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByZWR1Y2Ug bnVtYmVyIG9mIEZyYW1lTG9hZGVyQ2xpZW50OjpkaWRDaGFuZ2VTY3JvbGxPZmZzZXQgY2FsbHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyOTE1CisK KyAgICAgICAgT25seSBub3RpZnkgb2YgY2hhbmdlcyBpbiBzY3JvbGwgb2Zmc2V0IHdoZW4gdGhl cmUgYWN0dWFsbHkgaXMgYSBjaGFuZ2UuCisgICAgICAgIFRoaXMgcmVncmVzc2VkIGluIHI3NjI5 MS4KKyAgICAgICAgCisgICAgICAgIENvdmVyZWQgYnkgQ2hyb21pdW0gYnJvd3Nlcl90ZXN0cy4K KworICAgICAgICAqIHBsYXRmb3JtL1Njcm9sbEFuaW1hdG9yLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlNjcm9sbEFuaW1hdG9yOjpzY3JvbGxUb09mZnNldFdpdGhvdXRBbmltYXRpb24pOgorCiAy MDExLTAxLTIxICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IGNo cm9taXVtIG1hYyBidWlsZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Nj cm9sbEFuaW1hdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbEFuaW1hdG9y LmNwcAppbmRleCA5ZGVmMjk3M2IxMTcxYzVhYmMzOTIzNmJjYTYwYmI5YTQ3MTQxZDM4Li40Mjhh NzlkZGY2OWVkZGVmMTQxMTQzZDAyNzcwNWU4MjU4YWM1MTRkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxBbmltYXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vU2Nyb2xsQW5pbWF0b3IuY3BwCkBAIC03MSw5ICs3MSwxMSBAQCBib29sIFNjcm9s bEFuaW1hdG9yOjpzY3JvbGwoU2Nyb2xsYmFyT3JpZW50YXRpb24gb3JpZW50YXRpb24sIFNjcm9s bEdyYW51bGFyaXR5LAogCiB2b2lkIFNjcm9sbEFuaW1hdG9yOjpzY3JvbGxUb09mZnNldFdpdGhv dXRBbmltYXRpb24oY29uc3QgRmxvYXRQb2ludCYgb2Zmc2V0KQogewotICAgIG1fY3VycmVudFBv c1ggPSBvZmZzZXQueCgpOwotICAgIG1fY3VycmVudFBvc1kgPSBvZmZzZXQueSgpOwotICAgIG5v dGl0eVBvc2l0aW9uQ2hhbmdlZCgpOworICAgIGlmIChtX2N1cnJlbnRQb3NYICE9IG9mZnNldC54 KCkgfHwgbV9jdXJyZW50UG9zWSAhPSBvZmZzZXQueSgpKSB7CisgICAgICAgIG1fY3VycmVudFBv c1ggPSBvZmZzZXQueCgpOworICAgICAgICBtX2N1cnJlbnRQb3NZID0gb2Zmc2V0LnkoKTsKKyAg ICAgICAgbm90aXR5UG9zaXRpb25DaGFuZ2VkKCk7CisgICAgfQogfQogCiBGbG9hdFBvaW50IFNj cm9sbEFuaW1hdG9yOjpjdXJyZW50UG9zaXRpb24oKSBjb25zdAo=