52914 2011-01-21 13:01:20 -0800 Web Inspector: [Chromium] Heap snapshot table sorting is broken 2011-01-24 08:46:40 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov abarth apavlov bweinstein eric joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 338281 0 mnaganov 2011-01-21 13:01:20 -0800 From http://code.google.com/p/chromium/issues/detail?id=70436: Chrome Version : 9.0.597.67 (Official Build 71393) beta What steps will reproduce the problem? 1. Create a heap snapshot 2. Click on the Constructor column header What is the expected result? Table sorts alphabetically by constructor name. What happens instead? The first row randomly switches position with another row. Please provide any additional information below. Attach a screenshot if possible. This same problem happens when trying to sort on the ±Count column when all counts are 0. 338288 1 79779 mnaganov 2011-01-21 13:23:26 -0800 Created attachment 79779 patch 338978 2 mnaganov 2011-01-24 06:41:04 -0800 Manually committed http://trac.webkit.org/changeset/76514: 2011-01-21 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. Web Inspector: [Chromium] Fix heap snapshot table sorting. Fix table sorting to avoid qsort instability artefacts. https://bugs.webkit.org/show_bug.cgi?id=52914 * inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._sortData): (WebInspector.HeapSnapshotDataGridList.propertyComparator.comparator): (WebInspector.HeapSnapshotDataGridList.propertyComparator): 339040 3 webkit.review.bot 2011-01-24 08:46:40 -0800 http://trac.webkit.org/changeset/76514 might have broken GTK Linux 32-bit Debug The following tests are not passing: editing/selection/extend-selection-bidi.html 79779 2011-01-21 13:23:26 -0800 2011-01-24 06:30:22 -0800 patch patch-52914 text/plain 3109 mnaganov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3Njg3YzNlLi45NThhYjYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDEtMjEgIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBbQ2hyb21pdW1dIEZpeCBoZWFwIHNuYXBzaG90IHRhYmxlIHNvcnRpbmcuCisKKyAg ICAgICAgRml4IHRhYmxlIHNvcnRpbmcgdG8gYXZvaWQgcXNvcnQgaW5zdGFiaWxpdHkgYXJ0ZWZh Y3RzLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 MjkxNAorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3RWaWV3Lmpz OgorICAgICAgICAoV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdFZpZXcucHJvdG90eXBlLl9zb3J0 RGF0YSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90RGF0YUdyaWRMaXN0LnBy b3BlcnR5Q29tcGFyYXRvci5jb21wYXJhdG9yKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFw U25hcHNob3REYXRhR3JpZExpc3QucHJvcGVydHlDb21wYXJhdG9yKToKKwogMjAxMS0wMS0yMSAg Q2hyaXMgUm9nZXJzICA8Y3JvZ2Vyc0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEtlbm5ldGggUnVzc2VsbC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvSGVhcFNuYXBzaG90Vmlldy5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvSGVhcFNuYXBzaG90Vmlldy5qcwppbmRleCBmMzQ5MzYxLi5lYzQ4YmYyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdFZp ZXcuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNo b3RWaWV3LmpzCkBAIC02MDEsMTAgKzYwMSwxMCBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90 Vmlldy5wcm90b3R5cGUgPSB7CiAgICAgICAgIHZhciBzb3J0Q29sdW1uSWRlbnRpZmllciA9IHRo aXMuZGF0YUdyaWQuc29ydENvbHVtbklkZW50aWZpZXI7CiAgICAgICAgIHZhciBzb3J0UHJvcGVy dHkgPSB7CiAgICAgICAgICAgICBjb25zOiBbImNvbnN0cnVjdG9yTmFtZSIsIG51bGxdLAotICAg ICAgICAgICAgY291bnQ6IFsiY291bnQiLCBudWxsXSwKLSAgICAgICAgICAgIHNpemU6IFsic2l6 ZSIsICJjb3VudCJdLAotICAgICAgICAgICAgY291bnREZWx0YTogdGhpcy5zaG93Q291bnREZWx0 YUFzUGVyY2VudCA/IFsiY291bnREZWx0YVBlcmNlbnQiLCBudWxsXSA6IFsiY291bnREZWx0YSIs IG51bGxdLAotICAgICAgICAgICAgc2l6ZURlbHRhOiB0aGlzLnNob3dTaXplRGVsdGFBc1BlcmNl bnQgPyBbInNpemVEZWx0YVBlcmNlbnQiLCAiY291bnREZWx0YVBlcmNlbnQiXSA6IFsic2l6ZURl bHRhIiwgInNpemVEZWx0YVBlcmNlbnQiXQorICAgICAgICAgICAgY291bnQ6IFsiY291bnQiLCAi Y29uc3RydWN0b3JOYW1lIl0sCisgICAgICAgICAgICBzaXplOiBbInNpemUiLCAiY29uc3RydWN0 b3JOYW1lIl0sCisgICAgICAgICAgICBjb3VudERlbHRhOiBbdGhpcy5zaG93Q291bnREZWx0YUFz UGVyY2VudCA/ICJjb3VudERlbHRhUGVyY2VudCIgOiAiY291bnREZWx0YSIsICJjb25zdHJ1Y3Rv ck5hbWUiXSwKKyAgICAgICAgICAgIHNpemVEZWx0YTogW3RoaXMuc2hvd1NpemVEZWx0YUFzUGVy Y2VudCA/ICJzaXplRGVsdGFQZXJjZW50IiA6ICJzaXplRGVsdGEiLCAiY29uc3RydWN0b3JOYW1l Il0KICAgICAgICAgfVtzb3J0Q29sdW1uSWRlbnRpZmllcl07CiAKICAgICAgICAgdGhpcy5zbmFw c2hvdERhdGFHcmlkTGlzdC5zb3J0KFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3REYXRhR3JpZExp c3QucHJvcGVydHlDb21wYXJhdG9yKHNvcnRQcm9wZXJ0eVswXSwgc29ydFByb3BlcnR5WzFdLCBz b3J0QXNjZW5kaW5nKSk7CkBAIC0xMDQ2LDEwICsxMDQ2LDE3IEBAIFdlYkluc3BlY3Rvci5IZWFw U25hcHNob3REYXRhR3JpZExpc3QucHJvcGVydHlDb21wYXJhdG9yID0gZnVuY3Rpb24ocHJvcGVy dHksIHByCiAgICAgaWYgKCFjb21wYXJhdG9yKSB7CiAgICAgICAgIGNvbXBhcmF0b3IgPSBmdW5j dGlvbihsaHMsIHJocykgewogICAgICAgICAgICAgdmFyIGwgPSBsaHNbcHJvcGVydHldLCByID0g cmhzW3Byb3BlcnR5XTsKLSAgICAgICAgICAgIGlmICgobCA9PT0gbnVsbCB8fCByID09PSBudWxs KSAmJiBwcm9wZXJ0eTIgIT09IG51bGwpCi0gICAgICAgICAgICAgICAgbCA9IGxoc1twcm9wZXJ0 eTJdLCByID0gcmhzW3Byb3BlcnR5Ml07Ci0gICAgICAgICAgICB2YXIgcmVzdWx0ID0gbCA8IHIg PyAtMSA6IChsID4gciA/IDEgOiAwKTsKLSAgICAgICAgICAgIHJldHVybiBpc0FzY2VuZGluZyA/ IHJlc3VsdCA6IC1yZXN1bHQ7CisgICAgICAgICAgICB2YXIgcmVzdWx0ID0gMDsKKyAgICAgICAg ICAgIGlmIChsICE9PSBudWxsICYmIHIgIT09IG51bGwpIHsKKyAgICAgICAgICAgICAgICByZXN1 bHQgPSBsIDwgciA/IC0xIDogKGwgPiByID8gMSA6IDApOworICAgICAgICAgICAgfQorICAgICAg ICAgICAgaWYgKHJlc3VsdCAhPT0gMCB8fCBwcm9wZXJ0eTIgPT09IG51bGwpIHsKKyAgICAgICAg ICAgICAgICByZXR1cm4gaXNBc2NlbmRpbmcgPyByZXN1bHQgOiAtcmVzdWx0OworICAgICAgICAg ICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICBsID0gbGhzW3Byb3BlcnR5Ml07CisgICAgICAg ICAgICAgICAgciA9IHJoc1twcm9wZXJ0eTJdOworICAgICAgICAgICAgICAgIHJldHVybiBsIDwg ciA/IC0xIDogKGwgPiByID8gMSA6IDApOworICAgICAgICAgICAgfQogICAgICAgICB9OwogICAg ICAgICB0aGlzLnByb3BlcnR5Q29tcGFyYXRvcnNbKGlzQXNjZW5kaW5nID8gMSA6IDApXVtwcm9w ZXJ0eUhhc2hdID0gY29tcGFyYXRvcjsKICAgICB9Cg==