52909 2011-01-21 11:39:02 -0800 GraphicsLayer should be non-copyable 2011-01-21 11:45:03 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser cmarrin simon.fraser webkit.review.bot oldest_to_newest 338201 0 simon.fraser 2011-01-21 11:39:02 -0800 GraphicsLayer should be non-copyable 338208 1 79770 simon.fraser 2011-01-21 11:42:20 -0800 Created attachment 79770 Patch 338210 2 webkit.review.bot 2011-01-21 11:44:00 -0800 Attachment 79770 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/GraphicsLayer.h:151: More than one command on the same line [whitespace/newline] [4] Source/WebCore/platform/graphics/GraphicsLayer.h:183: More than one command on the same line [whitespace/newline] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 338212 3 simon.fraser 2011-01-21 11:45:03 -0800 http://trac.webkit.org/changeset/76374 79770 2011-01-21 11:42:20 -0800 2011-01-21 11:43:34 -0800 Patch bug-52909-20110121114219.patch text/plain 1757 simon.fraser ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyNjY5MDQzNjVhZGMyNjJiNTgzOGMyOWZmY2MzYzlmOTFhNDk0ZDE5Li4x MjE1YThmNjA2MDQ2MDM4YjVkYzMwMWZmYTIxZjBjZDc1OGQ2NmQ5IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDUgKzEsMTcgQEAKIDIwMTEtMDEtMjEgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBs ZS5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg R3JhcGhpY3NMYXllciBzaG91bGQgYmUgbm9uLWNvcHlhYmxlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjkwOQorCisgICAgICAgIFVzZSBXVEZfTUFL RV9OT05DT1BZQUJMRSBvbiBHcmFwaGljc0xheWVyLCBhbmQgV1RGX01BS0VfRkFTVF9BTExPQ0FU RUQKKyAgICAgICAgb24gdGhhdCBhbmQgS2V5ZnJhbWVWYWx1ZUxpc3QuCisgICAgICAgIAorICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuaDoKKworMjAxMS0wMS0yMSAg U2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKwogICAgICAgICBSZXZpZXdl ZCBieSBTYW0gV2VpbmlnLgogCiAgICAgICAgIFJlcG9ydCB0aGUgc2l6ZWQgdXNlZCBieSBjYW52 YXNlcyBhbmQgdHlwZXMgYXJyYXlzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9HcmFwaGljc0xheWVyLmgKaW5kZXggNzhjMWU3NTJiNGE0OWY3ZWEwODVkNTEwYTMyNTQw ODc0ZDJmMDBhOS4uNDg2YjY5YWZmYmU2MzRhNTk1YjkyNTVhODNhYWQwNjg3NTVmY2MxZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllci5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuaApA QCAtMTQ4LDcgKzE0OCw3IEBAIHByaXZhdGU6CiAvLyBVc2VkIHRvIHN0b3JlIGEgc2VyaWVzIG9m IHZhbHVlcyBpbiBhIGtleWZyYW1lIGxpc3QuIFZhbHVlcyB3aWxsIGFsbCBiZSBvZiB0aGUgc2Ft ZSB0eXBlLAogLy8gd2hpY2ggY2FuIGJlIGluZmVycmVkIGZyb20gdGhlIHByb3BlcnR5LgogY2xh c3MgS2V5ZnJhbWVWYWx1ZUxpc3QgewotICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKEtleWZyYW1l VmFsdWVMaXN0KTsKKyAgICBXVEZfTUFLRV9OT05DT1BZQUJMRShLZXlmcmFtZVZhbHVlTGlzdCk7 IFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgogCiAgICAgS2V5ZnJhbWVWYWx1ZUxp c3QoQW5pbWF0ZWRQcm9wZXJ0eUlEIHByb3BlcnR5KQpAQCAtMTgwLDggKzE4MCw4IEBAIHByb3Rl Y3RlZDoKIC8vIHdoaWNoIG1heSBoYXZlIGFzc29jaWF0ZWQgdHJhbnNmb3JtYXRpb24gYW5kIGFu aW1hdGlvbnMuCiAKIGNsYXNzIEdyYXBoaWNzTGF5ZXIgeworICAgIFdURl9NQUtFX05PTkNPUFlB QkxFKEdyYXBoaWNzTGF5ZXIpOyBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKIHB1YmxpYzoKLQog ICAgIHN0YXRpYyBQYXNzT3duUHRyPEdyYXBoaWNzTGF5ZXI+IGNyZWF0ZShHcmFwaGljc0xheWVy Q2xpZW50Kik7CiAgICAgCiAgICAgdmlydHVhbCB+R3JhcGhpY3NMYXllcigpOwo=