52880 2011-01-21 03:17:42 -0800 [GTK] Implement PlatformKeyboardEvent::getCurrentModifierState() 2011-02-20 01:28:39 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned kling mrobinson oldest_to_newest 337982 0 cgarcia 2011-01-21 03:17:42 -0800 While working on bug #52878 I noticed that PlatformKeyboardEvent::getCurrentModifierState() is currently unimplemented in the gtk port. I don't know if any test is failing because of this, but it could be easily implemented. 337984 1 79719 cgarcia 2011-01-21 03:20:36 -0800 Created attachment 79719 Patch implementing getCurrentModifierState() 338632 2 mrobinson 2011-01-22 14:17:40 -0800 I grepped the entire source tree an only found implementations with no callers. Perhaps it makes more sense just to remove this method, as it appears to be dead code. 338643 3 79719 eric 2011-01-22 15:04:02 -0800 Comment on attachment 79719 Patch implementing getCurrentModifierState() This does the current global event, not the actual object in question, right? 338868 4 cgarcia 2011-01-23 23:57:55 -0800 (In reply to comment #3) > (From update of attachment 79719 [details]) > This does the current global event, not the actual object in question, right? Yes, it takes the event from the global event list 342388 5 kling 2011-01-30 15:34:49 -0800 (In reply to comment #2) > I grepped the entire source tree an only found implementations with no callers. Perhaps it makes more sense just to remove this method, as it appears to be dead code. Sounds like a good idea to me. About this patch.. is the MOD1 key guaranteed to be Alt? 342483 6 cgarcia 2011-01-30 23:40:51 -0800 (In reply to comment #5) > (In reply to comment #2) > > I grepped the entire source tree an only found implementations with no callers. Perhaps it makes more sense just to remove this method, as it appears to be dead code. > > Sounds like a good idea to me. > > About this patch.. is the MOD1 key guaranteed to be Alt? GTK docs says: "It depends on the modifier mapping of the X server which key is interpreted as this modifier, but normally it is the Alt key" we are currently using it everywhere in gtk port, in MouseEventGtk.cpp we have a FIXME comment though: // FIXME: Would be even better to figure out which modifier is Alt instead of always using GDK_MOD1_MASK. 353194 7 79719 mrobinson 2011-02-17 15:13:47 -0800 Comment on attachment 79719 Patch implementing getCurrentModifierState() Seems this is used in DragController.cpp for createMouseEvent. 354263 8 cgarcia 2011-02-20 01:28:25 -0800 Committed r79151: <http://trac.webkit.org/changeset/79151> 79719 2011-01-21 03:20:36 -0800 2011-02-20 01:28:39 -0800 Patch implementing getCurrentModifierState() current-modifier-state.diff text/plain 1425 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmYjYzODk0Li42ZTQ0YTQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDEtMjEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd IEltcGxlbWVudCBQbGF0Zm9ybUtleWJvYXJkRXZlbnQ6OmdldEN1cnJlbnRNb2RpZmllclN0YXRl KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyODgw CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvS2V5RXZlbnRHdGsuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UGxhdGZvcm1LZXlib2FyZEV2ZW50OjpnZXRDdXJyZW50TW9kaWZpZXJTdGF0ZSk6CisK IDIwMTAtMTItMTQgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2d0ay9LZXlFdmVudEd0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvS2V5RXZlbnRHdGsuY3BwCmluZGV4IDVhMDM0ZDYuLjlmNGMyMGUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9LZXlFdmVudEd0ay5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3RrL0tleUV2ZW50R3RrLmNwcApAQCAtNTg4LDExICs1ODgsMTMgQEAg Ym9vbCBQbGF0Zm9ybUtleWJvYXJkRXZlbnQ6OmN1cnJlbnRDYXBzTG9ja1N0YXRlKCkKIAogdm9p ZCBQbGF0Zm9ybUtleWJvYXJkRXZlbnQ6OmdldEN1cnJlbnRNb2RpZmllclN0YXRlKGJvb2wmIHNo aWZ0S2V5LCBib29sJiBjdHJsS2V5LCBib29sJiBhbHRLZXksIGJvb2wmIG1ldGFLZXkpCiB7Ci0g ICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICBzaGlmdEtleSA9IGZhbHNlOwotICAgIGN0cmxLZXkg PSBmYWxzZTsKLSAgICBhbHRLZXkgPSBmYWxzZTsKLSAgICBtZXRhS2V5ID0gZmFsc2U7CisgICAg R2RrTW9kaWZpZXJUeXBlIHN0YXRlOworICAgIGd0a19nZXRfY3VycmVudF9ldmVudF9zdGF0ZSgm c3RhdGUpOworCisgICAgc2hpZnRLZXkgPSBzdGF0ZSAmIEdES19TSElGVF9NQVNLOworICAgIGN0 cmxLZXkgPSBzdGF0ZSAmIEdES19DT05UUk9MX01BU0s7CisgICAgYWx0S2V5ID0gc3RhdGUgJiBH REtfTU9EMV9NQVNLOworICAgIG1ldGFLZXkgPSBzdGF0ZSAmIEdES19NRVRBX01BU0s7CiB9CiAK IEdka0V2ZW50S2V5KiBQbGF0Zm9ybUtleWJvYXJkRXZlbnQ6Omdka0V2ZW50S2V5KCkgY29uc3QK