52878 2011-01-21 02:26:09 -0800 [GTK] Show caps lock indicator in password fields 2011-01-21 09:24:48 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned mrobinson oldest_to_newest 337958 0 cgarcia 2011-01-21 02:26:09 -0800 It's very common in password fields to alert the user when caps lock modifier is locked. GTK+ has an icon for this. 337959 1 79715 cgarcia 2011-01-21 02:32:14 -0800 Created attachment 79715 Patch to show caps lock indicator in password fields 338069 2 79715 mrobinson 2011-01-21 08:32:35 -0800 Comment on attachment 79715 Patch to show caps lock indicator in password fields Awesome. 338100 3 cgarcia 2011-01-21 09:22:15 -0800 Committed r76351: <http://trac.webkit.org/changeset/76351> 79715 2011-01-21 02:32:14 -0800 2011-01-21 09:24:48 -0800 Patch to show caps lock indicator in password fields caps-lock-indicator.diff text/plain 4992 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmYjYzODk0Li40ZjRkNWQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTEtMDEtMjEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd IFNob3cgY2FwcyBsb2NrIGluZGljYXRvciBpbiBwYXNzd29yZCBmaWVsZHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyODc4CisKKyAgICAgICAgVGVz dDogbWFudWFsLXRlc3RzL3Bhc3N3b3JkLWNhcHMtbG9jay5odG1sCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ndGsvS2V5RXZlbnRHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGxhdGZvcm1LZXli b2FyZEV2ZW50OjpjdXJyZW50Q2Fwc0xvY2tTdGF0ZSk6IEltcGxlbWVudAorICAgICAgICBjdXJy ZW50Q2Fwc0xvY2tTdGF0ZSgpIHVzaW5nIEdESyBBUEkuCisgICAgICAgICogcGxhdGZvcm0vZ3Rr L1JlbmRlclRoZW1lR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lR3RrOjpw YWludENhcHNMb2NrSW5kaWNhdG9yKTogUGFpbnQgYW4gaWNvbgorICAgICAgICBpbiB0aGUgcGFz c3dvcmQgZmllbGQgd2hlbiB0aGUgY2FwcyBsb2NrIG1vZGlmaWVyIGlzIGxvY2tlZC4KKyAgICAg ICAgKiBwbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsuaDoKKwogMjAxMC0xMi0xNCAgWXVyeSBT ZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBB ZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvU291 cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IGVmYmE0MGQuLjMxOTQ0Y2MgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMS0wMS0yMSAgQ2FybG9zIEdhcmNpYSBDYW1w b3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW0dUS10gU2hvdyBjYXBzIGxvY2sgaW5kaWNhdG9yIGluIHBhc3N3 b3JkIGZpZWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTI4NzgKKworICAgICAgICBUZXN0OiBtYW51YWwtdGVzdHMvcGFzc3dvcmQtY2Fwcy1sb2Nr Lmh0bWwKKworICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHdl YmtpdF93ZWJfdmlld19rZXlfcmVsZWFzZV9ldmVudCk6IENhbGwKKyAgICAgICAgY2Fwc0xvY2tT dGF0ZU1heUhhdmVDaGFuZ2VkKCkgd2hlbiBjYXBzIGxvY2sga2V5IGlzIHByZXNzZWQuCisKIDIw MTEtMDEtMTkgIEpvb25lIEh1ciAgPGpvb25lLmh1ckBjb2xsYWJvcmEuY28udWs+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2d0ay9LZXlFdmVudEd0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvS2V5RXZlbnRHdGsuY3BwCmluZGV4IDUwZGZhNGMuLjVhMDM0ZDYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9LZXlFdmVudEd0ay5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3RrL0tleUV2ZW50R3RrLmNwcApAQCAtNTgzLDggKzU4Myw3IEBAIHZv aWQgUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpkaXNhbWJpZ3VhdGVLZXlEb3duRXZlbnQoVHlwZSB0 eXBlLCBib29sIGJhY2t3YXJkQ29tCiAKIGJvb2wgUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpjdXJy ZW50Q2Fwc0xvY2tTdGF0ZSgpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICByZXR1cm4g ZmFsc2U7CisgICAgcmV0dXJuIGdka19rZXltYXBfZ2V0X2NhcHNfbG9ja19zdGF0ZShnZGtfa2V5 bWFwX2dldF9kZWZhdWx0KCkpOwogfQogCiB2b2lkIFBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6Z2V0 Q3VycmVudE1vZGlmaWVyU3RhdGUoYm9vbCYgc2hpZnRLZXksIGJvb2wmIGN0cmxLZXksIGJvb2wm IGFsdEtleSwgYm9vbCYgbWV0YUtleSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv UmVuZGVyVGhlbWVHdGsuY3BwCmluZGV4IGRjZTc3NjMuLmNkOWUyNDcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmNwcApAQCAtMzA5LDYgKzMwOSwy NCBAQCBib29sIFJlbmRlclRoZW1lR3RrOjpwYWludFNlYXJjaEZpZWxkKFJlbmRlck9iamVjdCog bywgY29uc3QgUGFpbnRJbmZvJiBpLCBjb25zdAogICAgIHJldHVybiBwYWludFRleHRGaWVsZChv LCBpLCByZWN0KTsKIH0KIAorYm9vbCBSZW5kZXJUaGVtZUd0azo6cGFpbnRDYXBzTG9ja0luZGlj YXRvcihSZW5kZXJPYmplY3QqIHJlbmRlck9iamVjdCwgY29uc3QgUGFpbnRJbmZvJiBwYWludElu Zm8sIGNvbnN0IEludFJlY3QmIHJlY3QpCit7CisgICAgLy8gVGhlIG90aGVyIHBhaW50IG1ldGhv ZHMgZG9uJ3QgbmVlZCB0byBjaGVjayB3aGV0aGVyIHBhaW50aW5nIGlzIGRpc2FibGVkIGJlY2F1 c2UgUmVuZGVyVGhlbWUgYWxyZWFkeSBjaGVja3MgaXQKKyAgICAvLyBiZWZvcmUgY2FsbGluZyB0 aGVtLCBidXQgcGFpbnRDYXBzTG9ja0luZGljYXRvcigpIGlzIGNhbGxlZCBieSBSZW5kZXJUZXh0 Q29udHJvbFNpbmdsZUxpbmUgd2hpY2ggZG9lc24ndCBjaGVjayBpdC4KKyAgICBpZiAocGFpbnRJ bmZvLmNvbnRleHQtPnBhaW50aW5nRGlzYWJsZWQoKSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisK KyAgICBHUmVmUHRyPEdka1BpeGJ1Zj4gaWNvbiA9IGdldFN0b2NrSWNvbihHVEtfVFlQRV9FTlRS WSwgR1RLX1NUT0NLX0NBUFNfTE9DS19XQVJOSU5HLAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGd0a1RleHREaXJlY3Rpb24ocmVuZGVyT2JqZWN0LT5zdHlsZSgp LT5kaXJlY3Rpb24oKSksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgZ3RrSWNvblN0YXRlKHRoaXMsIHJlbmRlck9iamVjdCksIEdUS19JQ09OX1NJWkVfTUVOVSk7 CisKKyAgICAvLyBHVEsrIGxvY2F0ZXMgdGhlIGljb24gcmlnaHQgYWxpZ25lZCBpbiB0aGUgZW50 cnkuIFRoZSBnaXZlbiByZWN0YW5nbGUgaXMgYWxyZWFkeQorICAgIC8vIGNlbnRlcmVkIHZlcnRp Y2FsbHkgYnkgUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lLgorICAgIEludFBvaW50IGljb25Q b3NpdGlvbihyZWN0LngoKSArIHJlY3Qud2lkdGgoKSAtIGdka19waXhidWZfZ2V0X3dpZHRoKGlj b24uZ2V0KCkpLCByZWN0LnkoKSk7CisgICAgcGFpbnRHZGtQaXhidWYocGFpbnRJbmZvLmNvbnRl eHQsIGljb24uZ2V0KCksIGljb25Qb3NpdGlvbik7CisgICAgcmV0dXJuIHRydWU7Cit9CisKIHZv aWQgUmVuZGVyVGhlbWVHdGs6OmFkanVzdFNsaWRlclRyYWNrU3R5bGUoQ1NTU3R5bGVTZWxlY3Rv ciosIFJlbmRlclN0eWxlKiBzdHlsZSwgRWxlbWVudCopIGNvbnN0CiB7CiAgICAgc3R5bGUtPnNl dEJveFNoYWRvdygwKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9S ZW5kZXJUaGVtZUd0ay5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1l R3RrLmgKaW5kZXggYmNlODlkOS4uYTU1ZDEzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3RrL1JlbmRlclRoZW1lR3RrLmgKQEAgLTE2OSw2ICsxNjksOCBAQCBwcm90ZWN0ZWQ6CiAg ICAgdmlydHVhbCBib29sIHBhaW50UHJvZ3Jlc3NCYXIoUmVuZGVyT2JqZWN0KiwgY29uc3QgUGFp bnRJbmZvJiwgY29uc3QgSW50UmVjdCYpOwogI2VuZGlmCiAKKyAgICB2aXJ0dWFsIGJvb2wgcGFp bnRDYXBzTG9ja0luZGljYXRvcihSZW5kZXJPYmplY3QqLCBjb25zdCBQYWludEluZm8mLCBjb25z dCBJbnRSZWN0Jik7CisKIHByaXZhdGU6CiAgICAgdm9pZCBwbGF0Zm9ybUluaXQoKTsKICAgICBz dGF0aWMgdm9pZCBzZXRUZXh0SW5wdXRCb3JkZXJzKFJlbmRlclN0eWxlKik7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggZTVkNWI4NC4uYzg1NTUwNyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAtNzkwLDYg Kzc5MCw5IEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfd2ViX3ZpZXdfa2V5X3JlbGVhc2VfZXZl bnQoR3RrV2lkZ2V0KiB3aWRnZXQsIEdka0V2ZW50S2V5CiAgICAgaWYgKCFmcmFtZS0+dmlldygp KQogICAgICAgICByZXR1cm4gRkFMU0U7CiAKKyAgICBpZiAoZXZlbnQtPmtleXZhbCA9PSBHREtf Q2Fwc19Mb2NrKQorICAgICAgICBmcmFtZS0+ZXZlbnRIYW5kbGVyKCktPmNhcHNMb2NrU3RhdGVN YXlIYXZlQ2hhbmdlZCgpOworCiAgICAgUGxhdGZvcm1LZXlib2FyZEV2ZW50IGtleWJvYXJkRXZl bnQoZXZlbnQpOwogICAgIGlmIChmcmFtZS0+ZXZlbnRIYW5kbGVyKCktPmtleUV2ZW50KGtleWJv YXJkRXZlbnQpKQogICAgICAgICByZXR1cm4gVFJVRTsK