<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>52873</bug_id>
          
          <creation_ts>2011-01-21 01:29:10 -0800</creation_ts>
          <short_desc>Chromium DRT should provide command-line option for specifying timeout to ease debugging</short_desc>
          <delta_ts>2011-02-15 22:48:23 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Xianzhu Wang">wangxianzhu</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>dglazkov</cc>
    
    <cc>eric</cc>
    
    <cc>phnixwxz</cc>
    
    <cc>tkent</cc>
    
    <cc>tony</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>337933</commentid>
    <comment_count>0</comment_count>
    <who name="Xianzhu Wang">wangxianzhu</who>
    <bug_when>2011-01-21 01:29:10 -0800</bug_when>
    <thetext>When debugging DRT, we need to specify a larger timeout so that DRT won&apos;t timeout during debugging. Though we can specify timeout in test-shell mode, sometimes the non-test-shell mode is more convenient to use in debugging.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>338011</commentid>
    <comment_count>1</comment_count>
      <attachid>79724</attachid>
    <who name="Xianzhu Wang">wangxianzhu</who>
    <bug_when>2011-01-21 04:50:38 -0800</bug_when>
    <thetext>Created attachment 79724
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>339303</commentid>
    <comment_count>2</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-01-24 15:29:46 -0800</bug_when>
    <thetext>We&apos;re tryign to be more like the other DRTs, not less. :)  How do other DRT implementations handle this case?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>339612</commentid>
    <comment_count>3</comment_count>
    <who name="Xianzhu Wang">wangxianzhu</who>
    <bug_when>2011-01-25 05:47:43 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; We&apos;re tryign to be more like the other DRTs, not less. :)  How do other DRT implementations handle this case?

Other implementations seem to also have the timeout issue.

I just asked a colleague how he prevent timeout when debugging DRT, he answered he just modifies DRT to disable timeout. Wondering how others do.

If you think the feature is useful, I&apos;d be glad to add it into other ports.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>339699</commentid>
    <comment_count>4</comment_count>
      <attachid>79724</attachid>
    <who name="Tony Chang">tony</who>
    <bug_when>2011-01-25 09:45:30 -0800</bug_when>
    <thetext>Comment on attachment 79724
patch

I think it&apos;s OK to add this, however I think it would be better if it were just a flag like --disable-time-out.  I don&apos;t see the benefit in being able to specify a timeout.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>340027</commentid>
    <comment_count>5</comment_count>
    <who name="Xianzhu Wang">phnixwxz</who>
    <bug_when>2011-01-25 17:01:57 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; (From update of attachment 79724 [details])
&gt; I think it&apos;s OK to add this, however I think it would be better if it were just a flag like --disable-time-out.  I don&apos;t see the benefit in being able to specify a timeout.

For --disable-time-out, the implementation will be &apos;shell.setLayoutTestTimeout(INT_MAX)&apos; instead of changing all of the TestShellXXX.cpp to actually disable timeout. Would this look good to you?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>340029</commentid>
    <comment_count>6</comment_count>
    <who name="Tony Chang">tony</who>
    <bug_when>2011-01-25 17:11:24 -0800</bug_when>
    <thetext>(In reply to comment #5)
&gt; For --disable-time-out, the implementation will be &apos;shell.setLayoutTestTimeout(INT_MAX)&apos; instead of changing all of the TestShellXXX.cpp to actually disable timeout. Would this look good to you?

Yes, I think that&apos;s ok.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>340149</commentid>
    <comment_count>7</comment_count>
      <attachid>80169</attachid>
    <who name="Xianzhu Wang">wangxianzhu</who>
    <bug_when>2011-01-25 22:07:53 -0800</bug_when>
    <thetext>Created attachment 80169
Updated patch: --no-timeout

I just investigated non-Chromium DRTs and found that they are different from Chromium DRTs about timeout. Chromium DRTs will call &apos;exit()&apos; on timeout, while non-Chromium DRTs call notifyDone() which will cause exiting in the next message loop. So for the latter timeout is not a big issue for debugging.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>340337</commentid>
    <comment_count>8</comment_count>
      <attachid>80169</attachid>
    <who name="Tony Chang">tony</who>
    <bug_when>2011-01-26 10:30:25 -0800</bug_when>
    <thetext>Comment on attachment 80169
Updated patch: --no-timeout

View in context: https://bugs.webkit.org/attachment.cgi?id=80169&amp;action=review

At some point, we should see if we can get Chromium DRT to do the same as Mac DRT and call notifyDone on timeout.

&gt; Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:191
&gt; +            // 0x20000000ms is big enough for the purpose to avoid timeout in debugging.
&gt; +            shell.setLayoutTestTimeout(0x20000000);

Why did you decide against INT_MAX from climits?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>340370</commentid>
    <comment_count>9</comment_count>
      <attachid>80169</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-01-26 11:54:10 -0800</bug_when>
    <thetext>Comment on attachment 80169
Updated patch: --no-timeout

Clearing flags on attachment: 80169

Committed r76704: &lt;http://trac.webkit.org/changeset/76704&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>340371</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-01-26 11:54:14 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>340381</commentid>
    <comment_count>11</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-01-26 12:04:22 -0800</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 80169:

java/lc3/JSObject/ToObject-001.html bug 53091 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>340622</commentid>
    <comment_count>12</comment_count>
    <who name="Xianzhu Wang">wangxianzhu</who>
    <bug_when>2011-01-26 17:25:08 -0800</bug_when>
    <thetext>(In reply to comment #8)

Thanks Tony for review.

&gt; (From update of attachment 80169 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=80169&amp;action=review
&gt; 
&gt; At some point, we should see if we can get Chromium DRT to do the same as Mac DRT and call notifyDone on timeout.
&gt; 

Non-Chromium DRT also has their problems:
1. Sometimes NRWT must kill the DRT process if it wants a timeout shorter than 30s. For Chromium DRT, the script can specify timeout for each test in test-shell mode.

2. If the DRT process is busy in a loop, it can&apos;t quit by itself and can only be killed.

&gt; &gt; Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:191
&gt; &gt; +            // 0x20000000ms is big enough for the purpose to avoid timeout in debugging.
&gt; &gt; +            shell.setLayoutTestTimeout(0x20000000);
&gt; 
&gt; Why did you decide against INT_MAX from climits?

I&apos;m afraid if INT_MAX as a timeout was added to some value it would overflow, for example, some port might need 1 more second for timeout.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>351877</commentid>
    <comment_count>13</comment_count>
    <who name="Xianzhu Wang">wangxianzhu</who>
    <bug_when>2011-02-15 21:46:55 -0800</bug_when>
    <thetext>Sorry there is a small bug in the last patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>351879</commentid>
    <comment_count>14</comment_count>
      <attachid>82588</attachid>
    <who name="Xianzhu Wang">wangxianzhu</who>
    <bug_when>2011-02-15 21:47:52 -0800</bug_when>
    <thetext>Created attachment 82588
Fix a small bug</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>351880</commentid>
    <comment_count>15</comment_count>
      <attachid>82588</attachid>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2011-02-15 21:54:49 -0800</bug_when>
    <thetext>Comment on attachment 82588
Fix a small bug

ok</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>351892</commentid>
    <comment_count>16</comment_count>
      <attachid>82588</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-02-15 22:48:17 -0800</bug_when>
    <thetext>Comment on attachment 82588
Fix a small bug

Clearing flags on attachment: 82588

Committed r78685: &lt;http://trac.webkit.org/changeset/78685&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>351893</commentid>
    <comment_count>17</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-02-15 22:48:23 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>79724</attachid>
            <date>2011-01-21 04:50:38 -0800</date>
            <delta_ts>2011-01-25 22:07:53 -0800</delta_ts>
            <desc>patch</desc>
            <filename>patch52873.txt</filename>
            <type>text/plain</type>
            <size>2432</size>
            <attacher name="Xianzhu Wang">wangxianzhu</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDc2MzQ0KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMTMgQEAKKzIwMTEtMDEtMjEgIFhpYW56aHUgV2FuZyAgPHdhbmd4aWFuemh1QGdvb2dsZS5j
b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRk
ICctLXRpbWUtb3V0LW1zJyBvcHRpb24gdG8gQ2hyb21pdW0gRFJUIHRvIGVhc2UgZGVidWdnaW5n
LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI4NzMK
KworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0R1bXBSZW5kZXJUcmVlLmNwcDoK
KyAgICAgICAgKG1haW4pOgorCiAyMDExLTAxLTIxICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0
Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogVG9vbHMvRHVt
cFJlbmRlclRyZWUvY2hyb21pdW0vRHVtcFJlbmRlclRyZWUuY3BwCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv
b2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0R1bXBSZW5kZXJUcmVlLmNwcAkocmV2aXNpb24g
NzYzMzcpCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9EdW1wUmVuZGVyVHJlZS5j
cHAJKHdvcmtpbmcgY29weSkKQEAgLTU4LDYgKzU4LDcgQEAgc3RhdGljIGNvbnN0IGNoYXIgb3B0
aW9uRW5hYmxlQWNjZWxlcmF0ZQogc3RhdGljIGNvbnN0IGNoYXIgb3B0aW9uU3RyZXNzT3B0W10g
PSAiLS1zdHJlc3Mtb3B0IjsKIHN0YXRpYyBjb25zdCBjaGFyIG9wdGlvblN0cmVzc0Rlb3B0W10g
PSAiLS1zdHJlc3MtZGVvcHQiOwogc3RhdGljIGNvbnN0IGNoYXIgb3B0aW9uSmF2YVNjcmlwdEZs
YWdzW10gPSAiLS1qcy1mbGFncz0iOworc3RhdGljIGNvbnN0IGNoYXIgb3B0aW9uVGltZU91dE1z
W10gPSAiLS10aW1lLW91dC1tcz0iOwogCiBzdGF0aWMgdm9pZCBydW5UZXN0KFRlc3RTaGVsbCYg
c2hlbGwsIFRlc3RQYXJhbXMmIHBhcmFtcywgY29uc3Qgc3RyaW5nJiB0ZXN0TmFtZSwgYm9vbCB0
ZXN0U2hlbGxNb2RlKQogewpAQCAtMTIzLDYgKzEyNCw3IEBAIGludCBtYWluKGludCBhcmdjLCBj
aGFyKiBhcmd2W10pCiAgICAgYm9vbCBzdHJlc3NEZW9wdCA9IGZhbHNlOwogICAgIGJvb2wgaGFy
ZHdhcmVBY2NlbGVyYXRlZEdMID0gZmFsc2U7CiAgICAgc3RyaW5nIGphdmFTY3JpcHRGbGFnczsK
KyAgICBpbnQgdGltZU91dE1zID0gLTE7CiAgICAgZm9yIChpbnQgaSA9IDE7IGkgPCBhcmdjOyAr
K2kpIHsKICAgICAgICAgc3RyaW5nIGFyZ3VtZW50KGFyZ3ZbaV0pOwogICAgICAgICBpZiAoYXJn
dW1lbnQgPT0gIi0iKQpAQCAtMTU1LDYgKzE1Nyw4IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFy
KiBhcmd2W10pCiAgICAgICAgICAgICBzdHJlc3NEZW9wdCA9IHRydWU7CiAgICAgICAgIGVsc2Ug
aWYgKCFhcmd1bWVudC5maW5kKG9wdGlvbkphdmFTY3JpcHRGbGFncykpCiAgICAgICAgICAgICBq
YXZhU2NyaXB0RmxhZ3MgPSBhcmd1bWVudC5zdWJzdHIoc3RybGVuKG9wdGlvbkphdmFTY3JpcHRG
bGFncykpOworICAgICAgICBlbHNlIGlmICghYXJndW1lbnQuZmluZChvcHRpb25UaW1lT3V0TXMp
KQorICAgICAgICAgICAgdGltZU91dE1zID0gYXRvaShhcmd1bWVudC5zdWJzdHIoc3RybGVuKG9w
dGlvblRpbWVPdXRNcykpLmNfc3RyKCkpOwogICAgICAgICBlbHNlIGlmIChhcmd1bWVudC5zaXpl
KCkgJiYgYXJndW1lbnRbMF0gPT0gJy0nKQogICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsICJV
bmtub3duIG9wdGlvbjogJXNcbiIsIGFyZ3ZbaV0pOwogICAgICAgICBlbHNlCkBAIC0xODIsNiAr
MTg2LDggQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqIGFyZ3ZbXSkKICAgICAgICAgc2hlbGwu
c2V0SmF2YVNjcmlwdEZsYWdzKGphdmFTY3JpcHRGbGFncyk7CiAgICAgICAgIHNoZWxsLnNldFN0
cmVzc09wdChzdHJlc3NPcHQpOwogICAgICAgICBzaGVsbC5zZXRTdHJlc3NEZW9wdChzdHJlc3NE
ZW9wdCk7CisgICAgICAgIGlmICh0aW1lT3V0TXMgIT0gLTEpCisgICAgICAgICAgICBzaGVsbC5z
ZXRMYXlvdXRUZXN0VGltZW91dCh0aW1lT3V0TXMpOwogICAgICAgICBpZiAoc2VydmVyTW9kZSAm
JiAhdGVzdHMuc2l6ZSgpKSB7CiAgICAgICAgICAgICBwYXJhbXMucHJpbnRTZXBhcmF0b3JzID0g
dHJ1ZTsKICAgICAgICAgICAgIGNoYXIgdGVzdFN0cmluZ1syMDQ4XTsgLy8gMjA0OCBpcyB0aGUg
c2FtZSBhcyB0aGUgc2l6ZXMgb2Ygb3RoZXIgcGxhdGZvcm1zLgo=
</data>
<flag name="review"
          id="71148"
          type_id="1"
          status="-"
          setter="tony"
    />
    <flag name="commit-queue"
          id="71149"
          type_id="3"
          status="-"
          setter="tony"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>80169</attachid>
            <date>2011-01-25 22:07:53 -0800</date>
            <delta_ts>2011-01-26 11:54:10 -0800</delta_ts>
            <desc>Updated patch: --no-timeout</desc>
            <filename>patch52873.txt</filename>
            <type>text/plain</type>
            <size>2491</size>
            <attacher name="Xianzhu Wang">wangxianzhu</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDc2NjU4KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMTMgQEAKKzIwMTEtMDEtMjUgIFhpYW56aHUgV2FuZyAgPHdhbmd4aWFuemh1QGdvb2dsZS5j
b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRk
ICctLW5vLXRpbWVvdXQnIG9wdGlvbiB0byBDaHJvbWl1bSBEUlQgdG8gZWFzZSBkZWJ1Z2dpbmcu
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Mjg3Mwor
CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRHVtcFJlbmRlclRyZWUuY3BwOgor
ICAgICAgICAobWFpbik6CisKIDIwMTEtMDEtMjUgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dh
QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IFRv
b2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0R1bXBSZW5kZXJUcmVlLmNwcAo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9EdW1wUmVuZGVyVHJlZS5jcHAJKHJl
dmlzaW9uIDc2NjU4KQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRHVtcFJlbmRl
clRyZWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01OCw2ICs1OCw3IEBAIHN0YXRpYyBjb25zdCBj
aGFyIG9wdGlvbkVuYWJsZUFjY2VsZXJhdGUKIHN0YXRpYyBjb25zdCBjaGFyIG9wdGlvblN0cmVz
c09wdFtdID0gIi0tc3RyZXNzLW9wdCI7CiBzdGF0aWMgY29uc3QgY2hhciBvcHRpb25TdHJlc3NE
ZW9wdFtdID0gIi0tc3RyZXNzLWRlb3B0IjsKIHN0YXRpYyBjb25zdCBjaGFyIG9wdGlvbkphdmFT
Y3JpcHRGbGFnc1tdID0gIi0tanMtZmxhZ3M9IjsKK3N0YXRpYyBjb25zdCBjaGFyIG9wdGlvbk5v
VGltZW91dFtdID0gIi0tbm8tdGltZW91dD0iOwogCiBzdGF0aWMgdm9pZCBydW5UZXN0KFRlc3RT
aGVsbCYgc2hlbGwsIFRlc3RQYXJhbXMmIHBhcmFtcywgY29uc3Qgc3RyaW5nJiB0ZXN0TmFtZSwg
Ym9vbCB0ZXN0U2hlbGxNb2RlKQogewpAQCAtMTIzLDYgKzEyNCw3IEBAIGludCBtYWluKGludCBh
cmdjLCBjaGFyKiBhcmd2W10pCiAgICAgYm9vbCBzdHJlc3NEZW9wdCA9IGZhbHNlOwogICAgIGJv
b2wgaGFyZHdhcmVBY2NlbGVyYXRlZEdMID0gZmFsc2U7CiAgICAgc3RyaW5nIGphdmFTY3JpcHRG
bGFnczsKKyAgICBib29sIG5vVGltZW91dCA9IGZhbHNlOwogICAgIGZvciAoaW50IGkgPSAxOyBp
IDwgYXJnYzsgKytpKSB7CiAgICAgICAgIHN0cmluZyBhcmd1bWVudChhcmd2W2ldKTsKICAgICAg
ICAgaWYgKGFyZ3VtZW50ID09ICItIikKQEAgLTE1NSw2ICsxNTcsOCBAQCBpbnQgbWFpbihpbnQg
YXJnYywgY2hhciogYXJndltdKQogICAgICAgICAgICAgc3RyZXNzRGVvcHQgPSB0cnVlOwogICAg
ICAgICBlbHNlIGlmICghYXJndW1lbnQuZmluZChvcHRpb25KYXZhU2NyaXB0RmxhZ3MpKQogICAg
ICAgICAgICAgamF2YVNjcmlwdEZsYWdzID0gYXJndW1lbnQuc3Vic3RyKHN0cmxlbihvcHRpb25K
YXZhU2NyaXB0RmxhZ3MpKTsKKyAgICAgICAgZWxzZSBpZiAoIWFyZ3VtZW50LmZpbmQob3B0aW9u
Tm9UaW1lb3V0KSkKKyAgICAgICAgICAgIG5vVGltZW91dCA9IHRydWU7CiAgICAgICAgIGVsc2Ug
aWYgKGFyZ3VtZW50LnNpemUoKSAmJiBhcmd1bWVudFswXSA9PSAnLScpCiAgICAgICAgICAgICBm
cHJpbnRmKHN0ZGVyciwgIlVua25vd24gb3B0aW9uOiAlc1xuIiwgYXJndltpXSk7CiAgICAgICAg
IGVsc2UKQEAgLTE4Miw2ICsxODYsMTAgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqIGFyZ3Zb
XSkKICAgICAgICAgc2hlbGwuc2V0SmF2YVNjcmlwdEZsYWdzKGphdmFTY3JpcHRGbGFncyk7CiAg
ICAgICAgIHNoZWxsLnNldFN0cmVzc09wdChzdHJlc3NPcHQpOwogICAgICAgICBzaGVsbC5zZXRT
dHJlc3NEZW9wdChzdHJlc3NEZW9wdCk7CisgICAgICAgIGlmIChub1RpbWVvdXQpIHsKKyAgICAg
ICAgICAgIC8vIDB4MjAwMDAwMDBtcyBpcyBiaWcgZW5vdWdoIGZvciB0aGUgcHVycG9zZSB0byBh
dm9pZCB0aW1lb3V0IGluIGRlYnVnZ2luZy4KKyAgICAgICAgICAgIHNoZWxsLnNldExheW91dFRl
c3RUaW1lb3V0KDB4MjAwMDAwMDApOworICAgICAgICB9CiAgICAgICAgIGlmIChzZXJ2ZXJNb2Rl
ICYmICF0ZXN0cy5zaXplKCkpIHsKICAgICAgICAgICAgIHBhcmFtcy5wcmludFNlcGFyYXRvcnMg
PSB0cnVlOwogICAgICAgICAgICAgY2hhciB0ZXN0U3RyaW5nWzIwNDhdOyAvLyAyMDQ4IGlzIHRo
ZSBzYW1lIGFzIHRoZSBzaXplcyBvZiBvdGhlciBwbGF0Zm9ybXMuCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>82588</attachid>
            <date>2011-02-15 21:47:52 -0800</date>
            <delta_ts>2011-02-15 22:48:17 -0800</delta_ts>
            <desc>Fix a small bug</desc>
            <filename>patch52873a.txt</filename>
            <type>text/plain</type>
            <size>1727</size>
            <attacher name="Xianzhu Wang">wangxianzhu</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDc4NjgyKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMTMgQEAKKzIwMTEtMDItMTUgIFhpYW56aHUgV2FuZyAgPHdhbmd4aWFuemh1QGdvb2dsZS5j
b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4
ZWQgYSBzbWFsbCBidWcgYWJvdXQgLS1uby10aW1lb3V0IG9wdGlvbi4KKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyODczCisKKyAgICAgICAgKiBEdW1w
UmVuZGVyVHJlZS9jaHJvbWl1bS9EdW1wUmVuZGVyVHJlZS5jcHA6CisgICAgICAgIChtYWluKToK
KwogMjAxMS0wMi0xNSAgS2VubmV0aCBSdXNzZWxsICA8a2JyQGdvb2dsZS5jb20+CiAKICAgICAg
ICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUv
Y2hyb21pdW0vRHVtcFJlbmRlclRyZWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0R1bXBSZW5k
ZXJUcmVlL2Nocm9taXVtL0R1bXBSZW5kZXJUcmVlLmNwcAkocmV2aXNpb24gNzg2NzcpCisrKyBU
b29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9EdW1wUmVuZGVyVHJlZS5jcHAJKHdvcmtpbmcg
Y29weSkKQEAgLTU4LDcgKzU4LDcgQEAgc3RhdGljIGNvbnN0IGNoYXIgb3B0aW9uRW5hYmxlQWNj
ZWxlcmF0ZQogc3RhdGljIGNvbnN0IGNoYXIgb3B0aW9uU3RyZXNzT3B0W10gPSAiLS1zdHJlc3Mt
b3B0IjsKIHN0YXRpYyBjb25zdCBjaGFyIG9wdGlvblN0cmVzc0Rlb3B0W10gPSAiLS1zdHJlc3Mt
ZGVvcHQiOwogc3RhdGljIGNvbnN0IGNoYXIgb3B0aW9uSmF2YVNjcmlwdEZsYWdzW10gPSAiLS1q
cy1mbGFncz0iOwotc3RhdGljIGNvbnN0IGNoYXIgb3B0aW9uTm9UaW1lb3V0W10gPSAiLS1uby10
aW1lb3V0PSI7CitzdGF0aWMgY29uc3QgY2hhciBvcHRpb25Ob1RpbWVvdXRbXSA9ICItLW5vLXRp
bWVvdXQiOwogCiBzdGF0aWMgdm9pZCBydW5UZXN0KFRlc3RTaGVsbCYgc2hlbGwsIFRlc3RQYXJh
bXMmIHBhcmFtcywgY29uc3Qgc3RyaW5nJiB0ZXN0TmFtZSwgYm9vbCB0ZXN0U2hlbGxNb2RlKQog
ewpAQCAtMTU3LDcgKzE1Nyw3IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyKiBhcmd2W10pCiAg
ICAgICAgICAgICBzdHJlc3NEZW9wdCA9IHRydWU7CiAgICAgICAgIGVsc2UgaWYgKCFhcmd1bWVu
dC5maW5kKG9wdGlvbkphdmFTY3JpcHRGbGFncykpCiAgICAgICAgICAgICBqYXZhU2NyaXB0Rmxh
Z3MgPSBhcmd1bWVudC5zdWJzdHIoc3RybGVuKG9wdGlvbkphdmFTY3JpcHRGbGFncykpOwotICAg
ICAgICBlbHNlIGlmICghYXJndW1lbnQuZmluZChvcHRpb25Ob1RpbWVvdXQpKQorICAgICAgICBl
bHNlIGlmIChhcmd1bWVudCA9PSBvcHRpb25Ob1RpbWVvdXQpCiAgICAgICAgICAgICBub1RpbWVv
dXQgPSB0cnVlOwogICAgICAgICBlbHNlIGlmIChhcmd1bWVudC5zaXplKCkgJiYgYXJndW1lbnRb
MF0gPT0gJy0nKQogICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsICJVbmtub3duIG9wdGlvbjog
JXNcbiIsIGFyZ3ZbaV0pOwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>