52872 2011-01-21 01:03:29 -0800 new-run-webkit-tests fails to start HTTP server if there are proxy settings 2011-01-24 14:55:42 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 phnixwxz webkit-unassigned abarth commit-queue dpranke eric evan levin mihaip ojan tony wangxianzhu webkit.review.bot oldest_to_newest 337924 0 phnixwxz 2011-01-21 01:03:29 -0800 new-run-webkit-tests script checks if the testing HTTP server has been properly started by sending testing requests to the server with urllib.urlopen(). However, in an environment with proxy set, urllib.urlopen() can't recognize the no_proxy settings, and always use proxy even to access http://127.0.0.1:8000/. This causes the checker fails to check the status of HTTP servers and reports 'failed to start httpd.' To resolve this, we can explicitly disable proxies in urllib.urlopen(). 337928 1 phnixwxz 2011-01-21 01:11:02 -0800 Even sometimes urlopen can recognize no_proxy config for non-https requests, the proxy setting sometimes still causes "SSL unknown protocol" error. Forcing disabling proxy can resolve this. 337930 2 79708 wangxianzhu 2011-01-21 01:18:20 -0800 Created attachment 79708 The patch 337957 3 eric 2011-01-21 02:22:58 -0800 How does one set a proxy so as to trigger this? Can we unit test this? 337966 4 wangxianzhu 2011-01-21 02:51:37 -0800 (In reply to comment #3) > How does one set a proxy so as to trigger this? I reproduce the issue on an Ubuntu Lucid with the following proxy settings: * Manual proxy configuration * Use the same proxy for all protocols * HTTP proxy: some valid proxy server * Ignored Host list: localhost 127.0.0.1/8 *.local $ python (before this, should start a web server serving https on 8443 port) >>> import urllib >>> urllib.urlopen('https://127.0.0.1:8443/') Traceback (most recent call last): File "/usr/lib/python2.6/urllib.py", line 86, in urlopen return opener.open(url) File "/usr/lib/python2.6/urllib.py", line 205, in open return getattr(self, name)(url) File "/usr/lib/python2.6/urllib.py", line 439, in open_https h.endheaders() File "/usr/lib/python2.6/httplib.py", line 904, in endheaders self._send_output() File "/usr/lib/python2.6/httplib.py", line 776, in _send_output self.send(msg) File "/usr/lib/python2.6/httplib.py", line 735, in send self.connect() File "/usr/lib/python2.6/httplib.py", line 1112, in connect self.sock = ssl.wrap_socket(sock, self.key_file, self.cert_file) File "/usr/lib/python2.6/ssl.py", line 350, in wrap_socket suppress_ragged_eofs=suppress_ragged_eofs) File "/usr/lib/python2.6/ssl.py", line 118, in __init__ self.do_handshake() File "/usr/lib/python2.6/ssl.py", line 293, in do_handshake self._sslobj.do_handshake() IOError: [Errno socket error] [Errno 1] _ssl.c:480: error:140770FC:SSL routines:SSL23_GET_SERVER_HELLO:unknown protocol >>> urllib.urlopen('https://127.0.0.1:8443/', proxies={}) <addinfourl at 19614032 whose fp = <socket._fileobject object at 0x129f550>> >>> This seems a bug of python or some underlying library. Unsetting http_proxy, https_proxy, all_proxy environment variables doesn't help. I searched the error message and knew that many people encountered this and disabling proxy can resolve. > > Can we unit test this? I've no idea. Is it necessary? 337977 5 eric 2011-01-21 03:13:36 -0800 Tests are generally more important than code fixes :) As they prevent us from making the same bugs twice! But if it's not possible to unit test this then we don't need to. It may not be realistic to unit test this give that it depends on system settings. 338135 6 tony 2011-01-21 10:15:33 -0800 Will DRT pick up system proxy settings? If so, can having a proxy set cause the http layout tests to fail? Would it be better to just detect there is a proxy set and provide a good warning message to the user (e.g., what environment variables to set to disable when running the tests)? 338479 7 wangxianzhu 2011-01-21 19:50:26 -0800 (In reply to comment #6) > Will DRT pick up system proxy settings? If so, can having a proxy set cause the http layout tests to fail? > A correct proxy setting should bypass localhost, and webkit can handle this correctly, so layout tests won't fail. The problem only occurs during python urllib.urlopen(). > Would it be better to just detect there is a proxy set and provide a good warning message to the user (e.g., what environment variables to set to disable when running the tests)? Environment variables is not the only way to set proxy. Only unsetting environment variables seems not working for me. And I think disabling proxy before testing might be annoying for people who rely on proxies all the time. 339138 8 79708 tony 2011-01-24 11:39:20 -0800 Comment on attachment 79708 The patch I see, given that DRT should be able to handle system proxy settings and this is just a bug with python on Linux, this seems fine to me. 339265 9 79708 commit-queue 2011-01-24 14:22:50 -0800 Comment on attachment 79708 The patch Clearing flags on attachment: 79708 Committed r76547: <http://trac.webkit.org/changeset/76547> 339266 10 commit-queue 2011-01-24 14:22:55 -0800 All reviewed patches have been landed. Closing bug. 339284 11 webkit.review.bot 2011-01-24 14:55:42 -0800 http://trac.webkit.org/changeset/76547 might have broken Qt Linux Release The following tests are not passing: fast/text/international/cjk-segmentation.html 79708 2011-01-21 01:18:20 -0800 2011-01-24 14:22:49 -0800 The patch patch52872.txt text/plain 1997 wangxianzhu SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc2MzM0KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMDEtMjEgIFhpYW56aHUgV2FuZyAgPHdhbmd4aWFuemh1QGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbmV3 LXJ1bi13ZWJraXQtdGVzdHMgZmFpbHMgdG8gc3RhcnQgSFRUUCBzZXJ2ZXIgaWYgdGhlcmUgYXJl IHByb3h5IHNldHRpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01Mjg3MgorCisgICAgICAgIEZvcmNlIGRpc2FibGluZyBwcm94eSB0byByZXNvbHZl IHRoZSBwcm9ibGVtLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9odHRwX3NlcnZlcl9iYXNlLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvd2Vic29ja2V0X3NlcnZlci5weToKKwogMjAxMS0wMS0yMCAgRGlyayBQ cmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFt IEJhcnRoLgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9o dHRwX3NlcnZlcl9iYXNlLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3BvcnQvaHR0cF9zZXJ2ZXJfYmFzZS5weQkocmV2aXNpb24gNzYzMzQpCisr KyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2h0dHBfc2VydmVyX2Jh c2UucHkJKHdvcmtpbmcgY29weSkKQEAgLTY3LDcgKzY3LDcgQEAgY2xhc3MgSHR0cFNlcnZlckJh c2Uob2JqZWN0KToKICAgICAgICAgICAgIHVybCA9ICdodHRwJXM6Ly8xMjcuMC4wLjE6JWQvJyAl IChodHRwX3N1ZmZpeCwgbWFwcGluZ1sncG9ydCddKQogCiAgICAgICAgICAgICB0cnk6Ci0gICAg ICAgICAgICAgICAgcmVzcG9uc2UgPSB1cmxsaWIudXJsb3Blbih1cmwpCisgICAgICAgICAgICAg ICAgcmVzcG9uc2UgPSB1cmxsaWIudXJsb3Blbih1cmwsIHByb3hpZXM9e30pCiAgICAgICAgICAg ICAgICAgX2xvZy5kZWJ1ZygiU2VydmVyIHJ1bm5pbmcgYXQgJXMiICUgdXJsKQogICAgICAgICAg ICAgZXhjZXB0IElPRXJyb3IsIGU6CiAgICAgICAgICAgICAgICAgX2xvZy5kZWJ1ZygiU2VydmVy IE5PVCBydW5uaW5nIGF0ICVzOiAlcyIgJSAodXJsLCBlKSkKSW5kZXg6IFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Vic29ja2V0X3NlcnZlci5weQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYnNvY2tldF9z ZXJ2ZXIucHkJKHJldmlzaW9uIDc2MzM0KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC93ZWJzb2NrZXRfc2VydmVyLnB5CSh3b3JraW5nIGNvcHkpCkBAIC03Myw3 ICs3Myw3IEBAIGRlZiB1cmxfaXNfYWxpdmUodXJsKToKICAgICB3YWl0X3RpbWUgPSAxMAogICAg IHdoaWxlIHdhaXRfdGltZSA+IDA6CiAgICAgICAgIHRyeToKLSAgICAgICAgICAgIHJlc3BvbnNl ID0gdXJsbGliLnVybG9wZW4odXJsKQorICAgICAgICAgICAgcmVzcG9uc2UgPSB1cmxsaWIudXJs b3Blbih1cmwsIHByb3hpZXM9e30pCiAgICAgICAgICAgICAjIFNlcnZlciBpcyB1cCBhbmQgcmVz cG9uZGluZy4KICAgICAgICAgICAgIHJldHVybiBUcnVlCiAgICAgICAgIGV4Y2VwdCBJT0Vycm9y Ogo=