52854 2011-01-20 16:56:56 -0800 nrwt: fix generated output links in results.html 2011-01-20 17:06:57 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke oldest_to_newest 337722 0 dpranke 2011-01-20 16:56:56 -0800 nrwt: fix generated output links in results.html 337725 1 79667 dpranke 2011-01-20 16:58:49 -0800 Created attachment 79667 Patch 337730 2 79667 tony 2011-01-20 17:00:49 -0800 Comment on attachment 79667 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79667&action=review > Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:98 > + self.assertEquals(actual_filename, > + "fast/html/article-element-actual.txt") Nit: doesn't seem worth wrapping here since you didn't wrap in the line preceding it. 337732 3 dpranke 2011-01-20 17:01:58 -0800 (In reply to comment #2) > (From update of attachment 79667 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=79667&action=review > > > Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:98 > > + self.assertEquals(actual_filename, > > + "fast/html/article-element-actual.txt") > > Nit: doesn't seem worth wrapping here since you didn't wrap in the line preceding it. fair enough. Old habits die hard. 337740 4 dpranke 2011-01-20 17:06:57 -0800 Committed r76311: <http://trac.webkit.org/changeset/76311> 79667 2011-01-20 16:58:49 -0800 2011-01-20 17:00:49 -0800 Patch bug-52854-20110120165848.patch text/plain 2779 dpranke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjNzY0 ZDIyNWM0MTE1MzBkMDNlNzQwNTg3YWQwMTUyM2FiOWU0OGQzLi5lNDhkOTEyZTVjNTBkOWI5MzZj M2MwMjliNzRjZmQ1N2RjMTkzYTdjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTEtMDEtMjAgIERpcmsgUHJhbmtl ICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRml4IGJ1ZyBpbnRyb2R1Y2VkIGluIHI3MjY4OCAvIGJ1ZyA1Mjc2 OCB0aGF0IGJyb2tlIHRoZQorICAgICAgICBnZW5lcmF0aW9uIG9mIHRoZSBvdXRwdXQgZmlsZW5h bWUgbGlua3MgaW4gdGhlIHJlc3VsdHMuaHRtbAorICAgICAgICBvdXRwdXQuIEFwcGFyZW50bHkg bm9uZSBvZiB0aGUgdW5pdCB0ZXN0cyBhY3R1YWxseSBjaGVja2VkIHRvCisgICAgICAgIG1ha2Ug c3VyZSB0aGUgZ2VuZXJhdGVkIGxpbmtzIHdlcmUgY29ycmVjdCA6KAorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Mjg1NAorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvdGVzdF9mYWlsdXJlcy5w eToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2Fn ZS90ZXN0X2ZhaWx1cmVzX3VuaXR0ZXN0LnB5OgorCisyMDExLTAxLTIwICBEaXJrIFByYW5rZSAg PGRwcmFua2VAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVs LgogCiAgICAgICAgIG5yd3Q6IHJlbW92ZSBmcyByZWZzIGZyb20gcHJpbnRpbmcsIHRlc3RfZmFp bHVyZXMsIHRlc3RfZXhwZWN0YXRpb25zLCB0ZXh0X2RpZmYKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rlc3RfZmFpbHVyZXMu cHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS90 ZXN0X2ZhaWx1cmVzLnB5CmluZGV4IDVhZDJlMDRjZTFkNTQ5Y2FlY2U5M2ViOWZiYjJmNjc1MWVi Mjg4Y2MuLmViNTlkMzZhMDg4NjUzNzIwMjQ3ZTNlOTI1OWVmY2QyYmRiNGJhYWUgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rl c3RfZmFpbHVyZXMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv bGF5b3V0X3BhY2thZ2UvdGVzdF9mYWlsdXJlcy5weQpAQCAtMTIzLDcgKzEyMyw3IEBAIGNsYXNz IFRlc3RGYWlsdXJlKG9iamVjdCk6CiAgICAgICAgICMgRklYTUU6IHRlY2huaWNhbGx5IHRoaXMg YnJlYWtzIGlmIGZpbGVzIGRvbid0IHVzZSAiLmV4dCIgdG8gaW5kaWNhdGUKICAgICAgICAgIyB0 aGUgZXh0ZW5zaW9uLCBidXQgcGFzc2luZyBpbiBhIEZpbGVzeXN0ZW0gb2JqZWN0IGhlcmUgaXMg YSBodWdlCiAgICAgICAgICMgaGFzc2xlLgotICAgICAgICByZXR1cm4gZmlsZW5hbWVbZmlsZW5h bWUucmZpbmQoJy4nKV0gKyBtb2RpZmllcgorICAgICAgICByZXR1cm4gZmlsZW5hbWVbOmZpbGVu YW1lLnJmaW5kKCcuJyldICsgbW9kaWZpZXIKIAogCiBjbGFzcyBGYWlsdXJlV2l0aFR5cGUoVGVz dEZhaWx1cmUpOgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvbGF5b3V0X3BhY2thZ2UvdGVzdF9mYWlsdXJlc191bml0dGVzdC5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rlc3RfZmFpbHVyZXNfdW5p dHRlc3QucHkKaW5kZXggYjI2OThkMTc1ZGQyMDRkMTQ1YmQxY2MzMjlmYmZiZGM1Y2M4MjM3Yy4u NGU5MGIyZGQ4Mzg5ZTMyN2MwZDA5YWM2ZjMwNmQwNzNhZjU5YWJlMiAxMDA2NDQKLS0tIGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvdGVzdF9mYWls dXJlc191bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9sYXlvdXRfcGFja2FnZS90ZXN0X2ZhaWx1cmVzX3VuaXR0ZXN0LnB5CkBAIC04OSw2ICs4OSwx MyBAQCBjbGFzcyBUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgY3Jhc2hfc2V0ID0g c2V0KFtGYWlsdXJlQ3Jhc2goKSwgIkZhaWx1cmVDcmFzaCJdKQogICAgICAgICBzZWxmLmFzc2Vy dEVxdWFsKGxlbihjcmFzaF9zZXQpLCAyKQogCisgICAgZGVmIHRlc3RfcmVsYXRpdmVfb3V0cHV0 X2ZpbGVuYW1lKHNlbGYpOgorICAgICAgICAjIFRoaXMgY291bGQgYmUgYW55IEZhaWx1cmUqIG9i amVjdCwgc2luY2Ugd2UncmUgdGVzdGluZyBhIG1ldGhvZAorICAgICAgICAjIG9uIHRoZSBiYXNl IGNsYXNzLgorICAgICAgICBmYWlsdXJlX29iaiA9IEZhaWx1cmVUZXh0TWlzbWF0Y2goKQorICAg ICAgICBhY3R1YWxfZmlsZW5hbWUgPSBmYWlsdXJlX29iai5yZWxhdGl2ZV9vdXRwdXRfZmlsZW5h bWUoImZhc3QvaHRtbC9hcnRpY2xlLWVsZW1lbnQuaHRtbCIsICItYWN0dWFsLnR4dCIpCisgICAg ICAgIHNlbGYuYXNzZXJ0RXF1YWxzKGFjdHVhbF9maWxlbmFtZSwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgImZhc3QvaHRtbC9hcnRpY2xlLWVsZW1lbnQtYWN0dWFsLnR4dCIpCiAKIGlmIF9f bmFtZV9fID09ICdfX21haW5fXyc6CiAgICAgdW5pdHRlc3QubWFpbigpCg==