52848 2011-01-20 15:07:07 -0800 Keep track of the latest update timestamp in the backing store 2011-01-20 16:13:37 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca darin oldest_to_newest 337635 0 andersca 2011-01-20 15:07:07 -0800 Keep track of the latest update timestamp in the backing store 337664 1 79659 andersca 2011-01-20 15:43:40 -0800 Created attachment 79659 Patch 337685 2 79659 darin 2011-01-20 16:05:24 -0800 Comment on attachment 79659 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79659&action=review > Source/WebKit2/Shared/UpdateInfo.h:44 > + UpdateInfo() : timestamp(0) { } Is 0 the best thing for a not-set value? Maybe NaN or -infinity? Or maybe 0 is OK. > Source/WebKit2/UIProcess/BackingStore.cpp:47 > + , m_latestUpdateTimestamp(0) Is 0 the best way to represent this? I guess a date in the distant past is OK, but for that we could also use -infinity. Or maybe 0 is OK. > Source/WebKit2/UIProcess/BackingStore.cpp:69 > + platformIncorporateUpdate(bitmap.get(), updateInfo); I kinda hate using platform as a function name prefix. Especially since this is not the same function as incorporateUpdate -- it’s only a part of the work. I would prefer this have the same name the function would have if there was only one platform. 337690 3 andersca 2011-01-20 16:12:24 -0800 (In reply to comment #2) > (From update of attachment 79659 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=79659&action=review > > > Source/WebKit2/Shared/UpdateInfo.h:44 > > + UpdateInfo() : timestamp(0) { } > > Is 0 the best thing for a not-set value? Maybe NaN or -infinity? Or maybe 0 is OK. > This should always be initialized directly afterwards by the caller so it really doesn't matter. > > Source/WebKit2/UIProcess/BackingStore.cpp:47 > > + , m_latestUpdateTimestamp(0) > > Is 0 the best way to represent this? I guess a date in the distant past is OK, but for that we could also use -infinity. Or maybe 0 is OK. I think 0 is OK. > > > Source/WebKit2/UIProcess/BackingStore.cpp:69 > > + platformIncorporateUpdate(bitmap.get(), updateInfo); > > I kinda hate using platform as a function name prefix. Especially since this is not the same function as incorporateUpdate -- it’s only a part of the work. I would prefer this have the same name the function would have if there was only one platform. I changed this to be just another overload of incorporateUpdate. 337691 4 andersca 2011-01-20 16:13:37 -0800 Committed r76305: <http://trac.webkit.org/changeset/76305> 79659 2011-01-20 15:43:40 -0800 2011-01-20 16:05:24 -0800 Patch bug-52848-20110120154339.patch text/plain 4631 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2Mjg4KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjkgQEAKKzIwMTEtMDEtMjAgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBLZWVwIHRyYWNrIG9mIHRoZSBsYXRlc3QgdXBkYXRlIHRp bWVzdGFtcCBpbiB0aGUgYmFja2luZyBzdG9yZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI4NDgKKworICAgICAgICAqIFNoYXJlZC9VcGRhdGVJbmZv Lmg6CisgICAgICAgIChXZWJLaXQ6OlVwZGF0ZUluZm86OlVwZGF0ZUluZm8pOgorICAgICAgICBJ bml0aWFsaXplIHRpbWVzdGFtcCB0byAwLgorCisgICAgICAgICogVUlQcm9jZXNzL0JhY2tpbmdT dG9yZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkJhY2tpbmdTdG9yZTo6QmFja2luZ1N0b3JlKToK KyAgICAgICAgSW5pdGlhbGl6ZSBtX2xhdGVzdFVwZGF0ZVRpbWVzdGFtcCB0byAwLgorCisgICAg ICAgIChXZWJLaXQ6OkJhY2tpbmdTdG9yZTo6aW5jb3Jwb3JhdGVVcGRhdGUpOgorICAgICAgICBJ ZiB0aGUgdXBkYXRlIGlzIHRvbyBvbGQsIGRpc2NhcmQgaXQuIE90aGVyd2lzZSwgY3JlYXRlIGEg Yml0bWFwCisgICAgICAgIGFuZCBwYXNzIGl0IHRvIHBsYXRmb3JtSW5jb3Jwb3JhdGVVcGRhdGUu IEZpbmFsbHkgdXBkYXRlIHRoZSB0aW1lc3RhbXAuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQmFj a2luZ1N0b3JlLmg6CisgICAgICAgIEFkZCBtX2xhdGVzdFVwZGF0ZVRpbWVzdGFtcC4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9tYWMvQmFja2luZ1N0b3JlTWFjLm1tOgorICAgICAgICAoV2ViS2l0 OjpCYWNraW5nU3RvcmU6OnBsYXRmb3JtSW5jb3Jwb3JhdGVVcGRhdGUpOgorICAgICAgICBVcGRh dGUgbm93IHRoYXQgd2UgYXJlIGFscmVhZHkgZ2l2ZW4gdGhlIHNoYXJlYWJsZSBiaXRtYXAuCisK IDIwMTEtMDEtMjAgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpJbmRleDogU291cmNlL1dlYktpdDIvU2hhcmVk L1VwZGF0ZUluZm8uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvVXBkYXRl SW5mby5oCShyZXZpc2lvbiA3NjI4NSkKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9VcGRhdGVJ bmZvLmgJKHdvcmtpbmcgY29weSkKQEAgLTQxLDcgKzQxLDcgQEAgY2xhc3MgVXBkYXRlSW5mbyB7 CiAgICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoVXBkYXRlSW5mbyk7CiAKIHB1YmxpYzoKLSAgICBV cGRhdGVJbmZvKCkgeyB9CisgICAgVXBkYXRlSW5mbygpIDogdGltZXN0YW1wKDApIHsgfQogCiAg ICAgdm9pZCBlbmNvZGUoQ29yZUlQQzo6QXJndW1lbnRFbmNvZGVyKikgY29uc3Q7CiAgICAgc3Rh dGljIGJvb2wgZGVjb2RlKENvcmVJUEM6OkFyZ3VtZW50RGVjb2RlciosIFVwZGF0ZUluZm8mKTsK SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9CYWNraW5nU3RvcmUuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9CYWNraW5nU3RvcmUuY3BwCShyZXZpc2lv biA3NjI3MykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9CYWNraW5nU3RvcmUuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0yNSw2ICsyNSw5IEBACiAKICNpbmNsdWRlICJCYWNraW5nU3RvcmUu aCIKIAorI2luY2x1ZGUgIlNoYXJlYWJsZUJpdG1hcC5oIgorI2luY2x1ZGUgIlVwZGF0ZUluZm8u aCIKKwogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKICNpZiAhUExBVEZPUk0oTUFDKQpAQCAt NDEsNiArNDQsNyBAQCBQYXNzT3duUHRyPEJhY2tpbmdTdG9yZT4gQmFja2luZ1N0b3JlOjpjCiBC YWNraW5nU3RvcmU6OkJhY2tpbmdTdG9yZShjb25zdCBJbnRTaXplJiBzaXplLCBXZWJQYWdlUHJv eHkqIHdlYlBhZ2VQcm94eSkKICAgICA6IG1fc2l6ZShzaXplKQogICAgICwgbV93ZWJQYWdlUHJv eHkod2ViUGFnZVByb3h5KQorICAgICwgbV9sYXRlc3RVcGRhdGVUaW1lc3RhbXAoMCkKIHsKICAg ICBBU1NFUlQoIW1fc2l6ZS5pc0VtcHR5KCkpOwogfQpAQCAtNDksNCArNTMsMjIgQEAgQmFja2lu Z1N0b3JlOjp+QmFja2luZ1N0b3JlKCkKIHsKIH0KIAordm9pZCBCYWNraW5nU3RvcmU6OmluY29y cG9yYXRlVXBkYXRlKGNvbnN0IFVwZGF0ZUluZm8mIHVwZGF0ZUluZm8pCit7CisgICAgaWYgKHVw ZGF0ZUluZm8udGltZXN0YW1wIDwgbV9sYXRlc3RVcGRhdGVUaW1lc3RhbXApIHsKKyAgICAgICAg Ly8gVGhlIHVwZGF0ZSBpcyB0b28gb2xkLCBkaXNjYXJkIGl0LgorICAgICAgICByZXR1cm47Cisg ICAgfQorCisgICAgQVNTRVJUKG1fc2l6ZSA9PSB1cGRhdGVJbmZvLnZpZXdTaXplKTsKKyAgICAK KyAgICBSZWZQdHI8U2hhcmVhYmxlQml0bWFwPiBiaXRtYXAgPSBTaGFyZWFibGVCaXRtYXA6OmNy ZWF0ZSh1cGRhdGVJbmZvLnVwZGF0ZVJlY3RCb3VuZHMuc2l6ZSgpLCB1cGRhdGVJbmZvLmJpdG1h cEhhbmRsZSk7CisgICAgaWYgKCFiaXRtYXApCisgICAgICAgIHJldHVybjsKKyAgICAKKyAgICBw bGF0Zm9ybUluY29ycG9yYXRlVXBkYXRlKGJpdG1hcC5nZXQoKSwgdXBkYXRlSW5mbyk7CisKKyAg ICBtX2xhdGVzdFVwZGF0ZVRpbWVzdGFtcCA9IHVwZGF0ZUluZm8udGltZXN0YW1wOworfQorCiB9 IC8vIG5hbWVzcGFjZSBXZWJLaXQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9CYWNr aW5nU3RvcmUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQmFja2lu Z1N0b3JlLmgJKHJldmlzaW9uIDc2MjczKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Jh Y2tpbmdTdG9yZS5oCSh3b3JraW5nIGNvcHkpCkBAIC00MCw2ICs0MCw3IEBAIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKK2NsYXNzIFNoYXJlYWJsZUJpdG1hcDsK IGNsYXNzIFVwZGF0ZUluZm87CiBjbGFzcyBXZWJQYWdlUHJveHk7CiAKQEAgLTYwLDEwICs2MSwx MiBAQCBwdWJsaWM6CiBwcml2YXRlOgogICAgIEJhY2tpbmdTdG9yZShjb25zdCBXZWJDb3JlOjpJ bnRTaXplJiwgV2ViUGFnZVByb3h5Kik7CiAKKyAgICB2b2lkIHBsYXRmb3JtSW5jb3Jwb3JhdGVV cGRhdGUoU2hhcmVhYmxlQml0bWFwKiwgY29uc3QgVXBkYXRlSW5mbyYpOwogICAgIHZvaWQgc2Ny b2xsKGNvbnN0IFdlYkNvcmU6OkludFJlY3QmIHNjcm9sbFJlY3QsIGNvbnN0IFdlYkNvcmU6Oklu dFNpemUmIHNjcm9sbE9mZnNldCk7CiAKICAgICBXZWJDb3JlOjpJbnRTaXplIG1fc2l6ZTsKICAg ICBXZWJQYWdlUHJveHkqIG1fd2ViUGFnZVByb3h5OworICAgIGRvdWJsZSBtX2xhdGVzdFVwZGF0 ZVRpbWVzdGFtcDsKIAogI2lmIFBMQVRGT1JNKE1BQykKICAgICBDR0NvbnRleHRSZWYgYmFja2lu Z1N0b3JlQ29udGV4dCgpOwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9CYWNr aW5nU3RvcmVNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21h Yy9CYWNraW5nU3RvcmVNYWMubW0JKHJldmlzaW9uIDc2MjczKQorKysgU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL21hYy9CYWNraW5nU3RvcmVNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTkyLDE0 ICs5Miw4IEBAIENHQ29udGV4dFJlZiBCYWNraW5nU3RvcmU6OmJhY2tpbmdTdG9yZUMKICAgICBy ZXR1cm4gbV9iaXRtYXBDb250ZXh0LmdldCgpOwogfQogCi12b2lkIEJhY2tpbmdTdG9yZTo6aW5j b3Jwb3JhdGVVcGRhdGUoY29uc3QgVXBkYXRlSW5mbyYgdXBkYXRlSW5mbykKK3ZvaWQgQmFja2lu Z1N0b3JlOjpwbGF0Zm9ybUluY29ycG9yYXRlVXBkYXRlKFNoYXJlYWJsZUJpdG1hcCogYml0bWFw LCBjb25zdCBVcGRhdGVJbmZvJiB1cGRhdGVJbmZvKQogewotICAgIEFTU0VSVChtX3NpemUgPT0g dXBkYXRlSW5mby52aWV3U2l6ZSk7Ci0KLSAgICBSZWZQdHI8U2hhcmVhYmxlQml0bWFwPiBiaXRt YXAgPSBTaGFyZWFibGVCaXRtYXA6OmNyZWF0ZSh1cGRhdGVJbmZvLnVwZGF0ZVJlY3RCb3VuZHMu c2l6ZSgpLCB1cGRhdGVJbmZvLmJpdG1hcEhhbmRsZSk7Ci0gICAgaWYgKCFiaXRtYXApCi0gICAg ICAgIHJldHVybjsKLQogICAgIENHQ29udGV4dFJlZiBjb250ZXh0ID0gYmFja2luZ1N0b3JlQ29u dGV4dCgpOwogCiAgICAgc2Nyb2xsKHVwZGF0ZUluZm8uc2Nyb2xsUmVjdCwgdXBkYXRlSW5mby5z Y3JvbGxPZmZzZXQpOwo=