<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>52839</bug_id>
          
          <creation_ts>2011-01-20 13:27:34 -0800</creation_ts>
          <short_desc>[Qt][Symbian] Fix --minimal build</short_desc>
          <delta_ts>2011-01-26 15:05:03 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>S60 Hardware</rep_platform>
          <op_sys>S60 3rd edition</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>41464</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Siddharth Mathur">s.mathur</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>commit-queue</cc>
    
    <cc>eric</cc>
    
    <cc>koshuin</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>yael</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>337555</commentid>
    <comment_count>0</comment_count>
    <who name="Siddharth Mathur">s.mathur</who>
    <bug_when>2011-01-20 13:27:34 -0800</bug_when>
    <thetext>&quot;build-webkit --qt --release --symbian --minimal&quot; has 2-3 small issues for QtWebkit.dll which will be good to fix quickly. Upside is that ARM UDEB builds are then much smaller and rebuilding is quite fast (even on a measly 4 core machine)!

- linker error with unresolved PluginPackage methods (those in PluginPackageSymbian.cpp) 
- linker error with unresolved PluginPackage::unload()
- USE_SYSTEM_MALLOC is set to 0 via qmake command-line args (due to --minimal it seems) , but is set to 1 explictly for symbian in all our .pro/.pri . This causes the autogenerated .mmp files to contain _both_ flags set. Leads to warnings at a minimum from compiler.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>338630</commentid>
    <comment_count>1</comment_count>
      <attachid>79856</attachid>
    <who name="Yael">yael</who>
    <bug_when>2011-01-22 13:45:52 -0800</bug_when>
    <thetext>Created attachment 79856
Patch

Build fix for the plugins issue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>338649</commentid>
    <comment_count>2</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2011-01-22 15:10:12 -0800</bug_when>
    <thetext>Siddharth, USE_SYSTEM_MALLOC is turned off by default. You have to turn it on by passing --system-malloc to build-webkit.
Based on your comment it seems we always want this to be on for Symbian builds, so I will upload a patch to do that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>338715</commentid>
    <comment_count>3</comment_count>
      <attachid>79856</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-01-23 11:28:49 -0800</bug_when>
    <thetext>Comment on attachment 79856
Patch

Clearing flags on attachment: 79856

Committed r76466: &lt;http://trac.webkit.org/changeset/76466&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>338716</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-01-23 11:28:54 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>338998</commentid>
    <comment_count>5</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2011-01-24 07:17:04 -0800</bug_when>
    <thetext>Only the plugins part was fixed. We still have the USE_SYSTEM_MALLOC issue.
Reopening the bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>339021</commentid>
    <comment_count>6</comment_count>
    <who name="Siddharth Mathur">s.mathur</who>
    <bug_when>2011-01-24 08:20:00 -0800</bug_when>
    <thetext>/me Yael is awesome!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>339037</commentid>
    <comment_count>7</comment_count>
      <attachid>79927</attachid>
    <who name="Yael">yael</who>
    <bug_when>2011-01-24 08:43:50 -0800</bug_when>
    <thetext>Created attachment 79927
Patch

USE_SYSTEM_MALLOC is controlled by webkit.pri for Symbian and should never be turned off.
When building the qmake paramaters list for Symbian, do not add it to the list.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>339069</commentid>
    <comment_count>8</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2011-01-24 09:46:11 -0800</bug_when>
    <thetext>It would be good to avoid the special treatment for Symbian in build-webkit (and in webkitdirs.pm) especially that that the problem we&apos;re trying to solve is not specific to Symbian (e.g. I suspect that Windows minimal build would have the same problem).

I suggest to move setting USE_SYSTEM_MALLOC out from the Qt-specific make-system (WebKit.pri) and set it instead in common source-code (Platform.h like e.g. Android). By doing so build-webkit --minimal will no longer set USE_SYSTEM_MALLOC to 0. This would require adding a guard to TCSystemAlloc.cpp and including it for every Qt build.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>339092</commentid>
    <comment_count>9</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2011-01-24 10:50:42 -0800</bug_when>
    <thetext>(In reply to comment #8)
&gt; It would be good to avoid the special treatment for Symbian in build-webkit (and in webkitdirs.pm) especially that that the problem we&apos;re trying to solve is not specific to Symbian (e.g. I suspect that Windows minimal build would have the same problem).
&gt; 
&gt; I suggest to move setting USE_SYSTEM_MALLOC out from the Qt-specific make-system (WebKit.pri) and set it instead in common source-code (Platform.h like e.g. Android). By doing so build-webkit --minimal will no longer set USE_SYSTEM_MALLOC to 0. This would require adding a guard to TCSystemAlloc.cpp and including it for every Qt build.

Sorry, I did not realize that we check webkit.pri to figure out the defaults :(
I&apos;ll update the patch as you suggested.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>339219</commentid>
    <comment_count>10</comment_count>
      <attachid>79927</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-01-24 13:14:23 -0800</bug_when>
    <thetext>Comment on attachment 79927
Patch

?  You&apos;re grepping the passed build flags?  This doesn&apos;t make sense.

If you pass FOO= before a command, it gets set in the environment.  If you pass FOO= after build-webkit, it&apos;s supposed to treat all arguments it doesnt&apos; understand as arguments to be passed to the underlying build system.  I assume that&apos;s what you&apos;re tryign to do here?  But if so, why special case USE_SYSTEM_MALLOC.  Are we sure thsi is the right fix?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>339232</commentid>
    <comment_count>11</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2011-01-24 13:33:22 -0800</bug_when>
    <thetext>I seem to have a problem with the previously landed patch as linking still fails:

   Error: L6218E: Undefined symbol RFs::DriveToChar(int, TChar&amp;) (referred from
PluginDatabaseSymbian.o).
   Error: L6218E: Undefined symbol RFs::Close() (referred from PluginDatabaseSym
bian.o).
   Error: L6218E: Undefined symbol RFs::Connect(int) (referred from PluginDataba
seSymbian.o).
   Error: L6218E: Undefined symbol RFs::DriveList(TBuf8&lt;(int)26&gt;&amp;) const (referr
ed from PluginDatabaseSymbian.o).

It seem that &quot;LIBS += -lefsrv&quot; should be outside of the ENABLE_NETSCAPE_PLUGIN_API guard for Symbian.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>339246</commentid>
    <comment_count>12</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2011-01-24 13:52:56 -0800</bug_when>
    <thetext>(In reply to comment #11)
&gt; I seem to have a problem with the previously landed patch as linking still fails:
&gt; 
&gt;    Error: L6218E: Undefined symbol RFs::DriveToChar(int, TChar&amp;) (referred from
&gt; PluginDatabaseSymbian.o).
&gt;    Error: L6218E: Undefined symbol RFs::Close() (referred from PluginDatabaseSym
&gt; bian.o).
&gt;    Error: L6218E: Undefined symbol RFs::Connect(int) (referred from PluginDataba
&gt; seSymbian.o).
&gt;    Error: L6218E: Undefined symbol RFs::DriveList(TBuf8&lt;(int)26&gt;&amp;) const (referr
&gt; ed from PluginDatabaseSymbian.o).
&gt; 
&gt; It seem that &quot;LIBS += -lefsrv&quot; should be outside of the ENABLE_NETSCAPE_PLUGIN_API guard for Symbian.

You are probably right. Should we fix all the issues in one bug or create one per patch?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>339286</commentid>
    <comment_count>13</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2011-01-24 14:56:06 -0800</bug_when>
    <thetext>&gt; &gt; It seem that &quot;LIBS += -lefsrv&quot; should be outside of the ENABLE_NETSCAPE_PLUGIN_API guard for Symbian.
&gt; 
&gt; You are probably right. Should we fix all the issues in one bug or create one per patch?

Separate patch - this might qualify as a buildfix.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>339722</commentid>
    <comment_count>14</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2011-01-25 10:22:25 -0800</bug_when>
    <thetext>(In reply to comment #8)
&gt; 
&gt; Separate patch - this might qualify as a buildfix.

Fixed in http://trac.webkit.org/changeset/76606.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>339736</commentid>
    <comment_count>15</comment_count>
      <attachid>80081</attachid>
    <who name="Yael">yael</who>
    <bug_when>2011-01-25 10:42:39 -0800</bug_when>
    <thetext>Created attachment 80081
Patch

Move definition of USE_SYSTEM_MALLOC out of pri file and put it in platform.h instead.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>339882</commentid>
    <comment_count>16</comment_count>
      <attachid>80081</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2011-01-25 13:29:03 -0800</bug_when>
    <thetext>Comment on attachment 80081
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80081&amp;action=review

r- to fix the Windows build.

&gt; Source/JavaScriptCore/wtf/Platform.h:786
&gt; +

This would only set USE_SYSTEM_MALLOC for the Symbian port and would break for example the Windows port of QtWebKit. I suggest we repeat the original rule from WebKit.pri. 

We already have a section for setting memory management related defaults for the Qt port, so perhaps we can add this rule there.

 #if PLATFORM(QT)
 /* We must not customize the global operator new and delete for the Qt port. */
 #define ENABLE_GLOBAL_FASTMALLOC_NEW 0
+#if !PLATFORM(UNIX) || OS(SYMBIAN)
+#define USE_SYSTEM_MALLOC 1
+#endif
 #endif

&gt; Source/JavaScriptCore/wtf/TCSystemAlloc.cpp:34
&gt; +#if !(defined(USE_SYSTEM_MALLOC) &amp;&amp; USE_SYSTEM_MALLOC)

Can we just use !USE(SYSTEM_MALLOC) instead ?

&gt; Source/JavaScriptCore/wtf/wtf.pri:45
&gt; +SOURCES += wtf/TCSystemAlloc.cpp

I think we should move this entry together with the rest of the SOURCES list - alphabetically ordered.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>339902</commentid>
    <comment_count>17</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2011-01-25 13:51:19 -0800</bug_when>
    <thetext>(In reply to comment #16)
&gt; (From update of attachment 80081 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=80081&amp;action=review
&gt; 
&gt; r- to fix the Windows build.
&gt; 
Thank you for your review, and the offline explanation of how to fix the windows build.
As you pointed out, we cannot use !USE(SYSTEM_MALLOC) .
I will upload a new patch soon, addressing all the other issues.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>339928</commentid>
    <comment_count>18</comment_count>
      <attachid>80123</attachid>
    <who name="Yael">yael</who>
    <bug_when>2011-01-25 14:32:33 -0800</bug_when>
    <thetext>Created attachment 80123
Patch

Address comment #16.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>340230</commentid>
    <comment_count>19</comment_count>
      <attachid>80123</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2011-01-26 06:03:48 -0800</bug_when>
    <thetext>Comment on attachment 80123
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80123&amp;action=review

r- to fix the guard, otherwise looks good.

&gt; Source/JavaScriptCore/wtf/Platform.h:834
&gt; +#if !(PLATFORM(UNIX) || OS(SYMBIAN))

I think this should be &quot;!PLATFORM(UNIX) || OS(SYMBIAN)&quot; - the test above is false for Symbian.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>340241</commentid>
    <comment_count>20</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2011-01-26 06:39:51 -0800</bug_when>
    <thetext>(In reply to comment #19)
&gt; (From update of attachment 80123 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=80123&amp;action=review
&gt; 
&gt; r- to fix the guard, otherwise looks good.
&gt; 
&gt; &gt; Source/JavaScriptCore/wtf/Platform.h:834
&gt; &gt; +#if !(PLATFORM(UNIX) || OS(SYMBIAN))
&gt; 
&gt; I think this should be &quot;!PLATFORM(UNIX) || OS(SYMBIAN)&quot; - the test above is false for Symbian.

Good catch :)
A bad last minute change I did.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>340248</commentid>
    <comment_count>21</comment_count>
      <attachid>80190</attachid>
    <who name="Yael">yael</who>
    <bug_when>2011-01-26 06:55:42 -0800</bug_when>
    <thetext>Created attachment 80190
Patch

Address comment #19</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>340435</commentid>
    <comment_count>22</comment_count>
      <attachid>80190</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2011-01-26 13:30:58 -0800</bug_when>
    <thetext>Comment on attachment 80190
Patch

LGTM, r+. Thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>340449</commentid>
    <comment_count>23</comment_count>
      <attachid>80190</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-01-26 13:59:29 -0800</bug_when>
    <thetext>Comment on attachment 80190
Patch

Clearing flags on attachment: 80190

Committed r76716: &lt;http://trac.webkit.org/changeset/76716&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>340450</commentid>
    <comment_count>24</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-01-26 13:59:34 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>340503</commentid>
    <comment_count>25</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-01-26 15:05:03 -0800</bug_when>
    <thetext>http://trac.webkit.org/changeset/76716 might have broken Leopard Intel Release (Tests)</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>79856</attachid>
            <date>2011-01-22 13:45:52 -0800</date>
            <delta_ts>2011-01-23 11:28:49 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>52839.patch</filename>
            <type>text/plain</type>
            <size>2421</size>
            <attacher name="Yael">yael</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2NDU0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDEtMjIgIFlhZWwgQWhh
cm9uICA8eWFlbC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIFtRdF1bU3ltYmlhbl0gRml4IC0tbWluaW1hbCBidWlsZAor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI4MzkKKwor
ICAgICAgICBTb21lIG9mIHRoZSBwbHVnaW5zJyBmdW5jdGlvbmFsaXR5IGlzIHJlaW1wbGVtZW50
ZWQgaW4KKyAgICAgICAgU3ltYmlhbiBzcGVjaWZpYyBmaWxlcy4KKyAgICAgICAgU29tZSBvZiB0
aGlzIGZ1bmN0aW9uYWxpdHkgc2hvdWxkIGJlIGNvbXBpbGVkIGluIGV2ZW4gaWYgCisgICAgICAg
IHRoZSBndWFyZCBORVRTQ0FQRV9QTFVHSU5fQVBJIGlzIHR1cm5lZCBvZmYuCisgICAgICAgIFRo
aXMgcGF0Y2ggbW92ZXMgdGhhdCBmdW5jdGlvbmFsaXR5IG91dCBvZiB0aGUKKyAgICAgICAgTkVU
U0NBUEVfUExVR0lOX0FQSSBndWFyZC4KKworICAgICAgICBCdWlsZCBmaXggc28gbm8gbmV3IHRl
c3RzLgorCisgICAgICAgICogV2ViQ29yZS5wcm86CisgICAgICAgICogcGx1Z2lucy9zeW1iaWFu
L1BsdWdpblBhY2thZ2VTeW1iaWFuLmNwcDoKKwogMjAxMS0wMS0yMiAgQW5kcmVpIFBvcGVzY3Ug
IDxhbmRyZWlwQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmVyZW15IE9ybG93
LgpJbmRleDogU291cmNlL1dlYkNvcmUvV2ViQ29yZS5wcm8KPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl
L1dlYkNvcmUvV2ViQ29yZS5wcm8JKHJldmlzaW9uIDc2NDU0KQorKysgU291cmNlL1dlYkNvcmUv
V2ViQ29yZS5wcm8JKHdvcmtpbmcgY29weSkKQEAgLTI4NDAsMTQgKzI4NDAsMTggQEAgY29udGFp
bnMgKENPTkZJRywgdGV4dF9icmVha2luZ193aXRoX2ljdQogICAgIExJQlMgKz0gLWxpY3V1Ywog
fQogCitzeW1iaWFuIHsKKyAgICBTT1VSQ0VTICs9IFwKKyAgICAgICAgcGx1Z2lucy9zeW1iaWFu
L1BsdWdpbkRhdGFiYXNlU3ltYmlhbi5jcHAgXAorICAgICAgICBwbHVnaW5zL3N5bWJpYW4vUGx1
Z2luUGFja2FnZVN5bWJpYW4uY3BwCit9CisKIGNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9ORVRT
Q0FQRV9QTFVHSU5fQVBJPTEpIHsKIAogICAgIFNPVVJDRVMgKz0gcGx1Z2lucy9ucGFwaS5jcHAK
IAogICAgIHN5bWJpYW4gewogICAgICAgICBTT1VSQ0VTICs9IFwKLSAgICAgICAgcGx1Z2lucy9z
eW1iaWFuL1BsdWdpblBhY2thZ2VTeW1iaWFuLmNwcCBcCi0gICAgICAgIHBsdWdpbnMvc3ltYmlh
bi9QbHVnaW5EYXRhYmFzZVN5bWJpYW4uY3BwIFwKICAgICAgICAgcGx1Z2lucy9zeW1iaWFuL1Bs
dWdpblZpZXdTeW1iaWFuLmNwcCBcCiAgICAgICAgIHBsdWdpbnMvc3ltYmlhbi9QbHVnaW5Db250
YWluZXJTeW1iaWFuLmNwcAogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL3N5bWJpYW4v
UGx1Z2luUGFja2FnZVN5bWJpYW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bs
dWdpbnMvc3ltYmlhbi9QbHVnaW5QYWNrYWdlU3ltYmlhbi5jcHAJKHJldmlzaW9uIDc2NDU0KQor
KysgU291cmNlL1dlYkNvcmUvcGx1Z2lucy9zeW1iaWFuL1BsdWdpblBhY2thZ2VTeW1iaWFuLmNw
cAkod29ya2luZyBjb3B5KQpAQCAtMjksNiArMjksNyBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7
CiAKKyNpZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKIGJvb2wgUGx1Z2luUGFja2FnZTo6
ZmV0Y2hJbmZvKCkKIHsKICAgICBpZiAoIWxvYWQoKSkKQEAgLTE2OSw2ICsxNzAsNyBAQCBib29s
IFBsdWdpblBhY2thZ2U6OmxvYWQoKQogICAgIG1fbG9hZENvdW50Kys7CiAgICAgcmV0dXJuIHRy
dWU7CiB9CisjZW5kaWYKIAogdm9pZCBQbHVnaW5QYWNrYWdlOjp1bmxvYWQoKQogewpAQCAtMTg2
LDkgKzE4OCwxMSBAQCB2b2lkIFBsdWdpblBhY2thZ2U6OnVubG9hZCgpCiAgICAgbV9wbHVnaW5M
b2FkZXIgPSAwOwogfQogCisjaWYgRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCiB1aW50MTZf
dCBQbHVnaW5QYWNrYWdlOjpOUFZlcnNpb24oKSBjb25zdAogewogICAgIHJldHVybiBOUF9WRVJT
SU9OX01JTk9SOwogfQorI2VuZGlmCiB9CiAK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>79927</attachid>
            <date>2011-01-24 08:43:50 -0800</date>
            <delta_ts>2011-01-25 10:42:39 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>52839.patch</filename>
            <type>text/plain</type>
            <size>1183</size>
            <attacher name="Yael">yael</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDc2NTIxKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMTUgQEAKKzIwMTEtMDEtMjQgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9raWEuY29t
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF1b
U3ltYmlhbl0gRml4IC0tbWluaW1hbCBidWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI4MzkKKworICAgICAgICBVU0VfU1lTVEVNX01BTExPQyBp
cyBjb250cm9sbGVkIGJ5IHdlYmtpdC5wcmkgZm9yIFN5bWJpYW4gYW5kCisgICAgICAgIHNob3Vs
ZCBuZXZlciBiZSB0dXJuZWQgb2ZmLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBt
OgorCiAyMDExLTAxLTI0ICBNaWtoYWlsIE5hZ2Fub3YgIDxtbmFnYW5vdkBjaHJvbWl1bS5vcmc+
CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4KSW5kZXg6IFRvb2xzL1Nj
cmlwdHMvd2Via2l0ZGlycy5wbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdGRp
cnMucG0JKHJldmlzaW9uIDc2NTE3KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCSh3
b3JraW5nIGNvcHkpCkBAIC0xNTYxLDYgKzE1NjEsMTAgQEAgc3ViIGJ1aWxkUU1ha2VQcm9qZWN0
KCRAKQogICAgICAgICAgICAgJGluc3RhbGxIZWFkZXJzID0gJDE7CiAgICAgICAgIH0gZWxzaWYg
KCRvcHQgPX4gL14tLWluc3RhbGwtbGlicz0oLiopL2kgKSB7CiAgICAgICAgICAgICAkaW5zdGFs
bExpYnMgPSAkMTsKKyAgICAgICAgfSBlbHNpZiAoJG9wdCA9fiAiVVNFX1NZU1RFTV9NQUxMT0Mi
KSB7CisgICAgICAgICAgICBpZiAoIWlzU3ltYmlhbigpKSB7CisgICAgICAgICAgICAgICAgcHVz
aCBAYnVpbGRBcmdzLCAkb3B0OworICAgICAgICAgICAgfQogICAgICAgICB9IGVsc2UgewogICAg
ICAgICAgICAgcHVzaCBAYnVpbGRBcmdzLCAkb3B0OwogICAgICAgICB9Cg==
</data>
<flag name="review"
          id="71386"
          type_id="1"
          status="-"
          setter="eric"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>80081</attachid>
            <date>2011-01-25 10:42:39 -0800</date>
            <delta_ts>2011-01-25 14:32:33 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>52839.patch</filename>
            <type>text/plain</type>
            <size>3155</size>
            <attacher name="Yael">yael</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDc2NjA5
KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDEt
MjUgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF1bU3ltYmlhbl0gRml4IC0tbWlu
aW1hbCBidWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9NTI4MzkKKworICAgICAgICBNb3ZlIGRlZmluaXRpb24gb2YgVVNFX1NZU1RFTV9NQUxMT0Mg
b3V0IG9mIHByaSBmaWxlLgorICAgICAgICBQdXQgaXQgaW4gcGxhdGZvcm0uaCBpbnN0ZWFkLgor
CisgICAgICAgICogU291cmNlL1dlYktpdC5wcmk6CisKIDIwMTEtMDEtMjQgIENocmlzIE1hcnJp
biAgPGNtYXJyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVs
LgpJbmRleDogU291cmNlL1dlYktpdC5wcmkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC5w
cmkJKHJldmlzaW9uIDc2NjA3KQorKysgU291cmNlL1dlYktpdC5wcmkJKHdvcmtpbmcgY29weSkK
QEAgLTQ3LDEwICs0Nyw2IEBAIGJ1aWxkaW5nLWxpYnMgewogICAgIERFUEVORFBBVEggKz0gJCRQ
V0QvV2ViS2l0L3F0L0FwaQogfQogCi0hbWFjOiF1bml4fHN5bWJpYW4gewotICAgIERFRklORVMg
Kz0gVVNFX1NZU1RFTV9NQUxMT0M9MQotfQotCiBDT05GSUcocmVsZWFzZSwgZGVidWd8cmVsZWFz
ZSkgewogICAgIERFRklORVMgKz0gTkRFQlVHCiB9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM
b2cJKHJldmlzaW9uIDc2NjA5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwko
d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDExLTAxLTI1ICBZYWVsIEFoYXJvbiAg
PHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBbUXRdW1N5bWJpYW5dIEZpeCAtLW1pbmltYWwgYnVpbGQKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyODM5CisKKyAgICAg
ICAgTW92ZSBkZWZpbml0aW9uIG9mIFVTRV9TWVNURU1fTUFMTE9DIG91dCBvZiBwcmkgZmlsZS4K
KyAgICAgICAgUHV0IGl0IGluIHBsYXRmb3JtLmggaW5zdGVhZC4KKworICAgICAgICAqIHd0Zi9Q
bGF0Zm9ybS5oOgorICAgICAgICAqIHd0Zi9UQ1N5c3RlbUFsbG9jLmNwcDoKKyAgICAgICAgKiB3
dGYvd3RmLnByaToKKwogMjAxMS0wMS0yNSAgTWFyY2lsaW8gTWVuZG9uY2EgIDxtYW1lbmRvbmNh
QHJpbS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBTb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph
dmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiA3NjYwNykKKysrIFNvdXJjZS9K
YXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAtNzgyLDYgKzc4
Miw4IEBACiAjZGVmaW5lIEhBVkVfU1lTX1RJTUVfSCAxCiAjZGVmaW5lIEhBVkVfU1RSSU5HU19I
IDEKIAorI2RlZmluZSBVU0VfU1lTVEVNX01BTExPQyAxCisKICNpZiAhQ09NUElMRVIoUlZDVCkK
ICNkZWZpbmUgSEFWRV9TWVNfUEFSQU1fSCAxCiAjZW5kaWYKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny
aXB0Q29yZS93dGYvVENTeXN0ZW1BbGxvYy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT
Y3JpcHRDb3JlL3d0Zi9UQ1N5c3RlbUFsbG9jLmNwcAkocmV2aXNpb24gNzY2MDcpCisrKyBTb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvd3RmL1RDU3lzdGVtQWxsb2MuY3BwCSh3b3JraW5nIGNvcHkpCkBA
IC0zMSw2ICszMSw3IEBACiAvLyBBdXRob3I6IFNhbmpheSBHaGVtYXdhdAogCiAjaW5jbHVkZSAi
Y29uZmlnLmgiCisjaWYgIShkZWZpbmVkKFVTRV9TWVNURU1fTUFMTE9DKSAmJiBVU0VfU1lTVEVN
X01BTExPQykKICNpbmNsdWRlICJUQ1N5c3RlbUFsbG9jLmgiCiAKICNpbmNsdWRlIDxhbGdvcml0
aG0+CkBAIC01MTksMyArNTIwLDYgQEAgdm9pZCBUQ01hbGxvY19TeXN0ZW1Db21taXQodm9pZCog
c3RhcnQsIAogLy8gZGVjbGFyZWQgaW4gVENTeXN0ZW1BbGxvYy5oCiAKICNlbmRpZgorCisjZW5k
aWYgLy8gI2lmICEoZGVmaW5lZChVU0VfU1lTVEVNX01BTExPQykgJiYgVVNFX1NZU1RFTV9NQUxM
T0MpCisKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvd3RmLnByaQo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL3d0Zi5wcmkJKHJldmlzaW9uIDc2NjA3KQor
KysgU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi93dGYucHJpCSh3b3JraW5nIGNvcHkpCkBAIC00
Miw5ICs0Miw3IEBAIGNvbnRhaW5zKERFRklORVMsIFVTRV9HU1RSRUFNRVI9MSkgewogICAgIENP
TkZJRyArPSBsaW5rX3BrZ2NvbmZpZwogfQogCi0hY29udGFpbnMoREVGSU5FUywgVVNFX1NZU1RF
TV9NQUxMT0M9MSkgewotICAgIFNPVVJDRVMgKz0gd3RmL1RDU3lzdGVtQWxsb2MuY3BwCi19CitT
T1VSQ0VTICs9IHd0Zi9UQ1N5c3RlbUFsbG9jLmNwcAogCiB1bml4OiFzeW1iaWFuOiBTT1VSQ0VT
ICs9IHd0Zi9PU0FsbG9jYXRvclBvc2l4LmNwcAogc3ltYmlhbjogU09VUkNFUyArPSB3dGYvT1NB
bGxvY2F0b3JTeW1iaWFuLmNwcAo=
</data>
<flag name="review"
          id="71547"
          type_id="1"
          status="-"
          setter="laszlo.gombos"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>80123</attachid>
            <date>2011-01-25 14:32:33 -0800</date>
            <delta_ts>2011-01-26 06:55:42 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>52839.patch</filename>
            <type>text/plain</type>
            <size>3552</size>
            <attacher name="Yael">yael</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDc2NjA5
KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDEt
MjUgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF1bU3ltYmlhbl0gRml4IC0tbWlu
aW1hbCBidWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9NTI4MzkKKworICAgICAgICBNb3ZlIGRlZmluaXRpb24gb2YgVVNFX1NZU1RFTV9NQUxMT0Mg
b3V0IG9mIHByaSBmaWxlLgorICAgICAgICBQdXQgaXQgaW4gcGxhdGZvcm0uaCBpbnN0ZWFkLgor
CisgICAgICAgICogU291cmNlL1dlYktpdC5wcmk6CisKIDIwMTEtMDEtMjQgIENocmlzIE1hcnJp
biAgPGNtYXJyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVs
LgpJbmRleDogU291cmNlL1dlYktpdC5wcmkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC5w
cmkJKHJldmlzaW9uIDc2NjA3KQorKysgU291cmNlL1dlYktpdC5wcmkJKHdvcmtpbmcgY29weSkK
QEAgLTQ3LDEwICs0Nyw2IEBAIGJ1aWxkaW5nLWxpYnMgewogICAgIERFUEVORFBBVEggKz0gJCRQ
V0QvV2ViS2l0L3F0L0FwaQogfQogCi0hbWFjOiF1bml4fHN5bWJpYW4gewotICAgIERFRklORVMg
Kz0gVVNFX1NZU1RFTV9NQUxMT0M9MQotfQotCiBDT05GSUcocmVsZWFzZSwgZGVidWd8cmVsZWFz
ZSkgewogICAgIERFRklORVMgKz0gTkRFQlVHCiB9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM
b2cJKHJldmlzaW9uIDc2NjA5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwko
d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDExLTAxLTI1ICBZYWVsIEFoYXJvbiAg
PHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBbUXRdW1N5bWJpYW5dIEZpeCAtLW1pbmltYWwgYnVpbGQKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyODM5CisKKyAgICAg
ICAgTW92ZSBkZWZpbml0aW9uIG9mIFVTRV9TWVNURU1fTUFMTE9DIG91dCBvZiBwcmkgZmlsZS4K
KyAgICAgICAgUHV0IGl0IGluIHBsYXRmb3JtLmggaW5zdGVhZC4KKworICAgICAgICAqIHd0Zi9Q
bGF0Zm9ybS5oOgorICAgICAgICAqIHd0Zi9UQ1N5c3RlbUFsbG9jLmNwcDoKKyAgICAgICAgKiB3
dGYvd3RmLnByaToKKwogMjAxMS0wMS0yNSAgTWFyY2lsaW8gTWVuZG9uY2EgIDxtYW1lbmRvbmNh
QHJpbS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBTb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph
dmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiA3NjYwNykKKysrIFNvdXJjZS9K
YXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAtODMxLDYgKzgz
MSw5IEBACiAjaWYgUExBVEZPUk0oUVQpCiAvKiBXZSBtdXN0IG5vdCBjdXN0b21pemUgdGhlIGds
b2JhbCBvcGVyYXRvciBuZXcgYW5kIGRlbGV0ZSBmb3IgdGhlIFF0IHBvcnQuICovCiAjZGVmaW5l
IEVOQUJMRV9HTE9CQUxfRkFTVE1BTExPQ19ORVcgMAorI2lmICEoUExBVEZPUk0oVU5JWCkgfHwg
T1MoU1lNQklBTikpCisjZGVmaW5lIFVTRV9TWVNURU1fTUFMTE9DIDEKKyNlbmRpZgogI2VuZGlm
CiAKIC8qIGZhc3RNYWxsb2MgbWF0Y2ggdmFsaWRhdGlvbiBhbGxvd3MgZm9yIHJ1bnRpbWUgdmVy
aWZpY2F0aW9uIHRoYXQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvVENTeXN0ZW1B
bGxvYy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9UQ1N5c3Rl
bUFsbG9jLmNwcAkocmV2aXNpb24gNzY2MDcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3Rm
L1RDU3lzdGVtQWxsb2MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMSw2ICszMSw3IEBACiAvLyBB
dXRob3I6IFNhbmpheSBHaGVtYXdhdAogCiAjaW5jbHVkZSAiY29uZmlnLmgiCisjaWYgIShkZWZp
bmVkKFVTRV9TWVNURU1fTUFMTE9DKSAmJiBVU0VfU1lTVEVNX01BTExPQykKICNpbmNsdWRlICJU
Q1N5c3RlbUFsbG9jLmgiCiAKICNpbmNsdWRlIDxhbGdvcml0aG0+CkBAIC01MTksMyArNTIwLDYg
QEAgdm9pZCBUQ01hbGxvY19TeXN0ZW1Db21taXQodm9pZCogc3RhcnQsIAogLy8gZGVjbGFyZWQg
aW4gVENTeXN0ZW1BbGxvYy5oCiAKICNlbmRpZgorCisjZW5kaWYgLy8gI2lmICEoZGVmaW5lZChV
U0VfU1lTVEVNX01BTExPQykgJiYgVVNFX1NZU1RFTV9NQUxMT0MpCisKSW5kZXg6IFNvdXJjZS9K
YXZhU2NyaXB0Q29yZS93dGYvd3RmLnByaQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw
dENvcmUvd3RmL3d0Zi5wcmkJKHJldmlzaW9uIDc2NjA3KQorKysgU291cmNlL0phdmFTY3JpcHRD
b3JlL3d0Zi93dGYucHJpCSh3b3JraW5nIGNvcHkpCkBAIC0yMiw2ICsyMiw3IEBAIFNPVVJDRVMg
Kz0gXAogICAgIHd0Zi9SYW5kb21OdW1iZXIuY3BwIFwKICAgICB3dGYvUmVmQ291bnRlZExlYWtD
b3VudGVyLmNwcCBcCiAgICAgd3RmL1N0YWNrQm91bmRzLmNwcCBcCisgICAgd3RmL1RDU3lzdGVt
QWxsb2MuY3BwIFwKICAgICB3dGYvVGhyZWFkaW5nTm9uZS5jcHAgXAogICAgIHd0Zi9UaHJlYWRp
bmcuY3BwIFwKICAgICB3dGYvVHlwZVRyYWl0cy5jcHAgXApAQCAtNDIsMTAgKzQzLDYgQEAgY29u
dGFpbnMoREVGSU5FUywgVVNFX0dTVFJFQU1FUj0xKSB7CiAgICAgQ09ORklHICs9IGxpbmtfcGtn
Y29uZmlnCiB9CiAKLSFjb250YWlucyhERUZJTkVTLCBVU0VfU1lTVEVNX01BTExPQz0xKSB7Ci0g
ICAgU09VUkNFUyArPSB3dGYvVENTeXN0ZW1BbGxvYy5jcHAKLX0KLQogdW5peDohc3ltYmlhbjog
U09VUkNFUyArPSB3dGYvT1NBbGxvY2F0b3JQb3NpeC5jcHAKIHN5bWJpYW46IFNPVVJDRVMgKz0g
d3RmL09TQWxsb2NhdG9yU3ltYmlhbi5jcHAKIHdpbip8d2luY2UqOiBTT1VSQ0VTICs9IHd0Zi9P
U0FsbG9jYXRvcldpbi5jcHAK
</data>
<flag name="review"
          id="71588"
          type_id="1"
          status="-"
          setter="laszlo.gombos"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>80190</attachid>
            <date>2011-01-26 06:55:42 -0800</date>
            <delta_ts>2011-01-26 13:59:29 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>52839.patch</filename>
            <type>text/plain</type>
            <size>3550</size>
            <attacher name="Yael">yael</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDc2NjA5
KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDEt
MjUgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF1bU3ltYmlhbl0gRml4IC0tbWlu
aW1hbCBidWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9NTI4MzkKKworICAgICAgICBNb3ZlIGRlZmluaXRpb24gb2YgVVNFX1NZU1RFTV9NQUxMT0Mg
b3V0IG9mIHByaSBmaWxlLgorICAgICAgICBQdXQgaXQgaW4gcGxhdGZvcm0uaCBpbnN0ZWFkLgor
CisgICAgICAgICogU291cmNlL1dlYktpdC5wcmk6CisKIDIwMTEtMDEtMjQgIENocmlzIE1hcnJp
biAgPGNtYXJyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVs
LgpJbmRleDogU291cmNlL1dlYktpdC5wcmkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC5w
cmkJKHJldmlzaW9uIDc2NjA3KQorKysgU291cmNlL1dlYktpdC5wcmkJKHdvcmtpbmcgY29weSkK
QEAgLTQ3LDEwICs0Nyw2IEBAIGJ1aWxkaW5nLWxpYnMgewogICAgIERFUEVORFBBVEggKz0gJCRQ
V0QvV2ViS2l0L3F0L0FwaQogfQogCi0hbWFjOiF1bml4fHN5bWJpYW4gewotICAgIERFRklORVMg
Kz0gVVNFX1NZU1RFTV9NQUxMT0M9MQotfQotCiBDT05GSUcocmVsZWFzZSwgZGVidWd8cmVsZWFz
ZSkgewogICAgIERFRklORVMgKz0gTkRFQlVHCiB9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM
b2cJKHJldmlzaW9uIDc2NjA5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwko
d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDExLTAxLTI1ICBZYWVsIEFoYXJvbiAg
PHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBbUXRdW1N5bWJpYW5dIEZpeCAtLW1pbmltYWwgYnVpbGQKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyODM5CisKKyAgICAg
ICAgTW92ZSBkZWZpbml0aW9uIG9mIFVTRV9TWVNURU1fTUFMTE9DIG91dCBvZiBwcmkgZmlsZS4K
KyAgICAgICAgUHV0IGl0IGluIHBsYXRmb3JtLmggaW5zdGVhZC4KKworICAgICAgICAqIHd0Zi9Q
bGF0Zm9ybS5oOgorICAgICAgICAqIHd0Zi9UQ1N5c3RlbUFsbG9jLmNwcDoKKyAgICAgICAgKiB3
dGYvd3RmLnByaToKKwogMjAxMS0wMS0yNSAgTWFyY2lsaW8gTWVuZG9uY2EgIDxtYW1lbmRvbmNh
QHJpbS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBTb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph
dmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiA3NjYwNykKKysrIFNvdXJjZS9K
YXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAtODMxLDYgKzgz
MSw5IEBACiAjaWYgUExBVEZPUk0oUVQpCiAvKiBXZSBtdXN0IG5vdCBjdXN0b21pemUgdGhlIGds
b2JhbCBvcGVyYXRvciBuZXcgYW5kIGRlbGV0ZSBmb3IgdGhlIFF0IHBvcnQuICovCiAjZGVmaW5l
IEVOQUJMRV9HTE9CQUxfRkFTVE1BTExPQ19ORVcgMAorI2lmICFQTEFURk9STShVTklYKSB8fCBP
UyhTWU1CSUFOKQorI2RlZmluZSBVU0VfU1lTVEVNX01BTExPQyAxCisjZW5kaWYKICNlbmRpZgog
CiAvKiBmYXN0TWFsbG9jIG1hdGNoIHZhbGlkYXRpb24gYWxsb3dzIGZvciBydW50aW1lIHZlcmlm
aWNhdGlvbiB0aGF0CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1RDU3lzdGVtQWxs
b2MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvVENTeXN0ZW1B
bGxvYy5jcHAJKHJldmlzaW9uIDc2NjA3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9U
Q1N5c3RlbUFsbG9jLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzEsNiArMzEsNyBAQAogLy8gQXV0
aG9yOiBTYW5qYXkgR2hlbWF3YXQKIAogI2luY2x1ZGUgImNvbmZpZy5oIgorI2lmICEoZGVmaW5l
ZChVU0VfU1lTVEVNX01BTExPQykgJiYgVVNFX1NZU1RFTV9NQUxMT0MpCiAjaW5jbHVkZSAiVENT
eXN0ZW1BbGxvYy5oIgogCiAjaW5jbHVkZSA8YWxnb3JpdGhtPgpAQCAtNTE5LDMgKzUyMCw2IEBA
IHZvaWQgVENNYWxsb2NfU3lzdGVtQ29tbWl0KHZvaWQqIHN0YXJ0LCAKIC8vIGRlY2xhcmVkIGlu
IFRDU3lzdGVtQWxsb2MuaAogCiAjZW5kaWYKKworI2VuZGlmIC8vICNpZiAhKGRlZmluZWQoVVNF
X1NZU1RFTV9NQUxMT0MpICYmIFVTRV9TWVNURU1fTUFMTE9DKQorCkluZGV4OiBTb3VyY2UvSmF2
YVNjcmlwdENvcmUvd3RmL3d0Zi5wcmkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD
b3JlL3d0Zi93dGYucHJpCShyZXZpc2lvbiA3NjYwNykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y
ZS93dGYvd3RmLnByaQkod29ya2luZyBjb3B5KQpAQCAtMjIsNiArMjIsNyBAQCBTT1VSQ0VTICs9
IFwKICAgICB3dGYvUmFuZG9tTnVtYmVyLmNwcCBcCiAgICAgd3RmL1JlZkNvdW50ZWRMZWFrQ291
bnRlci5jcHAgXAogICAgIHd0Zi9TdGFja0JvdW5kcy5jcHAgXAorICAgIHd0Zi9UQ1N5c3RlbUFs
bG9jLmNwcCBcCiAgICAgd3RmL1RocmVhZGluZ05vbmUuY3BwIFwKICAgICB3dGYvVGhyZWFkaW5n
LmNwcCBcCiAgICAgd3RmL1R5cGVUcmFpdHMuY3BwIFwKQEAgLTQyLDEwICs0Myw2IEBAIGNvbnRh
aW5zKERFRklORVMsIFVTRV9HU1RSRUFNRVI9MSkgewogICAgIENPTkZJRyArPSBsaW5rX3BrZ2Nv
bmZpZwogfQogCi0hY29udGFpbnMoREVGSU5FUywgVVNFX1NZU1RFTV9NQUxMT0M9MSkgewotICAg
IFNPVVJDRVMgKz0gd3RmL1RDU3lzdGVtQWxsb2MuY3BwCi19Ci0KIHVuaXg6IXN5bWJpYW46IFNP
VVJDRVMgKz0gd3RmL09TQWxsb2NhdG9yUG9zaXguY3BwCiBzeW1iaWFuOiBTT1VSQ0VTICs9IHd0
Zi9PU0FsbG9jYXRvclN5bWJpYW4uY3BwCiB3aW4qfHdpbmNlKjogU09VUkNFUyArPSB3dGYvT1NB
bGxvY2F0b3JXaW4uY3BwCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>