52834 2011-01-20 12:46:43 -0800 handle cases where PrettyPatch.rb doesn't linkify filenames 2011-01-20 16:05:03 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth aroben eric mihaip oldest_to_newest 337526 0 ojan 2011-01-20 12:46:43 -0800 handle cases where PrettyPatch.rb doesn't linkify filenames 337527 1 79638 ojan 2011-01-20 12:47:06 -0800 Created attachment 79638 Patch 337566 2 79638 eric 2011-01-20 13:39:13 -0800 Comment on attachment 79638 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79638&action=review I think this is really an aroben patch to review. > Websites/bugs.webkit.org/code-review.js:343 > + file_link.target = "_blank"; > + file_link.href += url_hash; > + diff_links.append(tracLinks(file_name, url_hash)); two space indent? 337572 3 79638 ojan 2011-01-20 13:43:12 -0800 Comment on attachment 79638 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79638&action=review >> Websites/bugs.webkit.org/code-review.js:343 >> + diff_links.append(tracLinks(file_name, url_hash)); > > two space indent? Following the style of the file. Eventually we should make this file follow something closer to standard WebKit style. 337579 4 abarth 2011-01-20 13:51:52 -0800 jQuery in four-space indent is painful, which is why the file uses two-space indent. 337682 5 ojan 2011-01-20 16:05:03 -0800 Committed r76302: <http://trac.webkit.org/changeset/76302> 79638 2011-01-20 12:47:06 -0800 2011-01-20 13:52:24 -0800 Patch bug-52834-20110120124705.patch text/plain 2635 ojan ZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cgYi9XZWJzaXRl cy9idWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDVlYjIxMGE1NWI2MDliOGMxODg4ZTc3 MzUzMjdmYjc2ZWZhNjMxNzAuLjk4ZWMwYmRkOWY4ZWQ0OWJkNWEwN2E0MGE4NjVlMWNhMWQ5Mzhm OTQgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIv V2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDEx LTAxLTIwICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaGFuZGxlIGNhc2VzIHdoZXJlIFByZXR0 eVBhdGNoLnJiIGRvZXNuJ3QgbGlua2lmeSBmaWxlbmFtZXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyODM0CisKKyAgICAgICAgKiBjb2RlLXJldmll dy5qczoKKworMjAxMS0wMS0yMCAgT2phbiBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgorCiAg ICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCiAKICAgICAgICAgZml4IGdvb2Z1cCBpbiBo dHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC83NjA4MgpkaWZmIC0tZ2l0IGEvV2Vic2l0 ZXMvYnVncy53ZWJraXQub3JnL2NvZGUtcmV2aWV3LmpzIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQu b3JnL2NvZGUtcmV2aWV3LmpzCmluZGV4IDEwYjUyMmM3YWI2MjgzNzkxODEzNTAxZTJkOTRlNzhk NjA3NzRkZTIuLmZmYTI1MWRmNzJjNmUxOWE3OGM5OTUyMjgzYjA1Y2IxMzYzZjFkZmEgMTAwNjQ0 Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9jb2RlLXJldmlldy5qcworKysgYi9XZWJz aXRlcy9idWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXcuanMKQEAgLTMyNSwzMCArMzI1LDM0IEBA CiAgICAgICB2YXIgaGVhZGVyID0gJCh0aGlzKS5jaGlsZHJlbignaDEnKTsKICAgICAgIHZhciB1 cmxfaGFzaCA9ICcjTCcgKyBmaXJzdExpbmUodGhpcyk7CiAKLSAgICAgIHZhciBmaWxlX2xpbmsg PSAkKCdhJywgaGVhZGVyKVswXTsKLSAgICAgIGZpbGVfbGluay50YXJnZXQgPSAiX2JsYW5rIjsK LSAgICAgIGZpbGVfbGluay5ocmVmICs9IHVybF9oYXNoOwotCiAgICAgICB2YXIgZmlsZV9uYW1l ID0gaGVhZGVyLnRleHQoKTsKICAgICAgIGZpbGVzW2ZpbGVfbmFtZV0gPSB0aGlzOwogCiAgICAg ICBhZGRFeHBhbmRMaW5rcyhmaWxlX25hbWUpOwotICAgICAgYWRkRmlsZURpZmZMaW5rcyhmaWxl X25hbWUsIHVybF9oYXNoKTsKKworICAgICAgdmFyIGRpZmZfbGlua3MgPSAkKCc8ZGl2IGNsYXNz PSJGaWxlRGlmZkxpbmtDb250YWluZXIgTGlua0NvbnRhaW5lciI+JyArCisgICAgICAgICAgZGlm ZkxpbmtzSHRtbCgpICsKKyAgICAgICAgICAnPC9kaXY+Jyk7CisKKyAgICAgIHZhciBmaWxlX2xp bmsgPSAkKCdhJywgaGVhZGVyKVswXTsKKyAgICAgIC8vIElmIHRoZSBiYXNlIGRpcmVjdG9yeSBp biB0aGUgZmlsZSBwYXRoIGRvZXMgbm90IG1hdGNoIGEgV2ViS2l0IHRvcCBsZXZlbCBkaXJlY3Rv cnksCisgICAgICAvLyB0aGVuIFByZXR0eVBhdGNoLnJiIGRvZXNuJ3QgbGlua2lmeSB0aGUgaGVh ZGVyLgorICAgICAgaWYgKGZpbGVfbGluaykgeworICAgICAgICBmaWxlX2xpbmsudGFyZ2V0ID0g Il9ibGFuayI7CisgICAgICAgIGZpbGVfbGluay5ocmVmICs9IHVybF9oYXNoOworICAgICAgICBk aWZmX2xpbmtzLmFwcGVuZCh0cmFjTGlua3MoZmlsZV9uYW1lLCB1cmxfaGFzaCkpOworICAgICAg fQorCisgICAgICAkKCdoMScsIHRoaXMpLmFmdGVyKGRpZmZfbGlua3MpOworICAgICAgdXBkYXRl RGlmZkxpbmtWaXNpYmlsaXR5KHRoaXMpOwogICAgIH0pOwogICB9CiAKLSAgZnVuY3Rpb24gYWRk RmlsZURpZmZMaW5rcyhmaWxlX25hbWUsIHVybF9oYXNoKSB7Ci0gICAgdmFyIGRpZmZfbGlua3Mg PSAkKCc8ZGl2IGNsYXNzPSJGaWxlRGlmZkxpbmtDb250YWluZXIgTGlua0NvbnRhaW5lciI+JyAr Ci0gICAgICAgIGRpZmZMaW5rc0h0bWwoKSArCi0gICAgICAgICc8L2Rpdj4nKTsKLQorICBmdW5j dGlvbiB0cmFjTGlua3MoZmlsZV9uYW1lLCB1cmxfaGFzaCkgewogICAgIHZhciB0cmFjX2xpbmtz ID0gJCgnPGEgdGFyZ2V0PSJfYmxhbmsiPmFubm90YXRlPC9hPjxhIHRhcmdldD0iX2JsYW5rIj5y ZXZpc2lvbiBsb2c8L2E+Jyk7CiAgICAgdHJhY19saW5rc1swXS5ocmVmID0gJ2h0dHA6Ly90cmFj LndlYmtpdC5vcmcvYnJvd3Nlci90cnVuay8nICsgZmlsZV9uYW1lICsgJz9hbm5vdGF0ZT1ibGFt ZScgKyB1cmxfaGFzaDsKICAgICB0cmFjX2xpbmtzWzFdLmhyZWYgPSAnaHR0cDovL3RyYWMud2Vi a2l0Lm9yZy9sb2cvdHJ1bmsvJyArIGZpbGVfbmFtZTsKLSAgICBkaWZmX2xpbmtzLmFwcGVuZCh0 cmFjX2xpbmtzKTsKLQotICAgICQoJ2gxJywgZmlsZXNbZmlsZV9uYW1lXSkuYWZ0ZXIoZGlmZl9s aW5rcyk7Ci0gICAgdXBkYXRlRGlmZkxpbmtWaXNpYmlsaXR5KGZpbGVzW2ZpbGVfbmFtZV0pOwor ICAgIHJldHVybiB0cmFjX2xpbmtzOwogICB9CiAKICAgZnVuY3Rpb24gYWRkRXhwYW5kTGlua3Mo ZmlsZV9uYW1lKSB7Cg==