52823 2011-01-20 10:51:08 -0800 need a way to obtain the rendered rectangle for box elements 2011-06-18 12:01:54 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 kdecker kdecker darin oldest_to_newest 337443 0 kdecker 2011-01-20 10:51:08 -0800 <rdar://problem/8880689> need a way to obtain the rendered rectangle for box elements 337445 1 79617 kdecker 2011-01-20 10:57:11 -0800 Created attachment 79617 proposed fix 337451 2 79617 andersca 2011-01-20 11:03:05 -0800 Comment on attachment 79617 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=79617&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:43 > +WK_EXPORT WKRect WKBundleNodeHandleRenderRect(WKBundleNodeHandleRef nodeHandle, bool* isReplaced); A better name for this function would be WKBundleNodeHandleGetRenderRect. 423152 3 darin 2011-06-18 12:01:54 -0700 http://trac.webkit.org/projects/webkit/changeset/76267 79617 2011-01-20 10:57:11 -0800 2011-01-20 11:03:04 -0800 proposed fix patch.txt text/plain 4089 kdecker SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2MjY2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDEtMjAgIEtldmluIERl Y2tlciAgPGtkZWNrZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84ODgwNjg5PiBuZWVkIGEgd2F5IHRv IG9idGFpbiB0aGUgcmVuZGVyZWQgcmVjdGFuZ2xlIGZvciBib3ggZWxlbWVudHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyODIzCisgICAgICAgIAor ICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVOb2RlSGFu ZGxlLmNwcDoKKyAgICAgICAgKFdLQnVuZGxlTm9kZUhhbmRsZVJlbmRlclJlY3QpOiBBZGRlZCBu ZXcgbWV0aG9kIHRoYXQgd2lsbCByZXR1cm4gYSByZW5kZXJlZCByZWN0YW5nbGUgZm9yIGJveCBl bGVtZW50cworICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5k bGVOb2RlSGFuZGxlUHJpdmF0ZS5oOiBEaXR0by4KKyAgICAgICAgKiBXZWJQcm9jZXNzL0luamVj dGVkQnVuZGxlL0RPTS9JbmplY3RlZEJ1bmRsZU5vZGVIYW5kbGUuY3BwOiBEaXR0by4KKyAgICAg ICAgKFdlYktpdDo6SW5qZWN0ZWRCdW5kbGVOb2RlSGFuZGxlOjpyZW5kZXJSZWN0KTogRGl0dG8u CisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9ET00vSW5qZWN0ZWRCdW5kbGVO b2RlSGFuZGxlLmg6IERpdHRvLgorCiAyMDExLTAxLTIwICBLaW1tbyBLaW5udW5lbiAgPGtpbW1v LnQua2lubnVuZW5Abm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xp bmcuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9j L1dLQnVuZGxlTm9kZUhhbmRsZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZU5vZGVIYW5kbGUuY3BwCShyZXZp c2lvbiA3NjI2NikKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUv QVBJL2MvV0tCdW5kbGVOb2RlSGFuZGxlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDksNiArNDks MTEgQEAgV0tSZWN0IFdLQnVuZGxlTm9kZUhhbmRsZUdldEVsZW1lbnRCb3VuZAogICAgIHJldHVy biB0b0FQSSh0b0ltcGwobm9kZUhhbmRsZVJlZiktPmVsZW1lbnRCb3VuZHMoKSk7CiB9CiAKK1dL UmVjdCBXS0J1bmRsZU5vZGVIYW5kbGVSZW5kZXJSZWN0KFdLQnVuZGxlTm9kZUhhbmRsZVJlZiBu b2RlSGFuZGxlUmVmLCBib29sKiBpc1JlcGxhY2VkKQoreworICAgIHJldHVybiB0b0FQSSh0b0lt cGwobm9kZUhhbmRsZVJlZiktPnJlbmRlclJlY3QoaXNSZXBsYWNlZCkpOworfQorCiB2b2lkIFdL QnVuZGxlTm9kZUhhbmRsZVNldEhUTUxJbnB1dEVsZW1lbnRWYWx1ZUZvclVzZXIoV0tCdW5kbGVO b2RlSGFuZGxlUmVmIGh0bWxJbnB1dEVsZW1lbnRIYW5kbGVSZWYsIFdLU3RyaW5nUmVmIHZhbHVl UmVmKQogewogICAgIHRvSW1wbChodG1sSW5wdXRFbGVtZW50SGFuZGxlUmVmKS0+c2V0SFRNTElu cHV0RWxlbWVudFZhbHVlRm9yVXNlcih0b1dURlN0cmluZyh2YWx1ZVJlZikpOwpJbmRleDogU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZU5vZGVI YW5kbGVQcml2YXRlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9J bmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZU5vZGVIYW5kbGVQcml2YXRlLmgJKHJldmlzaW9u IDc2MjY2KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkv Yy9XS0J1bmRsZU5vZGVIYW5kbGVQcml2YXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTQwLDYgKzQw LDggQEAgV0tfRVhQT1JUIFdLQnVuZGxlTm9kZUhhbmRsZVJlZiBXS0J1bmRsZQogLyogQWRkaXRp b25hbCBET00gT3BlcmF0aW9ucyAqLwogCiBXS19FWFBPUlQgV0tSZWN0IFdLQnVuZGxlTm9kZUhh bmRsZUdldEVsZW1lbnRCb3VuZHMoV0tCdW5kbGVOb2RlSGFuZGxlUmVmIG5vZGVIYW5kbGUpOwor V0tfRVhQT1JUIFdLUmVjdCBXS0J1bmRsZU5vZGVIYW5kbGVSZW5kZXJSZWN0KFdLQnVuZGxlTm9k ZUhhbmRsZVJlZiBub2RlSGFuZGxlLCBib29sKiBpc1JlcGxhY2VkKTsKKwogCiAvKiBIVE1MSW5w dXRFbGVtZW50IFNwZWNpZmljIE9wZXJhdGlvbnMgKi8KIFdLX0VYUE9SVCB2b2lkIFdLQnVuZGxl Tm9kZUhhbmRsZVNldEhUTUxJbnB1dEVsZW1lbnRWYWx1ZUZvclVzZXIoV0tCdW5kbGVOb2RlSGFu ZGxlUmVmIGh0bWxJbnB1dEVsZW1lbnRIYW5kbGUsIFdLU3RyaW5nUmVmIHZhbHVlKTsKSW5kZXg6 IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvRE9NL0luamVjdGVkQnVu ZGxlTm9kZUhhbmRsZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9JbmplY3RlZEJ1bmRsZS9ET00vSW5qZWN0ZWRCdW5kbGVOb2RlSGFuZGxlLmNwcAkocmV2aXNp b24gNzYyNjYpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0RP TS9JbmplY3RlZEJ1bmRsZU5vZGVIYW5kbGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDQsNiAr MTA0LDExIEBAIEludFJlY3QgSW5qZWN0ZWRCdW5kbGVOb2RlSGFuZGxlOjplbGVtZW4KIAogICAg IHJldHVybiBzdGF0aWNfY2FzdDxFbGVtZW50Kj4obV9ub2RlLmdldCgpKS0+Ym91bmRzSW5XaW5k b3dTcGFjZSgpOwogfQorICAgIAorSW50UmVjdCBJbmplY3RlZEJ1bmRsZU5vZGVIYW5kbGU6OnJl bmRlclJlY3QoYm9vbCogaXNSZXBsYWNlZCkgY29uc3QKK3sKKyAgICByZXR1cm4gbV9ub2RlLmdl dCgpLT5yZW5kZXJSZWN0KGlzUmVwbGFjZWQpOworfQogCiB2b2lkIEluamVjdGVkQnVuZGxlTm9k ZUhhbmRsZTo6c2V0SFRNTElucHV0RWxlbWVudFZhbHVlRm9yVXNlcihjb25zdCBTdHJpbmcmIHZh bHVlKQogewpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9E T00vSW5qZWN0ZWRCdW5kbGVOb2RlSGFuZGxlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9ET00vSW5qZWN0ZWRCdW5kbGVOb2RlSGFuZGxl LmgJKHJldmlzaW9uIDc2MjY2KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3Rl ZEJ1bmRsZS9ET00vSW5qZWN0ZWRCdW5kbGVOb2RlSGFuZGxlLmgJKHdvcmtpbmcgY29weSkKQEAg LTU2LDYgKzU2LDcgQEAgcHVibGljOgogICAgIC8vIEFkZGl0aW9uYWwgRE9NIE9wZXJhdGlvbnMK ICAgICAvLyBOb3RlOiBUaGVzZSBzaG91bGQgb25seSBiZSBvcGVyYXRpb25zIHRoYXQgYXJlIG5v dCBleHBvc2VkIHRvIEphdmFTY3JpcHQuCiAgICAgV2ViQ29yZTo6SW50UmVjdCBlbGVtZW50Qm91 bmRzKCkgY29uc3Q7CisgICAgV2ViQ29yZTo6SW50UmVjdCByZW5kZXJSZWN0KGJvb2wqKSBjb25z dDsKICAgICB2b2lkIHNldEhUTUxJbnB1dEVsZW1lbnRWYWx1ZUZvclVzZXIoY29uc3QgU3RyaW5n Jik7CiAgICAgYm9vbCBpc0hUTUxJbnB1dEVsZW1lbnRBdXRvZmlsbGVkKCkgY29uc3Q7CiAgICAg dm9pZCBzZXRIVE1MSW5wdXRFbGVtZW50QXV0b2ZpbGxlZChib29sKTsK