52814 2011-01-20 07:26:22 -0800 REGRESSION(r76177): All JavaScriptCore tests fail on ARM 2011-01-22 03:25:22 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P1 Blocker --- 52622 1 ossy webkit-unassigned commit-queue galpeter ggaren koivisto loki oliver zherczeg oldest_to_newest 337330 0 ossy 2011-01-20 07:26:22 -0800 http://trac.webkit.org/changeset/76177 made all jsc tests fail on ARM Gabor or Zoltan, could you check it, please? 338199 1 79767 galpeter 2011-01-21 11:37:50 -0800 Created attachment 79767 proposed fix I'm not an OwnPtr expert, but shouldn't we need to get the approximateByteSize before releasing the OwnPtr? Tested on an ARM build, with run-sunspider and run-javascriptcore-tests all runs ok. 338214 2 79767 darin 2011-01-21 11:45:47 -0800 Comment on attachment 79767 proposed fix Perfect. Great fix. This depends on the compiler’s order of evaluation for arguments, so could behave differently for different compilers. 338236 3 79767 commit-queue 2011-01-21 12:01:19 -0800 Comment on attachment 79767 proposed fix Clearing flags on attachment: 79767 Committed r76376: <http://trac.webkit.org/changeset/76376> 338237 4 commit-queue 2011-01-21 12:01:24 -0800 All reviewed patches have been landed. Closing bug. 338558 5 koivisto 2011-01-22 03:25:22 -0800 Good catch. Thanks for fixing this. 79767 2011-01-21 11:37:50 -0800 2011-01-21 12:01:19 -0800 proposed fix arm-fix.patch text/plain 1429 galpeter ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDlkN2M0MzYuLjlkNTlhZmYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTAxLTIxICBQZXRlciBHYWwgIDxn YWxwZXRlckBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTihyNzYxNzcpOiBBbGwgSmF2YVNjcmlwdENvcmUg dGVzdHMgZmFpbCBvbiBBUk0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTUyODE0CisKKyAgICAgICAgR2V0IHRoZSBhcHByb3hpbWF0ZUJ5dGVTaXplIHZh bHVlIGJlZm9yZSByZWxlYXNpbmcgdGhlIE93blB0ci4KKworICAgICAgICAqIHBhcnNlci9KU1Bh cnNlci5jcHA6CisgICAgICAgIChKU0M6OkpTUGFyc2VyOjpwYXJzZUZ1bmN0aW9uSW5mbyk6CisK IDIwMTEtMDEtMjAgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgTWFjaWVqIFN0YWNob3dpYWsuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcGFyc2VyL0pTUGFyc2VyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJz ZXIvSlNQYXJzZXIuY3BwCmluZGV4IGQwNmY3ZDkuLmNiNTlmOTMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvSlNQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9wYXJzZXIvSlNQYXJzZXIuY3BwCkBAIC0xMzU3LDggKzEzNTcsMTAgQEAgdGVtcGxh dGUgPEpTUGFyc2VyOjpGdW5jdGlvblJlcXVpcmVtZW50cyByZXF1aXJlbWVudHMsIGJvb2wgbmFt ZUlzSW5Db250YWluaW5nU2MKICAgICBmYWlsSWZGYWxzZShwb3BTY29wZShmdW5jdGlvblNjb3Bl LCBUcmVlQnVpbGRlcjo6TmVlZHNGcmVlVmFyaWFibGVJbmZvKSk7CiAgICAgbWF0Y2hPckZhaWwo Q0xPU0VCUkFDRSk7CiAKLSAgICBpZiAobmV3SW5mbykKLSAgICAgICAgbV9mdW5jdGlvbkNhY2hl LT5hZGQob3BlbkJyYWNlUG9zLCBuZXdJbmZvLnJlbGVhc2UoKSwgbmV3SW5mby0+YXBwcm94aW1h dGVCeXRlU2l6ZSgpKTsKKyAgICBpZiAobmV3SW5mbykgeworICAgICAgICB1bnNpZ25lZCBhcHBy b3hpbWF0ZUJ5dGVTaXplID0gbmV3SW5mby0+YXBwcm94aW1hdGVCeXRlU2l6ZSgpOworICAgICAg ICBtX2Z1bmN0aW9uQ2FjaGUtPmFkZChvcGVuQnJhY2VQb3MsIG5ld0luZm8ucmVsZWFzZSgpLCBh cHByb3hpbWF0ZUJ5dGVTaXplKTsKKyAgICB9CiAKICAgICBuZXh0KCk7CiAgICAgcmV0dXJuIHRy dWU7Cg==