52808 2011-01-20 05:52:12 -0800 Web Inspector: [Chromium] REGRESSION: Using the "Back" button while profiling causes renderer crash 2022-03-01 02:36:09 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov abarth apavlov bweinstein eric joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 337297 0 mnaganov 2011-01-20 05:52:12 -0800 From http://code.google.com/p/chromium/issues/detail?id=70228: Chromium 10.0.642.0 (71590) What steps will reproduce the problem? 1. Navigate to some page (e.g. google.com) 2. In the same tab, navigate to other page (e.g. yandex.ru) 3. Open DevTools, open CPU profiles page, start profiling. 4. Press the "Back" button in browser. Expected: tab navigates back to the page from item 1., profiling continues. Actual: tab renderer crashes. 337302 1 79589 mnaganov 2011-01-20 06:03:34 -0800 Created attachment 79589 patch 338027 2 yurys 2011-01-21 06:22:14 -0800 Probably related Chromium issue: http://code.google.com/p/chromium/issues/detail?id=67052 338028 3 79589 yurys 2011-01-21 06:25:46 -0800 Comment on attachment 79589 patch r+ for this quick fix but we need to figure out what causes the crash. 338039 4 mnaganov 2011-01-21 07:03:31 -0800 Committed manually http://trac.webkit.org/changeset/76345 2011-01-21 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: [Chromium] REGRESSION: Using the "Back" button while profiling causes renderer crash. https://bugs.webkit.org/show_bug.cgi?id=52808 * inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole): (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole): I agree, we should investigate the real cause of the crash. 338044 5 webkit.review.bot 2011-01-21 07:30:59 -0800 http://trac.webkit.org/changeset/76345 might have broken GTK Linux 64-bit Debug The following tests are not passing: loader/reload-subresource-when-type-changes.html 79589 2011-01-20 06:03:34 -0800 2022-03-01 02:36:09 -0800 patch patch-52808 text/plain 2174 mnaganov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiMzhjZWI4Li43YWMxZTEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDEtMjAgIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBbQ2hyb21pdW1dIFJFR1JFU1NJT046IFVzaW5nIHRoZSAiQmFjayIgYnV0dG9uCisg ICAgICAgIHdoaWxlIHByb2ZpbGluZyBjYXVzZXMgcmVuZGVyZXIgY3Jhc2guCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyODA4CisKKyAgICAgICAg KiBpbnNwZWN0b3IvSW5zcGVjdG9yUHJvZmlsZXJBZ2VudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpJbnNwZWN0b3JQcm9maWxlckFnZW50OjphZGRQcm9maWxlRmluaXNoZWRNZXNzYWdlVG9Db25z b2xlKToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvclByb2ZpbGVyQWdlbnQ6OmFkZFN0YXJ0 UHJvZmlsaW5nTWVzc2FnZVRvQ29uc29sZSk6CisKIDIwMTEtMDEtMTkgIFN0ZXBoZW4gV2hpdGUg IDxzZW5vcmJsYW5jb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1JlLWxhbmQgb2Ygcjc2MTU5 IHdpdGggYSBjb21waWxlIGZpeCBmb3IgdGhlIENocm9taXVtIGxpbnV4IHNobGliCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUHJvZmlsZXJBZ2VudC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUHJvZmlsZXJBZ2VudC5jcHAKaW5k ZXggZGE5YjY3ZC4uN2ZlN2IzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0luc3BlY3RvclByb2ZpbGVyQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JQcm9maWxlckFnZW50LmNwcApAQCAtODgsNiArODgsOCBAQCB2b2lkIEluc3Bl Y3RvclByb2ZpbGVyQWdlbnQ6OmFkZFByb2ZpbGUoUGFzc1JlZlB0cjxTY3JpcHRQcm9maWxlPiBw cnBQcm9maWxlLCB1bgogCiB2b2lkIEluc3BlY3RvclByb2ZpbGVyQWdlbnQ6OmFkZFByb2ZpbGVG aW5pc2hlZE1lc3NhZ2VUb0NvbnNvbGUoUGFzc1JlZlB0cjxTY3JpcHRQcm9maWxlPiBwcnBQcm9m aWxlLCB1bnNpZ25lZCBsaW5lTnVtYmVyLCBjb25zdCBTdHJpbmcmIHNvdXJjZVVSTCkKIHsKKyAg ICBpZiAoIW1fZnJvbnRlbmQpCisgICAgICAgIHJldHVybjsKICAgICBSZWZQdHI8U2NyaXB0UHJv ZmlsZT4gcHJvZmlsZSA9IHBycFByb2ZpbGU7CiAgICAgU3RyaW5nIHRpdGxlID0gcHJvZmlsZS0+ dGl0bGUoKTsKICAgICBTdHJpbmcgbWVzc2FnZSA9IG1ha2VTdHJpbmcoIlByb2ZpbGUgXCJ3ZWJr aXQtcHJvZmlsZTovLyIsIENQVVByb2ZpbGVUeXBlLCAnLycsIGVuY29kZVdpdGhVUkxFc2NhcGVT ZXF1ZW5jZXModGl0bGUpLCAnIycsIFN0cmluZzo6bnVtYmVyKHByb2ZpbGUtPnVpZCgpKSwgIlwi IGZpbmlzaGVkLiIpOwpAQCAtOTYsNiArOTgsOCBAQCB2b2lkIEluc3BlY3RvclByb2ZpbGVyQWdl bnQ6OmFkZFByb2ZpbGVGaW5pc2hlZE1lc3NhZ2VUb0NvbnNvbGUoUGFzc1JlZlB0cjxTY3JpcAog CiB2b2lkIEluc3BlY3RvclByb2ZpbGVyQWdlbnQ6OmFkZFN0YXJ0UHJvZmlsaW5nTWVzc2FnZVRv Q29uc29sZShjb25zdCBTdHJpbmcmIHRpdGxlLCB1bnNpZ25lZCBsaW5lTnVtYmVyLCBjb25zdCBT dHJpbmcmIHNvdXJjZVVSTCkKIHsKKyAgICBpZiAoIW1fZnJvbnRlbmQpCisgICAgICAgIHJldHVy bjsKICAgICBTdHJpbmcgbWVzc2FnZSA9IG1ha2VTdHJpbmcoIlByb2ZpbGUgXCJ3ZWJraXQtcHJv ZmlsZTovLyIsIENQVVByb2ZpbGVUeXBlLCAnLycsIGVuY29kZVdpdGhVUkxFc2NhcGVTZXF1ZW5j ZXModGl0bGUpLCAiIzBcIiBzdGFydGVkLiIpOwogICAgIG1faW5zcGVjdG9yQ29udHJvbGxlci0+ Y29uc29sZUFnZW50KCktPmFkZE1lc3NhZ2VUb0NvbnNvbGUoSlNNZXNzYWdlU291cmNlLCBMb2dN ZXNzYWdlVHlwZSwgTG9nTWVzc2FnZUxldmVsLCBtZXNzYWdlLCBsaW5lTnVtYmVyLCBzb3VyY2VV UkwpOwogfQo=