52772 2011-01-19 17:33:59 -0800 nrwt: rewrite google chrome unittests to use mock filesystem 2011-01-20 18:31:08 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 52771 1 dpranke dpranke eric mihaip ojan tony oldest_to_newest 336976 0 dpranke 2011-01-19 17:33:59 -0800 nrwt: rewrite google chrome unittests to use mock filesystem 336978 1 79529 dpranke 2011-01-19 17:35:03 -0800 Created attachment 79529 Patch 337223 2 79529 eric 2011-01-20 02:57:20 -0800 Comment on attachment 79529 Patch OK. 337782 3 79529 dpranke 2011-01-20 18:31:04 -0800 Comment on attachment 79529 Patch Clearing flags on attachment: 79529 Committed r76323: <http://trac.webkit.org/changeset/76323> 337783 4 dpranke 2011-01-20 18:31:08 -0800 All reviewed patches have been landed. Closing bug. 79529 2011-01-19 17:35:03 -0800 2011-01-20 18:31:03 -0800 Patch bug-52772-20110119173502.patch text/plain 4438 dpranke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwMDRj YTE0MTIwNTljMDBiOGNlMzY0NDMwMmVjYTAxNTBjYzMzNjU5Li44NGNhZTlhYWFhMjJmZmUzOWNm M2I0YjdlNGM4YjIwMjRjM2ExOWU0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTYgQEAKIAogICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBucnd0OiByZXdyaXRlIGdvb2dsZV9jaHJvbWVfdW5p dHRlc3QgdG8gdXNlIG1vY2sgZmlsZXN5c3RlbS4KKyAgICAgICAgCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Mjc3MgorICAgICAgICAKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2dvb2dsZV9jaHJvbWVfdW5pdHRl c3QucHk6CisKKzIwMTEtMDEtMTkgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAgbnJ3dDog Y2xlYW4gdXAgYWxtb3N0IGFsbCByZW1haW5pbmcgcG9ydCByZWZlcmVuY2VzLCByZW1vdmUKICAg ICAgICAgdW5uZWNlc3NhcnkgaW1wb3J0IGNsYXVzZXMuIFRoZSBvbmx5IHJlbWFpbmluZyByZWZl cmVuY2VzIGFyZQogICAgICAgICBpbiBwbGFjZXMgd2hlcmUgYSBtb2NrIGZpbGVzeXN0ZW0gbWFr ZXMgbm8gc2Vuc2Ugb3IgY2FuJ3QgYmUKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZ29vZ2xlX2Nocm9tZV91bml0dGVzdC5weSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZ29vZ2xlX2Nocm9tZV91bml0dGVzdC5w eQppbmRleCA2NTM5YmIyYjRiZWI5ODgwNWFhZjkzZDQzMTRkMDYwYTQ0YWE4MzhhLi5hYWI4ZGQx OTk0MWU1MzQwZGRkMGRkYjg3ZGU0MTcxMjhlNmY5NDJmIDEwMDY0NAotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2dvb2dsZV9jaHJvbWVfdW5pdHRlc3QucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9nb29nbGVfY2hy b21lX3VuaXR0ZXN0LnB5CkBAIC0yNCwxMSArMjQsOSBAQAogIyAoSU5DTFVESU5HIE5FR0xJR0VO Q0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKICMgT0Yg VEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNI IERBTUFHRS4KIAotaW1wb3J0IGNvZGVjcwotaW1wb3J0IG9zCiBpbXBvcnQgdW5pdHRlc3QKIAot ZnJvbSB3ZWJraXRweS5jb21tb24gaW1wb3J0IG5ld3N0cmluZ2lvCitmcm9tIHdlYmtpdHB5LmNv bW1vbi5zeXN0ZW0gaW1wb3J0IGZpbGVzeXN0ZW1fbW9jawogCiBpbXBvcnQgZmFjdG9yeQogaW1w b3J0IGdvb2dsZV9jaHJvbWUKQEAgLTU4LDQ1ICs1NiwyNyBAQCBjbGFzcyBHZXRHb29nbGVDaHJv bWVQb3J0VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgICMgYmUgYWJsZSB0byBjb250 cm9sIHRoZSBjb250ZW50cyBiZXR0ZXIuCiAKICAgICAgICAgY2hyb21pdW1fcG9ydCA9IGZhY3Rv cnkuZ2V0KCJjaHJvbWl1bS1tYWMiKQotICAgICAgICBjaHJvbWl1bV9vdmVycmlkZXMgPSBjaHJv bWl1bV9wb3J0LnRlc3RfZXhwZWN0YXRpb25zX292ZXJyaWRlcygpCisgICAgICAgIGNocm9taXVt X2Jhc2UgPSBjaHJvbWl1bV9wb3J0LnBhdGhfZnJvbV9jaHJvbWl1bV9iYXNlKCkKKyAgICAgICAg ZnMgPSBmaWxlc3lzdGVtX21vY2suTW9ja0ZpbGVTeXN0ZW0oKQogICAgICAgICBwb3J0ID0gZ29v Z2xlX2Nocm9tZS5HZXRHb29nbGVDaHJvbWVQb3J0KHBvcnRfbmFtZT1wb3J0X25hbWUsCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgb3B0aW9ucz1Ob25l KQotCi0gICAgICAgIG9yaWdfZXhpc3RzID0gb3MucGF0aC5leGlzdHMKLSAgICAgICAgb3JpZ19v cGVuID0gY29kZWNzLm9wZW4KLSAgICAgICAgZXhwZWN0ZWRfc3RyaW5nID0gIi8vIGhlbGxvLCB3 b3JsZFxuIgotCi0gICAgICAgIGRlZiBtb2NrX2V4aXN0c19jaHJvbWVfbm90X2ZvdW5kKHBhdGgp OgotICAgICAgICAgICAgaWYgJ3Rlc3RfZXhwZWN0YXRpb25zX2Nocm9tZS50eHQnIGluIHBhdGg6 Ci0gICAgICAgICAgICAgICAgcmV0dXJuIEZhbHNlCi0gICAgICAgICAgICByZXR1cm4gb3JpZ19l eGlzdHMocGF0aCkKLQotICAgICAgICBkZWYgbW9ja19leGlzdHNfY2hyb21lX2ZvdW5kKHBhdGgp OgotICAgICAgICAgICAgaWYgJ3Rlc3RfZXhwZWN0YXRpb25zX2Nocm9tZS50eHQnIGluIHBhdGg6 Ci0gICAgICAgICAgICAgICAgcmV0dXJuIFRydWUKLSAgICAgICAgICAgIHJldHVybiBvcmlnX2V4 aXN0cyhwYXRoKQotCi0gICAgICAgIGRlZiBtb2NrX29wZW4ocGF0aCwgbW9kZSwgZW5jb2Rpbmcp OgotICAgICAgICAgICAgaWYgJ3Rlc3RfZXhwZWN0YXRpb25zX2Nocm9tZS50eHQnIGluIHBhdGg6 Ci0gICAgICAgICAgICAgICAgcmV0dXJuIG5ld3N0cmluZ2lvLlN0cmluZ0lPKGV4cGVjdGVkX3N0 cmluZykKLSAgICAgICAgICAgIHJldHVybiBvcmlnX29wZW4ocGF0aCwgbW9kZSwgZW5jb2Rpbmcp Ci0KLSAgICAgICAgdHJ5OgotICAgICAgICAgICAgb3MucGF0aC5leGlzdHMgPSBtb2NrX2V4aXN0 c19jaHJvbWVfbm90X2ZvdW5kCi0gICAgICAgICAgICBjaHJvbWVfb3ZlcnJpZGVzID0gcG9ydC50 ZXN0X2V4cGVjdGF0aW9uc19vdmVycmlkZXMoKQotICAgICAgICAgICAgc2VsZi5hc3NlcnRFcXVh bChjaHJvbWl1bV9vdmVycmlkZXMsIGNocm9tZV9vdmVycmlkZXMpCi0KLSAgICAgICAgICAgIG9z LnBhdGguZXhpc3RzID0gbW9ja19leGlzdHNfY2hyb21lX2ZvdW5kCi0gICAgICAgICAgICBjb2Rl Y3Mub3BlbiA9IG1vY2tfb3BlbgotICAgICAgICAgICAgY2hyb21lX292ZXJyaWRlcyA9IHBvcnQu dGVzdF9leHBlY3RhdGlvbnNfb3ZlcnJpZGVzKCkKLSAgICAgICAgICAgIGlmIGNocm9taXVtX292 ZXJyaWRlczoKLSAgICAgICAgICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGNocm9tZV9vdmVycmlk ZXMsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjaHJvbWl1bV9vdmVycmlkZXMg KyBleHBlY3RlZF9zdHJpbmcpCi0gICAgICAgICAgICBlbHNlOgotICAgICAgICAgICAgICAgIHNl bGYuYXNzZXJ0RXF1YWwoY2hyb21lX292ZXJyaWRlcywgZXhwZWN0ZWRfc3RyaW5nKQotICAgICAg ICBmaW5hbGx5OgotICAgICAgICAgICAgb3MucGF0aC5leGlzdHMgPSBvcmlnX2V4aXN0cwotICAg ICAgICAgICAgY29kZWNzLm9wZW4gPSBvcmlnX29wZW4KKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBvcHRpb25zPU5vbmUsIGZpbGVzeXN0ZW09ZnMpCisK KyAgICAgICAgZXhwZWN0ZWRfY2hyb21pdW1fb3ZlcnJpZGVzID0gJy8vIGNocm9taXVtIG92ZXJy aWRlc1xuJworICAgICAgICBleHBlY3RlZF9jaHJvbWVfb3ZlcnJpZGVzID0gJy8vIGNocm9tZSBv dmVycmlkZXNcbicKKyAgICAgICAgY2hyb21pdW1fcGF0aCA9IGZzLmpvaW4oY2hyb21pdW1fYmFz ZSwgJ3dlYmtpdCcsICd0b29scycsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICds YXlvdXRfdGVzdHMnLCAndGVzdF9leHBlY3RhdGlvbnMudHh0JykKKyAgICAgICAgY2hyb21lX3Bh dGggPSBmcy5qb2luKGNocm9taXVtX2Jhc2UsICd3ZWJraXQnLCAndG9vbHMnLAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgJ2xheW91dF90ZXN0cycsICd0ZXN0X2V4cGVjdGF0aW9uc19j aHJvbWUudHh0JykKKworICAgICAgICBmcy5maWxlc1tjaHJvbWl1bV9wYXRoXSA9IGV4cGVjdGVk X2Nocm9taXVtX292ZXJyaWRlcworICAgICAgICBmcy5maWxlc1tjaHJvbWVfcGF0aF0gPSBOb25l CisgICAgICAgIGFjdHVhbF9jaHJvbWVfb3ZlcnJpZGVzID0gcG9ydC50ZXN0X2V4cGVjdGF0aW9u c19vdmVycmlkZXMoKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGV4cGVjdGVkX2Nocm9taXVt X292ZXJyaWRlcywgYWN0dWFsX2Nocm9tZV9vdmVycmlkZXMpCisKKyAgICAgICAgZnMuZmlsZXNb Y2hyb21lX3BhdGhdID0gZXhwZWN0ZWRfY2hyb21lX292ZXJyaWRlcworICAgICAgICBhY3R1YWxf Y2hyb21lX292ZXJyaWRlcyA9IHBvcnQudGVzdF9leHBlY3RhdGlvbnNfb3ZlcnJpZGVzKCkKKyAg ICAgICAgc2VsZi5hc3NlcnRFcXVhbChhY3R1YWxfY2hyb21lX292ZXJyaWRlcywKKyAgICAgICAg ICAgICAgICAgICAgICAgICBleHBlY3RlZF9jaHJvbWl1bV9vdmVycmlkZXMgKyBleHBlY3RlZF9j aHJvbWVfb3ZlcnJpZGVzKQogCiAKIGlmIF9fbmFtZV9fID09ICdfX21haW5fXyc6Cg==