52745 2011-01-19 14:24:31 -0800 Chromium builders don't delete unversioned directories when DEPS change 2011-01-20 04:16:28 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth commit-queue tony oldest_to_newest 336797 0 abarth 2011-01-19 14:24:31 -0800 Chromium builders don't delete unversioned directories when DEPS change 336801 1 79483 abarth 2011-01-19 14:26:19 -0800 Created attachment 79483 Patch 336809 2 79483 tony 2011-01-19 14:31:48 -0800 Comment on attachment 79483 Patch I'm not 100% convinced we should just be piggy backing off of --force here. It could result in losing work if a directory moves out from under you. Maybe that's rare enough and since the user already passed in a flag that it's not a big deal? 336810 3 79483 tony 2011-01-19 14:32:54 -0800 Comment on attachment 79483 Patch I guess it's ok, but if someone loses data, I'm going to direct them to you :) 336828 4 abarth 2011-01-19 14:45:17 -0800 IMHO, if you're passing the --force flag, you shouldn't be surprised if something bad happens, but maybe that's just because I've been abused by git for too long. :) 336831 5 tony 2011-01-19 14:48:11 -0800 (In reply to comment #4) > IMHO, if you're passing the --force flag, you shouldn't be surprised if something bad happens, but maybe that's just because I've been abused by git for too long. :) I agree, but it's weird to have different semantics for --force depending on whether you're in chromium or webkit. 337107 6 79483 abarth 2011-01-19 21:20:44 -0800 Comment on attachment 79483 Patch Ok. I think I can stand behind update-webkit-chromium not being the same as gclient sync as well as --force leading to dataloss. We'll see how I feel when someone is sad later. :( 337250 7 79483 commit-queue 2011-01-20 04:16:21 -0800 Comment on attachment 79483 Patch Clearing flags on attachment: 79483 Committed r76222: <http://trac.webkit.org/changeset/76222> 337251 8 commit-queue 2011-01-20 04:16:28 -0800 All reviewed patches have been landed. Closing bug. 79483 2011-01-19 14:26:19 -0800 2011-01-20 04:16:21 -0800 Patch bug-52745-20110119142617.patch text/plain 1293 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc2MTYyKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTcgQEAKKzIwMTEtMDEtMTkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaHJvbWl1bSBi dWlsZGVycyBkb24ndCBkZWxldGUgdW52ZXJzaW9uZWQgZGlyZWN0b3JpZXMgd2hlbiBERVBTIGNo YW5nZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI3 NDUKKworICAgICAgICBJZiB3ZSBwYXNzIHRoaXMgb3B0aW9uIHRvIGdjbGllbnQgc3luYywgZ2Ns aWVudCB3aWxsIGRlbGV0ZSBkaXJlY3RvcmllcworICAgICAgICB0aGF0IGFyZSBubyBsb25nZXIg cGFydCBvZiBERVBTIGluc3RlYWQgb2YgbGVhdmluZyB0aGVtIGFyb3VuZCB0bworICAgICAgICBj b25mdXNlIHVzIGxhdGVyLiAgQXBwYXJlbnRseSwgdGhlIGRvd25zdHJlYW0gYnVpbGRib3RzIHVz ZSB0aGlzIG9wdGlvbgorICAgICAgICBhbHJlYWR5LgorCisgICAgICAgICogU2NyaXB0cy91cGRh dGUtd2Via2l0LWNocm9taXVtOgorCiAyMDExLTAxLTE5ICBEaXJrIFByYW5rZSAgPGRwcmFua2VA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9qYW4gVmFmYWkuCkluZGV4OiBU b29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQtY2hyb21pdW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv U2NyaXB0cy91cGRhdGUtd2Via2l0LWNocm9taXVtCShyZXZpc2lvbiA3NjE1NikKKysrIFRvb2xz L1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1jaHJvbWl1bQkod29ya2luZyBjb3B5KQpAQCAtNjUsNCAr NjUsNSBAQCBHZXRPcHRpb25zKAogcHJpbnQgIlVwZGF0aW5nIGNocm9taXVtIHBvcnQgZGVwZW5k ZW5jaWVzIHVzaW5nIGdjbGllbnQuLi5cbiI7CiBteSBAZ2NsaWVudEFyZ3MgPSAoJGdjbGllbnRQ YXRoLCAic3luYyIpOwogcHVzaCBAZ2NsaWVudEFyZ3MsICItLWZvcmNlIiBpZiAkZm9yY2U7Citw dXNoIEBnY2xpZW50QXJncywgIi0tZGVsZXRlX3VudmVyc2lvbmVkX3RyZWVzIiBpZiAkZm9yY2U7 CiBzeXN0ZW0oQGdjbGllbnRBcmdzKSA9PSAwIG9yIGRpZSAkITsK