52733 2011-01-19 12:29:27 -0800 [Qt] Fix Layering violation in MediaPlayerPrivateQt... 2011-01-20 10:24:31 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED P5 Minor --- 0 adawit webkit-unassigned commit-queue oldest_to_newest 336704 0 adawit 2011-01-19 12:29:27 -0800 The attached patch is inteded to fix a layering violation, usage of FrameLoaderClientQt, in WebCore/platform/graphics/MediaPlayerPrivateQt.cpp. 336709 1 79465 adawit 2011-01-19 12:31:23 -0800 Created attachment 79465 proposed patch... 336844 2 79465 kling 2011-01-19 15:00:55 -0800 Comment on attachment 79465 proposed patch... Patch itself looks good, but we need a ChangeLog entry. 337015 3 79532 adawit 2011-01-19 18:17:48 -0800 Created attachment 79532 proposed patch II... Added missing Changelog. 337065 4 79532 laszlo.gombos 2011-01-19 19:47:32 -0800 Comment on attachment 79532 proposed patch II... View in context: https://bugs.webkit.org/attachment.cgi?id=79532&action=review r- as the ChangeLog needs to be fixed. > Source/WebCore/ChangeLog:5 > + [Qt] Fix Layering violation in MediaPlayerPrivateQt... One dot please. > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) OOPS would need to go - from http://webkit.org/coding/contributing.html The "No new tests. (OOPS!)" line appears if prepare-ChangeLog did not detect the addition of test cases. If your patch does not require test cases (or test cases are not possible), you should include a line stating such. Otherwise all changes require test cases which should be mentioned in the ChangeLog. 337146 5 79554 adawit 2011-01-19 23:21:57 -0800 Created attachment 79554 proposed patch III... Fix changelog file some more... 337202 6 79554 eric 2011-01-20 02:27:59 -0800 Comment on attachment 79554 proposed patch III... OK. Can we remove the include of FrameLoaderClientQt.h? 337339 7 79601 adawit 2011-01-20 07:48:36 -0800 Created attachment 79601 proposed patch IV... Removed the FrameLoaderClientQt.h include... 337424 8 79601 commit-queue 2011-01-20 10:24:27 -0800 Comment on attachment 79601 proposed patch IV... Clearing flags on attachment: 79601 Committed r76265: <http://trac.webkit.org/changeset/76265> 337425 9 commit-queue 2011-01-20 10:24:31 -0800 All reviewed patches have been landed. Closing bug. 79465 2011-01-19 12:31:23 -0800 2011-01-19 18:17:48 -0800 proposed patch... bug_52733_mediaplayerprivateqt_illegal_layering_fix.patch text/plain 1127 adawit ZGlmZiAtLWdpdCBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9NZWRpYVBsYXll clByaXZhdGVRdC5jcHAgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVkaWFQ bGF5ZXJQcml2YXRlUXQuY3BwCmluZGV4IGJlNmY3MzIuLmVmMGE5YjQgMTAwNjQ0Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9NZWRpYVBsYXllclByaXZhdGVRdC5jcHAK KysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L01lZGlhUGxheWVyUHJpdmF0 ZVF0LmNwcApAQCAtMjA1LDEwICsyMDUsMTAgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVRdDo6 Y29tbWl0TG9hZChjb25zdCBTdHJpbmcmIHVybCkKIAogICAgICAgICAvLyBHcmFiIHRoZSBmcmFt ZSBhbmQgbmV0d29yayBtYW5hZ2VyCiAgICAgICAgIEZyYW1lKiBmcmFtZSA9IGRvY3VtZW50ID8g ZG9jdW1lbnQtPmZyYW1lKCkgOiAwOwotICAgICAgICBRTmV0d29ya0FjY2Vzc01hbmFnZXIqIG1h bmFnZXIgPSBmcmFtZSA/IGZyYW1lLT5sb2FkZXIoKS0+bmV0d29ya2luZ0NvbnRleHQoKS0+bmV0 d29ya0FjY2Vzc01hbmFnZXIoKSA6IDA7Ci0gICAgICAgIEZyYW1lTG9hZGVyQ2xpZW50UXQqIGZy YW1lTG9hZGVyID0gIGZyYW1lID8gc3RhdGljX2Nhc3Q8RnJhbWVMb2FkZXJDbGllbnRRdCo+KGZy YW1lLT5sb2FkZXIoKS0+Y2xpZW50KCkpIDogMDsKKyAgICAgICAgRnJhbWVMb2FkZXIqIGZyYW1l TG9hZGVyID0gZnJhbWUgPyBmcmFtZS0+bG9hZGVyKCkgOiAwOworICAgICAgICBRTmV0d29ya0Fj Y2Vzc01hbmFnZXIqIG1hbmFnZXIgPSBmcmFtZUxvYWRlciA/IGZyYW1lTG9hZGVyLT5uZXR3b3Jr aW5nQ29udGV4dCgpLT5uZXR3b3JrQWNjZXNzTWFuYWdlcigpIDogMDsKIAotICAgICAgICBpZiAo ZG9jdW1lbnQgJiYgbWFuYWdlcikgeworICAgICAgICBpZiAobWFuYWdlcikgewogICAgICAgICAg ICAgLy8gU2V0IHRoZSBjb29raWVzCiAgICAgICAgICAgICBRdE5BTVRocmVhZFNhZmVQcm94eSBt YW5hZ2VyUHJveHkobWFuYWdlcik7CiAgICAgICAgICAgICBRTGlzdDxRTmV0d29ya0Nvb2tpZT4g Y29va2llcyA9IG1hbmFnZXJQcm94eS5jb29raWVzRm9yVXJsKHJVcmwpOwo= 79532 2011-01-19 18:17:48 -0800 2011-01-19 23:21:57 -0800 proposed patch II... bug_52733_mediaplayerprivateqt_illegal_layering_fix.patch text/plain 1749 adawit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhM2U1ZGM4Li41M2E3ODAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDEtMTkgIERhd2l0IEFsZW1heWVodSAgPGFkYXdpdEBrZGUub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRml4IExheWVy aW5nIHZpb2xhdGlvbiBpbiBNZWRpYVBsYXllclByaXZhdGVRdC4uLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI3MzMKKworICAgICAgICBObyBuZXcg dGVzdHMuIChPT1BTISkKKworICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVkaWFQbGF5 ZXJQcml2YXRlUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlUXQ6 OmNvbW1pdExvYWQpOgorCiAyMDExLTAxLTE4IE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2ds ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUnlvc3VrZSBOaXdhLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVkaWFQbGF5ZXJQcml2YXRlUXQu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVkaWFQbGF5ZXJQcml2 YXRlUXQuY3BwCmluZGV4IGJlNmY3MzIuLmVmMGE5YjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L01lZGlhUGxheWVyUHJpdmF0ZVF0LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9NZWRpYVBsYXllclByaXZhdGVRdC5j cHAKQEAgLTIwNSwxMCArMjA1LDEwIEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlUXQ6OmNvbW1p dExvYWQoY29uc3QgU3RyaW5nJiB1cmwpCiAKICAgICAgICAgLy8gR3JhYiB0aGUgZnJhbWUgYW5k IG5ldHdvcmsgbWFuYWdlcgogICAgICAgICBGcmFtZSogZnJhbWUgPSBkb2N1bWVudCA/IGRvY3Vt ZW50LT5mcmFtZSgpIDogMDsKLSAgICAgICAgUU5ldHdvcmtBY2Nlc3NNYW5hZ2VyKiBtYW5hZ2Vy ID0gZnJhbWUgPyBmcmFtZS0+bG9hZGVyKCktPm5ldHdvcmtpbmdDb250ZXh0KCktPm5ldHdvcmtB Y2Nlc3NNYW5hZ2VyKCkgOiAwOwotICAgICAgICBGcmFtZUxvYWRlckNsaWVudFF0KiBmcmFtZUxv YWRlciA9ICBmcmFtZSA/IHN0YXRpY19jYXN0PEZyYW1lTG9hZGVyQ2xpZW50UXQqPihmcmFtZS0+ bG9hZGVyKCktPmNsaWVudCgpKSA6IDA7CisgICAgICAgIEZyYW1lTG9hZGVyKiBmcmFtZUxvYWRl ciA9IGZyYW1lID8gZnJhbWUtPmxvYWRlcigpIDogMDsKKyAgICAgICAgUU5ldHdvcmtBY2Nlc3NN YW5hZ2VyKiBtYW5hZ2VyID0gZnJhbWVMb2FkZXIgPyBmcmFtZUxvYWRlci0+bmV0d29ya2luZ0Nv bnRleHQoKS0+bmV0d29ya0FjY2Vzc01hbmFnZXIoKSA6IDA7CiAKLSAgICAgICAgaWYgKGRvY3Vt ZW50ICYmIG1hbmFnZXIpIHsKKyAgICAgICAgaWYgKG1hbmFnZXIpIHsKICAgICAgICAgICAgIC8v IFNldCB0aGUgY29va2llcwogICAgICAgICAgICAgUXROQU1UaHJlYWRTYWZlUHJveHkgbWFuYWdl clByb3h5KG1hbmFnZXIpOwogICAgICAgICAgICAgUUxpc3Q8UU5ldHdvcmtDb29raWU+IGNvb2tp ZXMgPSBtYW5hZ2VyUHJveHkuY29va2llc0ZvclVybChyVXJsKTsK 79554 2011-01-19 23:21:57 -0800 2011-01-20 07:48:36 -0800 proposed patch III... bug_52733_mediaplayerprivateqt_illegal_layering_fix.patch text/plain 1761 adawit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhM2U1ZGM4Li4wZGI4ZTQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDEtMTkgIERhd2l0IEFsZW1heWVodSAgPGFkYXdpdEBrZGUub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRml4IExheWVy aW5nIHZpb2xhdGlvbiBpbiBNZWRpYVBsYXllclByaXZhdGVRdC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyNzMzCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLiBubyBiZWhhdmlvcmFsIGNoYW5nZS4KKworICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv cXQvTWVkaWFQbGF5ZXJQcml2YXRlUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5 ZXJQcml2YXRlUXQ6OmNvbW1pdExvYWQpOgorCiAyMDExLTAxLTE4IE1PUklUQSBIYWppbWUgIDxt b3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUnlvc3VrZSBOaXdhLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVkaWFQbGF5 ZXJQcml2YXRlUXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVk aWFQbGF5ZXJQcml2YXRlUXQuY3BwCmluZGV4IGJlNmY3MzIuLmVmMGE5YjQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L01lZGlhUGxheWVyUHJpdmF0ZVF0 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9NZWRpYVBsYXll clByaXZhdGVRdC5jcHAKQEAgLTIwNSwxMCArMjA1LDEwIEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2 YXRlUXQ6OmNvbW1pdExvYWQoY29uc3QgU3RyaW5nJiB1cmwpCiAKICAgICAgICAgLy8gR3JhYiB0 aGUgZnJhbWUgYW5kIG5ldHdvcmsgbWFuYWdlcgogICAgICAgICBGcmFtZSogZnJhbWUgPSBkb2N1 bWVudCA/IGRvY3VtZW50LT5mcmFtZSgpIDogMDsKLSAgICAgICAgUU5ldHdvcmtBY2Nlc3NNYW5h Z2VyKiBtYW5hZ2VyID0gZnJhbWUgPyBmcmFtZS0+bG9hZGVyKCktPm5ldHdvcmtpbmdDb250ZXh0 KCktPm5ldHdvcmtBY2Nlc3NNYW5hZ2VyKCkgOiAwOwotICAgICAgICBGcmFtZUxvYWRlckNsaWVu dFF0KiBmcmFtZUxvYWRlciA9ICBmcmFtZSA/IHN0YXRpY19jYXN0PEZyYW1lTG9hZGVyQ2xpZW50 UXQqPihmcmFtZS0+bG9hZGVyKCktPmNsaWVudCgpKSA6IDA7CisgICAgICAgIEZyYW1lTG9hZGVy KiBmcmFtZUxvYWRlciA9IGZyYW1lID8gZnJhbWUtPmxvYWRlcigpIDogMDsKKyAgICAgICAgUU5l dHdvcmtBY2Nlc3NNYW5hZ2VyKiBtYW5hZ2VyID0gZnJhbWVMb2FkZXIgPyBmcmFtZUxvYWRlci0+ bmV0d29ya2luZ0NvbnRleHQoKS0+bmV0d29ya0FjY2Vzc01hbmFnZXIoKSA6IDA7CiAKLSAgICAg ICAgaWYgKGRvY3VtZW50ICYmIG1hbmFnZXIpIHsKKyAgICAgICAgaWYgKG1hbmFnZXIpIHsKICAg ICAgICAgICAgIC8vIFNldCB0aGUgY29va2llcwogICAgICAgICAgICAgUXROQU1UaHJlYWRTYWZl UHJveHkgbWFuYWdlclByb3h5KG1hbmFnZXIpOwogICAgICAgICAgICAgUUxpc3Q8UU5ldHdvcmtD b29raWU+IGNvb2tpZXMgPSBtYW5hZ2VyUHJveHkuY29va2llc0ZvclVybChyVXJsKTsK 79601 2011-01-20 07:48:36 -0800 2011-01-20 10:24:27 -0800 proposed patch IV... bug_52733_mediaplayerprivateqt_illegal_layering_fix.patch text/plain 1956 adawit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhM2U1ZGM4Li4wZGI4ZTQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDEtMTkgIERhd2l0IEFsZW1heWVodSAgPGFkYXdpdEBrZGUub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRml4IExheWVy aW5nIHZpb2xhdGlvbiBpbiBNZWRpYVBsYXllclByaXZhdGVRdC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyNzMzCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLiBubyBiZWhhdmlvcmFsIGNoYW5nZS4KKworICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv cXQvTWVkaWFQbGF5ZXJQcml2YXRlUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5 ZXJQcml2YXRlUXQ6OmNvbW1pdExvYWQpOgorCiAyMDExLTAxLTE4IE1PUklUQSBIYWppbWUgIDxt b3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUnlvc3VrZSBOaXdhLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVkaWFQbGF5 ZXJQcml2YXRlUXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVk aWFQbGF5ZXJQcml2YXRlUXQuY3BwCmluZGV4IGJlNmY3MzIuLjBhNGMwZjYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L01lZGlhUGxheWVyUHJpdmF0ZVF0 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9NZWRpYVBsYXll clByaXZhdGVRdC5jcHAKQEAgLTIwLDcgKzIwLDYgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNp bmNsdWRlICJNZWRpYVBsYXllclByaXZhdGVRdC5oIgogCi0jaW5jbHVkZSAiRnJhbWVMb2FkZXJD bGllbnRRdC5oIgogI2luY2x1ZGUgIkZyYW1lVmlldy5oIgogI2luY2x1ZGUgIkdyYXBoaWNzQ29u dGV4dC5oIgogI2luY2x1ZGUgIkhUTUxNZWRpYUVsZW1lbnQuaCIKQEAgLTIwNSwxMCArMjA0LDEw IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlUXQ6OmNvbW1pdExvYWQoY29uc3QgU3RyaW5nJiB1 cmwpCiAKICAgICAgICAgLy8gR3JhYiB0aGUgZnJhbWUgYW5kIG5ldHdvcmsgbWFuYWdlcgogICAg ICAgICBGcmFtZSogZnJhbWUgPSBkb2N1bWVudCA/IGRvY3VtZW50LT5mcmFtZSgpIDogMDsKLSAg ICAgICAgUU5ldHdvcmtBY2Nlc3NNYW5hZ2VyKiBtYW5hZ2VyID0gZnJhbWUgPyBmcmFtZS0+bG9h ZGVyKCktPm5ldHdvcmtpbmdDb250ZXh0KCktPm5ldHdvcmtBY2Nlc3NNYW5hZ2VyKCkgOiAwOwot ICAgICAgICBGcmFtZUxvYWRlckNsaWVudFF0KiBmcmFtZUxvYWRlciA9ICBmcmFtZSA/IHN0YXRp Y19jYXN0PEZyYW1lTG9hZGVyQ2xpZW50UXQqPihmcmFtZS0+bG9hZGVyKCktPmNsaWVudCgpKSA6 IDA7CisgICAgICAgIEZyYW1lTG9hZGVyKiBmcmFtZUxvYWRlciA9IGZyYW1lID8gZnJhbWUtPmxv YWRlcigpIDogMDsKKyAgICAgICAgUU5ldHdvcmtBY2Nlc3NNYW5hZ2VyKiBtYW5hZ2VyID0gZnJh bWVMb2FkZXIgPyBmcmFtZUxvYWRlci0+bmV0d29ya2luZ0NvbnRleHQoKS0+bmV0d29ya0FjY2Vz c01hbmFnZXIoKSA6IDA7CiAKLSAgICAgICAgaWYgKGRvY3VtZW50ICYmIG1hbmFnZXIpIHsKKyAg ICAgICAgaWYgKG1hbmFnZXIpIHsKICAgICAgICAgICAgIC8vIFNldCB0aGUgY29va2llcwogICAg ICAgICAgICAgUXROQU1UaHJlYWRTYWZlUHJveHkgbWFuYWdlclByb3h5KG1hbmFnZXIpOwogICAg ICAgICAgICAgUUxpc3Q8UU5ldHdvcmtDb29raWU+IGNvb2tpZXMgPSBtYW5hZ2VyUHJveHkuY29v a2llc0ZvclVybChyVXJsKTsK