52727 2011-01-19 10:26:35 -0800 Throttle sending of SetSize messages 2011-01-19 10:36:52 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca darin oldest_to_newest 336612 0 andersca 2011-01-19 10:26:35 -0800 Throttle sending of SetSize messages 336613 1 79445 andersca 2011-01-19 10:27:34 -0800 Created attachment 79445 Patch 336620 2 79445 darin 2011-01-19 10:33:26 -0800 Comment on attachment 79445 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79445&action=review > Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:113 > + // FIXME: Send a new SetSize message if needed. Is it really OK to land without this? 336622 3 andersca 2011-01-19 10:36:27 -0800 (In reply to comment #2) > (From update of attachment 79445 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=79445&action=review > > > Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:113 > > + // FIXME: Send a new SetSize message if needed. > > Is it really OK to land without this? The new drawing area is currently opt-in by setting an environment variable so yes. 336623 4 andersca 2011-01-19 10:36:52 -0800 Committed r76139: <http://trac.webkit.org/changeset/76139> 79445 2011-01-19 10:27:34 -0800 2011-01-19 10:33:26 -0800 Patch bug-52727-20110119102733.patch text/plain 2856 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2MTM1KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDEtMTkgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaHJvdHRsZSBzZW5kaW5nIG9mIFNldFNpemUgbWVzc2Fn ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyNzI3 CisKKyAgICAgICAgKiBVSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94eUltcGwuY3BwOgorICAgICAg ICAoV2ViS2l0OjpEcmF3aW5nQXJlYVByb3h5SW1wbDo6RHJhd2luZ0FyZWFQcm94eUltcGwpOgor ICAgICAgICBJbml0aWFsaXplIG1faXNXYWl0aW5nRm9yRGlkU2V0U2l6ZSB0byBmYWxzZS4KKwor ICAgICAgICAoV2ViS2l0OjpEcmF3aW5nQXJlYVByb3h5SW1wbDo6ZGlkU2V0U2l6ZSk6CisgICAg ICAgIE51bGwgb3V0IHRoZSBiYWNraW5nIHN0b3JlLgorCisgICAgICAgIChXZWJLaXQ6OkRyYXdp bmdBcmVhUHJveHlJbXBsOjpzZW5kU2V0U2l6ZSk6CisgICAgICAgIElmIG1faXNXYWl0aW5nRm9y RGlkU2V0U2l6ZSBpcyB0cnVlLCBkbyBub3RoaW5nLiBPdGhlcndpc2UsIHNldCBtX2lzV2FpdGlu Z0ZvckRpZFNldFNpemUKKyAgICAgICAgdG8gdHJ1ZSBhbmQgc2VuZCBhIFNldFNpemUgbWVzc2Fn ZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5SW1wbC5oOgorICAgICAg ICBBZGQgbV9pc1dhaXRpbmdGb3JEaWRTZXRTaXplLgorCiAyMDExLTAxLTE5ICBBbmRlcnMgQ2Fy bHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4g QWRsZXIuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94eUlt cGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9EcmF3aW5nQXJl YVByb3h5SW1wbC5jcHAJKHJldmlzaW9uIDc2MTI5KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0RyYXdpbmdBcmVhUHJveHlJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDUsNiArNDUs NyBAQCBQYXNzT3duUHRyPERyYXdpbmdBcmVhUHJveHlJbXBsPiBEcmF3aW5nCiAKIERyYXdpbmdB cmVhUHJveHlJbXBsOjpEcmF3aW5nQXJlYVByb3h5SW1wbChXZWJQYWdlUHJveHkqIHdlYlBhZ2VQ cm94eSkKICAgICA6IERyYXdpbmdBcmVhUHJveHkoRHJhd2luZ0FyZWFJbmZvOjpJbXBsLCB3ZWJQ YWdlUHJveHkpCisgICAgLCBtX2lzV2FpdGluZ0ZvckRpZFNldFNpemUoZmFsc2UpCiB7CiB9CiAK QEAgLTEwNiw2ICsxMDcsMTIgQEAgdm9pZCBEcmF3aW5nQXJlYVByb3h5SW1wbDo6dXBkYXRlKGNv bnN0IAogCiB2b2lkIERyYXdpbmdBcmVhUHJveHlJbXBsOjpkaWRTZXRTaXplKCkKIHsKKyAgICBB U1NFUlQobV9pc1dhaXRpbmdGb3JEaWRTZXRTaXplKTsKKyAgICBtX2lzV2FpdGluZ0ZvckRpZFNl dFNpemUgPSBmYWxzZTsKKworICAgIC8vIEZJWE1FOiBTZW5kIGEgbmV3IFNldFNpemUgbWVzc2Fn ZSBpZiBuZWVkZWQuCisKKyAgICBtX2JhY2tpbmdTdG9yZSA9IG51bGxwdHI7CiB9CiAKIHZvaWQg RHJhd2luZ0FyZWFQcm94eUltcGw6OmluY29ycG9yYXRlVXBkYXRlKGNvbnN0IFVwZGF0ZUluZm8m IHVwZGF0ZUluZm8pCkBAIC0xMzQsNiArMTQxLDEwIEBAIHZvaWQgRHJhd2luZ0FyZWFQcm94eUlt cGw6OnNlbmRTZXRTaXplKCkKICAgICBpZiAoIW1fd2ViUGFnZVByb3h5LT5pc1ZhbGlkKCkpCiAg ICAgICAgIHJldHVybjsKIAorICAgIGlmIChtX2lzV2FpdGluZ0ZvckRpZFNldFNpemUpCisgICAg ICAgIHJldHVybjsKKworICAgIG1faXNXYWl0aW5nRm9yRGlkU2V0U2l6ZSA9IHRydWU7CiAgICAg bV93ZWJQYWdlUHJveHktPnByb2Nlc3MoKS0+c2VuZChNZXNzYWdlczo6RHJhd2luZ0FyZWE6OlNl dFNpemUobV9zaXplKSwgbV93ZWJQYWdlUHJveHktPnBhZ2VJRCgpKTsKIH0KIApJbmRleDogU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHlJbXBsLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHlJbXBsLmgJKHJldmlz aW9uIDc2MTI5KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHlJ bXBsLmgJKHdvcmtpbmcgY29weSkKQEAgLTU3LDYgKzU3LDEwIEBAIHByaXZhdGU6CiAgICAgdm9p ZCBpbmNvcnBvcmF0ZVVwZGF0ZShjb25zdCBVcGRhdGVJbmZvJik7CiAgICAgdm9pZCBzZW5kU2V0 U2l6ZSgpOwogCisgICAgLy8gV2hldGhlciB3ZSd2ZSBzZW50IGEgU2V0U2l6ZSBtZXNzYWdlIGFu ZCBhcmUgbm93IHdhaXRpbmcgZm9yIGEgRGlkU2V0U2l6ZSBtZXNzYWdlLgorICAgIC8vIFVzZWQg dG8gdGhyb3R0bGUgU2V0U2l6ZSBtZXNzYWdlcyBzbyB3ZSBkb24ndCBzZW5kIHRoZW0gZmFzdGVy IHRoYW4gdGhlIFdlYiBwcm9jZXNzIGNhbiBoYW5kbGUuCisgICAgYm9vbCBtX2lzV2FpdGluZ0Zv ckRpZFNldFNpemU7CisKICAgICBPd25QdHI8QmFja2luZ1N0b3JlPiBtX2JhY2tpbmdTdG9yZTsK IH07CiAK