52702 2011-01-18 23:35:56 -0800 [GTK] No need to invalidate empty areas in ChromeClient::invalidateContentsAndWindow 2011-01-19 10:52:59 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P3 Normal --- 0 joone webkit-unassigned cgarcia commit-queue eric gustavo mrobinson xan.lopez oldest_to_newest 336360 0 joone 2011-01-18 23:35:56 -0800 When rendering a web page, WebKitGtk+ invalidates empty areas too much. It causes unnecessary calls to GDK. 336365 1 79397 joone 2011-01-19 00:01:21 -0800 Created attachment 79397 Proposed Patch 336402 2 cgarcia 2011-01-19 01:56:18 -0800 gdk_window_invalidate_rect() doesn't check whether the rectangle is empty, so the patch makes sense to me. 336404 3 79397 kling 2011-01-19 02:06:53 -0800 Comment on attachment 79397 Proposed Patch r=me 336442 4 79397 commit-queue 2011-01-19 05:39:20 -0800 Comment on attachment 79397 Proposed Patch Rejecting attachment 79397 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'bu..." exit_code: 2 Last 500 characters of output: ests/css .... http/tests/eventsource ....... http/tests/eventsource/workers . http/tests/globalhistory .... http/tests/history ............................. http/tests/incremental ...... http/tests/inspector-enabled . http/tests/inspector ...... http/tests/inspector/extensions-resources-redirect.html -> failed Exiting early after 1 failures. 21479 tests run. 418.29s total testing time 21478 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 11 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/7615202 336517 5 joone 2011-01-19 07:36:45 -0800 The above test fail is not relevant to this patch. You can see the automatically generated bug from the commit-queue. https://bugs.webkit.org/show_bug.cgi?id=52709 336583 6 79397 commit-queue 2011-01-19 09:48:09 -0800 Comment on attachment 79397 Proposed Patch Clearing flags on attachment: 79397 Committed r76130: <http://trac.webkit.org/changeset/76130> 336584 7 commit-queue 2011-01-19 09:48:14 -0800 All reviewed patches have been landed. Closing bug. 336639 8 eric 2011-01-19 10:52:59 -0800 (In reply to comment #5) > The above test fail is not relevant to this patch. > You can see the automatically generated bug from the commit-queue. > https://bugs.webkit.org/show_bug.cgi?id=52709 Thanks. The commit-queue runs the tests 3 times. Twice with your patch and once w/o (if the first two runs failed). In this case, the flaky test failed both times when you patch was applied, and then didn't fail when the tests ran w/o your patch. So the queue had no choice but to (wrongly) assume it was your patch at fault. Such is the cost of flaky tests! Hopefully folks will continue to whittle down the number of flaky tests in the tree. http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py#L214 79397 2011-01-19 00:01:21 -0800 2011-01-19 09:48:09 -0800 Proposed Patch updatedRect.patch text/plain 1460 joone ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Z3RrL0NoYW5nZUxvZwppbmRleCBlZjFmMmFhLi5iODZlM2I1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDEtMTggIEpvb25lIEh1ciAgPGpvb25lLmh1ckBjb2xsYWJv cmEuY28udWs+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW0dUS10gTm8gbmVlZCB0byBpbnZhbGlkYXRlIGVtcHR5IGFyZWFzIGluIENocm9tZUNsaWVu dDo6aW52YWxpZGF0ZUNvbnRlbnRzQW5kV2luZG93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjcwMgorCisgICAgICAgIERvbid0IGNhbGwgZ2RrX3dp bmRvd19pbnZhbGlkYXRlX3JlY3QgaWYgYW4gdXBkYXRlZCByZWN0YW5nbGUgaXMgZW1wdHkuCisK KyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwOgorICAgICAgICAo V2ViS2l0OjpDaHJvbWVDbGllbnQ6OmludmFsaWRhdGVDb250ZW50c0FuZFdpbmRvdyk6IAorCiAy MDExLTAxLTE3ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAg ICAgICBVbnJldmlld2VkLCBidWlsZCBmaXggZm9yIDIgR1RLIHRlc3RzIGh0bWwgZmlsZSBwYXRo cy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNs aWVudEd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGll bnRHdGsuY3BwCmluZGV4IDhiNmE0ODMuLjA0ZWU4YmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHAKKysrIGIvU291cmNlL1dl YktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcApAQCAtMzc3LDcgKzM3 Nyw3IEBAIHZvaWQgQ2hyb21lQ2xpZW50OjppbnZhbGlkYXRlQ29udGVudHNBbmRXaW5kb3coY29u c3QgSW50UmVjdCYgdXBkYXRlUmVjdCwgYm9vbCBpCiAgICAgR2RrUmVjdGFuZ2xlIHJlY3QgPSB1 cGRhdGVSZWN0OwogICAgIEdka1dpbmRvdyogd2luZG93ID0gZ3RrX3dpZGdldF9nZXRfd2luZG93 KEdUS19XSURHRVQobV93ZWJWaWV3KSk7CiAKLSAgICBpZiAod2luZG93KSB7CisgICAgaWYgKHdp bmRvdyAmJiAhdXBkYXRlUmVjdC5pc0VtcHR5KCkpIHsKICAgICAgICAgZ2RrX3dpbmRvd19pbnZh bGlkYXRlX3JlY3Qod2luZG93LCAmcmVjdCwgRkFMU0UpOwogICAgICAgICAvLyBXZSBkb24ndCBj dXJyZW50bHkgZG8gaW1tZWRpYXRlIHVwZGF0ZXMgc2luY2UgdGhleSBkZWxheSBvdGhlciBVSSBl bGVtZW50cy4KICAgICAgICAgLy9pZiAoaW1tZWRpYXRlKQo=