52694 2011-01-18 18:33:00 -0800 new-run-webkit-tests: add a --build-directory command line argument 2011-01-18 21:15:20 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke chase eric mihaip ojan tony oldest_to_newest 336280 0 dpranke 2011-01-18 18:33:00 -0800 new-run-webkit-tests: add a --build-directory command line argument 336282 1 79379 dpranke 2011-01-18 18:35:01 -0800 Created attachment 79379 Patch 336310 2 79379 tony 2011-01-18 19:54:07 -0800 Comment on attachment 79379 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79379&action=review > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:281 > + optparse.make_option("--build-directory", > + help="Absolute path to the directory under which build files are kept (should not include configuration)"), Does it have to be absolute? Won't paths relative to where NRWT is run from work? 336327 3 dpranke 2011-01-18 21:09:47 -0800 (In reply to comment #2) > (From update of attachment 79379 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=79379&action=review > > > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:281 > > + optparse.make_option("--build-directory", > > + help="Absolute path to the directory under which build files are kept (should not include configuration)"), > > Does it have to be absolute? Won't paths relative to where NRWT is run from work? Yeah, technically relative paths would work, too. I'll fix the comment when I land the patch. 336328 4 dpranke 2011-01-18 21:15:20 -0800 Committed r76101: <http://trac.webkit.org/changeset/76101> 79379 2011-01-18 18:35:01 -0800 2011-01-18 19:54:07 -0800 Patch bug-52694-20110118183500.patch text/plain 4610 dpranke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4Y2Jm Y2MzZWIwYzA0NzljM2JkMGEzODgwNWJiYzY1YWYwNDJjYmQ1Li4xMjY0MzY3ODk5MWE5MWQ1YTM5 Y2UyNWI5NWEwYzJlZDFmMTE3Nzk3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMDEtMTggIERpcmsgUHJhbmtl ICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgbmV3LXJ1bi13ZWJraXQtdGVzdHM6IGFkZCBhIC0tYnVpbGQtZGly ZWN0b3J5IGNvbW1hbmQgbGluZSBhcmd1bWVudAorCisgICAgICAgIE9mZmljaWFsIEdvb2dsZSBD aHJvbWUgYnVpbGRzIHVzZSBhIG5vbi1zdGFuZGFyZCBidWlsZCBkaXJlY3RvcnkKKyAgICAgICAg bG9jYXRpb24uIFRoaXMgcGF0Y2ggYWRkcyBhIC0tYnVpbGQtZGlyZWN0b3J5IGFyZ3VtZW50IHRo YXQKKyAgICAgICAgYWxsb3dzIHRoYXQgbG9jYXRpb24gdG8gYmUgc3BlY2lmaWVkIG9uIHRoZSBj b21tYW5kIGxpbmUuIE9ubHkKKyAgICAgICAgQ2hyb21pdW0tYmFzZWQgYnVpbGRzIHdpbGwgdXNl IHRoaXMgZmxhZyBmb3Igbm93LCBidXQgYW55b25lIGNhbgorICAgICAgICBpbiB0aGUgZnV0dXJl LgorCisgICAgICAgIFRoZXJlIGFyZSBubyB1bml0IHRlc3RzIGZvciB0aGlzIHNpbmNlIGl0J3Mg ZGlmZmljdWx0IHRvIHRlc3QKKyAgICAgICAgdW50aWwgbW9jayBmaWxlc3lzdGVtcyBhcmUgZnVs bHkgc3VwcG9ydGVkIGluIHRoZSBjb2RlLiBUaGlzIHdhcworICAgICAgICB0ZXN0ZWQgYnkgaGFu ZCBmb3Igbm93LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD01MjY5NAorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC9jaHJvbWl1bV9saW51eC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L2Nocm9taXVtX21hYy5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX3dpbi5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5OgorCiAyMDExLTAxLTE4ICBNaWhh aSBQYXJwYXJpdGEgIDxtaWhhaXBAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEtlbnQgVGFtdXJhLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9jaHJvbWl1bV9saW51eC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbGludXgucHkKaW5kZXggNWQ5ZGQ4NzRhOWRmYmNmYmIx YTIzOWFhMDRjYWE5NGNhZTI2MDBhNy4uNzk3NDFiMmVjOTRmZDg2YjRlNzUxMjQ3YjgzOTQzNTg2 NjZlOGJmNiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9jaHJvbWl1bV9saW51eC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L2Nocm9taXVtX2xpbnV4LnB5CkBAIC03OCw2ICs3OCwxMCBAQCBjbGFzcyBD aHJvbWl1bUxpbnV4UG9ydChjaHJvbWl1bS5DaHJvbWl1bVBvcnQpOgogICAgICMKIAogICAgIGRl ZiBfYnVpbGRfcGF0aChzZWxmLCAqY29tcHMpOgorICAgICAgICBpZiBzZWxmLmdldF9vcHRpb24o J2J1aWxkX2RpcmVjdG9yeScpOgorICAgICAgICAgICAgcmV0dXJuIHNlbGYuX2ZpbGVzeXN0ZW0u am9pbihzZWxmLmdldF9vcHRpb24oJ2J1aWxkX2RpcmVjdG9yeScpLAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAqY29tcHMpCisKICAgICAgICAgYmFzZSA9IHNlbGYu cGF0aF9mcm9tX2Nocm9taXVtX2Jhc2UoKQogICAgICAgICBpZiBvcy5wYXRoLmV4aXN0cyhvcy5w YXRoLmpvaW4oYmFzZSwgJ3Njb25zYnVpbGQnKSk6CiAgICAgICAgICAgICByZXR1cm4gb3MucGF0 aC5qb2luKGJhc2UsICdzY29uc2J1aWxkJywgKmNvbXBzKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9tYWMucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX21hYy5weQppbmRleCA2 ODAyNzA3YzJmMGU5OGUxM2ZlMTE2MGU2MWVjYzQ5MzNlMTNmYjRhLi5iMDhhOTQ4YjQ0OTQ2ZDM4 ZjhiYzY2NTA4ODA0Nzk3ZWEwYjhlNzEzIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX21hYy5weQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX21hYy5weQpAQCAtMTA1LDYgKzEw NSwxMCBAQCBjbGFzcyBDaHJvbWl1bU1hY1BvcnQoY2hyb21pdW0uQ2hyb21pdW1Qb3J0KToKICAg ICAjCiAKICAgICBkZWYgX2J1aWxkX3BhdGgoc2VsZiwgKmNvbXBzKToKKyAgICAgICAgaWYgc2Vs Zi5nZXRfb3B0aW9uKCdidWlsZF9kaXJlY3RvcnknKToKKyAgICAgICAgICAgIHJldHVybiBzZWxm Ll9maWxlc3lzdGVtLmpvaW4oc2VsZi5nZXRfb3B0aW9uKCdidWlsZF9kaXJlY3RvcnknKSwKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKmNvbXBzKQorCiAgICAgICAg IHBhdGggPSBzZWxmLnBhdGhfZnJvbV9jaHJvbWl1bV9iYXNlKCd4Y29kZWJ1aWxkJywgKmNvbXBz KQogICAgICAgICBpZiBvcy5wYXRoLmV4aXN0cyhwYXRoKSBvciBzZWxmLmdldF9vcHRpb24oJ3Vz ZV90ZXN0X3NoZWxsJyk6CiAgICAgICAgICAgICByZXR1cm4gcGF0aApkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV93aW4ucHkgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX3dpbi5weQpp bmRleCBkMDgwZjgyNGQwMTNkMTU1NjcxMzMzZjgyNmMyNzNjNDg0NGQxNmQ5Li4wZmVjYzZkMmQ0 MWE3MTI2YjY2ZGJiYmM2YTAzN2RmMzdlYmI2ZDlkIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX3dpbi5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX3dpbi5weQpAQCAtMTA2 LDYgKzEwNiwxMCBAQCBjbGFzcyBDaHJvbWl1bVdpblBvcnQoY2hyb21pdW0uQ2hyb21pdW1Qb3J0 KToKICAgICAjIFBST1RFQ1RFRCBST1VUSU5FUwogICAgICMKICAgICBkZWYgX2J1aWxkX3BhdGgo c2VsZiwgKmNvbXBzKToKKyAgICAgICAgaWYgc2VsZi5nZXRfb3B0aW9uKCdidWlsZF9kaXJlY3Rv cnknKToKKyAgICAgICAgICAgIHJldHVybiBzZWxmLl9maWxlc3lzdGVtLmpvaW4oc2VsZi5nZXRf b3B0aW9uKCdidWlsZF9kaXJlY3RvcnknKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgKmNvbXBzKQorCiAgICAgICAgIHAgPSBzZWxmLnBhdGhfZnJvbV9jaHJvbWl1 bV9iYXNlKCd3ZWJraXQnLCAqY29tcHMpCiAgICAgICAgIGlmIG9zLnBhdGguZXhpc3RzKHApOgog ICAgICAgICAgICAgcmV0dXJuIHAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CmluZGV4IGExNDE2NjFmZTg1NzRmNzcw OWIyYTY3NWU1NThhZDhkZjZkMDhjN2IuLjAxY2JmYjdkYWMyMDQwNDhhZDFlMTIyOGQ0YmU3ODBm ZWI2MDcxNjcgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3J1bl93ZWJraXRfdGVzdHMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQpAQCAtMjc3LDYgKzI3Nyw4IEBAIGRlZiBwYXJzZV9h cmdzKGFyZ3M9Tm9uZSk6CiAgICAgICAgICAgICBkZWZhdWx0PSJsYXlvdXQtdGVzdC1yZXN1bHRz IiwKICAgICAgICAgICAgIGhlbHA9Ik91dHB1dCByZXN1bHRzIGRpcmVjdG9yeSBzb3VyY2UgZGly LCByZWxhdGl2ZSB0byBEZWJ1ZyBvciAiCiAgICAgICAgICAgICAgICAgICJSZWxlYXNlIiksCisg ICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLWJ1aWxkLWRpcmVjdG9yeSIsCisgICAgICAg ICAgICBoZWxwPSJBYnNvbHV0ZSBwYXRoIHRvIHRoZSBkaXJlY3RvcnkgdW5kZXIgd2hpY2ggYnVp bGQgZmlsZXMgYXJlIGtlcHQgKHNob3VsZCBub3QgaW5jbHVkZSBjb25maWd1cmF0aW9uKSIpLAog ICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1uZXctYmFzZWxpbmUiLCBhY3Rpb249InN0 b3JlX3RydWUiLAogICAgICAgICAgICAgZGVmYXVsdD1GYWxzZSwgaGVscD0iU2F2ZSBhbGwgZ2Vu ZXJhdGVkIHJlc3VsdHMgYXMgbmV3IGJhc2VsaW5lcyAiCiAgICAgICAgICAgICAgICAgICJpbnRv IHRoZSBwbGF0Zm9ybSBkaXJlY3RvcnksIG92ZXJ3cml0aW5nIHdoYXRldmVyJ3MgIgo=