52684 2011-01-18 16:56:04 -0800 Don't return void from void function String::split 2011-02-17 00:06:48 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 kalman kalman abarth commit-queue eric webkit.review.bot oldest_to_newest 336216 0 kalman 2011-01-18 16:56:04 -0800 Don't return void from void function String::split 336218 1 79357 kalman 2011-01-18 16:56:51 -0800 Created attachment 79357 Patch 336475 2 79357 commit-queue 2011-01-19 06:27:47 -0800 Comment on attachment 79357 Patch Clearing flags on attachment: 79357 Committed r76121: <http://trac.webkit.org/changeset/76121> 336476 3 commit-queue 2011-01-19 06:27:52 -0800 All reviewed patches have been landed. Closing bug. 336501 4 webkit.review.bot 2011-01-19 07:02:17 -0800 http://trac.webkit.org/changeset/76121 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: http/tests/xmlhttprequest/cross-origin-authorization.html 79357 2011-01-18 16:56:51 -0800 2011-01-19 06:27:47 -0800 Patch bug-52684-20110119115648.patch text/plain 1611 kalman ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDNlNTNlOTZkNjA3ZGEyZDVmNjFkZDlmMmNiMjg2 Zjg4N2Q3ODBlOTYuLmY1N2Q4Yzc3ZmEwY2JjZWZmYWY1YjA2ZjIwZGExMTRjNTM0OTU1M2QgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTAxLTE4ICBCZW5q YW1pbiBLYWxtYW4gIDxrYWxtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvbid0IHJldHVybiB2b2lkIGZyb20gdm9pZCBm dW5jdGlvbiBTdHJpbmc6OnNwbGl0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01MjY4NAorCisgICAgICAgICogd3RmL3RleHQvV1RGU3RyaW5nLmNwcDoK KyAgICAgICAgKFdURjo6U3RyaW5nOjpzcGxpdCk6CisKIDIwMTEtMDEtMTggIERhbmllbCBCYXRl cyAgPGRiYXRlc0ByaW0uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdhdmluIEJhcnJhY2xv dWdoLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1dURlN0cmlu Zy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvV1RGU3RyaW5nLmNwcAppbmRl eCA2YmI3NGY2ZTk3N2VjMmM5ZjZiYmQyOWI1Mzc5NGYzNjdkMDcxOTkzLi40YjZmZjc1OTdkNGNj MTljMmVlZDRiMTRjODA0MjUyNGVkMGY5NjczIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvd3RmL3RleHQvV1RGU3RyaW5nLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv d3RmL3RleHQvV1RGU3RyaW5nLmNwcApAQCAtNjEyLDcgKzYxMiw3IEBAIHZvaWQgU3RyaW5nOjpz cGxpdChjb25zdCBTdHJpbmcmIHNlcGFyYXRvciwgYm9vbCBhbGxvd0VtcHR5RW50cmllcywgVmVj dG9yPFN0cmluCiAKIHZvaWQgU3RyaW5nOjpzcGxpdChjb25zdCBTdHJpbmcmIHNlcGFyYXRvciwg VmVjdG9yPFN0cmluZz4mIHJlc3VsdCkgY29uc3QKIHsKLSAgICByZXR1cm4gc3BsaXQoc2VwYXJh dG9yLCBmYWxzZSwgcmVzdWx0KTsKKyAgICBzcGxpdChzZXBhcmF0b3IsIGZhbHNlLCByZXN1bHQp OwogfQogCiB2b2lkIFN0cmluZzo6c3BsaXQoVUNoYXIgc2VwYXJhdG9yLCBib29sIGFsbG93RW1w dHlFbnRyaWVzLCBWZWN0b3I8U3RyaW5nPiYgcmVzdWx0KSBjb25zdApAQCAtNjMyLDcgKzYzMiw3 IEBAIHZvaWQgU3RyaW5nOjpzcGxpdChVQ2hhciBzZXBhcmF0b3IsIGJvb2wgYWxsb3dFbXB0eUVu dHJpZXMsIFZlY3RvcjxTdHJpbmc+JiByZXN1CiAKIHZvaWQgU3RyaW5nOjpzcGxpdChVQ2hhciBz ZXBhcmF0b3IsIFZlY3RvcjxTdHJpbmc+JiByZXN1bHQpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIHNw bGl0KFN0cmluZygmc2VwYXJhdG9yLCAxKSwgZmFsc2UsIHJlc3VsdCk7CisgICAgc3BsaXQoU3Ry aW5nKCZzZXBhcmF0b3IsIDEpLCBmYWxzZSwgcmVzdWx0KTsKIH0KIAogQ1N0cmluZyBTdHJpbmc6 OmFzY2lpKCkgY29uc3QK