52681 2011-01-18 16:15:26 -0800 [chromium] Fix compositor repaints for offscreen fixed elements 2011-01-22 02:00:27 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 enne enne cmarrin commit-queue enne eric fishd jamesr kbr vangelis oldest_to_newest 336186 0 enne 2011-01-18 16:15:26 -0800 [chromium] Fix compositor repaints for offscreen fixed elements 337597 1 79650 enne 2011-01-20 14:14:50 -0800 Created attachment 79650 Patch 337599 2 enne 2011-01-20 14:16:48 -0800 This bug was causing weird repainting issues on youtube when viewing hardware accelerated video. See: http://crbug.com/69692 337603 3 79650 jamesr 2011-01-20 14:24:04 -0800 Comment on attachment 79650 Patch Can we at least add a test somewhere that would demonstrate the issue, even if it doesn't show the issue in our current test harness? 337606 4 enne 2011-01-20 14:27:05 -0800 (In reply to comment #3) > (From update of attachment 79650 [details]) > Can we at least add a test somewhere that would demonstrate the issue, even if it doesn't show the issue in our current test harness? Sure. I'll admit that I'm reluctant to add a manual test that will almost certainly gather copious amounts of dust, but if you tell me where it should go, I'd be glad to add it to this patch. 337608 5 vangelis 2011-01-20 14:29:06 -0800 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 79650 [details] [details]) > > Can we at least add a test somewhere that would demonstrate the issue, even if it doesn't show the issue in our current test harness? > > Sure. I'll admit that I'm reluctant to add a manual test that will almost certainly gather copious amounts of dust, but if you tell me where it should go, I'd be glad to add it to this patch. Is it not possible to have a pixel test for it and demonstrate it by scrolling the page in JS? 337614 6 jamesr 2011-01-20 14:40:10 -0800 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 79650 [details] [details]) > > Can we at least add a test somewhere that would demonstrate the issue, even if it doesn't show the issue in our current test harness? > > Sure. I'll admit that I'm reluctant to add a manual test that will almost certainly gather copious amounts of dust, but if you tell me where it should go, I'd be glad to add it to this patch. What does the manual test look like? It's probably possible to coerce it into something that we can run in DRT (although it may be tricksy). 337620 7 enne 2011-01-20 14:50:02 -0800 (In reply to comment #5) > Is it not possible to have a pixel test for it and demonstrate it by scrolling the page in JS? I have a page that automatically scrolls and demonstrates this bug in the browser. I've spent a good bit of time unsuccessfully trying to make it work in the test harness. After some information from jamesr, I verified that the FrameView::scrollContentsFastPath code path that I modified doesn't get called in DumpRenderTree. It seems to use FrameView::scrollContentsSlowPath, which always works because everything is invalidated. So, this bug doesn't get triggered when using DumpRenderTree at this point. I can file a bug about improving our test coverage, but I'd prefer to not shave that yak in this patch. 337626 8 79654 enne 2011-01-20 14:55:12 -0800 Created attachment 79654 Manual test I've attached the manual test I created. 337976 9 eric 2011-01-21 03:06:25 -0800 cmarrin likes compositor bugs. :) 338103 10 jamesr 2011-01-21 09:28:31 -0800 (In reply to comment #9) > cmarrin likes compositor bugs. :) This is a chromium compositor bug. 338305 11 79650 jamesr 2011-01-21 13:44:33 -0800 Comment on attachment 79650 Patch R=me. Please consider scripting that manual test and adding it to compositing/, even though it doesn't fail without this patch in chromium today. At some point in the future the test code will get close enough to the real code for that test to be a real regression test. 338319 12 enne 2011-01-21 13:58:34 -0800 Thanks for the review. (In reply to comment #11) > (From update of attachment 79650 [details]) > R=me. Please consider scripting that manual test and adding it to compositing/, even though it doesn't fail without this patch in chromium today. At some point in the future the test code will get close enough to the real code for that test to be a real regression test. Forgive me if I'm reluctant to add a test that doesn't actually test this regression. Each additional test is a burden and this has no immediate benefit. The bug tracker will keep this file around until we need it. Also, if this issue ever regresses, we can reprioritize changing how we scroll when testing. 338353 13 jamesr 2011-01-21 14:38:11 -0800 OK, just promise not to break it :) 338550 14 79650 commit-queue 2011-01-22 02:00:21 -0800 Comment on attachment 79650 Patch Clearing flags on attachment: 79650 Committed r76437: <http://trac.webkit.org/changeset/76437> 338551 15 commit-queue 2011-01-22 02:00:27 -0800 All reviewed patches have been landed. Closing bug. 79650 2011-01-20 14:14:50 -0800 2011-01-22 02:00:21 -0800 Patch bug-52681-20110120141449.patch text/plain 3415 enne ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NzQ4ZjgzYTExODJmYWU2ZTM1MGRjM2I1ZTIwMGM5ZTkxODBmNzYxLi44 NDFmYTQ5MzJhNTExYmNlMTJmZjg3NThlZmVhNjA2ZjZmOGJmYzRmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjIgQEAKKzIwMTEtMDEtMTggIEFkcmllbm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hy b21pdW1dIEZpeCBjb21wb3NpdG9yIHJlcGFpbnRzIGZvciBvZmZzY3JlZW4gZml4ZWQgZWxlbWVu dHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyNjgx CisKKyAgICAgICAgVGhlIGZhc3QgcGF0aCBzY3JvbGxpbmcgd2FzIGNsaXBwaW5nIG9mZnNjcmVl biBpbnZhbGlkYXRpb25zLgorICAgICAgICBBZGRpdGlvbmFsbHksIHRoZSBjb21wb3NpdG9yIHdh cyBpZ25vcmluZyBhbGwgaW52YWxpZGF0aW9ucyB0aGF0IHdlcmUKKyAgICAgICAgZW50aXJlbHkg b3V0IG9mIHRoZSBjb250ZW50IHJlY3QuCisKKyAgICAgICAgVGVzdDogY29tcG9zaXRpbmcvIHRv IHZlcmlmeSB0aGlzIGNhdXNlZCBubyByZWdyZXNzaW9ucy4KKyAgICAgICAgVGVzdGVkIGZpeCBt YW51YWxseSBpbiBicm93c2VyIGFzIEkgY291bGQgbm90IGdlbmVyYXRlIGEgTGF5b3V0VGVzdCB0 aGF0IHJlcHJvZHVjZWQgdGhlIGJ1ZyBpbiBydW4td2Via2l0LXRlc3RzLgorCisgICAgICAgICog cGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpzY3JvbGxD b250ZW50c0Zhc3RQYXRoKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9M YXllclJlbmRlcmVyQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJSZW5kZXJl ckNocm9taXVtOjppbnZhbGlkYXRlUm9vdExheWVyUmVjdCk6CisKIDIwMTEtMDEtMTkgIENzYWJh IE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBM YXN6bG8gR29tYm9zIGFuZCBUb3IgQXJuZSBWZXN0YsO4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcu Y3BwCmluZGV4IDExODczMThmYzAyODBhNTMzNzc4NGVhZmJhMzM5MDY4Y2MxNGFhNGIuLjA2MGQw MjEyMmNkMTllODc2MmNmNTRjMDYwY2NkZDQ3OGNlZDc3OTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1l Vmlldy5jcHAKQEAgLTEwOTIsOCArMTA5Miw4IEBAIGJvb2wgRnJhbWVWaWV3OjpzY3JvbGxDb250 ZW50c0Zhc3RQYXRoKGNvbnN0IEludFNpemUmIHNjcm9sbERlbHRhLCBjb25zdCBJbnRSZWN0CiAg ICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgSW50UmVjdCB1cGRhdGVSZWN0ID0gcmVuZGVy Qm94LT5sYXllcigpLT5yZXBhaW50UmVjdEluY2x1ZGluZ0Rlc2NlbmRhbnRzKCk7CiAgICAgICAg IHVwZGF0ZVJlY3QgPSBjb250ZW50c1RvV2luZG93KHVwZGF0ZVJlY3QpOwotCi0gICAgICAgIHVw ZGF0ZVJlY3QuaW50ZXJzZWN0KHJlY3RUb1Njcm9sbCk7CisgICAgICAgIGlmIChjbGlwc1JlcGFp bnRzKCkpCisgICAgICAgICAgICB1cGRhdGVSZWN0LmludGVyc2VjdChyZWN0VG9TY3JvbGwpOwog ICAgICAgICBpZiAoIXVwZGF0ZVJlY3QuaXNFbXB0eSgpKSB7CiAgICAgICAgICAgICBpZiAoc3Vi UmVjdFRvVXBkYXRlLnNpemUoKSA+PSBmaXhlZE9iamVjdFRocmVzaG9sZCkgewogICAgICAgICAg ICAgICAgIHVwZGF0ZUludmFsaWRhdGVkU3ViUmVjdCA9IGZhbHNlOwpAQCAtMTExNSw3ICsxMTE1 LDggQEAgYm9vbCBGcmFtZVZpZXc6OnNjcm9sbENvbnRlbnRzRmFzdFBhdGgoY29uc3QgSW50U2l6 ZSYgc2Nyb2xsRGVsdGEsIGNvbnN0IEludFJlY3QKICAgICAgICAgICAgIEludFJlY3Qgc2Nyb2xs ZWRSZWN0ID0gdXBkYXRlUmVjdDsKICAgICAgICAgICAgIHNjcm9sbGVkUmVjdC5tb3ZlKHNjcm9s bERlbHRhKTsKICAgICAgICAgICAgIHVwZGF0ZVJlY3QudW5pdGUoc2Nyb2xsZWRSZWN0KTsKLSAg ICAgICAgICAgIHVwZGF0ZVJlY3QuaW50ZXJzZWN0KHJlY3RUb1Njcm9sbCk7CisgICAgICAgICAg ICBpZiAoY2xpcHNSZXBhaW50cygpKQorICAgICAgICAgICAgICAgIHVwZGF0ZVJlY3QuaW50ZXJz ZWN0KHJlY3RUb1Njcm9sbCk7CiAgICAgICAgICAgICBob3N0V2luZG93KCktPmludmFsaWRhdGVD b250ZW50c0FuZFdpbmRvdyh1cGRhdGVSZWN0LCBmYWxzZSk7CiAgICAgICAgIH0KICAgICAgICAg cmV0dXJuIHRydWU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmNwcAppbmRleCA4 ZDc3YmVhZTliNTM2MjI3M2IzOGE5OGU5YzZjNDM3M2I0NDZmNGI0Li45NDNkNTc3MmI3Y2U1NzY1 OGRiNjgxYTI3YzcxMDc4ZTUyNWU1YzE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJv bWl1bS5jcHAKQEAgLTE2MSw4ICsxNjEsNyBAQCBJbnRSZWN0IExheWVyUmVuZGVyZXJDaHJvbWl1 bTo6aG9yaXpvbnRhbFNjcm9sbGJhclJlY3QoY29uc3QgSW50UmVjdCYgdmlzaWJsZVJlYwogCiB2 b2lkIExheWVyUmVuZGVyZXJDaHJvbWl1bTo6aW52YWxpZGF0ZVJvb3RMYXllclJlY3QoY29uc3Qg SW50UmVjdCYgZGlydHlSZWN0LCBjb25zdCBJbnRSZWN0JiB2aXNpYmxlUmVjdCwgY29uc3QgSW50 UmVjdCYgY29udGVudFJlY3QpCiB7Ci0gICAgaWYgKGNvbnRlbnRSZWN0LmludGVyc2VjdHMoZGly dHlSZWN0KSkKLSAgICAgICAgbV9yb290TGF5ZXJUaWxlci0+aW52YWxpZGF0ZVJlY3QoZGlydHlS ZWN0KTsKKyAgICBtX3Jvb3RMYXllclRpbGVyLT5pbnZhbGlkYXRlUmVjdChkaXJ0eVJlY3QpOwog ICAgIGlmIChtX2hvcml6b250YWxTY3JvbGxiYXJUaWxlcikgewogICAgICAgICBJbnRSZWN0IHNj cm9sbGJhciA9IGhvcml6b250YWxTY3JvbGxiYXJSZWN0KHZpc2libGVSZWN0LCBjb250ZW50UmVj dCk7CiAgICAgICAgIGlmIChkaXJ0eVJlY3QuaW50ZXJzZWN0cyhzY3JvbGxiYXIpKSB7Cg== 79654 2011-01-20 14:55:12 -0800 2011-01-20 14:55:12 -0800 Manual test offscreen-fixed-position.html text/html 1454 enne PGh0bWw+CiAgICA8aGVhZD4KICAgICAgPHN0eWxlIHR5cGU9InRleHQvY3NzIj4KICAgICAgICAg ICAgI29mZnNjcmVlbmJveGFib3ZlIHsKICAgICAgICAgICAgICAgIHBvc2l0aW9uOiBmaXhlZDsK ICAgICAgICAgICAgICAgIGxlZnQ6IDBweDsKICAgICAgICAgICAgICAgIHRvcDogLTEwMDBweDsK ICAgICAgICAgICAgICAgIHdpZHRoOiAxMDAlOwogICAgICAgICAgICAgICAgaGVpZ2h0OiAxMDAw cHg7CiAgICAgICAgICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiByZWQ7CiAgICAgICAgICAgIH0K CiAgICAgICAgICAgICNsYXJnZWRpdiB7CiAgICAgICAgICAgICAgICBoZWlnaHQ6IDIwMDBweDsK ICAgICAgICAgICAgICAgIC13ZWJraXQtdHJhbnNmb3JtOnRyYW5zbGF0ZVooMCk7CiAgICAgICAg ICAgIH0KICAgICAgICA8L3N0eWxlPgogICAgICAgIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2Ny aXB0IiBjaGFyc2V0PXV0Zi04Ij4KICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29u dHJvbGxlcikKICAgICAgICAgICAgICAgIHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlci53YWl0 VW50aWxEb25lKCk7CiAgICAgICAgICAgIHZhciBmaXJzdFNjcm9sbCA9IHRydWU7CiAgICAgICAg ICAgIHZhciBzY3JvbGxBbW91bnQgPSA1MDA7CiAgICAgICAgICAgIHdpbmRvdy5hZGRFdmVudExp c3RlbmVyKCdzY3JvbGwnLCBmdW5jdGlvbigpIHsKICAgICAgICAgICAgICAgIGlmIChmaXJzdFNj cm9sbCkgewogICAgICAgICAgICAgICAgICAgIGZpcnN0U2Nyb2xsID0gZmFsc2U7CiAgICAgICAg ICAgICAgICAgICAgd2luZG93LnNjcm9sbEJ5KDAsIC1zY3JvbGxBbW91bnQpOwogICAgICAgICAg ICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCiAgICAgICAgICAgICAg ICAgICAgICAgIHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CiAgICAg ICAgICAgICAgICB9CiAgICAgICAgICAgIH0sIGZhbHNlKTsKICAgICAgICAgICAgd2luZG93LmFk ZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBmdW5jdGlvbigpIHsKICAgICAgICAgICAgICAgIHdpbmRv dy5zY3JvbGxCeSgwLCBzY3JvbGxBbW91bnQpOwogICAgICAgICAgICB9LCBmYWxzZSk7CiAgICAg ICAgPC9zY3JpcHQ+CiAgICA8L2hlYWQ+CiAgICA8Ym9keSBzdHlsZT0iYmFja2dyb3VuZC1jb2xv cjogZ3JlZW47Ij4KICAgICAgICA8IS0tU2Nyb2xsIGRvd24gYSBmZXcgaHVuZHJlZCBwaXhlbHMg YW5kIHRoZW4gYmFjayB1cC4gICAgSWYgeW91IHNlZSBhCiAgICAgICAgcmVkIGJhciwgdGhlbiB0 aGVyZSB3YXMgYSBtaXNzaW5nIG9mZnNjcmVlbiBpbnZhbGlkYXRpb24uLS0+CiAgICAgICAgPGRp diBpZD0ib2Zmc2NyZWVuYm94YWJvdmUiPjwvZGl2PgogICAgICAgIDxkaXYgaWQ9ImxhcmdlZGl2 Ij48L2Rpdj4KICAgIDwvYm9keT4KPC9odG1sPgo=