52677 2011-01-18 15:54:15 -0800 Update fast/events/offsetX-offsetY.html now that bug is fixed 2011-01-19 06:39:58 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned commit-queue oldest_to_newest 336166 0 joepeck 2011-01-18 15:54:15 -0800 LayoutTests/fast/events/offsetX-offsetY.html had commented out code: http://trac.webkit.org/browser/trunk/LayoutTests/fast/events/offsetX-offsetY.html#L40 > // dispatchEvent(639, 316, 'in-columns', 173, -172); // This is buggy. See https://bugs.webkit.org/show_bug.cgi?id=21993 I updated the test because the bug is now fixed. It looks correct in a WebKit nightly. I don't know how this can be affected with different fonts on different platforms but it looks like multi-column text is more consistent now. The hit-test of a <span> in columns works as expected. 336168 1 79346 joepeck 2011-01-18 15:57:07 -0800 Created attachment 79346 [PATCH] Update Test 336483 2 79346 commit-queue 2011-01-19 06:39:54 -0800 Comment on attachment 79346 [PATCH] Update Test Clearing flags on attachment: 79346 Committed r76124: <http://trac.webkit.org/changeset/76124> 336484 3 commit-queue 2011-01-19 06:39:58 -0800 All reviewed patches have been landed. Closing bug. 79346 2011-01-18 15:57:07 -0800 2011-01-19 06:39:54 -0800 [PATCH] Update Test update-test.patch text/plain 2049 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmMmMwMDFiLi5mMTA4ZGI4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDEt MTggIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgVGVzdCBOb3cgdGhhdCBC dWcgaXMgRml4ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTUyNjc3CisKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9vZmZzZXRYLW9mZnNldFktZXhwZWN0 ZWQudHh0OiBvbmUgbW9yZSBQQVNTIGxpbmUuCisgICAgICAgICogZmFzdC9ldmVudHMvb2Zmc2V0 WC1vZmZzZXRZLmh0bWw6IHVuY29tbWVudCBhbmQgdXBkYXRlIGhpdC10ZXN0IGxvY2F0aW9uLgor CiAyMDExLTAxLTE3ICBKZXNzaWUgQmVybGluICA8amJlcmxpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29uLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9ldmVudHMvb2Zmc2V0WC1vZmZzZXRZLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zh c3QvZXZlbnRzL29mZnNldFgtb2Zmc2V0WS1leHBlY3RlZC50eHQKaW5kZXggMjJkYzc3NS4uNDk5 OTQ3OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvb2Zmc2V0WC1vZmZzZXRZ LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9vZmZzZXRYLW9mZnNl dFktZXhwZWN0ZWQudHh0CkBAIC0xOCw2ICsxOCw3IEBAIFBBU1M6IGV2ZW50IGF0ICgxMTIsIDYy KSBoaXQgYWJzLWJveCBhdCBvZmZzZXQgKDMyLCAzNykKIFBBU1M6IGV2ZW50IGF0ICgxNTcsIDMy KSBoaXQgcmVsLWJveCBhdCBvZmZzZXQgKDIyLCAyNCkKIFBBU1M6IGV2ZW50IGF0ICg0MTAsIDMw KSBoaXQgZml4ZWQtYm94IGF0IG9mZnNldCAoMTAsIDEwKQogUEFTUzogZXZlbnQgYXQgKDM2LCAy NzIpIGhpdCB3aXRoLWJvcmRlcnRvcGV4dHJhIGF0IG9mZnNldCAoNCwgNCkKK1BBU1M6IGV2ZW50 IGF0ICg2MzksIDIwNykgaGl0IGluLWNvbHVtbnMgYXQgb2Zmc2V0ICgxNzMsIC0xNzIpCiBQQVNT OiBldmVudCBhdCAoNTYzLCA0MTApIGhpdCBpbnNpZGUtb3ZlcmZsb3cgYXQgb2Zmc2V0ICg3LCA2 KQogUEFTUzogZXZlbnQgYXQgKDExMiwgMzY5KSBoaXQgdHJhbnNmb3JtZWQgYXQgb2Zmc2V0ICgx MSwgMTYpCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL29mZnNldFgtb2Zm c2V0WS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvb2Zmc2V0WC1vZmZzZXRZLmh0bWwK aW5kZXggM2E2MTNiOC4uYTQzMjY2OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVu dHMvb2Zmc2V0WC1vZmZzZXRZLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvb2Zm c2V0WC1vZmZzZXRZLmh0bWwKQEAgLTM3LDcgKzM3LDcgQEAKICAgICAgIGRpc3BhdGNoRXZlbnQo MTU3LCAzMiwgJ3JlbC1ib3gnLCAyMiwgMjQpOwogICAgICAgZGlzcGF0Y2hFdmVudCg0MTAsIDMw LCAnZml4ZWQtYm94JywgMTAsIDEwKTsKICAgICAgIGRpc3BhdGNoRXZlbnQoMzYsIDI3MiwgJ3dp dGgtYm9yZGVydG9wZXh0cmEnLCA0LCA0KTsKLSAgICAgIC8vIGRpc3BhdGNoRXZlbnQoNjM5LCAz MTYsICdpbi1jb2x1bW5zJywgMTczLCAtMTcyKTsgIC8vIFRoaXMgaXMgYnVnZ3kuIFNlZSBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5OTMKKyAgICAgIGRpc3BhdGNo RXZlbnQoNjM5LCAyMDcsICdpbi1jb2x1bW5zJywgMTczLCAtMTcyKTsKICAgICAgIGRpc3BhdGNo RXZlbnQoNTYzLCA0MTAsICdpbnNpZGUtb3ZlcmZsb3cnLCA3LCA2KTsKICAgICAgIGRpc3BhdGNo RXZlbnQoMTEyLCAzNjksICd0cmFuc2Zvcm1lZCcsIDExLCAxNik7CiAgICAgICAgICAgICAK