52668 2011-01-18 14:44:42 -0800 Removed RegisterFile::markGlobals because it was obtuse, and it unnecessarily relied on conservative marking. 2011-01-19 18:56:55 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ggaren ggaren kbr oldest_to_newest 336107 0 ggaren 2011-01-18 14:44:42 -0800 Removed RegisterFile::markGlobals because it was obtuse, and it unnecessarily relied on conservative marking. 336109 1 79334 ggaren 2011-01-18 14:45:44 -0800 Created attachment 79334 Patch 336110 2 79334 darin 2011-01-18 14:49:53 -0800 Comment on attachment 79334 Patch Wow, this really does seem much better. 336159 3 ggaren 2011-01-18 15:45:41 -0800 Committed r76078: <http://trac.webkit.org/changeset/76078> 336322 4 kbr 2011-01-18 20:33:32 -0800 Reverted r76078 for reason: Caused WebGL and possibly other layout test crashes in Release mode Committed r76100: <http://trac.webkit.org/changeset/76100> 336323 5 kbr 2011-01-18 20:36:10 -0800 I apologize, but I had to roll out this change. It was causing random layout test crashes. The WebGL tests fast/canvas/webgl/constants.html and fast/canvas/webgl/gl-enum-tests.html seemed to be the most affected and crashed 100% of the time on my Snow Leopard machine in Release mode with "run-webkit-tests fast/canvas/webgl". I barely caught this before the revision scrolled off the bottom of the build.webkit.org console. Here are the top few frames from DumpRenderTree in gdb when the crash occurred. Program received signal EXC_BAD_ACCESS, Could not access memory. Reason: KERN_PROTECTION_FAILURE at address: 0x00000001006ffdc0 0x0000000100226aad in JSC::CollectorBitmap::getset () at /Users/kbr/src/chrome2/src/third_party/WebKit/Source/JavaScriptCore/runtime/MarkedSpace.h:148 #1 0x0000000100226aad in JSC::CollectorBitmap::getset () at /Users/kbr/src/chrome2/src/third_party/WebKit/Source/JavaScriptCore/runtime/MarkedSpace.h:148 #2 0x0000000100226aad in JSC::CollectorBitmap::getset () at /Users/kbr/src/chrome2/src/third_party/WebKit/Source/JavaScriptCore/runtime/MarkedSpace.h:148 #3 0x0000000100226aad in JSC::MachineStackMarker::markCurrentThreadConservativelyInternal (this=<value temporarily unavailable, due to optimizations>, markStack=@0x10dfaca80) at /Users/kbr/src/chrome2/src/third_party/WebKit/Source/JavaScriptCore/runtime/MachineStackMarker.cpp:200 336605 6 ggaren 2011-01-19 10:13:07 -0800 Strange -- the EWS bots seemed OK with the patch. Anyway, thanks for rolling this out, Kenneth. I'll take another look. 337038 7 ggaren 2011-01-19 18:56:55 -0800 Committed revision 76193: <http://trac.webkit.org/changeset/76193> 79334 2011-01-18 14:45:44 -0800 2011-01-18 14:49:53 -0800 Patch bug-52668-20110118144543.patch text/plain 3566 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzYwNjEpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAK KzIwMTEtMDEtMTggIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmVkIFJlZ2lzdGVy RmlsZTo6bWFya0dsb2JhbHMgYmVjYXVzZSBpdCB3YXMgb2J0dXNlLCBhbmQgaXQKKyAgICAgICAg dW5uZWNlc3NhcmlseSByZWxpZWQgb24gY29uc2VydmF0aXZlIG1hcmtpbmcuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjY2OAorCisgICAgICAgICog aW50ZXJwcmV0ZXIvUmVnaXN0ZXJGaWxlLmg6IFJlbW92ZWQgbWFya0dsb2JhbHMuCisKKyAgICAg ICAgKiBydW50aW1lL0pTQWN0aXZhdGlvbi5jcHA6CisgICAgICAgIChKU0M6OkpTQWN0aXZhdGlv bjo6bWFya0NoaWxkcmVuKTogQWRkZWQgYSBjb21tZW50IGV4cGxhbmluZyB3aHkgc29tZQorICAg ICAgICBKU0FjdGl2YXRpb25zIGRvbid0IGFsd2F5cyBtYXJrIHRoZWlyIHJlZ2lzdGVycyBhcnJh eXMuCisKKyAgICAgICAgKiBydW50aW1lL0pTR2xvYmFsT2JqZWN0LmNwcDoKKyAgICAgICAgKEpT Qzo6SlNHbG9iYWxPYmplY3Q6Om1hcmtDaGlsZHJlbik6IEluc3RlYWQgb2YgY2FsbGluZyBtYXJr R2xvYmFscywgbWFyaworICAgICAgICB0aGUgcmVnaXN0ZXJzIGFycmF5IGRpcmVjdGx5LgorCiAy MDExLTAxLTE4ICBEaW1pdHJ5IEFuZHJpYyAgPGRpbUBmcmVlYnNkLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2lu dGVycHJldGVyL1JlZ2lzdGVyRmlsZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9pbnRlcnByZXRlci9SZWdpc3RlckZpbGUuaAkocmV2aXNpb24gNzU5NzIpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvUmVnaXN0ZXJGaWxlLmgJKHdvcmtpbmcgY29w eSkKQEAgLTEzMSw3ICsxMzEsNiBAQCBuYW1lc3BhY2UgSlNDIHsKIAogICAgICAgICBSZWdpc3Rl ciogbGFzdEdsb2JhbCgpIGNvbnN0IHsgcmV0dXJuIG1fc3RhcnQgLSBtX251bUdsb2JhbHM7IH0K ICAgICAgICAgCi0gICAgICAgIHZvaWQgbWFya0dsb2JhbHMoTWFya1N0YWNrJiBtYXJrU3RhY2ss IEhlYXAqIGhlYXApIHsgaGVhcC0+bWFya0NvbnNlcnZhdGl2ZWx5KG1hcmtTdGFjaywgbGFzdEds b2JhbCgpLCBtX3N0YXJ0KTsgfQogICAgICAgICB2b2lkIG1hcmtDYWxsRnJhbWVzKE1hcmtTdGFj ayYgbWFya1N0YWNrLCBIZWFwKiBoZWFwKSB7IGhlYXAtPm1hcmtDb25zZXJ2YXRpdmVseShtYXJr U3RhY2ssIG1fc3RhcnQsIG1fZW5kKTsgfQogCiAgICAgICAgIHN0YXRpYyBzaXplX3QgY29tbWl0 dGVkQnl0ZUNvdW50KCk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0Fj dGl2YXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTQWN0aXZhdGlvbi5jcHAJKHJldmlzaW9uIDc1OTcyKQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvSlNBY3RpdmF0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTMsNiArNTMs NyBAQCB2b2lkIEpTQWN0aXZhdGlvbjo6bWFya0NoaWxkcmVuKE1hcmtTdGFjCiB7CiAgICAgQmFz ZTo6bWFya0NoaWxkcmVuKG1hcmtTdGFjayk7CiAKKyAgICAvLyBObyBuZWVkIHRvIG1hcmsgb3Vy IHJlZ2lzdGVycyBpZiB0aGV5J3JlIHN0aWxsIGluIHRoZSBSZWdpc3RlckZpbGUuCiAgICAgUmVn aXN0ZXIqIHJlZ2lzdGVyQXJyYXkgPSBkKCktPnJlZ2lzdGVyQXJyYXkuZ2V0KCk7CiAgICAgaWYg KCFyZWdpc3RlckFycmF5KQogICAgICAgICByZXR1cm47CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9KU0dsb2JhbE9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmplY3QuY3BwCShyZXZpc2lvbiA3NTk3MikK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0LmNwcAkod29y a2luZyBjb3B5KQpAQCAtMzQ5LDEwICszNDksNiBAQCB2b2lkIEpTR2xvYmFsT2JqZWN0OjptYXJr Q2hpbGRyZW4oTWFya1N0CiAgICAgZm9yIChIYXNoU2V0PEdsb2JhbENvZGVCbG9jayo+Ojpjb25z dF9pdGVyYXRvciBpdCA9IGNvZGVCbG9ja3MoKS5iZWdpbigpOyBpdCAhPSBlbmQ7ICsraXQpCiAg ICAgICAgICgqaXQpLT5tYXJrQWdncmVnYXRlKG1hcmtTdGFjayk7CiAKLSAgICBSZWdpc3RlckZp bGUmIHJlZ2lzdGVyRmlsZSA9IGdsb2JhbERhdGEoKS5pbnRlcnByZXRlci0+cmVnaXN0ZXJGaWxl KCk7Ci0gICAgaWYgKHJlZ2lzdGVyRmlsZS5nbG9iYWxPYmplY3QoKSA9PSB0aGlzKQotICAgICAg ICByZWdpc3RlckZpbGUubWFya0dsb2JhbHMobWFya1N0YWNrLCAmZ2xvYmFsRGF0YSgpLmhlYXAp OwotCiAgICAgbWFya0lmTmVlZGVkKG1hcmtTdGFjaywgZCgpLT5yZWdFeHBDb25zdHJ1Y3Rvcik7 CiAgICAgbWFya0lmTmVlZGVkKG1hcmtTdGFjaywgZCgpLT5lcnJvckNvbnN0cnVjdG9yKTsKICAg ICBtYXJrSWZOZWVkZWQobWFya1N0YWNrLCBkKCktPmV2YWxFcnJvckNvbnN0cnVjdG9yKTsKQEAg LTM5NywxMiArMzkzLDcgQEAgdm9pZCBKU0dsb2JhbE9iamVjdDo6bWFya0NoaWxkcmVuKE1hcmtT dAogICAgIC8vIE5vIG5lZWQgdG8gbWFyayB0aGUgb3RoZXIgc3RydWN0dXJlcywgYmVjYXVzZSB0 aGVpciBwcm90b3R5cGVzIGFyZSBhbGwKICAgICAvLyBndWFyYW50ZWVkIHRvIGJlIHJlZmVyZW5j ZWQgZWxzZXdoZXJlLgogCi0gICAgUmVnaXN0ZXIqIHJlZ2lzdGVyQXJyYXkgPSBkKCktPnJlZ2lz dGVyQXJyYXkuZ2V0KCk7Ci0gICAgaWYgKCFyZWdpc3RlckFycmF5KQotICAgICAgICByZXR1cm47 Ci0KLSAgICBzaXplX3Qgc2l6ZSA9IGQoKS0+cmVnaXN0ZXJBcnJheVNpemU7Ci0gICAgbWFya1N0 YWNrLmFwcGVuZFZhbHVlcyhyZWludGVycHJldF9jYXN0PEpTVmFsdWUqPihyZWdpc3RlckFycmF5 KSwgc2l6ZSk7CisgICAgbWFya1N0YWNrLmFwcGVuZFZhbHVlcyhkKCktPnJlZ2lzdGVycyAtIHN5 bWJvbFRhYmxlKCkuc2l6ZSgpLCBzeW1ib2xUYWJsZSgpLnNpemUoKSk7CiB9CiAKIEV4ZWNTdGF0 ZSogSlNHbG9iYWxPYmplY3Q6Omdsb2JhbEV4ZWMoKQo=