52650 2011-01-18 12:47:48 -0800 make file expansion use the file at the svn revision the diff was created at 2011-01-18 16:30:27 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth aroben eric mihaip oldest_to_newest 336012 0 ojan 2011-01-18 12:47:48 -0800 make file expansion use the file at the svn revision the diff was created at 336013 1 79310 ojan 2011-01-18 12:48:39 -0800 Created attachment 79310 Patch 336147 2 79310 eric 2011-01-18 15:26:47 -0800 Comment on attachment 79310 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79310&action=review Looks good though. > Websites/bugs.webkit.org/code-review.js:424 > + var suffix = revision ? '?p=' + revision : ''; suffix seems a bit odd for a name here. You're constructing a query, with a single p= parameter. 336197 3 ojan 2011-01-18 16:30:27 -0800 Committed r76082: <http://trac.webkit.org/changeset/76082> 79310 2011-01-18 12:48:39 -0800 2011-01-18 15:26:47 -0800 Patch bug-52650-20110118124838.patch text/plain 3143 ojan ZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cgYi9XZWJzaXRl cy9idWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDFjMjYwZDEyYjU5MTI5MTYxODAzMzQ2 ODFjMzFhMjI0OWNkYjQ0M2YuLjViZWY2OWJjOTU0MmY2NWUzN2NiYWQ3ODIzOTY0OGY4YmRiZWYz NGIgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIv V2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEx LTAxLTE4ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbWFrZSBmaWxlIGV4cGFuc2lvbiB1c2Ug dGhlIGZpbGUgYXQgdGhlIHN2biByZXZpc2lvbiB0aGUgZGlmZiB3YXMgY3JlYXRlZCBhdAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI2NTAKKworICAg ICAgICBUaGlzIG9ubHkgd29ya3MgZm9yIHBhdGNoZXMgY3JlYXRlZCB3aXRoIFNWTiBmb3Igbm93 IHNpbmNlIHRoZSBnaXQKKyAgICAgICAgZGlmZiBkb2VzIG5vdCBpbmNsdWRlIFNWTiByZXZpc2lv biBudW1iZXJzIGluIGl0LgorCisgICAgICAgICogUHJldHR5UGF0Y2gvUHJldHR5UGF0Y2gucmI6 CisgICAgICAgICogY29kZS1yZXZpZXcuanM6CisKIDIwMTEtMDEtMTUgIEFkYW0gQmFydGggIDxh YmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBFcmljIFNlaWRl bC4KZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9QcmV0dHlQYXRjaC9QcmV0 dHlQYXRjaC5yYiBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9QcmV0dHlQYXRjaC9QcmV0dHlQ YXRjaC5yYgppbmRleCBmYzBmOTExYTY4Njg4MGI2ZmI0ZTA1MjI4NWUwZjNlMmJhMTRkZDBlLi4x NjMzMTE2Y2FkMDI5ZGQ1ODUwZmQyZTcyZjFjMGUyOWEyNTYxODFiIDEwMDY0NAotLS0gYS9XZWJz aXRlcy9idWdzLndlYmtpdC5vcmcvUHJldHR5UGF0Y2gvUHJldHR5UGF0Y2gucmIKKysrIGIvV2Vi c2l0ZXMvYnVncy53ZWJraXQub3JnL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCkBAIC00MDks NyArNDA5LDcgQEAgYm9keSB7CiB9CiA8L3N0eWxlPgogPHNjcmlwdCBzcmM9Imh0dHBzOi8vYWph eC5nb29nbGVhcGlzLmNvbS9hamF4L2xpYnMvanF1ZXJ5LzEuNC4yL2pxdWVyeS5taW4uanMiPjwv c2NyaXB0PiAKLTxzY3JpcHQgc3JjPSJjb2RlLXJldmlldy5qcz92ZXJzaW9uPTI0Ij48L3Njcmlw dD4KKzxzY3JpcHQgc3JjPSJjb2RlLXJldmlldy5qcz92ZXJzaW9uPTI1Ij48L3NjcmlwdD4KIEVP RgogCiAgICAgZGVmIHNlbGYucmV2aXNpb25PckRlc2NyaXB0aW9uKHN0cmluZykKQEAgLTUxNiw2 ICs1MTYsMTEgQEAgRU9GCiAgICAgICAgICAgICBlbHNlCiAgICAgICAgICAgICAgICAgc3RyICs9 IEBzZWN0aW9ucy5jb2xsZWN0eyB8c2VjdGlvbnwgc2VjdGlvbi50b19odG1sIH0uam9pbigiPGJy PlxuIikgdW5sZXNzIEBzZWN0aW9ucy5uaWw/CiAgICAgICAgICAgICBlbmQKKworICAgICAgICAg ICAgaWYgQGZyb20gdGhlbgorICAgICAgICAgICAgICAgIHN0ciArPSAiPHNwYW4gY2xhc3M9J3Jl dmlzaW9uJz4iICsgQGZyb20gKyAiPC9zcGFuPiIKKyAgICAgICAgICAgIGVuZAorCiAgICAgICAg ICAgICBzdHIgKz0gIjwvZGl2PlxuIgogICAgICAgICBlbmQKIApkaWZmIC0tZ2l0IGEvV2Vic2l0 ZXMvYnVncy53ZWJraXQub3JnL2NvZGUtcmV2aWV3LmpzIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQu b3JnL2NvZGUtcmV2aWV3LmpzCmluZGV4IDJkYWFjMmQ0MzNjZTc4ZDBhM2NhNGY0OTI0YjdmMDli ODk2M2M0NWYuLjRlNDQxMGVhMjUxYmI4NTU5ZGU0NDM4ZWIxY2JiNzg4MGU3NDgzYjggMTAwNjQ0 Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9jb2RlLXJldmlldy5qcworKysgYi9XZWJz aXRlcy9idWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXcuanMKQEAgLTQwOCw2ICs0MDgsMTEgQEAK ICAgICBjb252ZXJ0QWxsRmlsZURpZmZzKGRpZmZ0eXBlLCBmaWxlX2RpZmZzKTsKICAgfQogCisg IGZ1bmN0aW9uIHBhdGNoUmV2aXNpb24oKSB7CisgICAgdmFyIHJldmlzaW9uID0gJCgnLnJldmlz aW9uJyk7CisgICAgcmV0dXJuIHJldmlzaW9uWzBdID8gcmV2aXNpb24uZmlyc3QoKS50ZXh0KCkg OiBudWxsOworICB9CisKICAgZnVuY3Rpb24gZ2V0V2ViS2l0U291cmNlRmlsZShmaWxlX25hbWUs IG9uTG9hZCwgZXhwYW5kX2JhcikgewogICAgIGZ1bmN0aW9uIGhhbmRsZUxvYWQoY29udGVudHMp IHsKICAgICAgIG9yaWdpbmFsX2ZpbGVfY29udGVudHNbZmlsZV9uYW1lXSA9IGNvbnRlbnRzLnNw bGl0KCdcbicpOwpAQCAtNDE1LDggKzQyMCwxMSBAQAogICAgICAgb25Mb2FkKCk7CiAgICAgfTsK IAorICAgIHZhciByZXZpc2lvbiA9IHBhdGNoUmV2aXNpb24oKTsKKyAgICB2YXIgc3VmZml4ID0g cmV2aXNpb24gPyAnP3A9JyArIHJldmlzaW9uIDogJyc7CisKICAgICAkLmFqYXgoewotICAgICAg dXJsOiBXRUJLSVRfQkFTRV9ESVIgKyBmaWxlX25hbWUsCisgICAgICB1cmw6IFdFQktJVF9CQVNF X0RJUiArIGZpbGVfbmFtZSArIHN1ZmZpeCwKICAgICAgIGNvbnRleHQ6IGRvY3VtZW50LmJvZHks CiAgICAgICBjb21wbGV0ZTogZnVuY3Rpb24oeGhyLCBkYXRhKSB7CiAgICAgICAgICAgICAgIGlm ICh4aHIuc3RhdHVzID09IDApCkBAIC00MzIsOSArNDQwLDYgQEAKICAgfQogCiAgIGZ1bmN0aW9u IGhhbmRsZUxvYWRFcnJvcihleHBhbmRfYmFyKSB7Ci0gICAgLy8gRklYTUU6IEluIHRoaXMgY2Fz ZSwgdHJ5IGZldGNoaW5nIHRoZSBzb3VyY2UgZmlsZSBhdCB0aGUgcmV2aXNpb24gdGhlIHBhdGNo IHdhcyBjcmVhdGVkIGF0LAotICAgIC8vIGluIGNhc2UgdGhlIGZpbGUgaGFzIGJlZSBkZWxldGVk LgotICAgIC8vIE1pZ2h0IG5lZWQgdG8gbW9kaWZ5IHdlYmtpdC1wYXRjaCB0byBpbmNsdWRlIHRo YXQgZGF0YSBpbiB0aGUgZGlmZi4KICAgICByZXBsYWNlRXhwYW5kTGlua0NvbnRhaW5lcnMoZXhw YW5kX2JhciwgIkNhbid0IGV4cGFuZC4gSXMgdGhpcyBhIG5ldyBvciBkZWxldGVkIGZpbGU/Iik7 CiAgIH0KIAo=