52647 2011-01-18 12:05:34 -0800 WK2 methods WKPageScaleWebView and WKPageGetViewScaleFactor need to have consistent names. 2011-01-18 14:30:53 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All OS X 10.6 RESOLVED FIXED P2 Minor --- 1 dkaleta webkit-unassigned commit-queue dkaleta oldest_to_newest 335980 0 dkaleta 2011-01-18 12:05:34 -0800 Setter and getter methods inside WK2: WKPageScaleWebView and WKPageGetViewScaleFactor need to have consistent names. 335984 1 79305 dkaleta 2011-01-18 12:10:30 -0800 Created attachment 79305 proposed patch 336098 2 79305 commit-queue 2011-01-18 14:30:49 -0800 Comment on attachment 79305 proposed patch Clearing flags on attachment: 79305 Committed r76066: <http://trac.webkit.org/changeset/76066> 336099 3 commit-queue 2011-01-18 14:30:53 -0800 All reviewed patches have been landed. Closing bug. 79305 2011-01-18 12:10:30 -0800 2011-01-18 14:30:49 -0800 proposed patch textmate stdin SrgALo.txt text/plain 2857 dkaleta SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2MDQyKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDEtMTggIERhbWlhbiBL YWxldGEgIDxka2FsZXRhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXSzIgbWV0aG9kcyBXS1BhZ2VTY2FsZVdlYlZpZXcgYW5kIFdL UGFnZUdldFZpZXdTY2FsZUZhY3RvciBuZWVkIHRvIGhhdmUgY29uc2lzdGVudCBuYW1lcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI2NDcKKworICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuY3BwOgorICAgICAgICAoV0tQYWdlU2V0U2Nh bGVGYWN0b3IpOgorICAgICAgICAoV0tQYWdlR2V0U2NhbGVGYWN0b3IpOgorICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvQy9XS1BhZ2UuaDoKKwogMjAxMS0wMS0xOCAgSmVzc2llIEJlcmxpbiAgPGpi ZXJsaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRl eDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5jcHAJKHJldmlzaW9uIDc2 MDM4KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTI2MCwxMSArMjYwLDE2IEBAIHZvaWQgV0tQYWdlU2V0UGFnZUFuZFRleHRa b29tRmFjdG9ycyhXS1AKICAgICB0b0ltcGwocGFnZVJlZiktPnNldFBhZ2VBbmRUZXh0Wm9vbUZh Y3RvcnMocGFnZVpvb21GYWN0b3IsIHRleHRab29tRmFjdG9yKTsKIH0KIAotdm9pZCBXS1BhZ2VT Y2FsZVdlYlZpZXcoV0tQYWdlUmVmIHBhZ2VSZWYsIGRvdWJsZSBzY2FsZSwgV0tQb2ludCBvcmln aW4pCit2b2lkIFdLUGFnZVNldFNjYWxlRmFjdG9yKFdLUGFnZVJlZiBwYWdlUmVmLCBkb3VibGUg c2NhbGUsIFdLUG9pbnQgb3JpZ2luKQogewogICAgIHRvSW1wbChwYWdlUmVmKS0+c2NhbGVXZWJW aWV3KHNjYWxlLCB0b0ludFBvaW50KG9yaWdpbikpOwogfQogCitkb3VibGUgV0tQYWdlR2V0U2Nh bGVGYWN0b3IoV0tQYWdlUmVmIHBhZ2VSZWYpCit7CisgICAgcmV0dXJuIHRvSW1wbChwYWdlUmVm KS0+dmlld1NjYWxlRmFjdG9yKCk7Cit9CisKIHZvaWQgV0tQYWdlU2V0VXNlRml4ZWRMYXlvdXQo V0tQYWdlUmVmIHBhZ2VSZWYsIGJvb2wgZml4ZWQpCiB7CiAgICAgdG9JbXBsKHBhZ2VSZWYpLT5z ZXRVc2VGaXhlZExheW91dChmaXhlZCk7CkBAIC0yODUsMTEgKzI5MCw2IEBAIFdLU2l6ZSBXS1Bh Z2VGaXhlZExheW91dFNpemUoV0tQYWdlUmVmIHAKICAgICByZXR1cm4gdG9BUEkodG9JbXBsKHBh Z2VSZWYpLT5maXhlZExheW91dFNpemUoKSk7CiB9CiAKLWRvdWJsZSBXS1BhZ2VHZXRWaWV3U2Nh bGVGYWN0b3IoV0tQYWdlUmVmIHBhZ2VSZWYpCi17Ci0gICAgcmV0dXJuIHRvSW1wbChwYWdlUmVm KS0+dmlld1NjYWxlRmFjdG9yKCk7Ci19Ci0KIHZvaWQgV0tQYWdlRmluZFN0cmluZyhXS1BhZ2VS ZWYgcGFnZVJlZiwgV0tTdHJpbmdSZWYgc3RyaW5nLCBXS0ZpbmRPcHRpb25zIG9wdGlvbnMsIHVu c2lnbmVkIG1heE1hdGNoQ291bnQpCiB7CiAgICAgdG9JbXBsKHBhZ2VSZWYpLT5maW5kU3RyaW5n KHRvSW1wbChzdHJpbmcpLT5zdHJpbmcoKSwgdG9GaW5kT3B0aW9ucyhvcHRpb25zKSwgbWF4TWF0 Y2hDb3VudCk7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5oCShy ZXZpc2lvbiA3NjAzOCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2Uu aAkod29ya2luZyBjb3B5KQpAQCAtMzA0LDggKzMwNCw4IEBAIFdLX0VYUE9SVCBkb3VibGUgV0tQ YWdlR2V0UGFnZVpvb21GYWN0b3IKIFdLX0VYUE9SVCB2b2lkIFdLUGFnZVNldFBhZ2Vab29tRmFj dG9yKFdLUGFnZVJlZiBwYWdlLCBkb3VibGUgem9vbUZhY3Rvcik7CiBXS19FWFBPUlQgdm9pZCBX S1BhZ2VTZXRQYWdlQW5kVGV4dFpvb21GYWN0b3JzKFdLUGFnZVJlZiBwYWdlLCBkb3VibGUgcGFn ZVpvb21GYWN0b3IsIGRvdWJsZSB0ZXh0Wm9vbUZhY3Rvcik7CiAKLVdLX0VYUE9SVCB2b2lkIFdL UGFnZVNjYWxlV2ViVmlldyhXS1BhZ2VSZWYgcGFnZSwgZG91YmxlIHNjYWxlLCBXS1BvaW50IG9y aWdpbik7Ci1XS19FWFBPUlQgZG91YmxlIFdLUGFnZUdldFZpZXdTY2FsZUZhY3RvcihXS1BhZ2VS ZWYgcGFnZSk7CitXS19FWFBPUlQgdm9pZCBXS1BhZ2VTZXRTY2FsZUZhY3RvcihXS1BhZ2VSZWYg cGFnZSwgZG91YmxlIHNjYWxlLCBXS1BvaW50IG9yaWdpbik7CitXS19FWFBPUlQgZG91YmxlIFdL UGFnZUdldFNjYWxlRmFjdG9yKFdLUGFnZVJlZiBwYWdlKTsKIAogV0tfRVhQT1JUIHZvaWQgV0tQ YWdlU2V0VXNlRml4ZWRMYXlvdXQoV0tQYWdlUmVmIHBhZ2UsIGJvb2wgZml4ZWQpOwogV0tfRVhQ T1JUIHZvaWQgV0tQYWdlU2V0Rml4ZWRMYXlvdXRTaXplKFdLUGFnZVJlZiBwYWdlLCBXS1NpemUg c2l6ZSk7Cg==