52646 2011-01-18 12:01:45 -0800 Implement NPN_PopUpContextMenu 2011-01-18 12:09:15 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 335977 0 andersca 2011-01-18 12:01:45 -0800 Implement NPN_PopUpContextMenu 335979 1 79304 andersca 2011-01-18 12:05:04 -0800 Created attachment 79304 Patch 335982 2 79304 sam 2011-01-18 12:07:56 -0800 Comment on attachment 79304 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79304&action=review > Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:209 > + NPCocoaEvent *m_currentMouseEvent; * on the wrong side. Or at least, I think it is, assuming NPCocoaEvent is no an objective-c object. > Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:492 > + NPCocoaEvent *previousMouseEvent = m_currentMouseEvent; * on wrong side. 335983 3 andersca 2011-01-18 12:09:15 -0800 Committed r76043: <http://trac.webkit.org/changeset/76043> 79304 2011-01-18 12:05:04 -0800 2011-01-18 12:07:55 -0800 Patch bug-52646-20110118120503.patch text/plain 5335 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2MDQyKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzAgQEAKKzIwMTEtMDEtMTggIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgTlBOX1BvcFVwQ29udGV4dE1lbnUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyNjQ2CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS84NzM1NjE2PgorCisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVn aW5zL05ldHNjYXBlL05ldHNjYXBlQnJvd3NlckZ1bmNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 TlBOX1BvcFVwQ29udGV4dE1lbnUpOgorICAgICAgICBDYWxsIE5ldHNjYXBlUGx1Z2luOjpwb3BV cENvbnRleHRNZW51LgorCisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05l dHNjYXBlUGx1Z2luLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0c2NhcGVQbHVnaW46Ok5ldHNj YXBlUGx1Z2luKToKKyAgICAgICAgSW5pdGlhbGl6ZSBtX2N1cnJlbnRNb3VzZUV2ZW50LgorCisg ICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmg6Cisg ICAgICAgIEFkZCBtX2N1cnJlbnRNb3VzZUV2ZW50LgorCisgICAgICAgICogV2ViUHJvY2Vzcy9Q bHVnaW5zL05ldHNjYXBlL21hYy9OZXRzY2FwZVBsdWdpbk1hYy5tbToKKyAgICAgICAgKFdlYktp dDo6TmV0c2NhcGVQbHVnaW46OnBvcFVwQ29udGV4dE1lbnUpOgorICAgICAgICBDb252ZXJ0IHRo ZSBjb29yZGluYXRlcyBmcm9tIHRoZSBjdXJyZW50IG1vdXNlIGV2ZW50IHRvIHNjcmVlbiBjb29y ZGluYXRlcyBhbmQgY2FsbAorICAgICAgICBXS1BvcHVwQ29udGV4dE1lbnUuCisKKyAgICAgICAg KFdlYktpdDo6TmV0c2NhcGVQbHVnaW46OnBsYXRmb3JtSGFuZGxlTW91c2VFdmVudCk6CisgICAg ICAgIFVwZGF0ZSBtX2N1cnJlbnRNb3VzZUV2ZW50LgorCiAyMDExLTAxLTE4ICBKZXNzaWUgQmVy bGluICA8amJlcmxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRs ZXIuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0 c2NhcGVCcm93c2VyRnVuY3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZUJyb3dzZXJGdW5jcy5jcHAJKHJldmlzaW9u IDc2MDQyKQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05l dHNjYXBlQnJvd3NlckZ1bmNzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzY2LDEwICs3NjYsMTEg QEAgc3RhdGljIHZvaWQgTlBOX1Vuc2NoZWR1bGVUaW1lcihOUFAgaW5zdAogfQogCiAjaWYgUExB VEZPUk0oTUFDKQotc3RhdGljIE5QRXJyb3IgTlBOX1BvcFVwQ29udGV4dE1lbnUoTlBQIGluc3Rh bmNlLCBOUE1lbnUqIG1lbnUpCitzdGF0aWMgTlBFcnJvciBOUE5fUG9wVXBDb250ZXh0TWVudShO UFAgbnBwLCBOUE1lbnUqIG1lbnUpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICByZXR1 cm4gTlBFUlJfR0VORVJJQ19FUlJPUjsKKyAgICBSZWZQdHI8TmV0c2NhcGVQbHVnaW4+IHBsdWdp biA9IE5ldHNjYXBlUGx1Z2luOjpmcm9tTlBQKG5wcCk7CisKKyAgICByZXR1cm4gcGx1Z2luLT5w b3BVcENvbnRleHRNZW51KG1lbnUpOwogfQogCiBzdGF0aWMgTlBCb29sIE5QTl9Db252ZXJ0UG9p bnQoTlBQIG5wcCwgZG91YmxlIHNvdXJjZVgsIGRvdWJsZSBzb3VyY2VZLCBOUENvb3JkaW5hdGVT cGFjZSBzb3VyY2VTcGFjZSwgZG91YmxlKiBkZXN0WCwgZG91YmxlKiBkZXN0WSwgTlBDb29yZGlu YXRlU3BhY2UgZGVzdFNwYWNlKQpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVn aW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW4uY3BwCShyZXZp c2lvbiA3NjA0MikKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2Fw ZS9OZXRzY2FwZVBsdWdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY3LDYgKzY3LDcgQEAgTmV0 c2NhcGVQbHVnaW46Ok5ldHNjYXBlUGx1Z2luKFBhc3NSZWZQdAogI2lmIFBMQVRGT1JNKE1BQykK ICAgICAsIG1fZHJhd2luZ01vZGVsKHN0YXRpY19jYXN0PE5QRHJhd2luZ01vZGVsPigtMSkpCiAg ICAgLCBtX2V2ZW50TW9kZWwoc3RhdGljX2Nhc3Q8TlBFdmVudE1vZGVsPigtMSkpCisgICAgLCBt X2N1cnJlbnRNb3VzZUV2ZW50KDApCiAgICAgLCBtX3BsdWdpbkhhc0ZvY3VzKGZhbHNlKQogICAg ICwgbV93aW5kb3dIYXNGb2N1cyhmYWxzZSkKICNpZm5kZWYgTlBfTk9fQ0FSQk9OCkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW4u aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2Nh cGUvTmV0c2NhcGVQbHVnaW4uaAkocmV2aXNpb24gNzYwNDIpCisrKyBTb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW4uaAkod29ya2luZyBjb3B5 KQpAQCAtNTQsNiArNTQsNyBAQCBwdWJsaWM6CiAgICAgTlBFcnJvciBzZXREcmF3aW5nTW9kZWwo TlBEcmF3aW5nTW9kZWwpOwogICAgIE5QRXJyb3Igc2V0RXZlbnRNb2RlbChOUEV2ZW50TW9kZWwp OwogICAgIE5QQm9vbCBjb252ZXJ0UG9pbnQoZG91YmxlIHNvdXJjZVgsIGRvdWJsZSBzb3VyY2VZ LCBOUENvb3JkaW5hdGVTcGFjZSBzb3VyY2VTcGFjZSwgZG91YmxlJiBkZXN0WCwgZG91YmxlJiBk ZXN0WSwgTlBDb29yZGluYXRlU3BhY2UgZGVzdFNwYWNlKTsKKyAgICBOUEVycm9yIHBvcFVwQ29u dGV4dE1lbnUoTlBNZW51Kik7CiAKICNpZm5kZWYgTlBfTk9fQ0FSQk9OCiAgICAgV2luZG93UmVm IHdpbmRvd1JlZigpIGNvbnN0OwpAQCAtMjA1LDYgKzIwNiw4IEBAIHByaXZhdGU6CiAgICAgTlBF dmVudE1vZGVsIG1fZXZlbnRNb2RlbDsKICAgICBSZXRhaW5QdHI8UGxhdGZvcm1MYXllcj4gbV9w bHVnaW5MYXllcjsKIAorICAgIE5QQ29jb2FFdmVudCAqbV9jdXJyZW50TW91c2VFdmVudDsKKwog ICAgIGJvb2wgbV9wbHVnaW5IYXNGb2N1czsKICAgICBib29sIG1fd2luZG93SGFzRm9jdXM7CiAK SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9tYWMvTmV0 c2NhcGVQbHVnaW5NYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9QbHVnaW5zL05ldHNjYXBlL21hYy9OZXRzY2FwZVBsdWdpbk1hYy5tbQkocmV2aXNpb24gNzYw NDIpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvbWFjL05l dHNjYXBlUGx1Z2luTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xNTcsNiArMTU3LDIwIEBAIE5Q Qm9vbCBOZXRzY2FwZVBsdWdpbjo6Y29udmVydFBvaW50KGRvdWIKICAgICByZXR1cm4gdHJ1ZTsK IH0KIAorCitOUEVycm9yIE5ldHNjYXBlUGx1Z2luOjpwb3BVcENvbnRleHRNZW51KE5QTWVudSog bnBNZW51KQoreworICAgIGlmICghbV9jdXJyZW50TW91c2VFdmVudCkKKyAgICAgICAgcmV0dXJu IE5QRVJSX0dFTkVSSUNfRVJST1I7CisKKyAgICBkb3VibGUgc2NyZWVuWCwgc2NyZWVuWTsKKyAg ICBpZiAoIWNvbnZlcnRQb2ludChtX2N1cnJlbnRNb3VzZUV2ZW50LT5kYXRhLm1vdXNlLnBsdWdp blgsIG1fY3VycmVudE1vdXNlRXZlbnQtPmRhdGEubW91c2UucGx1Z2luWSwgTlBDb29yZGluYXRl U3BhY2VQbHVnaW4sIHNjcmVlblgsIHNjcmVlblksIE5QQ29vcmRpbmF0ZVNwYWNlU2NyZWVuKSkK KyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisKKyAgICBXS1BvcHVwQ29udGV4dE1lbnUo cmVpbnRlcnByZXRfY2FzdDxOU01lbnUgKj4obnBNZW51KSwgTlNNYWtlUG9pbnQoc2NyZWVuWCwg c2NyZWVuWSkpOworICAgIHJldHVybiBOUEVSUl9OT19FUlJPUjsKK30KKwogI2lmbmRlZiBOUF9O T19DQVJCT04KIHR5cGVkZWYgSGFzaE1hcDxXaW5kb3dSZWYsIE5ldHNjYXBlUGx1Z2luKj4gV2lu ZG93TWFwOwogCkBAIC00NzQsNyArNDg4LDE5IEBAIGJvb2wgTmV0c2NhcGVQbHVnaW46OnBsYXRm b3JtSGFuZGxlTW91c2UKICAgICBzd2l0Y2ggKG1fZXZlbnRNb2RlbCkgewogICAgICAgICBjYXNl IE5QRXZlbnRNb2RlbENvY29hOiB7CiAgICAgICAgICAgICBOUENvY29hRXZlbnQgZXZlbnQgPSBp bml0aWFsaXplTW91c2VFdmVudChtb3VzZUV2ZW50LCBtX2ZyYW1lUmVjdC5sb2NhdGlvbigpKTsK LSAgICAgICAgICAgIHJldHVybiBOUFBfSGFuZGxlRXZlbnQoJmV2ZW50KTsKKworICAgICAgICAg ICAgTlBDb2NvYUV2ZW50ICpwcmV2aW91c01vdXNlRXZlbnQgPSBtX2N1cnJlbnRNb3VzZUV2ZW50 OworICAgICAgICAgICAgbV9jdXJyZW50TW91c2VFdmVudCA9ICZldmVudDsKKworICAgICAgICAg ICAgLy8gUHJvdGVjdCBhZ2FpbnN0IE5QUF9IYW5kbGVFdmVudCBjYXVzaW5nIHRoZSBwbHVnLWlu IHRvIGJlIGRlc3Ryb3llZCwgc2luY2Ugd2UKKyAgICAgICAgICAgIC8vIGFjY2VzcyBtX2N1cnJl bnRNb3VzZUV2ZW50IGFmdGVyd2FyZHMuCisgICAgICAgICAgICBSZWZQdHI8TmV0c2NhcGVQbHVn aW4+IHByb3RlY3QodGhpcyk7CisKKyAgICAgICAgICAgIGJvb2wgcmV0dXJuVmFsdWUgPSBOUFBf SGFuZGxlRXZlbnQoJmV2ZW50KTsKKworICAgICAgICAgICAgbV9jdXJyZW50TW91c2VFdmVudCA9 IHByZXZpb3VzTW91c2VFdmVudDsKKworICAgICAgICAgICAgcmV0dXJuIHJldHVyblZhbHVlOwog ICAgICAgICB9CiAKICNpZm5kZWYgTlBfTk9fQ0FSQk9OCg==