52636 2011-01-18 10:09:12 -0800 check-webkit-style should ignore the Source/WebCore/thirdparty directory 2011-06-18 12:06:32 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All NEW P3 Normal --- 1 senorblanco webkit-unassigned abarth commit-queue eric levin oldest_to_newest 335891 0 senorblanco 2011-01-18 10:09:12 -0800 Source/WebCore/thirdparty contains third-party code which does not follow WebKit coding style. check-webkit-style should skip it. (See https://bugs.webkit.org/show_bug.cgi?id=52627 for false positives.) 336043 1 levin 2011-01-18 13:11:00 -0800 I'm happy to r+ a change Tools/Scripts/webkitpy/style/checker.py to make this happen :) 336812 2 79487 jamesr 2011-01-19 14:34:24 -0800 Created attachment 79487 Patch 336826 3 79487 levin 2011-01-19 14:43:27 -0800 Comment on attachment 79487 Patch You may want to just make the "-" (which should get rid of all rules if that's what is desired) instead of "-whitespace". 337068 4 79487 jamesr 2011-01-19 19:50:12 -0800 Comment on attachment 79487 Patch Skipping whitespace is good enough to pass everything for now, but if we start failing other style checks we can add those as well. I'm slightly wary of skipping every single style check just in case some truly insane stuff starts getting added to WebCore/thirdparty/. We can figure it out when we see it :) 337176 5 79487 commit-queue 2011-01-20 00:44:09 -0800 Comment on attachment 79487 Patch Rejecting attachment 79487 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'bu..." exit_code: 2 Last 500 characters of output: ands failed: WebCore: CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/HTMLScriptElement.o /Projects/CommitQueue/Source/WebCore/html/HTMLScriptElement.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/HTMLSelectElement.o /Projects/CommitQueue/Source/WebCore/html/HTMLSelectElement.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 (2 failures) Full output: http://queues.webkit.org/results/7561236 337446 6 79487 abarth 2011-01-20 10:57:48 -0800 Comment on attachment 79487 Patch This patch can't have caused a compile error. Very strange. 337570 7 eric 2011-01-20 13:41:34 -0800 I think I was running too many bots on the machine: /Projects/CommitQueue/Source/WebCore/html/HTMLScriptElement.cpp -o /Projects/CommitQueue/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/HTMLScriptElement.o /Developer/usr/bin/../libexec/gcc/i686-apple-darwin10/4.2.1/as: can't fork a new process to execute: /Developer/usr/bin/../libexec/gcc/darwin/x86_64/as (Resource temporarily unavailable) /Projects/CommitQueue/Source/WebCore/html/HTMLScriptElement.cpp:181: fatal error: error writing to -: Broken pipe compilation terminated. 337952 8 eric 2011-01-21 02:16:47 -0800 ====================================================================== ERROR: test_path_rules_specifier (webkitpy.style.checker_unittest.GlobalVariablesTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Projects/CommitQueue/Tools/Scripts/webkitpy/style/checker_unittest.py", line 197, in test_path_rules_specifier validate_filter_rules(path_rules, self._all_categories()) File "/Projects/CommitQueue/Tools/Scripts/webkitpy/style/filter.py", line 45, in validate_filter_rules "must start with + or -." % rule) ValueError: Invalid filter rule "w": every rule must start with + or -. ---------------------------------------------------------------------- Ran 804 tests in 10.609s 338021 9 79487 levin 2011-01-21 05:50:38 -0800 Comment on attachment 79487 Patch You need a comma on line 165 after the ] or else python will interpret the () as a grouping instead of a list since there is only one item in the list. 423154 10 79487 darin 2011-06-18 12:06:32 -0700 Comment on attachment 79487 Patch Clearing review flag on this old patch that was rejected by commit-queue. 79487 2011-01-19 14:34:24 -0800 2011-06-18 12:06:32 -0700 Patch bug-52636-20110119143423.patch text/plain 1312 jamesr ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxOGMz M2NmOWRiZTk1NDQ0YzUxMzFiNzM2ZDgyNjA5Njg1YjUyMTRkLi5kNDkyNmJkZWM4MTRkMGE0Y2Qw ZTg2ODIwNmQxMzdkYWY0YmEyMmZiIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDEtMTkgIEphbWVzIFJvYmlu c29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBjaGVjay13ZWJraXQtc3R5bGUgc2hvdWxkIGlnbm9yZSB0aGUg U291cmNlL1dlYkNvcmUvdGhpcmRwYXJ0eSBkaXJlY3RvcnkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyNjM2CisKKyAgICAgICAgSWdub3JlcyBhbGwg d2hpdGVzcGFjZSBzdHlsZSBydWxlcyBmb3IgU291cmNlL1dlYkNvcmUvdGhpcmRwYXJ0eS4KKwor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weToKKwogMjAxMS0wMS0x OSAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBPamFuIFZhZmFpLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHls ZS9jaGVja2VyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5Cmlu ZGV4IGViY2YzMjY4ZjUwYTRhMzk4MzgzMzJhYjgzYTU1ZGZhYjFhODQ4MWYuLmY4ZjkxZmI5NDA1 NDc4MWViYzk5ODZhMGM0NDAxZmQ0NGI5NDViODggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXIucHkKQEAgLTE2MCw2ICsxNjAsOSBAQCBfUEFUSF9SVUxFU19TUEVDSUZJRVIg PSBbCiAgICAgICAiSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzLmNwcCJdLAogICAgICBbIi1y ZWFkYWJpbGl0eS9wYXJhbWV0ZXJfbmFtZSIsCiAgICAgICAiLXdoaXRlc3BhY2UvcGFyZW5zIl0p LAorICAgIChbIyBUaGlyZCBwYXJ0eSBDKysgY29kZSBkb2VzIG5vdCBmb2xsb3cgV2ViS2l0IHN0 eWxlIGNvbnZlbnRpb25zCisgICAgICAiU291cmNlL1dlYkNvcmUvdGhpcmRwYXJ0eSIsCisgICAg ICAiLXdoaXRlc3BhY2UiXSksCiAKICAgICAjIFdlYktpdDIgcnVsZXM6CiAgICAgIyBXZWJLaXQy IGRvZXNuJ3QgdXNlIGNvbmZpZy5oLCBhbmQgY2VydGFpbiBkaXJlY3RvcmllcyBoYXZlIG90aGVy Cg==