52634 2011-01-18 09:51:36 -0800 Web Inspector: Add layout test for the CPU profiler 2022-03-01 02:35:53 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 335874 0 mnaganov 2011-01-18 09:51:36 -0800 This test replaces DevToolsSanityTest.TestProfilerTab from Chromium's interactive_ui_tests. 335879 1 79288 mnaganov 2011-01-18 09:54:12 -0800 Created attachment 79288 patch 336382 2 79288 yurys 2011-01-19 01:09:47 -0800 Comment on attachment 79288 patch View in context: https://bugs.webkit.org/attachment.cgi?id=79288&action=review > LayoutTests/inspector/cpu-profiler-profiling.html:29 > + var tree = this.profileDataGridTree; You could dump textContent of the tree instead of traversing it. > LayoutTests/inspector/cpu-profiler-profiling.html:62 > +Tests that CPU profiling works. Layout tests usually include link to the bug. 336417 3 79288 mnaganov 2011-01-19 03:12:13 -0800 Comment on attachment 79288 patch View in context: https://bugs.webkit.org/attachment.cgi?id=79288&action=review >> LayoutTests/inspector/cpu-profiler-profiling.html:29 >> + var tree = this.profileDataGridTree; > > You could dump textContent of the tree instead of traversing it. This will also look complex because profileDataGridTree doesn't have a link to HTML element, so I will need to descend to children anyway. Also, directly matching textContent will not work, because it will contain timings -- substring search will be needed. >> LayoutTests/inspector/cpu-profiler-profiling.html:62 >> +Tests that CPU profiling works. > > Layout tests usually include link to the bug. OK, will add. 336435 4 mnaganov 2011-01-19 05:07:35 -0800 Committed as http://trac.webkit.org/changeset/76114 2011-01-18 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: Add layout test for the CPU profiler. This test replaces DevToolsSanityTest.TestProfilerTab from Chromium's interactive_ui_tests. https://bugs.webkit.org/show_bug.cgi?id=52634 * inspector/cpu-profiler-profiling-expected.txt: Added. * inspector/cpu-profiler-profiling.html: Added. 338061 5 mnaganov 2011-01-21 08:05:24 -0800 Relanded as http://trac.webkit.org/changeset/76346 This time the test passes in Chromium. 79288 2011-01-18 09:54:12 -0800 2022-03-01 02:35:53 -0800 patch patch-52634 text/plain 3165 mnaganov ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyMDgyOTkxLi5jZjllMzdhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDEt MTggIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGQg bGF5b3V0IHRlc3QgZm9yIHRoZSBDUFUgcHJvZmlsZXIuCisKKyAgICAgICAgVGhpcyB0ZXN0IHJl cGxhY2VzIERldlRvb2xzU2FuaXR5VGVzdC5UZXN0UHJvZmlsZXJUYWIgZnJvbQorICAgICAgICBD aHJvbWl1bSdzIGludGVyYWN0aXZlX3VpX3Rlc3RzLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjYzNAorCisgICAgICAgICogaW5zcGVjdG9yL2Nw dS1wcm9maWxlci1wcm9maWxpbmctZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBpbnNw ZWN0b3IvY3B1LXByb2ZpbGVyLXByb2ZpbGluZy5odG1sOiBBZGRlZC4KKwogMjAxMS0wMS0xOCAg QW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGF2ZSBIeWF0dC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9jcHUtcHJvZmls ZXItcHJvZmlsaW5nLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jcHUtcHJv ZmlsZXItcHJvZmlsaW5nLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwLi40MDI3NmJjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9y L2NwdS1wcm9maWxlci1wcm9maWxpbmctZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNCBAQAorVGVz dHMgdGhhdCBDUFUgcHJvZmlsaW5nIHdvcmtzLgorCitmb3VuZCBwYWdlRnVuY3Rpb24KKwpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NwdS1wcm9maWxlci1wcm9maWxpbmcuaHRt bCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jcHUtcHJvZmlsZXItcHJvZmlsaW5nLmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZmI1Y2ZkZAotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jcHUtcHJvZmlsZXItcHJvZmlsaW5nLmh0bWwKQEAg LTAsMCArMSw2NSBAQAorPGh0bWw+Cis8aGVhZD4KKyAgPHNjcmlwdCBzcmM9Ii4uL2h0dHAvdGVz dHMvaW5zcGVjdG9yL2luc3BlY3Rvci10ZXN0Mi5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgorCitm dW5jdGlvbiBwYWdlRnVuY3Rpb24oKSB7CisgICAgY29uc29sZS5wcm9maWxlKCJvdXRlciIpOwor ICAgIGNvbnNvbGUucHJvZmlsZSgiaW5uZXIiKTsgIC8vIFtDaHJvbWl1bV0gTWFrZSBzdXJlIHdl IGNhcHR1cmUgdGhlIGN1cnJlbnQgY2FsbHN0YWNrLgorICAgIGNvbnNvbGUucHJvZmlsZUVuZCgi aW5uZXIiKTsKKyAgICBjb25zb2xlLnByb2ZpbGVFbmQoIm91dGVyIik7Cit9CisKK2Z1bmN0aW9u IGluaXRpYWxpemVfUHJvZmlsZXJUZXN0cygpCit7CisgICAgdmFyIG9sZEFkZFByb2ZpbGVIZWFk ZXIgPSBXZWJJbnNwZWN0b3IucGFuZWxzLnByb2ZpbGVzLl9hZGRQcm9maWxlSGVhZGVyOworICAg IFdlYkluc3BlY3Rvci5wYW5lbHMucHJvZmlsZXMuX2FkZFByb2ZpbGVIZWFkZXIgPSBmdW5jdGlv bihwcm9maWxlKQorICAgIHsKKyAgICAgICAgb2xkQWRkUHJvZmlsZUhlYWRlci5jYWxsKHRoaXMs IHByb2ZpbGUpOworICAgICAgICBpZiAocHJvZmlsZS50aXRsZSA9PT0gImlubmVyIikgeworICAg ICAgICAgICAgdGhpcy5zaG93UHJvZmlsZShwcm9maWxlKTsKKyAgICAgICAgfQorICAgIH0KKwor ICAgIHZhciBvbGRSZWZyZXNoID0gV2ViSW5zcGVjdG9yLkNQVVByb2ZpbGVWaWV3LnByb3RvdHlw ZS5yZWZyZXNoOworICAgIFdlYkluc3BlY3Rvci5DUFVQcm9maWxlVmlldy5wcm90b3R5cGUucmVm cmVzaCA9IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIG9sZFJlZnJlc2guY2FsbCh0aGlzKTsK KyAgICAgICAgaWYgKHRoaXMucHJvZmlsZS50aXRsZSA9PT0gImlubmVyIikgeworICAgICAgICAg ICAgdmFyIHRyZWUgPSB0aGlzLnByb2ZpbGVEYXRhR3JpZFRyZWU7CisgICAgICAgICAgICBpZiAo IXRyZWUpCisgICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3QuYWRkUmVzdWx0KCJubyB0cmVl Iik7CisgICAgICAgICAgICB2YXIgbm9kZSA9IHRyZWUuY2hpbGRyZW5bMF07CisgICAgICAgICAg ICBpZiAoIW5vZGUpCisgICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3QuYWRkUmVzdWx0KCJu byBub2RlIik7CisgICAgICAgICAgICB3aGlsZSAobm9kZSkgeworICAgICAgICAgICAgICAgIGlm IChub2RlLmZ1bmN0aW9uTmFtZS5pbmRleE9mKCJwYWdlRnVuY3Rpb24iKSAhPT0gLTEpIHsKKyAg ICAgICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5hZGRSZXN1bHQoImZvdW5kIHBhZ2VGdW5j dGlvbiIpOworICAgICAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgICAgICB9Cisg ICAgICAgICAgICAgICAgbm9kZSA9IG5vZGUudHJhdmVyc2VOZXh0Tm9kZSh0cnVlLCBudWxsLCB0 cnVlKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIEluc3BlY3RvclRlc3QuY29tcGxldGVU ZXN0KCk7CisgICAgICAgIH0KKyAgICB9Cit9CisKK2Z1bmN0aW9uIHRlc3QoKQoreworICAgIFdl Ykluc3BlY3Rvci5zaG93UGFuZWwoInByb2ZpbGVzIik7CisgICAgV2ViSW5zcGVjdG9yLnBhbmVs cy5wcm9maWxlcy5fZW5hYmxlUHJvZmlsaW5nKCk7CisgICAgSW5zcGVjdG9yQmFja2VuZC5zdGFy dFByb2ZpbGluZygpOworICAgIEluc3BlY3RvclRlc3QuZXZhbHVhdGVJbkNvbnNvbGUoInBhZ2VG dW5jdGlvbigpIiwgZnVuY3Rpb24gZG9uZSgpCisgICAgeworICAgICAgICBJbnNwZWN0b3JCYWNr ZW5kLnN0b3BQcm9maWxpbmcoKTsKKyAgICB9KTsKK30KKworPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8 Ym9keSBvbmxvYWQ9InJ1blRlc3QoKSI+Cis8cD4KK1Rlc3RzIHRoYXQgQ1BVIHByb2ZpbGluZyB3 b3Jrcy4KKzwvcD4KKzwvYm9keT4KKzwvaHRtbD4K